- gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: test: adjust for libosmocore loglevel cache
by fixeria 11 Jan '24

11 Jan '24

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35550?usp=email ) Change subject: test: adjust for libosmocore loglevel cache ...................................................................... Patch Set 1: (1 comment) File tests/handover/handover_test.c: https://gerrit.osmocom.org/c/osmo-bts/+/35550/comment/9cb207ac_c0128af1 PS1, Line 73: osmo_stderr_target->categories[DHO].loglevel = LOGL_DEBUG; So, if accessing the logging internals is a bad idea (as you mentioned in the related patch), then why not just fix the code to use proper API - `log_set_category_filter()`? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie9c546210bc554843b1029afa20965bde1d7f228 Gerrit-Change-Number: 35550 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Jan 2024 17:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: test: adjust for libosmocore loglevel cache
by fixeria 11 Jan '24

11 Jan '24

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email ) Change subject: test: adjust for libosmocore loglevel cache ...................................................................... Patch Set 1: (1 comment) File tests/nanobts_omlattr/nanobts_omlattr_test.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35549/comment/8cdc7a35_61d6c709 PS1, Line 275: talloc_total_blocks(ctx) == 6 Well, I am simply suggesting a more fundamental fix, eliminating the need to adjust this count again next time somebody changes logging: > I would suggest to call `log_fini()` before checking the talloc report. If you do so, then there will be only one block alone - the root ctx. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If52bcb522d41918db9e0755ead58abdcb8f0209b Gerrit-Change-Number: 35549 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Jan 2024 17:37:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: test: adjust for libosmocore loglevel cache
by Hoernchen 11 Jan '24

11 Jan '24

Attention is currently required from: fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email ) Change subject: test: adjust for libosmocore loglevel cache ...................................................................... Patch Set 1: (1 comment) File tests/nanobts_omlattr/nanobts_omlattr_test.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35549/comment/9958137e_0c9ec9a9 PS1, Line 275: talloc_total_blocks(ctx) == 6 > Hmm, why do we even make assumptions on the logging hierarchy here. […] I have no idea and I don't care because the cache is not about test code originally commited >10 years ago... This ist just about making this work. Log levels should not be manipulated by accessing the logging structs either.... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If52bcb522d41918db9e0755ead58abdcb8f0209b Gerrit-Change-Number: 35549 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Jan 2024 17:21:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: test: adjust for libosmocore loglevel cache
by fixeria 11 Jan '24

11 Jan '24

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email ) Change subject: test: adjust for libosmocore loglevel cache ...................................................................... Patch Set 1: (1 comment) File tests/nanobts_omlattr/nanobts_omlattr_test.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35549/comment/9dec3b7c_25b9d687 PS1, Line 275: talloc_total_blocks(ctx) == 6 Hmm, why do we even make assumptions on the logging hierarchy here. This is wrong. We should only check what we actually allocate ourselves. I would suggest to call `log_fini()` before checking the talloc report. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If52bcb522d41918db9e0755ead58abdcb8f0209b Gerrit-Change-Number: 35549 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Jan 2024 17:19:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: on latest, skip TC_rab_assign_mgw_iuup_addr_chg
by neels 11 Jan '24

11 Jan '24

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35350?usp=email ) Change subject: hnbgw: on latest, skip TC_rab_assign_mgw_iuup_addr_chg ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53f3c67e0cf71cbc6bcc8a8e691b16c871df9d33 Gerrit-Change-Number: 35350 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 0

[M] Change in libosmocore[master]: Revert "Revert "logging: add log level cache""
by Hoernchen 11 Jan '24

11 Jan '24

Attention is currently required from: fixeria, laforge. Hoernchen has removed arehbein from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35525?usp=email ) Change subject: Revert "Revert "logging: add log level cache"" ...................................................................... Removed cc arehbein <arehbein(a)sysmocom.de>. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Gerrit-Change-Number: 35525 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteReviewer

1 0

[S] Change in osmo-bts[master]: test: adjust for libosmocore loglevel cache
by Hoernchen 11 Jan '24

11 Jan '24

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/35550?usp=email ) Change subject: test: adjust for libosmocore loglevel cache ...................................................................... test: adjust for libosmocore loglevel cache Depends: libosmocore.git I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Change-Id: Ie9c546210bc554843b1029afa20965bde1d7f228 --- M tests/handover/handover_test.c M tests/power/bs_power_loop_test.c M tests/power/ms_power_loop_test.c M tests/tx_power/tx_power_test.c 4 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/35550/1 diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index f1235f5..59a277f 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -71,7 +71,7 @@ osmo_init_logging2(tall_bts_ctx, &bts_log_info); osmo_stderr_target->categories[DHO].loglevel = LOGL_DEBUG; - + log_cache_update(DHO, 1, LOGL_DEBUG); g_bts_sm = gsm_bts_sm_alloc(tall_bts_ctx); if (!g_bts_sm) { fprintf(stderr, "Failed to create BTS Site Manager structure\n"); diff --git a/tests/power/bs_power_loop_test.c b/tests/power/bs_power_loop_test.c index f9eb3b7..d536dc5 100644 --- a/tests/power/bs_power_loop_test.c +++ b/tests/power/bs_power_loop_test.c @@ -491,6 +491,8 @@ osmo_init_logging2(tall_bts_ctx, &bts_log_info); osmo_stderr_target->categories[DLOOP].loglevel = LOGL_DEBUG; osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG; + log_cache_update(DLOOP, 1, LOGL_DEBUG); + log_cache_update(DL1C, 1, LOGL_DEBUG); log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); log_set_use_color(osmo_stderr_target, 0); log_set_print_category(osmo_stderr_target, 0); diff --git a/tests/power/ms_power_loop_test.c b/tests/power/ms_power_loop_test.c index d9916d5..777276b 100644 --- a/tests/power/ms_power_loop_test.c +++ b/tests/power/ms_power_loop_test.c @@ -415,6 +415,8 @@ osmo_init_logging2(tall_bts_ctx, &bts_log_info); osmo_stderr_target->categories[DLOOP].loglevel = LOGL_DEBUG; osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG; + log_cache_update(DLOOP, 1, LOGL_DEBUG); + log_cache_update(DL1C, 1, LOGL_DEBUG); log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); log_set_use_color(osmo_stderr_target, 0); log_set_print_category(osmo_stderr_target, 0); diff --git a/tests/tx_power/tx_power_test.c b/tests/tx_power/tx_power_test.c index 937d7f8..34b9da7 100644 --- a/tests/tx_power/tx_power_test.c +++ b/tests/tx_power/tx_power_test.c @@ -248,6 +248,7 @@ osmo_init_logging2(tall_bts_ctx, &bts_log_info); osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG; + log_cache_update(DL1C, 1, LOGL_DEBUG); log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); log_set_use_color(osmo_stderr_target, 0); log_set_print_category(osmo_stderr_target, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie9c546210bc554843b1029afa20965bde1d7f228 Gerrit-Change-Number: 35550 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: test: adjust for libosmocore loglevel cache
by Hoernchen 11 Jan '24

11 Jan '24

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email ) Change subject: test: adjust for libosmocore loglevel cache ...................................................................... test: adjust for libosmocore loglevel cache Depends: libosmocore.git I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Change-Id: If52bcb522d41918db9e0755ead58abdcb8f0209b --- M tests/nanobts_omlattr/nanobts_omlattr_test.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/35549/1 diff --git a/tests/nanobts_omlattr/nanobts_omlattr_test.c b/tests/nanobts_omlattr/nanobts_omlattr_test.c index 9ef90ae..1383ac8 100644 --- a/tests/nanobts_omlattr/nanobts_omlattr_test.c +++ b/tests/nanobts_omlattr/nanobts_omlattr_test.c @@ -272,7 +272,7 @@ * struct log_info contains 616 bytes in 2 blocks (ref 0) 0x60d000000310 * struct log_info_cat contains 576 bytes in 1 blocks (ref 0) 0x6170000000e0 * That's the root ctx + 5x logging: */ - OSMO_ASSERT(talloc_total_blocks(ctx) == 6); + OSMO_ASSERT(talloc_total_blocks(ctx) == 7); talloc_free(ctx); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If52bcb522d41918db9e0755ead58abdcb8f0209b Gerrit-Change-Number: 35549 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: Revert "Revert "logging: add log level cache""
by Hoernchen 11 Jan '24

11 Jan '24

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, fixeria, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35525?usp=email to review the following change. Change subject: Revert "Revert "logging: add log level cache"" ...................................................................... Revert "Revert "logging: add log level cache"" This reverts commit 7f1fb3ea817578f3f2f63e8065aa50f8355caa3b. Reason for revert: some fallout expected due to log manipulation in test code Change-Id: I539872fc9e3c50b407e6bc388f1e091fa2c826c3 --- M include/osmocom/core/logging.h M src/core/libosmocore.map M src/core/logging.c M src/vty/logging_vty.c M tests/ctrl/ctrl_test.c 5 files changed, 136 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/35525/1 diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index e8433a1..e4859cd 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -409,7 +409,7 @@ /* filter on the targets */ void log_set_all_filter(struct log_target *target, int); - +void log_cache_update(int mapped_subsys, uint8_t enabled, uint8_t level); void log_set_use_color(struct log_target *target, int); void log_set_print_extended_timestamp(struct log_target *target, int); void log_set_print_timestamp(struct log_target *target, int); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index b66e37d..06a3864 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -58,6 +58,7 @@ log_add_target; log_category_name; log_check_level; +log_cache_update; log_del_target; log_enable_multithread; log_fini; diff --git a/src/core/logging.c b/src/core/logging.c index 6941f9b..906d664 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -93,6 +93,68 @@ static __thread long int logging_tid; #if (!EMBEDDED) +/*! One global copy that contains the union of log levels for all targets +* for all categories, used for quick lock free checks of log targets. */ +static volatile uint8_t *log_level_lookup_cache; + +/*! Updates cache for all targets for all categies, caller must hold osmo_log_tgt_mutex. */ +static void log_cache_update_all(void) +{ + struct log_target *tgt; + uint8_t tmp_en[osmo_log_info->num_cat]; + uint8_t tmp_level[osmo_log_info->num_cat]; + memset(tmp_en, 0, osmo_log_info->num_cat); + memset(tmp_level, UINT8_MAX, osmo_log_info->num_cat); + + /* values can also decrease.. */ + llist_for_each_entry(tgt, &osmo_log_target_list, entry) { + for (int i = 0; i < osmo_log_info->num_cat; i++) { + struct log_category *cat = &tgt->categories[i]; + tmp_en[i] = OSMO_MAX(tmp_en[i], cat->enabled); + tmp_level[i] = OSMO_MIN(tmp_level[i], cat->loglevel); + tmp_level[i] = tgt->loglevel ? OSMO_MIN(tmp_level[i], tgt->loglevel) : tmp_level[i]; + } + } + + for (int i = 0; i < osmo_log_info->num_cat; i++) + log_level_lookup_cache[i] = tmp_en[i] ? tmp_level[i] : UINT8_MAX; +} + +/*! Updates single cache entry, caller must hold osmo_log_tgt_mutex. + * + * \param[in] mapped_subsys plain category index (after mapping) + * \param[in] enabled log category enabled? + * \param[in] level log level + */ +void log_cache_update(int mapped_subsys, uint8_t enabled, uint8_t level) +{ + struct log_target *tgt; + struct log_category tmp = { UINT8_MAX, 0 }; + + /* values can also decrease.. */ + llist_for_each_entry(tgt, &osmo_log_target_list, entry) { + struct log_category *cat = &tgt->categories[mapped_subsys]; + tmp.enabled = OSMO_MAX(tmp.enabled, cat->enabled); + tmp.loglevel = OSMO_MIN(tmp.loglevel, cat->loglevel); + tmp.loglevel = tgt->loglevel ? OSMO_MIN(tmp.loglevel, tgt->loglevel) : tmp.loglevel; + } + tmp.enabled = OSMO_MAX(tmp.enabled, enabled); + tmp.loglevel = OSMO_MIN(tmp.loglevel, level); + + log_level_lookup_cache[mapped_subsys] = tmp.enabled ? tmp.loglevel : UINT8_MAX; +} + +/*! Queries log level cache. + * + * \param[in] mapped_subsys plain category index (after mapping) + * \param[in] level log level + * \returns true if logging should happen for at least one log target +*/ +static bool log_cache_check(int mapped_subsys, int level) +{ + return (level < log_level_lookup_cache[mapped_subsys]) ? false : true; +} + /*! This mutex must be held while using osmo_log_target_list or any of its log_targets in a multithread program. Prevents race conditions between threads like producing unordered timestamps or VTY deleting a target while another @@ -426,6 +488,10 @@ } } while ((category_token = strtok(NULL, ":"))); +#if !defined(EMBEDDED) + log_cache_update_all(); +#endif + free(mask); } @@ -680,6 +746,11 @@ subsys = map_subsys(subsys); +#if !defined(EMBEDDED) + if (!log_cache_check(subsys, level)) + return; +#endif + log_tgt_mutex_lock(); llist_for_each_entry(tar, &osmo_log_target_list, entry) { @@ -754,6 +825,9 @@ void log_add_target(struct log_target *target) { llist_add_tail(&target->entry, &osmo_log_target_list); +#if (!EMBEDDED) + log_cache_update_all(); +#endif } /*! Unregister a log target from the logging core @@ -762,6 +836,9 @@ void log_del_target(struct log_target *target) { llist_del(&target->entry); +#if (!EMBEDDED) + log_cache_update_all(); +#endif } /*! Reset (clear) the logging context */ @@ -922,6 +999,9 @@ void log_set_log_level(struct log_target *target, int log_level) { target->loglevel = log_level; +#if !defined(EMBEDDED) + log_cache_update_all(); +#endif } /*! Set a category filter on a given log target @@ -938,6 +1018,10 @@ category = map_subsys(category); target->categories[category].enabled = !!enable; target->categories[category].loglevel = level; + +#if !defined(EMBEDDED) + log_cache_update(category, !!enable, level); +#endif } #if (!EMBEDDED) @@ -1046,6 +1130,15 @@ /* global log level */ target->loglevel = 0; + +#if !defined(EMBEDDED) + /* update cache */ + for (i = 0; i < osmo_log_info->num_cat; i++) { + const struct log_info_cat *c = &osmo_log_info->cat[i]; + log_cache_update(i, c->enabled, c->loglevel); + } +#endif + return target; } @@ -1424,6 +1517,15 @@ osmo_log_info->num_cat += inf->num_cat; } +#if !defined(EMBEDDED) + log_level_lookup_cache = talloc_zero_array(osmo_log_info, uint8_t, osmo_log_info->num_cat); + if (!log_level_lookup_cache) { + talloc_free(osmo_log_info); + osmo_log_info = NULL; + return -ENOMEM; + } +#endif + cat_ptr = talloc_zero_array(osmo_log_info, struct log_info_cat, osmo_log_info->num_cat); if (!cat_ptr) { @@ -1454,6 +1556,12 @@ osmo_log_info->cat = cat_ptr; +#if !defined(EMBEDDED) + /* copy everything for level lookup cache */ + for (i = 0; i < osmo_log_info->num_cat; i++) + log_level_lookup_cache[i] = cat_ptr[i].loglevel; +#endif + return 0; } @@ -1486,6 +1594,11 @@ subsys = map_subsys(subsys); +#if !defined(EMBEDDED) + if (!log_cache_check(subsys, level)) + return 0; +#endif + /* TODO: The following could/should be cached (update on config) */ log_tgt_mutex_lock(); diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index 2a07422..678ae68 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -382,6 +382,10 @@ tgt->categories[category].enabled = 1; tgt->categories[category].loglevel = level; +#if !defined(EMBEDDED) + log_cache_update(category, 1, level); +#endif + RET_WITH_UNLOCK(CMD_SUCCESS); } @@ -406,6 +410,9 @@ cat->enabled = 1; cat->loglevel = level; +#if !defined(EMBEDDED) + log_cache_update(i, 1, level); +#endif } RET_WITH_UNLOCK(CMD_SUCCESS); } diff --git a/tests/ctrl/ctrl_test.c b/tests/ctrl/ctrl_test.c index 1d4d4d7..7b7e6ce 100644 --- a/tests/ctrl/ctrl_test.c +++ b/tests/ctrl/ctrl_test.c @@ -482,7 +482,7 @@ test_deferred_cmd(); /* Expecting root ctx + msgb root ctx + 5 logging elements */ - if (talloc_total_blocks(ctx) != 7) { + if (talloc_total_blocks(ctx) != 8) { talloc_report_full(ctx, stdout); OSMO_ASSERT(false); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Gerrit-Change-Number: 35525 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: Revert "logging: add log level cache"
by Hoernchen 11 Jan '24

11 Jan '24

Hoernchen has created a revert of this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35524?usp=email ) Change subject: Revert "logging: add log level cache" ...................................................................... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ife4c49d1bb933e983ac68c57970c9c49b40e08be Gerrit-Change-Number: 35524 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: revert

1 0

2026

2025

2024

2023

2022

gerrit-log