- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: Fix encoding of decoded/json data in update_{record_binary}_decoded
by fixeria 18 Jan '24

18 Jan '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35612?usp=email ) Change subject: Fix encoding of decoded/json data in update_{record_binary}_decoded ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3c3d2a2753aa7a2566a3b1add7ba70c86499d293 Gerrit-Change-Number: 35612 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 18 Jan 2024 17:15:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: Fix encoding of decoded/json data in update_{record_binary}_decoded
by laforge 18 Jan '24

18 Jan '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35612?usp=email ) Change subject: Fix encoding of decoded/json data in update_{record_binary}_decoded ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3c3d2a2753aa7a2566a3b1add7ba70c86499d293 Gerrit-Change-Number: 35612 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 18 Jan 2024 15:59:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: osmo-smdpp: Actually dump Rx/Tx JSON in JSON format and not as python...
by laforge 18 Jan '24

18 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35613?usp=email ) Change subject: osmo-smdpp: Actually dump Rx/Tx JSON in JSON format and not as python dict ...................................................................... osmo-smdpp: Actually dump Rx/Tx JSON in JSON format and not as python dict Change-Id: Ieea3fd2d0f0239acfa6a5c4cfdbfd558d1a3e0ea --- M osmo-smdpp.py 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/13/35613/1 diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 6ae5be8..41cdfc8 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -252,13 +252,13 @@ # TODO: reject any non-JSON Content-type content = json.loads(request.content.read()) - print("Rx JSON: %s" % content) + print("Rx JSON: %s" % json.dumps(content)) set_headers(request) output = func(self, request, content) or {} build_resp_header(output) - print("Tx JSON: %s" % output) + print("Tx JSON: %s" % json.dumps(output)) return json.dumps(output) return _api_wrapper -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieea3fd2d0f0239acfa6a5c4cfdbfd558d1a3e0ea Gerrit-Change-Number: 35613 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: Fix encoding of decoded/json data in update_{record_binary}_decoded
by laforge 18 Jan '24

18 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35612?usp=email ) Change subject: Fix encoding of decoded/json data in update_{record_binary}_decoded ...................................................................... Fix encoding of decoded/json data in update_{record_binary}_decoded The patch introducing the is_hexstr type into the argparser was accidentially also introduce in two locations where we actually don't expect a hex-string. This is a partial revert of I6426ea864bec82be60554dd125961a48d7751904 Change-Id: I3c3d2a2753aa7a2566a3b1add7ba70c86499d293 Closes: #6331 --- M pySim/filesystem.py 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/35612/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 5d1970a..2bc5f01 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -622,7 +622,7 @@ self._cmd.poutput(data) upd_bin_dec_parser = argparse.ArgumentParser() - upd_bin_dec_parser.add_argument('data', type=is_hexstr, help='Abstract data (JSON format) to write') + upd_bin_dec_parser.add_argument('data', help='Abstract data (JSON format) to write') upd_bin_dec_parser.add_argument('--json-path', type=str, help='JSON path to modify specific element of file only') @@ -882,7 +882,7 @@ upd_rec_dec_parser = argparse.ArgumentParser() upd_rec_dec_parser.add_argument( 'record_nr', type=int, help='Number of record to be read') - upd_rec_dec_parser.add_argument('data', type=is_hexstr, help='Abstract data (JSON format) to write') + upd_rec_dec_parser.add_argument('data', help='Abstract data (JSON format) to write') upd_rec_dec_parser.add_argument('--json-path', type=str, help='JSON path to modify specific element of record only') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3c3d2a2753aa7a2566a3b1add7ba70c86499d293 Gerrit-Change-Number: 35612 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim.utils: Support datetime.datetime in JsonEncoder
by laforge 18 Jan '24

18 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35614?usp=email ) Change subject: pySim.utils: Support datetime.datetime in JsonEncoder ...................................................................... pySim.utils: Support datetime.datetime in JsonEncoder Change-Id: I6223475cec8eb45c6fc4278109ad9dd1cb557800 --- M pySim/utils.py 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/14/35614/1 diff --git a/pySim/utils.py b/pySim/utils.py index 581abf2..cf95dab 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -6,6 +6,7 @@ import json import abc import string +import datetime from io import BytesIO from typing import Optional, List, Dict, Any, Tuple, NewType @@ -973,6 +974,8 @@ def default(self, o): if isinstance(o, BytesIO) or isinstance(o, bytes) or isinstance(o, bytearray): return b2h(o) + elif isinstance(o, datetime.datetime): + return o.isoformat() return json.JSONEncoder.default(self, o) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6223475cec8eb45c6fc4278109ad9dd1cb557800 Gerrit-Change-Number: 35614 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[L] Change in osmocom-bb[master]: mobile: init/deinit GAPK I/O based on CC transaction events
by osmith 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email ) Change subject: mobile: init/deinit GAPK I/O based on CC transaction events ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I28f87f6a6de673611aa02a24e8985aee23d4498b Gerrit-Change-Number: 35579 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 15:55:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1d[master]: Prevent memory leaks / double free of msgb in proto_clnt.c
by tnt 18 Jan '24

18 Jan '24

Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35609?usp=email ) Change subject: Prevent memory leaks / double free of msgb in proto_clnt.c ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic0c4c06ba7c1a405ec3c73100fe9e8476f4f5512 Gerrit-Change-Number: 35609 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 18 Jan 2024 15:34:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: cosmetic: gsup.h: fix whitespace formatting
by pespin 18 Jan '24

18 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35611?usp=email ) Change subject: cosmetic: gsup.h: fix whitespace formatting ...................................................................... cosmetic: gsup.h: fix whitespace formatting Change-Id: Icd5e38db1b99889ad15a2a4cbb83393292a54180 --- M include/osmocom/gsm/gsup.h 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/35611/1 diff --git a/include/osmocom/gsm/gsup.h b/include/osmocom/gsm/gsup.h index 6e7fcf0..6c23297 100644 --- a/include/osmocom/gsm/gsup.h +++ b/include/osmocom/gsm/gsup.h @@ -71,7 +71,7 @@ OSMO_GSUP_FREEZE_PTMSI_IE = 0x07, OSMO_GSUP_MSISDN_IE = 0x08, OSMO_GSUP_HLR_NUMBER_IE = 0x09, - OSMO_GSUP_MESSAGE_CLASS_IE = 0x0a, + OSMO_GSUP_MESSAGE_CLASS_IE = 0x0a, OSMO_GSUP_PDP_CONTEXT_ID_IE = 0x10, OSMO_GSUP_PDP_TYPE_IE = 0x11, OSMO_GSUP_ACCESS_POINT_NAME_IE = 0x12, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd5e38db1b99889ad15a2a4cbb83393292a54180 Gerrit-Change-Number: 35611 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN
by fixeria 18 Jan '24

18 Jan '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email ) Change subject: ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File ttcn3-epdg-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/35607/comment/56fd92a4_100… PS1, Line 26: --privileged > Could you clarify why `--privileged` is needed? […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474 Gerrit-Change-Number: 35607 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jan 2024 14:03:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN
by pespin 18 Jan '24

18 Jan '24

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN ...................................................................... ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN This will be needed since soon osmo-epdg will start creating tunnel devices througth gtp_u_kmod, which requires CAP_NET_ADMIN, plus it will need probably need to set up local IP addresses. Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474 --- M ttcn3-epdg-test/jenkins.sh 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/07/35607/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474 Gerrit-Change-Number: 35607 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log