- gerrit-log - lists.osmocom.org

[M] Change in osmo-gsm-manuals[master]: gsup.adoc: Add links to section of each message type in table
by laforge 07 Feb '24

07 Feb '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email ) Change subject: gsup.adoc: Add links to section of each message type in table ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idbc8a8f2e41f90e545a420517bd030399fb229ac Gerrit-Change-Number: 35898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Feb 2024 19:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: gsup.adoc: Fix Authentication Info message naming in table
by laforge 07 Feb '24

07 Feb '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35897?usp=email ) Change subject: gsup.adoc: Fix Authentication Info message naming in table ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I'm not entirely sure it's a fix. AFAICT even some 3GPP specs call it SendAuthInfo and not SendAuthenticationInfo. But well, we don't really need to argue about that. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I6d5c95334c961f1f0aa083107713c31d9894c7aa Gerrit-Change-Number: 35897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Feb 2024 19:00:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-epdg[master]: Make PDP-Type and APN from GSUP AuthInfoReq available through all layers
by pespin 07 Feb '24

07 Feb '24

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901?usp=email ) Change subject: Make PDP-Type and APN from GSUP AuthInfoReq available through all layers ...................................................................... Patch Set 1: (1 comment) File src/aaa_diameter_swx.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901/comment/a638af84_7f39… PS1, Line 192: %16#21 -> idk why, if it go through this path, I get an encode error: 18:13:36.308 [debug] Swx MAR: IPv4Opt=<<"<FF><FF><FF><FE>">> IPv6Opt=[] *DBG* aaa_ue_fsm_262420000000001 send {error,encode} to <0.174.0> *DBG* aaa_ue_fsm_262420000000001 consume call {swm_auth_req,33,"internet"} from <0.174.0> in state state_new 18:13:36.329 [error] Error: encode Maybe I'm encoding wrong an OctetString? Quick check in https://www2.erlang.org/documentation/doc-10.5/lib/diameter-2.2.1/doc/html/… says: OctetString() = string() | binary() Maybe I need to encode it as a 4 int tuple, as explained in "Derived AVP Data Formats" section just below the line I shared above. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3f29b00f57f433f8623b9f0a5048c83985e5cced Gerrit-Change-Number: 35901 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 07 Feb 2024 18:26:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-epdg[master]: Make PDP-Type and APN from GSUP AuthInfoReq available through all layers
by pespin 07 Feb '24

07 Feb '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901?usp=email ) Change subject: Make PDP-Type and APN from GSUP AuthInfoReq available through all layers ...................................................................... Make PDP-Type and APN from GSUP AuthInfoReq available through all layers Change-Id: I3f29b00f57f433f8623b9f0a5048c83985e5cced --- M src/aaa_diameter_swm.erl M src/aaa_diameter_swx.erl M src/aaa_ue_fsm.erl M src/epdg_diameter_swm.erl M src/epdg_ue_fsm.erl M src/gsup_server.erl 6 files changed, 72 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/01/35901/1 diff --git a/src/aaa_diameter_swm.erl b/src/aaa_diameter_swm.erl index ee3a8cb..7fdc247 100644 --- a/src/aaa_diameter_swm.erl +++ b/src/aaa_diameter_swm.erl @@ -20,7 +20,7 @@ -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). -export([code_change/3, terminate/2]). --export([auth_request/1, auth_compl_request/2, session_termination_request/1]). +-export([auth_request/3, auth_compl_request/2, session_termination_request/1]). -export([auth_response/2, auth_compl_response/2, session_termination_answer/2]). -define(SERVER, ?MODULE). @@ -47,8 +47,8 @@ %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% % Rx from emulated SWm wire: %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% -auth_request(Imsi) -> - gen_server:cast(?SERVER, {epdg_auth_req, Imsi}). +auth_request(Imsi, PdpTypeNr, Apn) -> + gen_server:cast(?SERVER, {epdg_auth_req, Imsi, PdpTypeNr, Apn}). auth_compl_request(Imsi, Apn) -> gen_server:cast(?SERVER, {epdg_auth_compl_req, Imsi, Apn}). @@ -56,9 +56,9 @@ session_termination_request(Imsi) -> gen_server:cast(?SERVER, {str, Imsi}). -handle_cast({epdg_auth_req, Imsi}, State0) -> +handle_cast({epdg_auth_req, Imsi, PdpTypeNr, Apn}, State0) -> {Sess, State1} = find_or_new_swm_session(Imsi, State0), - aaa_ue_fsm:ev_swm_auth_req(Sess#swm_session.pid), + aaa_ue_fsm:ev_swm_auth_req(Sess#swm_session.pid, {PdpTypeNr, Apn}), {noreply, State1}; handle_cast({epdg_auth_compl_req, Imsi, Apn}, State) -> diff --git a/src/aaa_diameter_swx.erl b/src/aaa_diameter_swx.erl index 1db5809..6b8523c 100644 --- a/src/aaa_diameter_swx.erl +++ b/src/aaa_diameter_swx.erl @@ -49,7 +49,7 @@ %% gen_server Function Exports -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). -export([code_change/3]). --export([multimedia_auth_request/6]). +-export([multimedia_auth_request/7]). -export([server_assignment_request/3]). -export([test/0, test/1]). @@ -136,11 +136,11 @@ test("001011234567890"). test(IMSI) -> - multimedia_auth_request(IMSI, 3, "EAP-AKA", 1, [], []). + multimedia_auth_request(IMSI, 3, "EAP-AKA", 1, [], [], 33). -multimedia_auth_request(IMSI, NumAuthItems, AuthScheme, RAT, CKey, IntegrityKey) -> +multimedia_auth_request(IMSI, NumAuthItems, AuthScheme, RAT, CKey, IntegrityKey, PdpTypeNr) -> gen_server:call(?SERVER, - {mar, {IMSI, NumAuthItems, AuthScheme, RAT, CKey, IntegrityKey}}). + {mar, {IMSI, NumAuthItems, AuthScheme, RAT, CKey, IntegrityKey, PdpTypeNr}}). % APN is optional and should be [] server_assignment_request(IMSI, Type, APN) -> gen_server:call(?SERVER, @@ -181,8 +181,28 @@ parse_saa(Saa) -> {unknown_err, []}. -handle_call({mar, {IMSI, NumAuthItems, AuthScheme, RAT, CKey, IntegrityKey}}, {Pid, _Tag} = _From, State) -> +handle_call({mar, {IMSI, NumAuthItems, AuthScheme, RAT, CKey, IntegrityKey, PdpTypeNr}}, {Pid, _Tag} = _From, State) -> SessionId = diameter:session_id(application:get_env(?ENV_APP_NAME, origin_host, ?ENV_DEFAULT_ORIG_HOST)), + % RFC 4005 6.11.1 Framed-IP-Address AVP: + % "0xFFFFFFFE indicates that the NAS should select an address for the user + % (e.g., assigned from a pool of addresses kept by the NAS)." + %Ipv4Dyn = 16#FFFFFFFE, + case PdpTypeNr of + % FIXME: For some reason encoding when not empty fails... + %16#21 -> + % IPv4Opt = <<Ipv4Dyn:32>>, + % IPv6Opt = []; + %16#57 -> + % IPv4Opt = [], + % IPv6Opt = <<>>; + %16#8d -> + % IPv4Opt = <<Ipv4Dyn:32>>, + % IPv6Opt = <<>>; + _ -> + IPv4Opt = [], + IPv6Opt = [] + end, + lager:debug("Swx MAR: IPv4Opt=~p IPv6Opt=~p~n", [IPv4Opt, IPv6Opt]),% MAR = #'MAR'{'Vendor-Specific-Application-Id' = #'Vendor-Specific-Application-Id'{ 'Vendor-Id' = ?VENDOR_ID_3GPP, 'Auth-Application-Id' = [?DIAMETER_APP_ID_SWX]}, @@ -192,7 +212,10 @@ 'SIP-Auth-Data-Item' = #'SIP-Auth-Data-Item'{ 'SIP-Authentication-Scheme' = [AuthScheme], 'Confidentiality-Key' = CKey, - 'Integrity-Key' = IntegrityKey}, + 'Integrity-Key' = IntegrityKey, + 'Framed-IP-Address' = IPv4Opt, + 'Framed-IPv6-Prefix' = IPv6Opt + }, 'SIP-Number-Auth-Items' = NumAuthItems, 'RAT-Type' = RAT }, diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index 5cdb553..e982d57 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -41,7 +41,7 @@ -export([start_link/1]). -export([init/1,callback_mode/0,terminate/3]). -export([get_server_name_by_imsi/1, get_pid_by_imsi/1]). --export([ev_swm_auth_req/1, ev_swm_auth_compl/2, ev_rx_swm_str/1, ev_rx_swx_maa/2, ev_rx_swx_saa/2, +-export([ev_swm_auth_req/2, ev_swm_auth_compl/2, ev_rx_swm_str/1, ev_rx_swx_maa/2, ev_rx_swx_saa/2, ev_rx_s6b_aar/2, ev_rx_s6b_str/1]). -export([state_new/3, state_wait_swx_maa/3, state_wait_swx_saa/3, state_authenticated/3, state_authenticated_wait_swx_saa/3]). @@ -66,10 +66,10 @@ lager:info("ue_fsm start_link(~p)~n", [ServerName]), gen_statem:start_link({local, ServerName}, ?MODULE, Imsi, [{debug, [trace]}]). -ev_swm_auth_req(Pid) -> +ev_swm_auth_req(Pid, {PdpTypeNr, Apn}) -> lager:info("ue_fsm ev_swm_auth_req~n", []), try - gen_statem:call(Pid, swm_auth_req) + gen_statem:call(Pid, {swm_auth_req, PdpTypeNr, Apn}) catch exit:Err -> {error, Err} @@ -152,12 +152,12 @@ state_new(enter, _OldState, Data) -> {keep_state, Data}; -state_new({call, From}, swm_auth_req, Data) -> - lager:info("ue_fsm state_new event=swm_auth_req, ~p~n", [Data]), +state_new({call, From}, {swm_auth_req, PdpTypeNr, Apn}, Data) -> + lager:info("ue_fsm state_new event=swm_auth_req {~p, ~p}, ~p~n", [PdpTypeNr, Apn, Data]), % request the diameter code for a tuple CKey = [], IntegrityKey = [], - case aaa_diameter_swx:multimedia_auth_request(Data#ue_fsm_data.imsi, 1, "EAP-AKA", 1, CKey, IntegrityKey) of + case aaa_diameter_swx:multimedia_auth_request(Data#ue_fsm_data.imsi, 1, "EAP-AKA", 1, CKey, IntegrityKey, PdpTypeNr) of ok -> {next_state, state_wait_swx_maa, Data, [{reply,From,ok}]}; {error, Err} -> {keep_state, Data, [{reply,From,{error, Err}}]} end; diff --git a/src/epdg_diameter_swm.erl b/src/epdg_diameter_swm.erl index 800df44..9b010d9 100644 --- a/src/epdg_diameter_swm.erl +++ b/src/epdg_diameter_swm.erl @@ -19,7 +19,7 @@ -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). -export([code_change/3, terminate/2]). --export([auth_request/1, auth_compl_request/2, session_termination_request/1]). +-export([auth_request/3, auth_compl_request/2, session_termination_request/1]). -export([auth_response/2, auth_compl_response/2, session_termination_answer/2]). -define(SERVER, ?MODULE). @@ -33,10 +33,13 @@ {ok, #swm_state{}}. -auth_request(Imsi) -> +auth_request(Imsi, PdpTypeNr, Apn) -> % In Diameter we use Imsi as strings, as done by diameter module. ImsiStr = binary_to_list(Imsi), - Result = gen_server:call(?SERVER, {epdg_auth_req, ImsiStr}), + % epdg_auth_req: Swm Diameter message Diameter-EAP-Request 3GPP TS 29.273 7.2.2.1.1 + % PdpTypeNr: SWm Diameter AVP "UE-Local-IP-Address" + % Apn: SWm Diameter AVP "Service-Selection" + Result = gen_server:call(?SERVER, {epdg_auth_req, ImsiStr, PdpTypeNr, Apn}), case Result of {ok, _Mar} -> epdg_ue_fsm:received_swm_auth_response(self(), Result), @@ -68,10 +71,10 @@ _ -> Result end. -handle_call({epdg_auth_req, Imsi}, {Pid, _Tag} = _From, State0) -> +handle_call({epdg_auth_req, Imsi, PdpTypeNr, Apn}, {Pid, _Tag} = _From, State0) -> % we yet don't implement the Diameter SWm interface on the wire, we process the call internally: {_Sess, State1} = find_or_new_swm_session(Imsi, Pid, State0), - ok = aaa_diameter_swm:auth_request(Imsi), + ok = aaa_diameter_swm:auth_request(Imsi, PdpTypeNr, Apn), {reply, ok, State1}; handle_call({epdg_auth_compl_req, Imsi, Apn}, _From, State) -> diff --git a/src/epdg_ue_fsm.erl b/src/epdg_ue_fsm.erl index 711f695..9221c79 100644 --- a/src/epdg_ue_fsm.erl +++ b/src/epdg_ue_fsm.erl @@ -40,7 +40,7 @@ -export([start_link/1, stop/1]). -export([init/1,callback_mode/0,terminate/3]). -export([get_server_name_by_imsi/1, get_pid_by_imsi/1]). --export([auth_request/1, lu_request/1, tunnel_request/1, purge_ms_request/1]). +-export([auth_request/2, lu_request/1, tunnel_request/1, purge_ms_request/1]). -export([received_swm_auth_response/2, received_swm_auth_compl_response/2, received_swm_session_termination_answer/2]). -export([received_gtpc_create_session_response/2, received_gtpc_delete_session_response/2, received_gtpc_delete_bearer_request/1]). -export([state_new/3, state_wait_auth_resp/3, state_authenticating/3, state_authenticated/3, @@ -69,10 +69,10 @@ stop(SrvRef) -> gen_statem:stop(SrvRef). -auth_request(Pid) -> +auth_request(Pid, {PdpTypeNr, Apn}) -> lager:info("ue_fsm auth_request~n", []), try - gen_statem:call(Pid, auth_request) + gen_statem:call(Pid, {auth_request, PdpTypeNr, Apn}) catch exit:Err -> {error, Err} @@ -183,9 +183,9 @@ state_new(enter, _OldState, Data) -> {keep_state, Data}; -state_new({call, From}, auth_request, Data) -> - lager:info("ue_fsm state_new event=auth_request, ~p~n", [Data]), - case epdg_diameter_swm:auth_request(Data#ue_fsm_data.imsi) of +state_new({call, From}, {auth_request, PdpTypeNr, Apn}, Data) -> + lager:info("ue_fsm state_new event=auth_request {~p, ~p}, ~p~n", [PdpTypeNr, Apn, Data]), + case epdg_diameter_swm:auth_request(Data#ue_fsm_data.imsi, PdpTypeNr, Apn) of ok -> {next_state, state_wait_auth_resp, Data, [{reply,From,ok}]}; {error, Err} -> {stop_and_reply, Err, Data, [{reply,From,{error,Err}}]} end; diff --git a/src/gsup_server.erl b/src/gsup_server.erl index 8a070bf..799d6df 100644 --- a/src/gsup_server.erl +++ b/src/gsup_server.erl @@ -231,9 +231,16 @@ {noreply, S#gsups_state{socket=Socket}}; % send auth info / requesting authentication tuples -handle_info({ipa, Socket, ?IPAC_PROTO_EXT_GSUP, _GsupMsgRx = #{message_type := send_auth_info_req, imsi := Imsi}}, State0) -> +handle_info({ipa, Socket, ?IPAC_PROTO_EXT_GSUP, GsupMsgRx = #{message_type := send_auth_info_req, imsi := Imsi}}, State0) -> + #{pdp_info_list := [PdpInfo]} = GsupMsgRx, + #{pdp_context_id := _PDPCtxId, + pdp_address := #{address := #{}, + pdp_type_nr := PdpTypeNr, + pdp_type_org := 241}, + access_point_name := Apn + } = PdpInfo, {UE, State1} = find_or_new_gsups_ue(Imsi, State0), - case epdg_ue_fsm:auth_request(UE#gsups_ue.pid) of + case epdg_ue_fsm:auth_request(UE#gsups_ue.pid, {PdpTypeNr, Apn}) of ok -> State2 = State1; {error, Err} -> lager:error("Auth Req for Imsi ~p failed: ~p~n", [Imsi, Err]), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3f29b00f57f433f8623b9f0a5048c83985e5cced Gerrit-Change-Number: 35901 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Add PDP-Info IE to GSUP Auth Info Req
by pespin 07 Feb '24

07 Feb '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35900?usp=email ) Change subject: epdg: Add PDP-Info IE to GSUP Auth Info Req ...................................................................... epdg: Add PDP-Info IE to GSUP Auth Info Req Strongswan already has this information during first IKE_AUTH message, see 3GPP TS 24.302 7.2.2.1. Change-Id: I42e4dc4bbcef969aae5867dbb103f8a5db157c89 --- M epdg/EPDG_Tests.ttcn M epdg/gen_links.sh M library/GSUP_Templates.ttcn 3 files changed, 31 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/35900/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 14bb060..aceedd4 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -5,6 +5,7 @@ import from Native_Functions all; import from Osmocom_Types all; import from L3_Common all; +import from DNS_Helpers all; import from IPA_Emulation all; import from GSUP_Types all; @@ -552,13 +553,17 @@ /* GSUP AuthInfo Req + Resp, triggers SWx MAR + MAA. */ private function f_GSUP_AI_success() runs on EPDG_ConnHdlr { var GSUP_PDU rx_gsup; - var template (present) GSUP_IE auth_tuple_ie := tr_GSUP_IE_AuthTuple3G(g_pars.vec.rand, - g_pars.vec.ik, - g_pars.vec.ck, - g_pars.vec.autn, - g_pars.vec.rand & g_pars.vec.auts); - - GSUP.send(ts_GSUP_SAI_REQ(g_pars.imsi)); + var template (present) GSUP_IE auth_tuple_ie; + var template (value) GSUP_IEs pdp_info; + auth_tuple_ie := tr_GSUP_IE_AuthTuple3G(g_pars.vec.rand, + g_pars.vec.ik, + g_pars.vec.ck, + g_pars.vec.autn, + g_pars.vec.rand & g_pars.vec.auts); + pdp_info := { ts_GSUP_IE_PDP_CONTEXT_ID('00'O), + ts_GSUP_IE_PDP_ADDRESS(ts_EuaIPv4Dyn), + ts_GSUP_IE_APN(f_enc_dns_hostname(g_pars.apn)) }; + GSUP.send(ts_GSUP_SAI_REQ_PDP_INFO(g_pars.imsi, pdp_info)); as_DIA_SWx_MA_success(); /* Expect a positive response back to the translator; expect AIA */ alt { diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh index 82a0785..c8eadc8 100755 --- a/epdg/gen_links.sh +++ b/epdg/gen_links.sh @@ -41,6 +41,7 @@ FILES="Misc_Helpers.ttcn General_Types.ttcn GSM_Types.ttcn Osmocom_Types.ttcn Native_Functions.ttcn Native_FunctionDefs.cc " FILES+="Osmocom_CTRL_Types.ttcn " FILES+="L3_Common.ttcn " +FILES+="DNS_Helpers.ttcn " FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc DIAMETER_Emulation.ttcn " FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn " FILES+="IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 3a616a6..05b8295 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -324,6 +324,12 @@ valueof(ts_GSUP_IE_NUM_VECTORS_REQ(num_auth_vectors)) }); +template (value) GSUP_PDU ts_GSUP_SAI_REQ_PDP_INFO(hexstring imsi, template (value) GSUP_IEs pdp_info) := + ts_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, { + valueof(ts_GSUP_IE_IMSI(imsi)), + valueof(ts_GSUP_IE_PdpInfo_ie(pdp_info)) + }); + template GSUP_PDU tr_GSUP_SAI_REQ(template hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, imsi); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42e4dc4bbcef969aae5867dbb103f8a5db157c89 Gerrit-Change-Number: 35900 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Avoid tx PurgeMS before doing handover in TC_ho_wifi_to_lte
by pespin 07 Feb '24

07 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35866?usp=email ) Change subject: epdg: Avoid tx PurgeMS before doing handover in TC_ho_wifi_to_lte ...................................................................... epdg: Avoid tx PurgeMS before doing handover in TC_ho_wifi_to_lte Change-Id: Ic6db92c79e055bc98d502620930ab36e9a4fd4fd --- M epdg/EPDG_Tests.ttcn 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 82a2375..becf2e9 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -585,10 +585,14 @@ setverdict(pass); } -private function f_TC_authinfo_normal(charstring id) runs on EPDG_ConnHdlr { +private function f_initial_attach() runs on EPDG_ConnHdlr { f_GSUP_AI_success(); f_GSUP_LU_success(); f_GSUP_EPDGTunnel_success(); +} + +private function f_TC_authinfo_normal(charstring id) runs on EPDG_ConnHdlr { + f_initial_attach(); f_GSUP_PurgeMS_success(); } @@ -602,7 +606,7 @@ } private function f_TC_ho_wifi_to_lte(charstring id) runs on EPDG_ConnHdlr { - f_TC_authinfo_normal(id); + f_initial_attach(); /* Whenever UE goes back to 3GPP, PGW will notify ePDG with a Delete Bearer Request * cause="Access changed from non-3gpp to 3gpp" */ f_GTP2C_DeleteBearer_success(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic6db92c79e055bc98d502620930ab36e9a4fd4fd Gerrit-Change-Number: 35866 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Expect GSUP CancelLocationReq as consequence of DeleteBearerReq
by pespin 07 Feb '24

07 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35883?usp=email ) Change subject: epdg: Expect GSUP CancelLocationReq as consequence of DeleteBearerReq ...................................................................... epdg: Expect GSUP CancelLocationReq as consequence of DeleteBearerReq Change-Id: Ibc37a9ef53315edab18f7b97a55cf504a40a4bf1 --- M epdg/EPDG_Tests.ttcn M library/GSUP_Templates.ttcn 2 files changed, 46 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index becf2e9..e5cdafd 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -504,6 +504,7 @@ private function f_GTP2C_DeleteBearer_success() runs on EPDG_ConnHdlr { var integer proc_trans_id := 3; GTP2.send(ts_GTP2C_DeleteBearerReq(g_pars.teic_remote, proc_trans_id, g_pars.bearer.ebi, Access_changed_from_Non_3GPP_to_3GPP)); + as_GSUP_CancelLocation_success(); as_GTP2C_DeleteBearer_success(); } @@ -585,6 +586,18 @@ setverdict(pass); } +/* Expect CancelLocationReq */ +private altstep as_GSUP_CancelLocation_success() runs on EPDG_ConnHdlr { + var GSUP_PDU rx_gsup; + + [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi)) -> value rx_gsup { + GSUP.send(ts_GSUP_CL_RES(g_pars.imsi)); + } + [] GSUP.receive(GSUP_PDU:?) -> value rx_gsup { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GSUP msg rx: ", rx_gsup)); + } +} + private function f_initial_attach() runs on EPDG_ConnHdlr { f_GSUP_AI_success(); f_GSUP_LU_success(); diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 291b59a..3a616a6 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -403,6 +403,14 @@ template GSUP_PDU tr_GSUP_AUTH_FAIL_IND(hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_AUTH_FAIL_REPORT, imsi); +template (present) GSUP_PDU tr_GSUP_CL_REQ(template (present) hexstring imsi := ?, + template GSUP_CnDomain dom := omit, + template GSUP_CancelType ctype := omit) := + tr_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_REQUEST, + f_gen_tr_ies(imsi, + cancel_type := ctype, + cn_domain := dom)); + template (value) GSUP_PDU ts_GSUP_CL_REQ(hexstring imsi, GSUP_CancelType ctype) := ts_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_REQUEST, { valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_CancelType(ctype)) }); @@ -410,6 +418,9 @@ template GSUP_PDU tr_GSUP_CL_RES(template hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT, imsi); +template (value) GSUP_PDU ts_GSUP_CL_RES(template (value) hexstring imsi) := + ts_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT, {valueof(ts_GSUP_IE_IMSI(imsi))}); + template GSUP_PDU tr_GSUP_CL_ERR(template hexstring imsi, template integer cause := ?) := tr_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_ERROR, { tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause), * }); @@ -548,7 +559,7 @@ val := val } -template (value) GSUP_IE ts_GSUP_IE_IMSI(hexstring imsi) := { +template (value) GSUP_IE ts_GSUP_IE_IMSI(template (value) hexstring imsi) := { tag := OSMO_GSUP_IMSI_IE, len := 0, /* overwritten */ val := { @@ -1184,8 +1195,10 @@ template GSUP_IEs pdp_info := omit, template GSUP_Message_Class message_class := omit, template integer cause := omit, + template GSUP_CancelType cancel_type := omit, template hexstring msisdn := omit, template GSUP_IMEIResult imei_result := omit, + template GSUP_CnDomain cn_domain := omit, template octetstring source_name := omit, template octetstring destination_name := omit ) return template GSUP_IEs { @@ -1204,6 +1217,11 @@ idx := idx + 1; } + if (not istemplatekind(cancel_type, "omit")) { + ies[idx] := tr_GSUP_IE_CancelType(cancel_type); + idx := idx + 1; + } + if (not istemplatekind(pdp_info_compl, "omit")) { ies[idx] := tr_GSUP_IE_PdpInfoCompl; idx := idx + 1; @@ -1214,6 +1232,11 @@ idx := idx + 1; } + if (not istemplatekind(cn_domain, "omit")) { + ies[idx] := tr_GSUP_IE_CnDomain(cn_domain); + idx := idx + 1; + } + if (not istemplatekind(imei_result, "omit")) { ies[idx] := tr_GSUP_IE_IMEI_Result(imei_result); idx := idx + 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc37a9ef53315edab18f7b97a55cf504a40a4bf1 Gerrit-Change-Number: 35883 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_ho_lte_to_wifi
by pespin 07 Feb '24

07 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35884?usp=email ) Change subject: epdg: Introduce test TC_ho_lte_to_wifi ...................................................................... epdg: Introduce test TC_ho_lte_to_wifi This test emulates a UE doing handover to ePDG, when it may create extra dedicated bearers. Change-Id: Ibdfeda1fa5d7016b1952d64b306cd501cb33f61b --- M epdg/EPDG_Tests.ttcn M library/GTPv2_Templates.ttcn 2 files changed, 137 insertions(+), 21 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index e5cdafd..14bb060 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -488,6 +488,47 @@ } } +/* Expect CreateBearerResponse */ +private altstep as_GTP2C_CreateBearer_success() runs on EPDG_ConnHdlr { + var PDU_GTPCv2 rx_msg; + + [] GTP2.receive(tr_GTP2C_CreateBearerResp(g_pars.teic_local)) -> value rx_msg { + setverdict(pass); + } + [] GTP2.receive(PDU_GTPCv2:?) -> value rx_msg { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GTP2C msg rx: ", rx_msg)); + } +} +private function f_GTP2C_CreateBearer_success(uint4_t dedicated_bearer_id := 6) runs on EPDG_ConnHdlr { + + var template (value) FullyQualifiedTEID fteid_u_ie := ts_GTP2C_FTEID(FTEID_IF_S2bU_ePDG_GTPU, g_pars.bearer.teid_local, dedicated_bearer_id, + f_inet_addr(mp_s2b_local_ip), omit); + var template (value) FullyQualifiedTEID_List teid_list := { fteid_u_ie }; + + var template (value) FullyQualifiedPDN_ConnectionSetID pgw_fq_csid := ts_GTP2C_FQCSID_IPv4(f_inet_addr(mp_s2b_local_ip), int2oct(dedicated_bearer_id, 2)); + var template (value) FullyQualifiedPDN_ConnectionSetID_List csid_list := { pgw_fq_csid }; + + var template (value) BearerContextGrouped_List bcg_list := { + ts_GTP2C_BcGrouped({ + ePS_Bearer_ID := ts_GTP2C_EpsBearerId(dedicated_bearer_id), + cause := omit, + ePS_Bearer_TFT := omit, + fullyQualifiedTEID := teid_list, + bearerLevel_QoS := ts_GTP2C_BearerQos('09'O, 0,0,0,0), + chargingID := ts_GTP2C_ChargingID(f_rnd_octstring(4)), + bearerFlags := omit, + transactionIdentifier := omit, + protocolConfigOptions := omit, + rAN_NASCause := omit, + additionalProtocolConfigOptions := omit, + extendedProtocolConfigOptions := omit + }) + }; + GTP2.send(ts_GTP2C_CreateBearerReq(g_pars.teic_remote, omit, g_pars.bearer.ebi, + dedicated_bearer_id, bcg_list, csid_list)); + as_GTP2C_CreateBearer_success(); +} + /* Expect DeleteBearerResponse */ private altstep as_GTP2C_DeleteBearer_success() runs on EPDG_ConnHdlr { var PDU_GTPCv2 rx_msg; @@ -618,6 +659,23 @@ setverdict(pass); } +private function f_TC_ho_lte_to_wifi(charstring id) runs on EPDG_ConnHdlr { + f_initial_attach(); + /* Whenever UE comes from 3GPP, PGW may activate a dedicated S2b bearer + * and notify ePDG with a Create Bearer Request */ + f_GTP2C_CreateBearer_success(); + f_GSUP_PurgeMS_success(); +} + +testcase TC_ho_lte_to_wifi() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_ho_lte_to_wifi), pars); + vc_conn.done; + setverdict(pass); +} + private function f_TC_ho_wifi_to_lte(charstring id) runs on EPDG_ConnHdlr { f_initial_attach(); /* Whenever UE goes back to 3GPP, PGW will notify ePDG with a Delete Bearer Request @@ -636,6 +694,7 @@ control { execute ( TC_authinfo_normal() ); + execute ( TC_ho_lte_to_wifi() ); execute ( TC_ho_wifi_to_lte() ); } diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index afe0138..9f242ee 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -671,6 +671,13 @@ pTI_Value := pti, additionalOctets := omit } +private function f_ts_GTP2C_ProcTransId_omit(template (omit) integer pti) +return template (omit) ProcedureTransactionID { + if (istemplatekind(pti, "omit")) { + return omit; + } + return ts_GTP2C_ProcTransId(pti); +} template (present) ProcedureTransactionID tr_GTP2C_ProcTransId(template (present) integer pti) := { elementIdentifier := '64'O, @@ -725,7 +732,35 @@ additionalOctets := * } - +/* 8.62 Fully qualified PDN Connection Set Identifier (FQ-CSID) */ +template (value) NodeID ts_GTP2C_FQCSID_NodeID_IPv4(template (value) OCT4 addr) := { + globalUnicastIPv4 := addr +} +template (value) FullyQualifiedPDN_ConnectionSetID +ts_GTP2C_FQCSID(template (value) integer nRofCSIDs, + template (value) integer nodeIDType, + template (value) NodeID nodeID, + template (value) PDN_CSID_List pDN_CSID_List, + template (value) uint4_t instance := 0) := { + elementIdentifier := '84'O, + lengthIndicator := 0, /* overwritten */ + instance := int2bit(valueof(instance), 4), + spare := '0000'B, + nRofCSIDs := nRofCSIDs, + nodeIDType := nodeIDType, + nodeID := nodeID, + pDN_CSID_List := pDN_CSID_List, + additionalOctets := omit +} +template (value) FullyQualifiedPDN_ConnectionSetID +ts_GTP2C_FQCSID_IPv4(template (value) OCT4 addr, + template (value) OCT2 csid, + template (value) uint4_t instance := 0) := +ts_GTP2C_FQCSID(nRofCSIDs := 1, + nodeIDType := 0, + nodeID := ts_GTP2C_FQCSID_NodeID_IPv4(addr), + pDN_CSID_List := {csid}, + instance := instance); template (value) PDU_GTPCv2 ts_PDU_GTP2C(template (omit) OCT4 teid, template (value) OCT3 seq, @@ -1068,33 +1103,19 @@ template (value) PDU_GTPCv2 ts_GTP2C_CreateBearerReq(template (value) OCT4 d_teid, - template (value) integer proc_trans_id, + template (omit) integer proc_trans_id, template (value) uint4_t linked_id, template (value) uint4_t bearer_id, - template (omit) FullyQualifiedTEID_List teid_list, + template (value) BearerContextGrouped_List bearer_ctx_list, + template (omit) FullyQualifiedPDN_ConnectionSetID_List csid := omit, template (value) Bearer_QoS qos := ts_GTP2C_BearerQos('09'O, 0,0,0,0)) := ts_PDU_GTP2C(d_teid, '000000'O, '5F'O, { createBearerRequest := { - procedureTransactionID := ts_GTP2C_ProcTransId(proc_trans_id), + procedureTransactionID := f_ts_GTP2C_ProcTransId_omit(proc_trans_id), linkedEPS_BearerID := ts_GTP2C_EpsBearerId(linked_id), protocolConfigOptions := omit, - bearerContextGrouped := { - ts_GTP2C_BcGrouped({ - ePS_Bearer_ID := ts_GTP2C_EpsBearerId(bearer_id), - cause := omit, - ePS_Bearer_TFT := omit, - fullyQualifiedTEID := teid_list, - bearerLevel_QoS := qos, - chargingID := omit, - bearerFlags := omit, - transactionIdentifier := omit, - protocolConfigOptions := omit, - rAN_NASCause := omit, - additionalProtocolConfigOptions := omit, - extendedProtocolConfigOptions := omit - }) - }, - csid := omit, + bearerContextGrouped := bearer_ctx_list, + csid := csid, changeReportingAction := omit, cSG_InformationReportingAction := omit, heNBInformationReporting := omit, @@ -1105,6 +1126,30 @@ nBIFOMContainer := omit, privateExtension := omit }}); +template (present) PDU_GTPCv2 +tr_GTP2C_CreateBearerResp(template (present) OCT4 d_teid, + template (present) OCT3 seq := ?, + template (present) GTP2C_Cause cause := ? + ) := +tr_PDU_GTP2C(d_teid, seq, { + createBearerResponse := { + cause := tr_GTP2C_Cause(cause), + bearerContextGrouped := *, + recovery := *, + csid := *, + protocolConfigOptions := *, + uE_TimeZone := *, + uLI := *, + trustedWLANAccessNetworkIdentifier := *, + overloadControlInformationGrouped := *, + presenceReportingAreaInformation := *, + iP_Addr := *, + wLANLocationTimestamp := *, + portNumber := *, + nBIFOMContainer := *, + extendedProtocolConfigOptions := *, + privateExtension:= * + }}); template (present) PDU_GTPCv2 tr_GTP2C_ModifyBearerReq(template (present) OCT4 d_teid := ?, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdfeda1fa5d7016b1952d64b306cd501cb33f61b Gerrit-Change-Number: 35884 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_ho_lte_to_wifi
by pespin 07 Feb '24

07 Feb '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35884?usp=email ) Change subject: epdg: Introduce test TC_ho_lte_to_wifi ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdfeda1fa5d7016b1952d64b306cd501cb33f61b Gerrit-Change-Number: 35884 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 07 Feb 2024 16:36:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Expect GSUP CancelLocationReq as consequence of DeleteBearerReq
by pespin 07 Feb '24

07 Feb '24

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35883?usp=email ) Change subject: epdg: Expect GSUP CancelLocationReq as consequence of DeleteBearerReq ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc37a9ef53315edab18f7b97a55cf504a40a4bf1 Gerrit-Change-Number: 35883 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 07 Feb 2024 16:36:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log