Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35943?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Use gtp_u_kmod to create a gtp tundev
......................................................................
Use gtp_u_kmod to create a gtp tundev
Adding gtp_u_kmod app in osmo_epdg.app.src makes the module app started
and create gtp tunnel based on config file upon startup.
No other operation is done yet on the tunnel, but this step already
allows testing by manually creating pdp contexts outside of the app.
The module gtp_u_kmod currently creates the tundev interface with name
"gtp0" (hardcoded).
The module gtp_u_kmod will fail if the gtp tundev is already created, so
be sure to have it removed before starting osmo-epdg.
Change-Id: Ie7718e1b161477bd738fa75f803ab37e9f35121d
---
M config/sys.config
M debian/osmo-epdg.install
M debian/rules
M rebar.config
M rebar.lock
M src/osmo_epdg.app.src
6 files changed, 76 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/43/35943/3
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35943?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ie7718e1b161477bd738fa75f803ab37e9f35121d
Gerrit-Change-Number: 35943
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35943?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Use gtp_u_kmod to create a gtp tundev
......................................................................
Use gtp_u_kmod to create a gtp tundev
Adding gtp_u_kmod app in osmo_epdg.app.src makes the module app started
and create gtp tunnel based on config file upon startup.
No other operation is done yet on the tunnel, but this step already
allows testing by manually creating pdp contexts outside of the app.
The module gtp_u_kmod currently creates the tundev interface with name
"gtp0" (hardcoded).
The module gtp_u_kmod will fail if the gtp tundev is already created, so
be sure to have it removed before starting osmo-epdg.
Change-Id: Ie7718e1b161477bd738fa75f803ab37e9f35121d
---
M config/sys.config
M debian/osmo-epdg.install
M debian/rules
M rebar.config
M rebar.lock
M src/osmo_epdg.app.src
6 files changed, 74 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/43/35943/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35943?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ie7718e1b161477bd738fa75f803ab37e9f35121d
Gerrit-Change-Number: 35943
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35944?usp=email )
Change subject: Create pdp context in the tundev
......................................................................
Create pdp context in the tundev
Use gtp_u_kmod call to create a pdp context in the gtp interface.
Change-Id: I4e0b3fe0e3e156c9a20df0ab8cdfc447fd9bb1eb
---
M src/gtp_u_tun.erl
1 file changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/44/35944/1
diff --git a/src/gtp_u_tun.erl b/src/gtp_u_tun.erl
index e08b804..626c9a4 100644
--- a/src/gtp_u_tun.erl
+++ b/src/gtp_u_tun.erl
@@ -64,7 +64,5 @@
%RemoteTEID = 56768, % TODO: this should be set to TEID obtained from CreateSessionResponse
PeerIP = conv:bin_to_ip(PeerAddr), % TODO: IPv6
UEIP = conv:bin_to_ip(EUA#epdg_eua.ipv4), % TODO: IPv6.
- ok.
- % TODO: This will be enabled once we depend on the gtp_u_kmod module:
- %ServRef = get_env_gtp_u_kmod_server_ref(),
- %gen_server:call(ServRef, {PeerIP, UEIP, LocalTEID, RemoteTEID}).
\ No newline at end of file
+ ServRef = get_env_gtp_u_kmod_server_ref(),
+ gen_server:call(ServRef, {PeerIP, UEIP, LocalTEID, RemoteTEID}).
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35944?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I4e0b3fe0e3e156c9a20df0ab8cdfc447fd9bb1eb
Gerrit-Change-Number: 35944
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35932?usp=email )
Change subject: epdg: Fix UsernMame being NAI instead of IMSI in S6b AAR
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35932?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifa5b262db40b649c6dfe7b5ac43098208b3e8300
Gerrit-Change-Number: 35932
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Feb 2024 09:52:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment