- gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to co...
by pespin 13 Feb '24

13 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email ) Change subject: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to correct place ...................................................................... cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to correct place All the different procedures are placed in order, except this one. Change-Id: If0877deca2bcbf40229c9c61f471112f1e8cdb0e --- M tests/gsup/gsup_test.c 1 file changed, 25 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/tests/gsup/gsup_test.c b/tests/gsup/gsup_test.c index 3d7ea40..fb3708a 100644 --- a/tests/gsup/gsup_test.c +++ b/tests/gsup/gsup_test.c @@ -454,20 +454,6 @@ 0x51, /* GSM0808_CAUSE_INVALID_MESSAGE_CONTENTS */ }; - static const uint8_t send_e_process_access_signalling_req[] = { - 0x40, /* OSMO_GSUP_MSGT_E_PROCESS_ACCESS_SIGNALLING_REQUEST */ - TEST_IMSI_IE, - - /* Session ID and state (continue) */ - 0x30, 0x04, 0xde, 0xad, 0xbe, 0xef, - 0x31, 0x01, 0x02, - - TEST_CLASS_INTER_MSC_IE, - TEST_SOURCE_NAME_IE, - TEST_DESTINATION_NAME_IE, - TEST_AN_APDU_IE, /* (Handover Detect) */ - }; - static const uint8_t send_e_send_end_signal_res[] = { 0x3E, /* OSMO_GSUP_MSGT_E_SEND_END_SIGNAL_RESULT */ TEST_IMSI_IE, @@ -482,6 +468,20 @@ TEST_AN_APDU_IE, /* (Handover Complete) */ }; + static const uint8_t send_e_process_access_signalling_req[] = { + 0x40, /* OSMO_GSUP_MSGT_E_PROCESS_ACCESS_SIGNALLING_REQUEST */ + TEST_IMSI_IE, + + /* Session ID and state (continue) */ + 0x30, 0x04, 0xde, 0xad, 0xbe, 0xef, + 0x31, 0x01, 0x02, + + TEST_CLASS_INTER_MSC_IE, + TEST_SOURCE_NAME_IE, + TEST_DESTINATION_NAME_IE, + TEST_AN_APDU_IE, /* (Handover Detect) */ + }; + static const uint8_t send_e_forward_access_signalling_req [] = { 0x44, /* OSMO_GSUP_MSGT_E_FORWARD_ACCESS_SIGNALLING_REQUEST */ TEST_IMSI_IE, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0877deca2bcbf40229c9c61f471112f1e8cdb0e Gerrit-Change-Number: 35942 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to co...
by fixeria 13 Feb '24

13 Feb '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email ) Change subject: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to correct place ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0877deca2bcbf40229c9c61f471112f1e8cdb0e Gerrit-Change-Number: 35942 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Feb 2024 09:08:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req
by pespin 13 Feb '24

13 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35899?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req ...................................................................... gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req Change-Id: Iccb397410d1b08c8fbc87fdcad1e787f025a5d9f --- M common/chapters/gsup.adoc 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index a0023dd..1f70c5b 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -362,12 +362,17 @@ |28|CN Domain|<<gsup-ie-cndomain>>|O|TLV|3 |26|AUTS|<<gsup-ie-auts>>|C|TLV|18 |20|RAND|<<gsup-ie-rand>>|C|TLV|18 +|05|PDP info|<<gsup-ie-pdpinfo>>|C|TLV|2-N |=== The conditional 'AUTS' and 'RAND' IEs are both present in case the SIM (via UE) requests an UMTS AKA re-synchronization procedure. Either both optional IEs are present, or none of them. +The conditional 'PDP Info' IE is only present in the CEAI interface used by the +ePDG. It should contain the 'PDP Context ID', 'PDP Address' (dynamic addressing) +and 'Access Point Name' IEs. + [[gsup-msg-auth-info-err]] ==== Send Authentication Info Error @@ -446,7 +451,7 @@ |08|MSISDN|<<gsup-ie-msisdn>>|O|TLV|0-9 |09|HLR Number|<<gsup-ie-hlr>>|O|TLV|0-9 |04|PDP info complete|<<gsup-ie-empty>>|O|TLV|2 -|05|PDP info|<<gsup-ie-pdpinfo>>|O|TLV|1-10 +|05|PDP info|<<gsup-ie-pdpinfo>>|O|TLV|2-N |=== If the PDP info complete IE is present, the old PDP info list shall be cleared. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iccb397410d1b08c8fbc87fdcad1e787f025a5d9f Gerrit-Change-Number: 35899 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-gsm-manuals[master]: gsup.adoc: Add links to section of each message type in table
by pespin 13 Feb '24

13 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email ) Change subject: gsup.adoc: Add links to section of each message type in table ...................................................................... gsup.adoc: Add links to section of each message type in table Change-Id: Idbc8a8f2e41f90e545a420517bd030399fb229ac --- M common/chapters/gsup.adoc 1 file changed, 112 insertions(+), 35 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index 912ff6b..a0023dd 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -349,6 +349,7 @@ (Optional) or 'C' (Conditional). The 'format' column holds either 'V' (Value) or 'TLV' (Tag Length Value). +[[gsup-msg-auth-info-req]] ==== Send Authentication Info Request Direction: SGSN / VLR => HLR @@ -367,6 +368,7 @@ (via UE) requests an UMTS AKA re-synchronization procedure. Either both optional IEs are present, or none of them. +[[gsup-msg-auth-info-err]] ==== Send Authentication Info Error Direction: HLR => SGSN / VLR @@ -379,6 +381,7 @@ |02|Cause|<<gsup-ie-cause>>|M|TLV|3 |=== +[[gsup-msg-auth-info-res]] ==== Send Authentication Info Response Direction: HLR => SGSN / VLR @@ -391,6 +394,7 @@ |03|Auth Tuple|<<gsup-ie-authtuple>>|0-5|TLV|36 |=== +[[gsup-msg-auth-fail-rep]] ==== Authentication Failure Report Direction: SGSN / VLR => HLR @@ -403,6 +407,7 @@ |28|CN Domain|<<gsup-ie-cndomain>>|O|TLV|3 |=== +[[gsup-msg-upd-loc-req]] ==== Update Location Request Direction: SGSN / VLR => HLR @@ -415,6 +420,7 @@ |28|CN Domain|<<gsup-ie-cndomain>>|O|TLV|3 |=== +[[gsup-msg-upd-loc-err]] ==== Update Location Error Direction: HLR => SGSN / VLR @@ -427,6 +433,7 @@ |02|Cause|<<gsup-ie-cause>>|M|TLV|3 |=== +[[gsup-msg-upd-loc-res]] ==== Update Location Result Direction: HLR => SGSN / VLR @@ -444,6 +451,7 @@ If the PDP info complete IE is present, the old PDP info list shall be cleared. +[[gsup-msg-loc-cancel-req]] ==== Location Cancellation Request Direction: HLR => SGSN / VLR @@ -457,6 +465,14 @@ |06|Cancellation type|<<gsup-ie-canctype>>|O|TLV|3 |=== +[[gsup-msg-loc-cancel-err]] +==== Location Cancellation Error + +Direction: SGSN / VLR => HLR + +TODO + +[[gsup-msg-loc-cancel-res]] ==== Location Cancellation Result Direction: SGSN / VLR => HLR @@ -469,6 +485,7 @@ |28|CN Domain|<<gsup-ie-cndomain>>|O|TLV|3 |=== +[[gsup-msg-purge-ms-req]] ==== Purge MS Request Direction: SGSN / VLR => HLR @@ -482,6 +499,7 @@ |09|HLR Number|<<gsup-ie-hlr>>|M|TLV|0-9 |=== +[[gsup-msg-purge-ms-err]] ==== Purge MS Error Direction: HLR => SGSN / VLR @@ -494,6 +512,7 @@ |02|Cause|<<gsup-ie-cause>>|M|TLV|3 |=== +[[gsup-msg-purge-ms-res]] ==== Purge MS Result Direction: HLR => SGSN / VLR @@ -506,6 +525,7 @@ |07|Freeze P-TMSI|<<gsup-ie-empty>>|M|TLV|2 |=== +[[gsup-msg-ins-sub-req]] ==== Insert Subscriber Data Request Direction: HLR => SGSN / VLR @@ -525,6 +545,7 @@ If the PDP info complete IE is present, the old PDP info list shall be cleared. +[[gsup-msg-ins-sub-err]] ==== Insert Subscriber Data Error Direction: SGSN / VLR => HLR @@ -537,6 +558,7 @@ |02|Cause|<<gsup-ie-cause>>|M|TLV|3 |=== +[[gsup-msg-ins-sub-res]] ==== Insert Subscriber Data Result Direction: SGSN / VLR => HLR @@ -548,6 +570,7 @@ |01|IMSI|<<gsup-ie-imsi>>|M|TLV|2-10 |=== +[[gsup-msg-del-sub-req]] ==== Delete Subscriber Data Request Direction: HLR => SGSN / VLR @@ -561,6 +584,7 @@ |10|PDP Context ID|<<gsup-ie-pdpctxid>>|C|TLV|3 |=== +[[gsup-msg-del-sub-err]] ==== Delete Subscriber Data Error Direction: SGSN / VLR => HLR @@ -573,6 +597,7 @@ |02|Cause|<<gsup-ie-cause>>|M|TLV|3 |=== +[[gsup-msg-del-sub-res]] ==== Delete Subscriber Data Result Direction: HLR => SGSN / VLR @@ -584,6 +609,7 @@ |01|IMSI|<<gsup-ie-imsi>>|M|TLV|2-10 |=== +[[gsup-msg-proc-supl-serv-req]] ==== Process Supplementary Service Request Direction: bidirectional @@ -602,6 +628,7 @@ it is not known is it request or response without parsing the GSM 04.80 payload. +[[gsup-msg-proc-supl-serv-err]] ==== Process Supplementary Service Error Direction: EUSE / HLR => MSC @@ -616,6 +643,7 @@ |02|Cause|<<gsup-ie-cause>>|M|TLV|3 |=== +[[gsup-msg-proc-supl-serv-res]] ==== Process Supplementary Service Response Direction: EUSE / HLR => MSC @@ -634,6 +662,7 @@ can be used to notify the MSC that a structured supplementary service is successfully activated or deactivated, etc. +[[gsup-msg-mo-forwardsm-req]] ==== MO-forwardSM Request Direction: MSC / SGSN => SMSC (via HLR) @@ -653,6 +682,7 @@ The corresponding MAP service is MAP-MO-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.2. +[[gsup-msg-mo-forwardsm-err]] ==== MO-forwardSM Error Direction: SMSC (via HLR) => MSC / SGSN @@ -671,6 +701,7 @@ MO short message delivery. The corresponding MAP service is MAP-MO-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.2. +[[gsup-msg-mo-forwardsm-res]] ==== MO-forwardSM Result Direction: SMSC (via HLR) => MSC / SGSN @@ -687,6 +718,7 @@ MO short message delivery. The corresponding MAP service is MAP-MO-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.2. +[[gsup-msg-mt-forwardsm-req]] ==== MT-forwardSM Request Direction: SMSC (via HLR) => MSC / SGSN @@ -707,6 +739,7 @@ The corresponding MAP service is MAP-MT-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.9. +[[gsup-msg-mt-forwardsm-err]] ==== MT-forwardSM Error Direction: MSC / SGSN => SMSC (via HLR) @@ -725,6 +758,7 @@ MT short message delivery. The corresponding MAP service is MAP-MT-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.9. +[[gsup-msg-mt-forwardsm-res]] ==== MT-forwardSM Result Direction: MSC / SGSN => SMSC (via HLR) @@ -741,6 +775,7 @@ MT short message delivery. The corresponding MAP service is MAP-MT-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.9. +[[gsup-msg-ready-for-sm-req]] ==== READY-FOR-SM Request Direction: MSC / SGSN => SMSC (via HLR) @@ -759,6 +794,7 @@ The corresponding MAP service is MAP-READY-FOR-SM, see 3GPP TS 29.002, section 12.4. +[[gsup-msg-ready-for-sm-err]] ==== READY-FOR-SM Error Direction: SMSC (via HLR) => MSC / SGSN @@ -777,6 +813,7 @@ MO SMMA (Memory Available) indication. The corresponding MAP service is MAP-READY-FOR-SM, see 3GPP TS 29.002, section 12.4. +[[gsup-msg-ready-for-sm-res]] ==== READY-FOR-SM Result Direction: SMSC (via HLR) => MSC / SGSN @@ -793,6 +830,7 @@ MO SMMA (Memory Available) indication. The corresponding MAP service is MAP-READY-FOR-SM, see 3GPP TS 29.002, section 12.4. +[[gsup-msg-check-imei-req]] ==== CHECK-IMEI Request Direction: VLR => EIR (via HLR) @@ -805,6 +843,7 @@ |50|IMEI|<<gsup-ie-imei>>|M|TLV|11 |=== +[[gsup-msg-check-imei-err]] ==== CHECK-IMEI Error Direction: EIR (via HLR) => VLR @@ -817,6 +856,7 @@ |02|Cause|<<gsup-ie-cause>>|M|TLV|3 |=== +[[gsup-msg-check-imei-res]] ==== CHECK-IMEI Result Direction: EIR (via HLR) => VLR @@ -829,6 +869,7 @@ |51|IMEI Check Result|<<gsup-ie-imei-result>>|M|TLV|3 |=== +[[gsup-msg-e-prep-ho-req]] ==== E Prepare Handover Request Direction: MSC-A=MSC-I => MSC-B=MSC-T (via HLR) @@ -844,6 +885,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-prep-ho-err]] ==== E Prepare Handover Error Direction: MSC-B=MSC-T => MSC-A=MSC-I (via HLR) @@ -859,6 +901,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-prep-ho-res]] ==== E Prepare Handover Result Direction: MSC-B=MSC-T => MSC-A=MSC-I (via HLR) @@ -874,6 +917,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-prep-subs-ho-req]] ==== E Prepare Subsequent Handover Request Direction: MSC-B=MSC-I => MSC-A (via HLR) @@ -889,6 +933,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-prep-subs-ho-err]] ==== E Prepare Subsequent Handover Error Direction: MSC-A => MSC-B=MSC-I (via HLR) @@ -904,6 +949,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-prep-subs-ho-res]] ==== E Prepare Subsequent Handover Result Direction: MSC-A => MSC-B=MSC-I (via HLR) @@ -919,6 +965,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-snd-end-sig-req]] ==== E Send End Signal Request Direction: MSC-B=MSC-T => MSC-A=MSC-I (via HLR) @@ -934,6 +981,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-snd-end-sig-err]] ==== E Send End Signal Error Direction: MSC-A=MSC-I => MSC-B=MSC-T (via HLR) @@ -949,6 +997,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-snd-end-sig-res]] ==== E Send End Signal Result Direction: MSC-A => MSC-B=MSC-I (via HLR) @@ -964,6 +1013,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-proc-acc-sig-req]] ==== E Process Access Signalling Request Direction: MSC-B=MSC-T => MSC-A=MSC-I (via HLR) @@ -979,6 +1029,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-forw-acc-sig-req]] ==== E Forward Access Signalling Request Direction: MSC-A => MSC-B=MSC-I (via HLR) @@ -994,6 +1045,7 @@ |62|AN-APDU|<<gsup-ie-an-apdu>>|M|TLV|2-... |=== +[[gsup-msg-e-close]] ==== E Close Direction: MSC-A => MSC-B (via HLR) @@ -1008,11 +1060,13 @@ |61|Destination Name|<<gsup-ie-destination-name>>|M|TLV|2-... |=== +[[gsup-msg-e-abort]] ==== E Abort This message was added to GSUP for the inter-MSC handover. But so far it is not used yet. +[[gsup-msg-e-routing-err]] ==== E Routing Error Direction: GSUP Server (HLR) => GSUP Client (MSC) @@ -1037,41 +1091,55 @@ [options="header",cols="10%,90%"] |=== -|Type|Description -|0x04|Update Location Request -|0x05|Update Location Error -|0x06|Update Location Result -|0x08|Send Authentication Info Request -|0x09|Send Authentication Info Error -|0x0a|Send Authentication Info Result -|0x0b|Authentication Failure Report -|0x0c|Purge MS Request -|0x0d|Purge MS Error -|0x0e|Purge MS Result -|0x10|Insert Subscriber Data Request -|0x11|Insert Subscriber Data Error -|0x12|Insert Subscriber Data Result -|0x14|Delete Subscriber Data Request -|0x15|Delete Subscriber Data Error -|0x16|Delete Subscriber Data Result -|0x1c|Location Cancellation Request -|0x1d|Location Cancellation Error -|0x1e|Location Cancellation Result -|0x20|Supplementary Service Request -|0x21|Supplementary Service Error -|0x22|Supplementary Service Result -|0x24|MO-forwardSM Request -|0x25|MO-forwardSM Error -|0x26|MO-forwardSM Result -|0x28|MT-forwardSM Request -|0x29|MT-forwardSM Error -|0x2a|MT-forwardSM Result -|0x2c|READY-FOR-SM Request -|0x2d|READY-FOR-SM Error -|0x2e|READY-FOR-SM Result -|0x30|CHECK-IMEI Request -|0x31|CHECK-IMEI Error -|0x32|CHECK-IMEI Result +|Type|Name|Description +|0x04|Update Location Request|<<gsup-msg-upd-loc-req>> +|0x05|Update Location Error|<<gsup-msg-upd-loc-err>> +|0x06|Update Location Result|<<gsup-msg-upd-loc-res>> +|0x08|Send Authentication Info Request|<<gsup-msg-auth-info-req>> +|0x09|Send Authentication Info Error|<<gsup-msg-auth-info-err>> +|0x0a|Send Authentication Info Result|<<gsup-msg-auth-info-res>> +|0x0b|Authentication Failure Report|<<gsup-msg-auth-fail-rep>> +|0x0c|Purge MS Request|<<gsup-msg-purge-ms-reqs>> +|0x0d|Purge MS Error|<<gsup-msg-purge-ms-err>> +|0x0e|Purge MS Result|<<gsup-msg-purge-ms-res>> +|0x10|Insert Subscriber Data Request|<<gsup-msg-ins-sub-req>> +|0x11|Insert Subscriber Data Error|<<gsup-msg-ins-sub-err>> +|0x12|Insert Subscriber Data Result|<<gsup-msg-ins-sub-res>> +|0x14|Delete Subscriber Data Request|<<gsup-msg-del-sub-req>> +|0x15|Delete Subscriber Data Error|<<gsup-msg-del-sub-err>> +|0x16|Delete Subscriber Data Result|<<gsup-msg-del-sub-res>> +|0x1c|Location Cancellation Request|<<gsup-msg-loc-cancel-req>> +|0x1d|Location Cancellation Error|<<gsup-msg-loc-cancel-err>> +|0x1e|Location Cancellation Result|<<gsup-msg-loc-cancel-res>> +|0x20|Supplementary Service Request|<<gsup-msg-proc-supl-serv-req>> +|0x21|Supplementary Service Error|<<gsup-msg-proc-supl-serv-err>> +|0x22|Supplementary Service Result|<<gsup-msg-proc-supl-serv-res>> +|0x24|MO-forwardSM Request|<<gsup-msg-mo-forwardsm-req>> +|0x25|MO-forwardSM Error|<<gsup-msg-mo-forwardsm-err>> +|0x26|MO-forwardSM Result|<<gsup-msg-mo-forwardsm-res>> +|0x28|MT-forwardSM Request|<<gsup-msg-mt-forwardsm-req>> +|0x29|MT-forwardSM Error|<<gsup-msg-mt-forwardsm-err>> +|0x2a|MT-forwardSM Result|<<gsup-msg-mt-forwardsm-res>> +|0x2c|READY-FOR-SM Request|<<gsup-msg-ready-for-sm-req>> +|0x2d|READY-FOR-SM Error|<<gsup-msg-ready-for-sm-err>> +|0x2e|READY-FOR-SM Result|<<gsup-msg-ready-for-sm-res>> +|0x30|CHECK-IMEI Request|<<gsup-msg-check-imei-req>> +|0x31|CHECK-IMEI Error|<<gsup-msg-check-imei-err>> +|0x32|CHECK-IMEI Result|<<gsup-msg-check-imei-res>> +|0x34|E Prepare Handover Request|<<gsup-msg-e-prep-ho-req>> +|0x35|E Prepare Handover Error|<<gsup-msg-e-prep-ho-err>> +|0x36|E Prepare Handover Result|<<gsup-msg-e-prep-ho-res>> +|0x38|E Prepare Subsequent Handover Request|<<gsup-msg-e-prep-subs-ho-req>> +|0x39|E Prepare Subsequent Handover Error|<<gsup-msg-e-prep-subs-ho-err>> +|0x3a|E Prepare Subsequent Handover Result|<<gsup-msg-e-prep-subs-ho-res>> +|0x3c|E Send End Signal Request|<<gsup-msg-e-snd-end-sig-req>> +|0x3d|E Send End Signal Error|<<gsup-msg-e-snd-end-sig-err>> +|0x3e|E Send End Signal Result|<<gsup-msg-e-snd-end-sig-res>> +|0x40|E Process Access Signalling Request|<<gsup-msg-e-proc-acc-sig-req>> +|0x44|E Forward Access Signalling Request|<<gsup-msg-e-forw-acc-sig-req>> +|0x47|E Close|<<gsup-msg-e-close>> +|0x4B|E Abort|<<gsup-msg-e-abort>> +|0x4E|E Routing Error|<<gsup-msg-e-routing-err>> |=== The category of the message is indicated by the last two bits of the type. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idbc8a8f2e41f90e545a420517bd030399fb229ac Gerrit-Change-Number: 35898 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-gsm-manuals[master]: gsup.adoc: Add links to section of each message type in table
by fixeria 13 Feb '24

13 Feb '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email ) Change subject: gsup.adoc: Add links to section of each message type in table ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File common/chapters/gsup.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898/comment/70804d22_3876… PS1, Line 1129: ?? > I didn't forget, I didn't look them up since I considered this to be yet some other work and it was […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idbc8a8f2e41f90e545a420517bd030399fb229ac Gerrit-Change-Number: 35898 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Feb 2024 08:54:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-gsm-manuals[master]: gsup.adoc: Add links to section of each message type in table
by pespin 13 Feb '24

13 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email ) Change subject: gsup.adoc: Add links to section of each message type in table ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think this can be merged now? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idbc8a8f2e41f90e545a420517bd030399fb229ac Gerrit-Change-Number: 35898 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Feb 2024 23:04:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: epdg_ue_fsm: Allow re-auth procedure
by pespin 13 Feb '24

13 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35950?usp=email ) Change subject: epdg_ue_fsm: Allow re-auth procedure ...................................................................... epdg_ue_fsm: Allow re-auth procedure Change-Id: Ifa98b88aadc23a7dab70e7e0a3f6e01c35353333 --- M src/aaa_ue_fsm.erl M src/epdg_ue_fsm.erl 2 files changed, 19 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index e982d57..7f70005 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -245,8 +245,12 @@ end end; -state_authenticated({call, From}, _Whatever, Data) -> - lager:info("ue_fsm state_authenticated event=purge_ms_request, ~p~n", [Data]), +state_authenticated({call, _From}, {swm_auth_req, PdpTypeNr, Apn}, Data) -> + lager:info("ue_fsm state_authenticated event=swm_auth_req {~p, ~p}, ~p~n", [PdpTypeNr, Apn, Data]), + {next_state, state_new, Data, [postpone]}; + +state_authenticated({call, From}, Ev, Data) -> + lager:info("ue_fsm state_authenticated: Unexpected call event ~p, ~p~n", [Ev, Data]), {keep_state, Data, [{reply,From,ok}]}. state_authenticated_wait_swx_saa(enter, _OldState, Data) -> diff --git a/src/epdg_ue_fsm.erl b/src/epdg_ue_fsm.erl index 4b6747e..92f94f7 100644 --- a/src/epdg_ue_fsm.erl +++ b/src/epdg_ue_fsm.erl @@ -237,6 +237,10 @@ state_authenticated(enter, _OldState, Data) -> {keep_state, Data}; +state_authenticated({call, _From}, {auth_request, PdpTypeNr, Apn}, Data) -> + lager:info("ue_fsm state_authenticated event=auth_request {~p, ~p}, ~p~n", [PdpTypeNr, Apn, Data]), + {next_state, state_new, Data, [postpone]}; + state_authenticated({call, From}, tunnel_request, Data) -> lager:info("ue_fsm state_authenticated event=tunnel_request, ~p~n", [Data]), epdg_gtpc_s2b:create_session_req(Data#ue_fsm_data.imsi, Data#ue_fsm_data.apn), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ifa98b88aadc23a7dab70e7e0a3f6e01c35353333 Gerrit-Change-Number: 35950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: gtp_u_tun: Fix call to gtp_u_kmod create_pdp_context
by pespin 13 Feb '24

13 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35954?usp=email ) Change subject: gtp_u_tun: Fix call to gtp_u_kmod create_pdp_context ...................................................................... gtp_u_tun: Fix call to gtp_u_kmod create_pdp_context Change-Id: Ie3837cdcfabbfe3c21af42940a7c41a8b87cc799 --- M src/gtp_u_tun.erl 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gtp_u_tun.erl b/src/gtp_u_tun.erl index 626c9a4..d73eaad 100644 --- a/src/gtp_u_tun.erl +++ b/src/gtp_u_tun.erl @@ -65,4 +65,4 @@ PeerIP = conv:bin_to_ip(PeerAddr), % TODO: IPv6 UEIP = conv:bin_to_ip(EUA#epdg_eua.ipv4), % TODO: IPv6. ServRef = get_env_gtp_u_kmod_server_ref(), - gen_server:call(ServRef, {PeerIP, UEIP, LocalTEID, RemoteTEID}). + gen_server:call(ServRef, {create_pdp_context, PeerIP, LocalTEID, RemoteTEID, UEIP}). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ie3837cdcfabbfe3c21af42940a7c41a8b87cc799 Gerrit-Change-Number: 35954 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in ...osmo-epdg[master]: epdg_ue_fsm: Move s2b CreateSession to its own state
by pespin 13 Feb '24

13 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35951?usp=email ) Change subject: epdg_ue_fsm: Move s2b CreateSession to its own state ...................................................................... epdg_ue_fsm: Move s2b CreateSession to its own state Change-Id: Ifb29baeac8b4ea056ca0c3d2435305894954eaa6 --- M src/epdg_ue_fsm.erl 1 file changed, 40 insertions(+), 18 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/epdg_ue_fsm.erl b/src/epdg_ue_fsm.erl index 92f94f7..63c0223 100644 --- a/src/epdg_ue_fsm.erl +++ b/src/epdg_ue_fsm.erl @@ -44,7 +44,8 @@ -export([received_swm_auth_response/2, received_swm_auth_compl_response/2, received_swm_session_termination_answer/2]). -export([received_gtpc_create_session_response/2, received_gtpc_delete_session_response/2, received_gtpc_delete_bearer_request/1]). -export([state_new/3, state_wait_auth_resp/3, state_authenticating/3, state_authenticated/3, - state_wait_delete_session_resp/3, state_wait_swm_session_termination_answer/3]). + state_wait_create_session_resp/3, state_wait_delete_session_resp/3, + state_wait_swm_session_termination_answer/3]). -record(ue_fsm_data, { imsi, @@ -244,23 +245,7 @@ state_authenticated({call, From}, tunnel_request, Data) -> lager:info("ue_fsm state_authenticated event=tunnel_request, ~p~n", [Data]), epdg_gtpc_s2b:create_session_req(Data#ue_fsm_data.imsi, Data#ue_fsm_data.apn), - {keep_state, Data, [{reply,From,ok}]}; - -state_authenticated({call, From}, {received_gtpc_create_session_response, Result}, Data) -> - lager:info("ue_fsm state_authenticated event=received_gtpc_create_session_response, ~p~n", [Data]), - case Result of - {ok, ResInfo} -> - #{eua := EUA, - local_teid := LocalTEID, - remote_teid := RemoteTEID, - remote_ipv4 := RemoteIPv4 % TODO: remote_ipv6 - } = ResInfo, - Ret = gtp_u_tun:create_pdp_context(RemoteIPv4, EUA, LocalTEID, RemoteTEID), - lager:debug("gtp_u_tun:create_pdp_context(~p) returned ~p~n", [ResInfo, Ret]); - _ -> ok - end, - gsup_server:tunnel_response(Data#ue_fsm_data.imsi, Result), - {keep_state, Data, [{reply,From,ok}]}; + {next_state, state_wait_create_session_resp, Data, [{reply,From,ok}]}; state_authenticated({call, From}, purge_ms_request, Data) -> lager:info("ue_fsm state_authenticated event=purge_ms_request, ~p~n", [Data]), @@ -283,6 +268,34 @@ lager:error("ue_fsm state_authenticated: Unexpected cast event, ~p~n", [Data]), {keep_state, Data}. +state_wait_create_session_resp(enter, _OldState, Data) -> + {keep_state, Data, [{state_timeout,5000,create_session_timeout}]}; + +state_wait_create_session_resp({call, From}, {received_gtpc_create_session_response, Result}, Data) -> + lager:info("ue_fsm state_authenticated event=received_gtpc_create_session_response, ~p~n", [Data]), + case Result of + {ok, ResInfo} -> + #{eua := EUA, + local_teid := LocalTEID, + remote_teid := RemoteTEID, + remote_ipv4 := RemoteIPv4 % TODO: remote_ipv6 + } = ResInfo, + Ret = gtp_u_tun:create_pdp_context(RemoteIPv4, EUA, LocalTEID, RemoteTEID), + lager:debug("gtp_u_tun:create_pdp_context(~p) returned ~p~n", [ResInfo, Ret]); + _ -> ok + end, + gsup_server:tunnel_response(Data#ue_fsm_data.imsi, Result), + {next_state, state_authenticated, Data, [{reply,From,ok}]}; + +state_wait_create_session_resp({call, From}, Event, Data) -> + lager:error("ue_fsm state_wait_delete_session_resp: Unexpected call event ~p, ~p~n", [Event, Data]), + {keep_state, Data, [{reply,From,{error,unexpected_event}}]}; + +state_wait_create_session_resp(state_timeout, create_session_timeout, Data) -> + lager:error("ue_fsm state_wait_create_session_resp: Timeout ~p, ~p~n", [create_session_timeout, Data]), + gsup_server:tunnel_response(Data#ue_fsm_data.imsi, {error, create_session_timeout}), + {next_state, state_authenticated, Data}. + state_wait_delete_session_resp(enter, _OldState, Data) -> {keep_state, Data}; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ifb29baeac8b4ea056ca0c3d2435305894954eaa6 Gerrit-Change-Number: 35951 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in ...osmo-epdg[master]: epdg_ue_fsm: Add new state 'active'
by pespin 13 Feb '24

13 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35955?usp=email ) Change subject: epdg_ue_fsm: Add new state 'active' ...................................................................... epdg_ue_fsm: Add new state 'active' This state is reached after the pdp context is properly set up at the tun device. Change-Id: Idc651cc19ae8c22c73e40dfc04130854082e2de5 --- M src/epdg_ue_fsm.erl 1 file changed, 44 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/epdg_ue_fsm.erl b/src/epdg_ue_fsm.erl index 63c0223..5594dff 100644 --- a/src/epdg_ue_fsm.erl +++ b/src/epdg_ue_fsm.erl @@ -45,7 +45,7 @@ -export([received_gtpc_create_session_response/2, received_gtpc_delete_session_response/2, received_gtpc_delete_bearer_request/1]). -export([state_new/3, state_wait_auth_resp/3, state_authenticating/3, state_authenticated/3, state_wait_create_session_resp/3, state_wait_delete_session_resp/3, - state_wait_swm_session_termination_answer/3]). + state_wait_swm_session_termination_answer/3, state_active/3]). -record(ue_fsm_data, { imsi, @@ -249,10 +249,8 @@ state_authenticated({call, From}, purge_ms_request, Data) -> lager:info("ue_fsm state_authenticated event=purge_ms_request, ~p~n", [Data]), - case epdg_gtpc_s2b:delete_session_req(Data#ue_fsm_data.imsi) of - ok -> {next_state, state_wait_delete_session_resp, Data, [{reply,From,ok}]}; - {error, Err} -> {keep_state, Data, [{reply,From,{error, Err}}]} - end; + Data1 = Data#ue_fsm_data{tear_down_gsup_needed = true}, + {next_state, state_wait_swm_session_termination_answer, Data1, [{reply,From,ok}]}; state_authenticated({call, From}, received_gtpc_delete_bearer_request, Data) -> lager:info("ue_fsm state_authenticated event=received_gtpc_delete_bearer_request, ~p~n", [Data]), @@ -285,7 +283,7 @@ _ -> ok end, gsup_server:tunnel_response(Data#ue_fsm_data.imsi, Result), - {next_state, state_authenticated, Data, [{reply,From,ok}]}; + {next_state, state_active, Data, [{reply,From,ok}]}; state_wait_create_session_resp({call, From}, Event, Data) -> lager:error("ue_fsm state_wait_delete_session_resp: Unexpected call event ~p, ~p~n", [Event, Data]), @@ -296,6 +294,34 @@ gsup_server:tunnel_response(Data#ue_fsm_data.imsi, {error, create_session_timeout}), {next_state, state_authenticated, Data}. +state_active(enter, _OldState, Data) -> + {keep_state, Data}; + +state_active({call, _From}, {auth_request, PdpTypeNr, Apn}, Data) -> + lager:info("ue_fsm state_active event=auth_request {~p, ~p}, ~p~n", [PdpTypeNr, Apn, Data]), + {next_state, state_new, Data, [postpone]}; + +state_active({call, From}, purge_ms_request, Data) -> + lager:info("ue_fsm state_active event=purge_ms_request, ~p~n", [Data]), + case epdg_gtpc_s2b:delete_session_req(Data#ue_fsm_data.imsi) of + ok -> {next_state, state_wait_delete_session_resp, Data, [{reply,From,ok}]}; + {error, Err} -> {keep_state, Data, [{reply,From,{error, Err}}]} + end; + +state_active({call, From}, received_gtpc_delete_bearer_request, Data) -> + lager:info("ue_fsm state_active event=received_gtpc_delete_bearer_request, ~p~n", [Data]), + gsup_server:cancel_location_request(Data#ue_fsm_data.imsi), + Data1 = Data#ue_fsm_data{tear_down_gsup_needed = false}, + {next_state, state_wait_swm_session_termination_answer, Data1, [{reply,From,ok}]}; + +state_active({call, From}, _Whatever, Data) -> + lager:error("ue_fsm state_active: Unexpected call event, ~p~n", [Data]), + {keep_state, Data, [{reply,From,ok}]}; + +state_active(cast, _Whatever, Data) -> + lager:error("ue_fsm state_active: Unexpected cast event, ~p~n", [Data]), + {keep_state, Data}. + state_wait_delete_session_resp(enter, _OldState, Data) -> {keep_state, Data}; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Idc651cc19ae8c22c73e40dfc04130854082e2de5 Gerrit-Change-Number: 35955 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log