- gerrit-log - lists.osmocom.org

[S] Change in libgtpnl[master]: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES
by osmith 14 Feb '24

14 Feb '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email ) Change subject: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES ...................................................................... configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES Instead of having one file in AC_OUTPUT, and all others in AC_CONFIG_FILES, move all of them to AC_CONFIG_FILES. Sort the files while at it and have one per line. Fix this warning: configure.ac:86: warning: AC_OUTPUT should be used without arguments. Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967 --- M configure.ac 1 file changed, 27 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/69/35969/1 diff --git a/configure.ac b/configure.ac index a16f40b..2665b70 100644 --- a/configure.ac +++ b/configure.ac @@ -74,6 +74,14 @@ AC_SUBST([CPPFLAGS]) AC_SUBST([CFLAGS]) -AC_CONFIG_FILES([Makefile src/Makefile include/Makefile include/libgtpnl/Makefile include/linux/Makefile tools/Makefile libgtpnl.pc]) -AC_OUTPUT( - contrib/libgtpnl.spec) +AC_CONFIG_FILES([ + Makefile + contrib/libgtpnl.spec + include/Makefile + include/libgtpnl/Makefile + include/linux/Makefile + libgtpnl.pc + src/Makefile + tools/Makefile +]) +AC_OUTPUT() -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967 Gerrit-Change-Number: 35969 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: tests/vty: demonstrate a problem with optional-multi-choice
by fixeria 14 Feb '24

14 Feb '24

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: tests/vty: demonstrate a problem with optional-multi-choice ...................................................................... Patch Set 1: (1 comment) File tests/vty/vty_transcript_test.c: https://gerrit.osmocom.org/c/libosmocore/+/35961/comment/ec7780ec_6a5c2c6a PS1, Line 210: DEFUN(multi3, multi3_cmd, > See my comments in https://gerrit.osmocom. […] This patch is indeed related, but if you look more careful, you would find that here I am showing problems with the approach you suggested in the reference patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 14:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: tests/vty: demonstrate a problem with optional-multi-choice
by pespin 14 Feb '24

14 Feb '24

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: tests/vty: demonstrate a problem with optional-multi-choice ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you maybe create a ticket for this one and provide some feedback on the assert you are hitting? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 14:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: tests/vty: demonstrate a problem with optional-multi-choice
by pespin 14 Feb '24

14 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: tests/vty: demonstrate a problem with optional-multi-choice ...................................................................... Patch Set 1: (1 comment) File tests/vty/vty_transcript_test.c: https://gerrit.osmocom.org/c/libosmocore/+/35961/comment/a4c53814_f1fd01e8 PS1, Line 210: DEFUN(multi3, multi3_cmd, See my comments in https://gerrit.osmocom.org/c/libosmo-sccp/+/35796 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:56:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: return CMD_WARNING if osmo_ss7_xua_server_create() fails
by pespin 14 Feb '24

14 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email ) Change subject: return CMD_WARNING if osmo_ss7_xua_server_create() fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082 Gerrit-Change-Number: 35968 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:16:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-sccp[master]: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c
by pespin 14 Feb '24

14 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email ) Change subject: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: If you see the file, I think I left on purpose all the "lookup" functions which act on the llist of the instance. So to me this function is actually part of the ss7_inst and hence why it's left there. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Gerrit-Change-Number: 35967 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:15:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: return CMD_WARNING if osmo_ss7_xua_server_create() fails
by fixeria 14 Feb '24

14 Feb '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email ) Change subject: return CMD_WARNING if osmo_ss7_xua_server_create() fails ...................................................................... return CMD_WARNING if osmo_ss7_xua_server_create() fails Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082 Related: SYS#5424 --- M src/osmo_ss7_vty.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/68/35968/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 1483ac0..486f070 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -491,7 +491,7 @@ if (!xs) { xs = osmo_ss7_xua_server_create(inst, proto, port, NULL); if (!xs) - return CMD_SUCCESS; + return CMD_WARNING; /* Drop first dummy address created automatically by _create(): */ osmo_ss7_xua_server_set_local_hosts(xs, NULL, 0); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082 Gerrit-Change-Number: 35968 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-sccp[master]: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c
by fixeria 14 Feb '24

14 Feb '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email ) Change subject: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c ...................................................................... move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Related: SYS#5424 --- M src/osmo_ss7.c M src/osmo_ss7_xua_srv.c 2 files changed, 35 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/67/35967/1 diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index dbbef6b..ef958ae 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -1054,21 +1054,6 @@ return ss7_asp_alloc(inst, name, remote_port, local_port, proto); } -struct osmo_xua_server * -osmo_ss7_xua_server_find(struct osmo_ss7_instance *inst, enum osmo_ss7_asp_protocol proto, - uint16_t local_port) -{ - struct osmo_xua_server *xs; - - OSMO_ASSERT(ss7_initialized); - llist_for_each_entry(xs, &inst->xua_servers, list) { - if (proto == xs->cfg.proto && - local_port == xs->cfg.local.port) - return xs; - } - return NULL; -} - bool osmo_ss7_pc_is_local(struct osmo_ss7_instance *inst, uint32_t pc) { OSMO_ASSERT(ss7_initialized); diff --git a/src/osmo_ss7_xua_srv.c b/src/osmo_ss7_xua_srv.c index 32266ff..5928bae 100644 --- a/src/osmo_ss7_xua_srv.c +++ b/src/osmo_ss7_xua_srv.c @@ -169,6 +169,31 @@ return rc; } +/*! \brief find an xUA server with the given parameters + * \param[in] inst SS7 Instance on which we operate + * \param[in] proto protocol (xUA variant) in use + * \param[in] local_port local port of the server + * \returns \ref osmo_xua_server or NULL (not found) + */ +struct osmo_xua_server * +osmo_ss7_xua_server_find(struct osmo_ss7_instance *inst, + enum osmo_ss7_asp_protocol proto, + uint16_t local_port) +{ + struct osmo_xua_server *xs; + + OSMO_ASSERT(ss7_initialized); + llist_for_each_entry(xs, &inst->xua_servers, list) { + if (proto != xs->cfg.proto) + continue; + if (local_port != xs->cfg.local.port) + continue; + return xs; + } + + return NULL; +} + /*! \brief create a new xUA server configured with given ip/port * \param[in] ctx talloc allocation context * \param[in] proto protocol (xUA variant) to use -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Gerrit-Change-Number: 35967 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: msc_a_up_call_assignment_complete(): handle all CSD modes
by pespin 14 Feb '24

14 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35881?usp=email ) Change subject: msc_a_up_call_assignment_complete(): handle all CSD modes ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I92f7ab11ebc2e53700b27c38e91679c2c6f72050 Gerrit-Change-Number: 35881 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: libsmpputil: fix -Wtautological-constant-out-of-range-compare
by pespin 14 Feb '24

14 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email ) Change subject: libsmpputil: fix -Wtautological-constant-out-of-range-compare ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia71a0b6b9421911dc5113782d2f555a640fd90ed Gerrit-Change-Number: 35966 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:00:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log