- gerrit-log - lists.osmocom.org

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)
by pespin 15 Feb '24

15 Feb '24

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 4: (4 comments) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/5c6f7276_7447096c PS4, Line 515: int osmo_ss7_asp_get_trans_proto(const struct osmo_ss7_asp *asp); Is this needed by any app right now? Otherwise I vote for keeping it private until needed. https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/26384a30_1ce00802 PS4, Line 566: int trans_proto; You need to update TODO-RELEASE about new fields and APIs. I think right now all these structs are allocated by libosmo-sccp itself, so it's fine using same app with newer version. The opposite would be wrong though, so you need to say ABI BREAK here. File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/007917a1_cece3754 PS3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc, > > Any input is welcome. I'll continue investigating this. […] My understanding is that for current ticket only osmo-stp is needed. It is ofc desirable to support them in other users of libosmo-sccp, but usually those use the _simple_* APIs, which we want to drop at some point. So at least submit that part as a different patch and we can discuss whether we merge it or whether we rather move osmo-bsc/osmo-msc to get rid of the _simple_ APIs. File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/ccf7e884_d20e5592 PS4, Line 133: #define PROTO_MUX(proto, trans_proto) \ I still think this should be changed to avoid doing assumptions about size and max value of trans_proto. But I'm not gona block if nobody else cares. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 13:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: examples/stream-*: Prevent signals from interrupting main loop
by jolly 15 Feb '24

15 Feb '24

jolly has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35925?usp=email ) Change subject: examples/stream-*: Prevent signals from interrupting main loop ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ida3858600f5c87ff559e75ddf9ac031b3a8592a9 Gerrit-Change-Number: 35925 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0

[S] Change in libosmo-netif[master]: FIXME: debug-code
by jolly 15 Feb '24

15 Feb '24

jolly has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35928?usp=email ) Change subject: FIXME: debug-code ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib7dc6199cedd2cd24e6113675ec6bdeef801fa41 Gerrit-Change-Number: 35928 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0

[S] Change in osmo-ci[master]: jobs/registry-update-base…: remove almalinux8
by osmith 15 Feb '24

15 Feb '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35975?usp=email ) Change subject: jobs/registry-update-base…: remove almalinux8 ...................................................................... jobs/registry-update-base…: remove almalinux8 Related: https://osmocom.org/news/246 Related: SYS#6759 Change-Id: If921a5844ce602a7bda84b9e4d1507796c10948f --- M jobs/registry-update-base-images.yml 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index f3f20e3..b51ae95 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -27,7 +27,6 @@ debian:sid centos:centos7 - almalinux:8 " for i in $IMAGES; do src=$i -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If921a5844ce602a7bda84b9e4d1507796c10948f Gerrit-Change-Number: 35975 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/repo-install-test: remove centos8
by osmith 15 Feb '24

15 Feb '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35973?usp=email ) Change subject: jobs/repo-install-test: remove centos8 ...................................................................... jobs/repo-install-test: remove centos8 Related: https://osmocom.org/news/246 Related: SYS#6759 Change-Id: I311ccfe61b86e467996022107294ad560eee8bdf --- M jobs/repo-install-test.yml 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index 1340e20..0891e24 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -4,8 +4,6 @@ jobs: - Osmocom-repo-install-{distro} distro: - - centos8: - feeds: !!python/tuple [nightly, latest] # next: disabled (OS#5322) - debian10: feeds: !!python/tuple [nightly, latest] - debian11: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I311ccfe61b86e467996022107294ad560eee8bdf Gerrit-Change-Number: 35973 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: remove almalinux8
by osmith 15 Feb '24

15 Feb '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35972?usp=email ) Change subject: jobs/gerrit-verifications: remove almalinux8 ...................................................................... jobs/gerrit-verifications: remove almalinux8 Related: https://osmocom.org/news/246 Related: SYS#6759 Change-Id: Ia180ac87251c39d9715276cf23a2663fb917f50a --- M jobs/gerrit-verifications.yml 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 2efac00..2998619 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -92,7 +92,7 @@ # Which jobs to run in the pipeline pipeline_build: true pipeline_lint: true - pipeline_binpkgs: "almalinux:8 debian:10 debian:12" + pipeline_binpkgs: "debian:10 debian:12" # in alphabetical order repos: @@ -126,9 +126,7 @@ - libtelnet: pipeline_binpkgs: "" - - libusrp: - # centos8/almalinux doesn't have SDCC (OS#5898) - pipeline_binpkgs: "debian:10 debian:12" + - libusrp - openbsc: a1_name: SMPP @@ -394,7 +392,7 @@ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmo-upf: - pipeline_binpkgs: "almalinux:8 debian:11 debian:12" + pipeline_binpkgs: "debian:11 debian:12" - pysim: concurrent: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35972?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia180ac87251c39d9715276cf23a2663fb917f50a Gerrit-Change-Number: 35972 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ci[master]: jobs/ttcn3-testsuites: remove centos8
by osmith 15 Feb '24

15 Feb '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35974?usp=email ) Change subject: jobs/ttcn3-testsuites: remove centos8 ...................................................................... jobs/ttcn3-testsuites: remove centos8 Related: https://osmocom.org/news/246 Related: SYS#6759 Change-Id: I4142c5ababb85b74a890a0cbfc302bd15d44268e --- M jobs/ttcn3-testsuites.yml 1 file changed, 11 insertions(+), 84 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index ce18cfb..b367c49 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -202,76 +202,6 @@ - TTCN3-centos7-pcap-client-test-latest: timer: H 10 * * * - # centos8 nightly - - TTCN3-centos-ggsn-test: - timer: H 10 * * * - - TTCN3-centos-msc-test: - timer: H 10 * * * - - TTCN3-centos-pcu-test: - timer: H 10 * * * - - TTCN3-centos-pcu-test-sns: - timer: H 10 * * * - - TTCN3-centos-sgsn-test: - timer: H 11 * * * - - TTCN3-centos-bsc-test: - timer: H 11 * * * - - TTCN3-centos-mgw-test: - timer: H 11 * * * - - TTCN3-centos-hlr-test: - timer: H 11 * * * - - TTCN3-centos-bts-test: - timer: H 11 * * * - - TTCN3-centos-sip-test: - timer: H 11 * * * - - TTCN3-centos-bsc-test-sccplite: - timer: H 11 * * * - - TTCN3-centos-remsim-test: - timer: H 11 * * * - disabled: true - - TTCN3-centos-stp-test: - timer: H 11 * * * - - TTCN3-centos-gbproxy-test: - timer: H 11 * * * - - TTCN3-centos-cbc-test: - timer: H 12 * * * - - # centos8 latest stable - - TTCN3-centos-ggsn-test-latest: - timer: H 12 * * * - - TTCN3-centos-msc-test-latest: - timer: H 12 * * * - - TTCN3-centos-pcu-test-latest: - timer: H 12 * * * - - TTCN3-centos-pcu-test-sns-latest: - timer: H 12 * * * - - TTCN3-centos-sgsn-test-latest: - timer: H 12 * * * - - TTCN3-centos-bsc-test-latest: - timer: H 12 * * * - - TTCN3-centos-mgw-test-latest: - timer: H 12 * * * - - TTCN3-centos-hlr-test-latest: - timer: H 12 * * * - - TTCN3-centos-bts-test-latest: - timer: H 12 * * * - - TTCN3-centos-sip-test-latest: - timer: H 13 * * * - - TTCN3-centos-bsc-test-sccplite-latest: - timer: H 13 * * * - - TTCN3-centos-remsim-test-latest: - timer: H 13 * * * - disabled: true - - TTCN3-centos-stp-test-latest: - timer: H 13 * * * - - TTCN3-centos-smlc-test-latest: - timer: H 13 * * * - - TTCN3-centos-sccp-test-latest: - timer: H 13 * * * - - TTCN3-centos-gbproxy-test-latest: - timer: H 13 * * * - - TTCN3-centos-cbc-test-latest: - timer: H 13 * * * - - job-template: name: '{job-name}' project-type: freestyle @@ -322,24 +252,10 @@ export KERNEL_REMOTE_NAME="torvalds" export KERNEL_BRANCH="master" ;; - TTCN3-centos-*-latest) - DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/ | sed s/\-latest$//)" - export IMAGE_SUFFIX="latest-centos8" - ;; TTCN3-centos7-*-latest) DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/ | sed s/\-latest$//)" export IMAGE_SUFFIX="latest-centos7" ;; - TTCN3-centos-*-20*q*) - export OSMOCOM_REPO_PATH="osmo-maintained" - export OSMOCOM_REPO_VERSION="$(echo "{job-name}" | grep -o -P -- "20\d\dq.*$")" # e.g. "2021q1" - export IMAGE_SUFFIX="$OSMOCOM_REPO_VERSION-centos8" - DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/ | sed s/\-$OSMOCOM_REPO_VERSION$//)" - ;; - TTCN3-centos-*) - DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/)" - export IMAGE_SUFFIX="master-centos8" - ;; TTCN3-centos7-*) DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/)" export IMAGE_SUFFIX="master-centos7" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4142c5ababb85b74a890a0cbfc302bd15d44268e Gerrit-Change-Number: 35974 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)
by fixeria 15 Feb '24

15 Feb '24

Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 4: (1 comment) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/fc3b2353_436deaaf PS3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc, > Any input is welcome. I'll continue investigating this. Actually, better halt here and wait for feedback. > ... this way we keep osmo-stp support separated from other apps using the simple_client/server stuff, like osmo-bsc. Just to clarify: do we still want to support other transport protocols (e.g. M3UA-over-TCP) outside of osmo-stp, i.e. in apps like osmo-bsc and osmo-msc? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 23:37:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)
by fixeria 15 Feb '24

15 Feb '24

Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 4: (1 comment) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/ddb66e4c_9c85285f PS3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc, > Done Having done this, I can no longer get osmo-bsc to talk to osmo-stp using M3UA/TCP. AFAICS, osmo-bsc is actually using this API and since this API is assuming the default transport protocol (SCTP), something is definitely going wrong: ``` DMSC NOTICE osmo_bsc_sigtran.c:648 Initializing SCCP connection for A/m3ua on cs7 instance 0 DLSCCP NOTICE sccp_user.c:567 A-0-m3ua: Using SS7 instance 0, pc:0.23.3 DLSCCP NOTICE sccp_user.c:585 A-0-m3ua: Using AS instance as-clnt-OsmoBSC-A DLSCCP NOTICE sccp_user.c:590 A-0-m3ua: Creating default route DLSS7 INFO osmo_ss7.c:781 0: Creating route: pc=0=0.0.0 mask=0x0 via AS 'as-clnt-OsmoBSC-A' DLSCCP NOTICE sccp_user.c:632 A-0-m3ua: No unassociated ASP for m3ua, creating new ASP asp-clnt-A-0-m3ua DLSS7 INFO osmo_ss7_as.c:110 0: as-as-clnt-OsmoBSC-A: Adding ASP asp-clnt-A-0-m3ua to AS DLGLOBAL ERROR osmo_ss7_as.c:118 Trying to dispatch event 17 to non-existent FSM instance! DLGLOBAL ERROR backtrace.c:42 backtrace() returned 9 addresses DLGLOBAL ERROR backtrace.c:53 /opt/osmocom/lib/libosmocore.so.21(_osmo_fsm_inst_dispatch+0x3a3) [0x7660c5671443] DLGLOBAL ERROR backtrace.c:53 /opt/osmocom/lib/libosmo-sigtran.so.9(osmo_ss7_as_add_asp+0x31e) [0x7660c57da45e] DLGLOBAL ERROR backtrace.c:53 /opt/osmocom/lib/libosmo-sigtran.so.9(osmo_sccp_simple_client_on_ss7_id+0x101a) [0x7660c58055ca] DLGLOBAL ERROR backtrace.c:53 ./src/osmo-bsc/osmo-bsc(+0x1ee30c) [0x5f63af78430c] DLGLOBAL ERROR backtrace.c:53 ./src/osmo-bsc/osmo-bsc(+0x25bb7) [0x5f63af5bbbb7] DLGLOBAL ERROR backtrace.c:53 /usr/lib/libc.so.6(+0x27cd0) [0x7660c5151cd0] DLGLOBAL ERROR backtrace.c:53 /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7660c5151d8a] DLGLOBAL ERROR backtrace.c:53 ./src/osmo-bsc/osmo-bsc(+0x25165) [0x5f63af5bb165] ``` Note the `No unassociated ASP for m3ua, creating new ASP` line. This is despite I am using the following configuration in osmo-bsc.cfg: ``` cs7 instance 0 point-code 0.23.3 asp asp-clnt-OsmoBSC-A 2905 0 m3ua tcp remote-ip 127.0.0.1 role asp transport-role client as as-clnt-OsmoBSC-A m3ua asp asp-clnt-OsmoBSC-A routing-key 3 0.23.3 ``` Any input is welcome. I'll continue investigating this. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 23:33:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)
by fixeria 14 Feb '24

14 Feb '24

Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 4: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/9db5cc5b_fd97a032 PS1, Line 853: ss7_asp_m3ua_tcp_srv_conn_cb (re-opening the thread, since this was not addressed yet) > ... As jolly is trying to fix that right now, I guess the half-life of this code is going to be very low. @laforge@osmocom.org IIUC this means that this code is going to be reworked anyway once we migrate to `osmo_stream_srv_create2()` and I should not be spending time trying to reduce code duplication as was suggested by @pespin@sysmocom.de. @andreas@eversberg.eu feel free to ping me in case of the merge conflicts with this patch! -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 22:54:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log