- gerrit-log - lists.osmocom.org

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)
by pespin 20 Feb '24

20 Feb '24

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > Regarding changes v6..v7: […] If you didn't do that because then it would signal a deprecatio nwarning, you can add OSMO_DEPRECATED_OUTSIDE_LIBOSMOSCCP, as done in osmo-mgw.git 8e8d59ff0e6f5ea1ec15473a55e79f03a532e58c -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 10:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)
by pespin 20 Feb '24

20 Feb '24

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Regarding changes v6..v7: IMHO you are making the find_or_create2 API more complex simply to accomodate a new internal use. You can simply use the old API find_or_create there for those purposes, and avoid overloading the new API with this -1. I don't think any new code using the library should be using this -1 feature. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 10:01:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by pespin 20 Feb '24

20 Feb '24

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/8b8e12d0_34fa92c2 PS1, Line 84: interference = talloc_asprintf(cmd, "%ddBm(%u)", lchan->interf_dbm, lchan->interf_band); I don't see the point of adding the units here, plus parenthesis etc. making parsing more complex. Simply do "%d,%u", and if lchan->interf_dbm == INTERF_DBM_UNKNOWN, then use ",," -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 20 Feb 2024 09:55:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by matanp 20 Feb '24

20 Feb '24

Attention is currently required from: matanp. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email to look at the new patch set (#3). Change subject: ctrl: Add lchan show ...................................................................... ctrl: Add lchan show This new command shows information about a logical channel using net.btsN.trxM.tsI.lchanL.show.full Change-Id: I5432800eae452b6df71a151a7649f228704ed0da --- M src/osmo-bsc/bts_trx_ts_lchan_ctrl.c 1 file changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/36019/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by Jenkins Builder 20 Feb '24

20 Feb '24

Attention is currently required from: matanp. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 2: (2 comments) File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14513): https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/287ede40_77c66f3c PS2, Line 74: * <channel mode>,<imsi>,<tmsi>,<ipa bound ip>,<ipa bound port>,<ipa bound conn id>,<ipa conn ip>,<ipa conn port>, please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14513): https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/f9d27ace_b7c0a32b PS2, Line 75: * <ipa conn sppech mode> please, no space before tabs -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 20 Feb 2024 09:29:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by matanp 20 Feb '24

20 Feb '24

matanp has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... ctrl: Add lchan show This new command shows information about a logical channel using net.btsN.trxM.tsI.lchanL.show.full Change-Id: I5432800eae452b6df71a151a7649f228704ed0da --- M src/osmo-bsc/bts_trx_ts_lchan_ctrl.c 1 file changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/36019/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by Jenkins Builder 20 Feb '24

20 Feb '24

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14512): https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/fcd6389a_24fc8c1a PS1, Line 74: * <channel mode>,<imsi>,<tmsi>,<ipa bound ip>,<ipa bound port>,<ipa bound conn id>,<ipa conn ip>,<ipa conn port>, please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14512): https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/63e73020_1dcda1a7 PS1, Line 125: lchan->conn ? 1: 0, lchan_state_name(lchan), spaces required around that ':' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 20 Feb 2024 09:27:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by matanp 20 Feb '24

20 Feb '24

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... ctrl: Add lchan show This new command shows information about a logical channel using net.btsN.trxM.tsI.lchanL.show.full Change-Id: I5432800eae452b6df71a151a7649f228704ed0da --- M src/osmo-bsc/bts_trx_ts_lchan_ctrl.c 1 file changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/36019/1 diff --git a/src/osmo-bsc/bts_trx_ts_lchan_ctrl.c b/src/osmo-bsc/bts_trx_ts_lchan_ctrl.c index 2303373..acb367e 100644 --- a/src/osmo-bsc/bts_trx_ts_lchan_ctrl.c +++ b/src/osmo-bsc/bts_trx_ts_lchan_ctrl.c @@ -22,6 +22,7 @@ #include <osmocom/bsc/bts.h> #include <osmocom/bsc/system_information.h> #include <osmocom/bsc/abis_rsl.h> +#include <osmocom/bsc/lchan_fsm.h> static int verify_lchan_ms_power(struct ctrl_cmd *cmd, const char *value, void *_data) { @@ -67,11 +68,87 @@ CTRL_CMD_DEFINE(lchan_ms_power, "ms-power"); +/* Return full information about a logical channel. + * format: bts.<0-255>.trx.<0-255>.ts.<0-8>.lchan.<0-8>.show.full + * result format: <bts>,<trx>,<ts>,<lchan>,<type>,<connection>,<state>,<last error>,<bs power>,<ms power>,<interference>, + * <channel mode>,<imsi>,<tmsi>,<ipa bound ip>,<ipa bound port>,<ipa bound conn id>,<ipa conn ip>,<ipa conn port>, + * <ipa conn sppech mode> + */ +static int get_lchan_show_full(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_lchan *lchan = cmd->node; + struct in_addr ia; + char *interference = "", *tmsi = "", *ipa_bound = ",,", *ipa_conn = ",,"; + + if (lchan->interf_dbm != INTERF_DBM_UNKNOWN) { + interference = talloc_asprintf(cmd, "%ddBm(%u)", lchan->interf_dbm, lchan->interf_band); + if (!interference) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + if (lchan->conn && lchan->conn->bsub && lchan->conn->bsub->tmsi != GSM_RESERVED_TMSI) { + tmsi = talloc_asprintf(cmd, "0x%08x", lchan->conn->bsub->tmsi); + if (!tmsi) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + if (is_ipa_abisip_bts(lchan->ts->trx->bts) && lchan->abis_ip.bound_ip) { + ia.s_addr = htonl(lchan->abis_ip.bound_ip); + ipa_bound = talloc_asprintf(cmd, "%s,%u,%u", inet_ntoa(ia), lchan->abis_ip.bound_port, + lchan->abis_ip.conn_id); + if (!ipa_bound) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + if (is_ipa_abisip_bts(lchan->ts->trx->bts) && lchan->abis_ip.connect_ip) { + ia.s_addr = htonl(lchan->abis_ip.connect_ip); + ipa_conn = talloc_asprintf(cmd, "%s,%u,0x%02x", inet_ntoa(ia), lchan->abis_ip.connect_port, + lchan->abis_ip.speech_mode); + if (!ipa_conn) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + cmd->reply = talloc_asprintf(cmd, "%u,%u,%u,%u,%s,%u,%s,%s,%u,%u,%s,%s,%s,%s,%s,%s", + lchan->ts->trx->bts->nr, + lchan->ts->trx->nr, + lchan->ts->nr, + lchan->nr, + gsm_chan_t_name(lchan->type), + lchan->conn ? 1: 0, lchan_state_name(lchan), + lchan->fi && lchan->fi->state == LCHAN_ST_BORKEN ? lchan->last_error : "", + lchan->ts->trx->nominal_power - lchan->ts->trx->max_power_red - lchan->bs_power_db, + ms_pwr_dbm(lchan->ts->trx->bts->band, lchan->ms_power), + interference, + gsm48_chan_mode_name(lchan->current_ch_mode_rate.chan_mode), + lchan->conn && lchan->conn->bsub && strlen(lchan->conn->bsub->imsi) ? lchan->conn->bsub->imsi : "", + tmsi, + ipa_bound, + ipa_conn + ); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + return CTRL_CMD_REPLY; +} +CTRL_CMD_DEFINE_RO(lchan_show_full, "show full"); + + int bsc_bts_trx_ts_lchan_ctrl_cmds_install(void) { int rc = 0; rc |= ctrl_cmd_install(CTRL_NODE_LCHAN, &cmd_lchan_ms_power); + rc |= ctrl_cmd_install(CTRL_NODE_LCHAN, &cmd_lchan_show_full); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: osmo_io: Use poll/select to notify socket connection at osmo_io_uring.c
by daniel 20 Feb '24

20 Feb '24

Attention is currently required from: jolly, laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35910?usp=email ) Change subject: osmo_io: Use poll/select to notify socket connection at osmo_io_uring.c ...................................................................... Patch Set 4: (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/35910/comment/083278b8_b5c2f696 PS4, Line 437: /* Read connection error. */ Couldn't this also contain the first actual data read after connecting (e.g. the socket is both readable and writable)? If so the comment should reflect that. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4eca9ea72beb0d6ea4d44cce81ed620033f07270 Gerrit-Change-Number: 35910 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Feb 2024 08:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: osmo_io: SCTP support
by daniel 20 Feb '24

20 Feb '24

Attention is currently required from: arehbein, fixeria, jolly, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email ) Change subject: osmo_io: SCTP support ...................................................................... Patch Set 7: (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/02a2f193_7dc49848 PS7, Line 340: iofd->mode == OSMO_IO_FD_MODE_SCTP_RECVMSG_SEND) { If I understand correctly in https://gerrit.osmocom.org/c/libosmocore/+/35910 You don't use this code path (for SCTP) anymore, because it doesn't work? In that case just remove the code here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I89eb519b22d21011d61a7855b2364bc3c295df82 Gerrit-Change-Number: 35068 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 08:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log