Attention is currently required from: pespin.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36047?usp=email )
Change subject: ms: add demod test tool and data
......................................................................
Patch Set 3:
(1 comment)
File utils/va-test/burst-gen.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/36047/comment/df84e167_55cd4328
PS3, Line 80: // mrv(): bits(), demod_bits() {}
> this can be dropped?
All of this is debug code which is why it contains copied code from the sigproclib and constants so they can be modified, there is no point cleaning this up or trying to make it pretty, it's supposed to be modified and actively debugged.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36047?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I852e34d9667d1f12f235f8b3da1fcc0d738b2db9
Gerrit-Change-Number: 36047
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Feb 2024 11:12:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36061?usp=email )
Change subject: doc: fix typo ndoe -> node
......................................................................
doc: fix typo ndoe -> node
Change-Id: Ib78b5de45b93a7534163de2cd91211e9be75445d
---
M doc/manuals/chapters/configuration.adoc
1 file changed, 15 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/61/36061/1
diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc
index e87e5b0..5314d10 100644
--- a/doc/manuals/chapters/configuration.adoc
+++ b/doc/manuals/chapters/configuration.adoc
@@ -101,7 +101,7 @@
----
<1> Change into privileged mode
<2> Enter the interactive configuration mode
-<3> Enter the config ndoe of the GGSN instance `ggsn0`
+<3> Enter the config node of the GGSN instance `ggsn0`
<4> Take the GGSN instance out of shutdown
@@ -121,7 +121,7 @@
----
<1> Change into privileged mode
<2> Enter the interactive configuration mode
-<3> Enter the config ndoe of the GGSN instance `ggsn0`
+<3> Enter the config node of the GGSN instance `ggsn0`
<4> Shut down the GGSN instance
@@ -215,8 +215,8 @@
----
<1> Change into privileged mode
<2> Enter the interactive configuration mode
-<3> Enter the config ndoe of the GGSN instance `ggsn0`
-<4> Enter the config ndoe of the APN `internet`
+<3> Enter the config node of the GGSN instance `ggsn0`
+<4> Enter the config node of the APN `internet`
<5> Take the APN out of shutdown
@@ -237,8 +237,8 @@
----
<1> Change into privileged mode
<2> Enter the interactive configuration mode
-<3> Enter the config ndoe of the GGSN instance `ggsn0`
-<4> Enter the config ndoe of the APN `internet`
+<3> Enter the config node of the GGSN instance `ggsn0`
+<4> Enter the config node of the APN `internet`
<5> Shut down the APN
[[ggsn_no_root]]
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36061?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib78b5de45b93a7534163de2cd91211e9be75445d
Gerrit-Change-Number: 36061
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email )
Change subject: Use osmocom gtplib pointing to newer version of code
......................................................................
Patch Set 3:
(3 comments)
File rebar.config:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/a81cf836_0918…
PS3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib", {branch, "osmocom/master"}}},
wouldn't it be better to use an exact commit instead? that way it would be clear from git history which commit was used at which time
File rebar.lock:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/4ad6f843_7e95…
PS3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}},
* unrelated change
* just so I understand it, why is this using osmocom/master for osmo_gsup instead of master/a commit from master?
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/faf6a3b2_b5b9…
PS3, Line 37: {git,"https://github.com/uwiger/parse_trans.git",
unrelated change (unlike gitlab, there is no git redirect if using github urls without .git)
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Iaf2e195aaeac6d1b157a4b0dd6cd3d80deaa1308
Gerrit-Change-Number: 36052
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Feb 2024 09:27:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email )
Change subject: Use osmocom gtplib pointing to newer version of code
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> to disable build of osmo-epdg for in debian11 I need to touch osmo-ci?
yes: https://gerrit.osmocom.org/c/osmo-ci/+/36060
I've also disabled building osmo-epdg for debian 11 in OBS.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Iaf2e195aaeac6d1b157a4b0dd6cd3d80deaa1308
Gerrit-Change-Number: 36052
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Feb 2024 09:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36041?usp=email )
Change subject: [cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf]
......................................................................
[cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf]
Change-Id: I6ba728ccf7f6d81dc42d1ff82a29b557752e80ba
---
M src/input/ipaccess.c
1 file changed, 15 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 04244a6..75d9693 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -622,11 +622,11 @@
ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPCNT, &val, sizeof(val));
if (ret < 0)
LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP keepalive count: %s\n", strerror(errno));
- val = 1000 * line->keepalive_num_probes *
- line->keepalive_probe_interval +
- line->keepalive_idle_timeout;
+ val = 1000 * line->keepalive_num_probes *
+ line->keepalive_probe_interval +
+ line->keepalive_idle_timeout;
ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, &val, sizeof(val));
- if (ret < 0)
+ if (ret < 0)
LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP user timeout: %s\n", strerror(errno));
}
@@ -697,8 +697,8 @@
struct osmo_fd *bfd;
int i, ret;
- /* We don't know yet which OML link to associate it with. Thus, we
- * allocate a temporary E1 line until we have received ID. */
+ /* We don't know yet which OML link to associate it with. Thus, we
+ * allocate a temporary E1 line until we have received ID. */
line = e1inp_line_clone(tall_ipa_ctx, link->line, "ipa_bfd");
if (line == NULL) {
LOGP(DLINP, LOGL_ERROR, "could not clone E1 line\n");
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36041?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I6ba728ccf7f6d81dc42d1ff82a29b557752e80ba
Gerrit-Change-Number: 36041
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36036?usp=email )
Change subject: ipa_keepalive: Make FSM a bit less quiet
......................................................................
ipa_keepalive: Make FSM a bit less quiet
Let's make sure we log meaningful log messages whenever an IPA keepalive
FSM is started, stopped or if it times out. This allows the user to
observe whether IPA keepalive is actually enabled (using what timeout),
and also to learn why exactly the connection was dropped.
Change-Id: Iad20b86f893c1036affaf14f978099fa858a0031
Related: SYS#6801
---
M src/input/ipa_keepalive.c
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/input/ipa_keepalive.c b/src/input/ipa_keepalive.c
index 7fc28f1..de68879 100644
--- a/src/input/ipa_keepalive.c
+++ b/src/input/ipa_keepalive.c
@@ -147,6 +147,7 @@
ifp->params.wait_for_resp, T_PONG_NOT_RECEIVED);
return 0;
case T_PONG_NOT_RECEIVED:
+ LOGPFSML(fi, LOGL_NOTICE, "IPA keep-alive FSM timed out: PONG not received\n");
/* PONG not received within time */
if (ifp->srv_conn)
conn = ifp->srv_conn;
@@ -320,7 +321,10 @@
/*! Start the ping/pong procedure of the IPA Keepalive FSM. */
void ipa_keepalive_fsm_start(struct osmo_fsm_inst *fi)
{
+ struct ipa_fsm_priv *ifp = fi->priv;
OSMO_ASSERT(fi->fsm == &ipa_keepalive_fsm);
+ LOGPFSML(fi, LOGL_INFO, "Starting IPA keep-alive FSM (interval=%us wait=%us)\n",
+ ifp->params.interval, ifp->params.wait_for_resp);
osmo_fsm_inst_dispatch(fi, OSMO_IPA_KA_E_START, NULL);
}
@@ -328,5 +332,6 @@
void ipa_keepalive_fsm_stop(struct osmo_fsm_inst *fi)
{
OSMO_ASSERT(fi->fsm == &ipa_keepalive_fsm);
+ LOGPFSML(fi, LOGL_INFO, "Stopping IPA keep-alive FSM\n");
osmo_fsm_inst_dispatch(fi, OSMO_IPA_KA_E_STOP, NULL);
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36036?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iad20b86f893c1036affaf14f978099fa858a0031
Gerrit-Change-Number: 36036
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged