- gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsup.h: define newly added PCO IE
by pespin 27 Feb '24

27 Feb '24

Attention is currently required from: dexter, fixeria, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email ) Change subject: gsup.h: define newly added PCO IE ...................................................................... Patch Set 4: (1 comment) File src/gsm/gsup.c: https://gerrit.osmocom.org/c/libosmocore/+/36024/comment/2b39be6d_72e34f07 PS3, Line 881: msgb_tlv_put(msg, OSMO_GSUP_PCO_IE, gsup_msg->pco_len, gsup_msg->pco); > I think also that this makes sense. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f9de90c7c67fe194b441a9d118eba70f09afb5e Gerrit-Change-Number: 36024 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 16:10:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: update osmocom-bb submodule
by dexter 27 Feb '24

27 Feb '24

Attention is currently required from: Hoernchen. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36048?usp=email ) Change subject: ms: update osmocom-bb submodule ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Unfortunately this is a bit specific but as far as I can see the patch seems to be correct. At least the subproject hash points to the topmost commit in osmocom-bb.git. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0140f0a5333469f356c85a95660e10bbdd67cd25 Gerrit-Change-Number: 36048 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:58:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: examples/stream-{server,client}: Generate talloc report on SIGUSR1
by dexter 27 Feb '24

27 Feb '24

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36078?usp=email ) Change subject: examples/stream-{server,client}: Generate talloc report on SIGUSR1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia16632602b937db88e2da2b053192887bdb8a986 Gerrit-Change-Number: 36078 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:34:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmo-sccp[master]: [RFC] osmo_sccp_simple_{client,server}(): allow passing trans_proto
by dexter 27 Feb '24

27 Feb '24

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35999?usp=email ) Change subject: [RFC] osmo_sccp_simple_{client,server}(): allow passing trans_proto ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/sccp_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35999/comment/38596b20_291c5175 PS4, Line 729: enum osmo_ss7_asp_protocol proto, You seem to call the parameter sometimes "proto" and sometimes "trans_proto", (e.g. in osmo_sccp_simple_client_on_ss7_id2 its "trans_proto" -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ife62326daedaa3bf2f4d1fbff596ead209cb3656 Gerrit-Change-Number: 35999 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:31:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-trx[master]: ms: add demod test tool and data
by dexter 27 Feb '24

27 Feb '24

Attention is currently required from: Hoernchen, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36047?usp=email ) Change subject: ms: add demod test tool and data ...................................................................... Patch Set 3: Verified+1 Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/36047/comment/ff5d86e5_b88eb823 PS3, Line 7: ms: add demod test tool and data Maybe it makes sense to explain in more detail what it does. As far as I understood now, this is for testing/debugging the performance of the demodulator code of osmo-trx. Patchset: PS3: I tried it out and it seems to work fine. (I guess it is intentional that one has to call make manually in /utils/va-test to compile the tool) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I852e34d9667d1f12f235f8b3da1fcc0d738b2db9 Gerrit-Change-Number: 36047 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:24:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: check rc of in46a_from_eua
by osmith 27 Feb '24

27 Feb '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36090?usp=email ) Change subject: lib/gtp-kernel.c: check rc of in46a_from_eua ...................................................................... lib/gtp-kernel.c: check rc of in46a_from_eua Fixes: b17fe7bf ("kernel-gtp: support IPv6 on inner layer") Change-Id: I40e4de1517de8871224a45c173208810b42312ff --- M lib/gtp-kernel.c 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c index 3ad8424..6a14d78 100644 --- a/lib/gtp-kernel.c +++ b/lib/gtp-kernel.c @@ -115,6 +115,8 @@ in46a_from_gsna(&pdp->gsnrc, &sgsn); ms_addr_count = in46a_from_eua(&pdp->eua, ms); + if (ms_addr_count < 0) + return -1; for (int i = 0; i < ms_addr_count; i++) { t = gtp_tunnel_alloc(); @@ -169,6 +171,8 @@ pdp_debug(__func__, devname, pdp); ms_addr_count = in46a_from_eua(&pdp->eua, ms); + if (ms_addr_count < 0) + return -1; for (int i = 0; i < ms_addr_count; i++) { t = gtp_tunnel_alloc(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I40e4de1517de8871224a45c173208810b42312ff Gerrit-Change-Number: 36090 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: check rc of in46a_from_eua
by pespin 27 Feb '24

27 Feb '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36090?usp=email ) Change subject: lib/gtp-kernel.c: check rc of in46a_from_eua ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I40e4de1517de8871224a45c173208810b42312ff Gerrit-Change-Number: 36090 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:10:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: initialize ret with 0
by osmith 27 Feb '24

27 Feb '24

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email ) Change subject: lib/gtp-kernel.c: initialize ret with 0 ...................................................................... Patch Set 1: (1 comment) File lib/gtp-kernel.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/36089/comment/8f52442b_f1ac546b PS1, Line 117: ms_addr_count = in46a_from_eua(&pdp->eua, ms); > if in46a_from_eua returns negative, you are still returning 0. […] -> https://gerrit.osmocom.org/c/osmo-ggsn/+/36090 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e Gerrit-Change-Number: 36089 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: check rc of in46a_from_eua
by osmith 27 Feb '24

27 Feb '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36090?usp=email ) Change subject: lib/gtp-kernel.c: check rc of in46a_from_eua ...................................................................... lib/gtp-kernel.c: check rc of in46a_from_eua Fixes: b17fe7bf ("kernel-gtp: support IPv6 on inner layer") Change-Id: I40e4de1517de8871224a45c173208810b42312ff --- M lib/gtp-kernel.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/90/36090/1 diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c index 3ad8424..6a14d78 100644 --- a/lib/gtp-kernel.c +++ b/lib/gtp-kernel.c @@ -115,6 +115,8 @@ in46a_from_gsna(&pdp->gsnrc, &sgsn); ms_addr_count = in46a_from_eua(&pdp->eua, ms); + if (ms_addr_count < 0) + return -1; for (int i = 0; i < ms_addr_count; i++) { t = gtp_tunnel_alloc(); @@ -169,6 +171,8 @@ pdp_debug(__func__, devname, pdp); ms_addr_count = in46a_from_eua(&pdp->eua, ms); + if (ms_addr_count < 0) + return -1; for (int i = 0; i < ms_addr_count; i++) { t = gtp_tunnel_alloc(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I40e4de1517de8871224a45c173208810b42312ff Gerrit-Change-Number: 36090 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: gsup.h: define newly added PCO IE
by dexter 27 Feb '24

27 Feb '24

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email ) Change subject: gsup.h: define newly added PCO IE ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/gsm/gsup.c: https://gerrit.osmocom.org/c/libosmocore/+/36024/comment/1d3519b6_217b34ec PS3, Line 881: msgb_tlv_put(msg, OSMO_GSUP_PCO_IE, gsup_msg->pco_len, gsup_msg->pco); > Yeah I think we can check for pco_len <= 251 here. I think also that this makes sense. (I am not aware of this, in case the length is something the API user has to set consciously, then an OSMO_ASSERT might also make sense.) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f9de90c7c67fe194b441a9d118eba70f09afb5e Gerrit-Change-Number: 36024 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:01:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log