- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-ggsn-test: enable dynamic debug
by pespin 01 Mar '24

01 Mar '24

Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36133?usp=email ) Change subject: ttcn3-ggsn-test: enable dynamic debug ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > 8 is the current one, so it looks like you also have it set to 8? Weirdly enough, in my IM conversation I wrote a while ago: $ cat /proc/sys/kernel/printk 1 4 1 4 So either it changed automatically when I enabled dynamic_debug in gtp module myself, or I got confused and copied the output from somewhere else without noticing... Using kernel 6.7.6-arch1-1 here ("I use Arch btw"). -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I048646c4f90233939809546d30c94c4218eedbb1 Gerrit-Change-Number: 36133 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 01 Mar 2024 17:33:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: enable dynamic debug
by osmith 01 Mar '24

01 Mar '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36133?usp=email ) Change subject: ttcn3-ggsn-test: enable dynamic debug ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We still don't understand why, because in my system I have the following and it still works: […] 8 is the current one, so it looks like you also have it set to 8? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I048646c4f90233939809546d30c94c4218eedbb1 Gerrit-Change-Number: 36133 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Mar 2024 17:27:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: add /dev/null
by pespin 01 Mar '24

01 Mar '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36135?usp=email ) Change subject: scripts/kernel-test: add /dev/null ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie583ae816b517c10d13d77aa45155fc4d1209c26 Gerrit-Change-Number: 36135 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Mar 2024 17:26:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in docker-playground[master]: ttcn3-ggsn-test: tweak log options
by pespin 01 Mar '24

01 Mar '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36134?usp=email ) Change subject: ttcn3-ggsn-test: tweak log options ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think you should have log info in "stderr" section, and "debug" in "gsmtap" section. Isn't that what we do everywhere nowadays? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6c3095f4d3378d2026d3720bc32e27ce4c8345b3 Gerrit-Change-Number: 36134 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Mar 2024 17:26:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in docker-playground[master]: ttcn3-ggsn-test: tweak log options
by pespin 01 Mar '24

01 Mar '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36134?usp=email ) Change subject: ttcn3-ggsn-test: tweak log options ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6c3095f4d3378d2026d3720bc32e27ce4c8345b3 Gerrit-Change-Number: 36134 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Mar 2024 17:25:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: enable dynamic debug
by pespin 01 Mar '24

01 Mar '24

Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36133?usp=email ) Change subject: ttcn3-ggsn-test: enable dynamic debug ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: We still don't understand why, because in my system I have the following and it still works: $ cat /proc/sys/kernel/printk 8 4 1 4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I048646c4f90233939809546d30c94c4218eedbb1 Gerrit-Change-Number: 36133 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 01 Mar 2024 17:25:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: enable dynamic debug
by osmith 01 Mar '24

01 Mar '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36133?usp=email ) Change subject: ttcn3-ggsn-test: enable dynamic debug ...................................................................... ttcn3-ggsn-test: enable dynamic debug Enable loglevel=8, as otherwise the messages do not show up. Change-Id: I048646c4f90233939809546d30c94c4218eedbb1 --- M scripts/kernel-test/run-qemu.sh M ttcn3-ggsn-test/fragment.config M ttcn3-ggsn-test/initrd-ggsn.sh 3 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/33/36133/1 diff --git a/scripts/kernel-test/run-qemu.sh b/scripts/kernel-test/run-qemu.sh index 0c4fa26..800fc25 100755 --- a/scripts/kernel-test/run-qemu.sh +++ b/scripts/kernel-test/run-qemu.sh @@ -11,6 +11,7 @@ console=ttyS0 panic=-1 init=/init + loglevel=8 $@ " diff --git a/ttcn3-ggsn-test/fragment.config b/ttcn3-ggsn-test/fragment.config index b5a07b5..b6e2071 100644 --- a/ttcn3-ggsn-test/fragment.config +++ b/ttcn3-ggsn-test/fragment.config @@ -267,6 +267,8 @@ # CONFIG_X86_X2APIC is not set # CONFIG_XEN is not set +CONFIG_DYNAMIC_DEBUG=y + # For libgtpnl's qemu tests CONFIG_NAMESPACES=y CONFIG_NET_NS=y diff --git a/ttcn3-ggsn-test/initrd-ggsn.sh b/ttcn3-ggsn-test/initrd-ggsn.sh index 831dfff..c554f8a 100644 --- a/ttcn3-ggsn-test/initrd-ggsn.sh +++ b/ttcn3-ggsn-test/initrd-ggsn.sh @@ -11,6 +11,12 @@ initrd_add_file \ /data/osmo-ggsn.cfg +# Enable dynamic_debug, if it is compiled into the kernel +initrd_add_cmd \ + "mount -t debugfs none /sys/kernel/debug || true" \ + "(cat /sys/kernel/debug/dynamic_debug/control | grep gtp) || true" \ + "echo -n 'module gtp +p' > /sys/kernel/debug/dynamic_debug/control || true" + initrd_add_cmd \ "ip addr add 172.18.3.201/24 brd 172.18.3.255 dev eth0" \ "ip route add default via 172.18.3.1 dev eth0" \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I048646c4f90233939809546d30c94c4218eedbb1 Gerrit-Change-Number: 36133 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: add /dev/null
by osmith 01 Mar '24

01 Mar '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36135?usp=email ) Change subject: scripts/kernel-test: add /dev/null ...................................................................... scripts/kernel-test: add /dev/null Some busybox programs need /dev/null, add it to the initramfs. Change-Id: Ie583ae816b517c10d13d77aa45155fc4d1209c26 --- M scripts/kernel-test/initrd-build.sh 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/35/36135/1 diff --git a/scripts/kernel-test/initrd-build.sh b/scripts/kernel-test/initrd-build.sh index d942719..e97ff89 100755 --- a/scripts/kernel-test/initrd-build.sh +++ b/scripts/kernel-test/initrd-build.sh @@ -117,6 +117,8 @@ initrd_add_file \ /lib/modules/*/modules.dep +mknod dev/null c 1 3 + # Required for osmo-ggsn mknod dev/net/tun c 10 200 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie583ae816b517c10d13d77aa45155fc4d1209c26 Gerrit-Change-Number: 36135 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in docker-playground[master]: ttcn3-ggsn-test: tweak log options
by osmith 01 Mar '24

01 Mar '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36134?usp=email ) Change subject: ttcn3-ggsn-test: tweak log options ...................................................................... ttcn3-ggsn-test: tweak log options Change-Id: I6c3095f4d3378d2026d3720bc32e27ce4c8345b3 --- M ttcn3-ggsn-test/osmo-ggsn-kernel-gtp.cfg M ttcn3-ggsn-test/osmo-ggsn.cfg 2 files changed, 17 insertions(+), 46 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/34/36134/1 diff --git a/ttcn3-ggsn-test/osmo-ggsn-kernel-gtp.cfg b/ttcn3-ggsn-test/osmo-ggsn-kernel-gtp.cfg index b377bfa..639a586 100644 --- a/ttcn3-ggsn-test/osmo-ggsn-kernel-gtp.cfg +++ b/ttcn3-ggsn-test/osmo-ggsn-kernel-gtp.cfg @@ -9,31 +9,12 @@ log stderr logging filter all 1 logging color 1 + logging print level 1 logging print category 1 - logging timestamp 1 + logging print category-hex 0 + logging print file basename last logging print extended-timestamp 1 - logging level ip info - logging level tun info - logging level ggsn info - logging level sgsn notice - logging level icmp6 debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp info - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp notice + logging level set-all debug ! stats interval 5 ! diff --git a/ttcn3-ggsn-test/osmo-ggsn.cfg b/ttcn3-ggsn-test/osmo-ggsn.cfg index 2f09990..1848291 100644 --- a/ttcn3-ggsn-test/osmo-ggsn.cfg +++ b/ttcn3-ggsn-test/osmo-ggsn.cfg @@ -9,31 +9,12 @@ log stderr logging filter all 1 logging color 1 + logging print level 1 logging print category 1 - logging timestamp 1 + logging print category-hex 0 + logging print file basename last logging print extended-timestamp 1 - logging level ip info - logging level tun info - logging level ggsn info - logging level sgsn notice - logging level icmp6 debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp info - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp notice + logging level set-all debug ! stats interval 5 ! -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6c3095f4d3378d2026d3720bc32e27ce4c8345b3 Gerrit-Change-Number: 36134 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: osmo_io_uring: Check if osmo_fd_register fails at iofd_uring_notify_c...
by jolly 01 Mar '24

01 Mar '24

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36132?usp=email ) Change subject: osmo_io_uring: Check if osmo_fd_register fails at iofd_uring_notify_connected() ...................................................................... osmo_io_uring: Check if osmo_fd_register fails at iofd_uring_notify_connected() If it fails, do not set the IOFD_FLAG_NOTIFY_CONNECTED flag and log an error message. Closes: Coverity CID#349579 Change-Id: I34e8cc9a2b9df0c624841e5f9268a15c32418da1 --- M src/core/osmo_io_uring.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/36132/1 diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index cb636da..b174b22 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -496,8 +496,10 @@ if (!IOFD_FLAG_ISSET(iofd, IOFD_FLAG_NOTIFY_CONNECTED)) { osmo_fd_setup(&iofd->u.uring.connect_ofd, iofd->fd, OSMO_FD_WRITE, iofd_uring_connected_cb, iofd, 0); - osmo_fd_register(&iofd->u.uring.connect_ofd); - IOFD_FLAG_SET(iofd, IOFD_FLAG_NOTIFY_CONNECTED); + if (osmo_fd_register(&iofd->u.uring.connect_ofd) < 0) + LOGPIO(iofd, LOGL_ERROR, "Failed to register FD for connect event.\n"); + else + IOFD_FLAG_SET(iofd, IOFD_FLAG_NOTIFY_CONNECTED); } } else iofd_uring_write_enable(iofd); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I34e8cc9a2b9df0c624841e5f9268a15c32418da1 Gerrit-Change-Number: 36132 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log