- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-stp-test: enable M3UA-over-TCP testing for master
by fixeria 07 Mar '24

07 Mar '24

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36151?usp=email ) Change subject: ttcn3-stp-test: enable M3UA-over-TCP testing for master ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I210b7d62845075dcfe147f2f77603625cc1e64f9 Gerrit-Change-Number: 36151 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Mar 2024 11:24:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: fix -latest: add missing f_osmo_repo_is() checks
by fixeria 07 Mar '24

07 Mar '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36195?usp=email ) Change subject: stp: fix -latest: add missing f_osmo_repo_is() checks ...................................................................... stp: fix -latest: add missing f_osmo_repo_is() checks Change-Id: I9b00d3a72c5a2ad669dbaef65eec792a4c91785d Related: SYS#5424 --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/36195/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 9f3bf0c..a7dcd78 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -326,6 +326,12 @@ var OptionList opt_list := {}; var M3uaConfig m3cfg := mp_m3ua_configs[i]; + /* XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 */ + if (not Misc_Helpers.f_osmo_repo_is("nightly") and m3cfg.use_tcp) { + log("Not listen()ing m3cfg := ", m3cfg, " (not supported by IUT)"); + return; + } + if (lengthof(mp_local_m3ua_ip) == 0 ) { setverdict(fail, "Empty local address trying to bind SCTP socket: ", mp_local_m3ua_ip); @@ -365,6 +371,11 @@ } for (i := 0; i < NR_M3UA; i:=i+1) { + /* XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 */ + if (not Misc_Helpers.f_osmo_repo_is("nightly") and mp_m3ua_configs[i].use_tcp) { + log("Not connect()ing m3cfg := ", m3cfg, " (not supported by IUT)"); + continue; + } map(self:M3UA[i], system:M3UA_CODEC_PT); if (mp_m3ua_configs[i].use_tcp) { f_M3UA_connect_tcp(i); @@ -392,6 +403,11 @@ var PortEvent port_evt; for (i := NR_M3UA; i < NR_M3UA+NR_M3UA_SRV; i:=i+1) { + /* XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 */ + if (not Misc_Helpers.f_osmo_repo_is("nightly") and mp_m3ua_configs[i].use_tcp) { + log("Not listen()ing m3cfg := ", m3cfg, " (not supported by IUT)"); + continue; + } map(self:M3UA[i], system:M3UA_CODEC_PT); /* bind+ listen */ f_M3UA_listen(i); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b00d3a72c5a2ad669dbaef65eec792a4c91785d Gerrit-Change-Number: 36195 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: cosmetic: use m3cfg variable in f_M3UA_listen()
by fixeria 07 Mar '24

07 Mar '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36194?usp=email ) Change subject: stp: cosmetic: use m3cfg variable in f_M3UA_listen() ...................................................................... stp: cosmetic: use m3cfg variable in f_M3UA_listen() Change-Id: Ic5550f17e8925c292df5b3b27cf5898edf10fd23 Related: SYS#5424 --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/36194/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index a0162cb..9f3bf0c 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -338,7 +338,7 @@ opt_list := {opt_add_local_addrs}; } - if (mp_m3ua_configs[i].use_tcp) { + if (m3cfg.use_tcp) { res := M3UA_CodecPort_CtrlFunct.f_IPL4_listen(M3UA[i], mp_local_m3ua_ip[0], m3cfg.local_port, {tcp:={}}); } else { @@ -349,7 +349,7 @@ setverdict(fail, "Could not bind M3UA socket, check your configuration"); mtc.stop; } - if (mp_m3ua_configs[i].use_tcp) { + if (m3cfg.use_tcp) { M3UA_CodecPort.f_set_tcp_segmentation(M3UA[i], res.connId); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic5550f17e8925c292df5b3b27cf5898edf10fd23 Gerrit-Change-Number: 36194 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Use proper length for struct usb_cdc_notif_serial_state
by tnt 07 Mar '24

07 Mar '24

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36185?usp=email ) Change subject: icE1usb fw: Use proper length for struct usb_cdc_notif_serial_state ...................................................................... icE1usb fw: Use proper length for struct usb_cdc_notif_serial_state Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I30d451e76ebd192f037653179b6485b2b43b6dbc --- M firmware/ice40-riscv/icE1usb/usb_gps.c 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified tnt: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/usb_gps.c b/firmware/ice40-riscv/icE1usb/usb_gps.c index db188b1..ad893a5 100644 --- a/firmware/ice40-riscv/icE1usb/usb_gps.c +++ b/firmware/ice40-riscv/icE1usb/usb_gps.c @@ -148,6 +148,7 @@ }, .bits = 0x00 }; + const int notif_len = sizeof(struct usb_cdc_notif_serial_state); /* Check if PPS occurred */ uint32_t pps_now = time_pps_read(); @@ -159,8 +160,8 @@ /* Queue CD Set */ notif.bits = 1; - usb_data_write(ep_regs->bd[0].ptr, &notif, 12); - ep_regs->bd[0].csr = USB_BD_STATE_RDY_DATA | USB_BD_LEN(10); + usb_data_write(ep_regs->bd[0].ptr, &notif, notif_len); + ep_regs->bd[0].csr = USB_BD_STATE_RDY_DATA | USB_BD_LEN(notif_len); /* Need to clear in the future */ g_usb_gps.pps.set = true; @@ -169,8 +170,8 @@ { /* Queue CD Clear */ notif.bits = 0; - usb_data_write(ep_regs->bd[0].ptr, &notif, 12); - ep_regs->bd[0].csr = USB_BD_STATE_RDY_DATA | USB_BD_LEN(10); + usb_data_write(ep_regs->bd[0].ptr, &notif, notif_len); + ep_regs->bd[0].csr = USB_BD_STATE_RDY_DATA | USB_BD_LEN(notif_len); /* Cleared */ g_usb_gps.pps.set = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I30d451e76ebd192f037653179b6485b2b43b6dbc Gerrit-Change-Number: 36185 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1-hardware[master]: gateware/cores: Update no2usb
by tnt 07 Mar '24

07 Mar '24

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36183?usp=email ) Change subject: gateware/cores: Update no2usb ...................................................................... gateware/cores: Update no2usb Mostly to get firmware code fixes Need some code adaptation in icE1usb firmware to remove local usb_cdc_notif_serial_state struct sine tt's included in no2usb cdc proto header now. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I13e186627077c57329e4a83da11acc01ca5dce35 --- M firmware/ice40-riscv/icE1usb/usb_gps.c M gateware/cores/no2usb 2 files changed, 17 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve tnt: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/usb_gps.c b/firmware/ice40-riscv/icE1usb/usb_gps.c index e219cf8..db188b1 100644 --- a/firmware/ice40-riscv/icE1usb/usb_gps.c +++ b/firmware/ice40-riscv/icE1usb/usb_gps.c @@ -46,12 +46,6 @@ } g_usb_gps; -struct usb_cdc_notif_serial_state { - struct usb_ctrl_req hdr; - uint16_t bits; -} __attribute__((packed,aligned(4))); - - static void _usb_gps_set_active(bool active) { diff --git a/gateware/cores/no2usb b/gateware/cores/no2usb index fdf42a6..9a3e752 160000 --- a/gateware/cores/no2usb +++ b/gateware/cores/no2usb @@ -1 +1 @@ -Subproject commit fdf42a6571a4ae49556626e6fffca1582796f7e8 +Subproject commit 9a3e752eab17c8f12a3a1dd6cf291368eaf3161d -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I13e186627077c57329e4a83da11acc01ca5dce35 Gerrit-Change-Number: 36183 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Ensure alignement of the structure for the usb_data_write
by tnt 07 Mar '24

07 Mar '24

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36186?usp=email ) Change subject: icE1usb fw: Ensure alignement of the structure for the usb_data_write ...................................................................... icE1usb fw: Ensure alignement of the structure for the usb_data_write Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Id80468ef95bb908cf34b6eeca04c83f1285fd2f5 --- M firmware/ice40-riscv/icE1usb/usb_gps.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: tnt: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/firmware/ice40-riscv/icE1usb/usb_gps.c b/firmware/ice40-riscv/icE1usb/usb_gps.c index ad893a5..0fe5c98 100644 --- a/firmware/ice40-riscv/icE1usb/usb_gps.c +++ b/firmware/ice40-riscv/icE1usb/usb_gps.c @@ -138,7 +138,7 @@ { /* Default request */ /* Put as static to work around gcc aliasing bug ... */ - static struct usb_cdc_notif_serial_state notif = { + static struct usb_cdc_notif_serial_state __attribute__((aligned(4))) notif = { .hdr = { .bmRequestType = USB_REQ_READ | USB_REQ_TYPE_CLASS | USB_REQ_RCPT_INTF, .bRequest = USB_NOTIF_CDC_SERIAL_STATE, -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id80468ef95bb908cf34b6eeca04c83f1285fd2f5 Gerrit-Change-Number: 36186 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Use proper length for struct usb_cdc_notif_serial_state
by tnt 07 Mar '24

07 Mar '24

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36185?usp=email ) Change subject: icE1usb fw: Use proper length for struct usb_cdc_notif_serial_state ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I30d451e76ebd192f037653179b6485b2b43b6dbc Gerrit-Change-Number: 36185 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Thu, 07 Mar 2024 10:06:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1-hardware[master]: gateware/cores: Update no2usb
by tnt 07 Mar '24

07 Mar '24

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36183?usp=email ) Change subject: gateware/cores: Update no2usb ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I13e186627077c57329e4a83da11acc01ca5dce35 Gerrit-Change-Number: 36183 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Thu, 07 Mar 2024 10:06:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Ensure alignement of the structure for the usb_data_write
by tnt 07 Mar '24

07 Mar '24

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36186?usp=email ) Change subject: icE1usb fw: Ensure alignement of the structure for the usb_data_write ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id80468ef95bb908cf34b6eeca04c83f1285fd2f5 Gerrit-Change-Number: 36186 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Thu, 07 Mar 2024 10:06:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode
by jolly 07 Mar '24

07 Mar '24

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email ) Change subject: xua + ipa: Add support for I/O in OSMO_IO mode ...................................................................... Patch Set 9: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/64c6fa71_42b7d877 PS9, Line 867: if (rc < 0) { > How is this supposed to happen now with osmo_io? It's still not clear to me. […] Yes, it is done automatically. See stream_srv_iofd_read_cb() at stream_srv.c at libosmo-netif. It calls osmo_stream_srv_destroy(). Because the callback function is set, ss7_asp_xua_srv_conn_closed_cb will be closed in this case. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369 Gerrit-Change-Number: 35070 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 07 Mar 2024 09:59:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log