- gerrit-log - lists.osmocom.org

[XL] Change in osmo-ttcn3-hacks[master]: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templ...
by laforge 11 Mar '24

11 Mar '24

Attention is currently required from: daniel, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email ) Change subject: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templates ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9df8caa98aeb6953a738660a758c92249832d780 Gerrit-Change-Number: 36154 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Mar 2024 16:21:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-epdg[master]: aaa_diameter_swm: Look up aaa_ue_fsm process each time it needs to be...
by pespin 11 Mar '24

11 Mar '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36231?usp=email ) Change subject: aaa_diameter_swm: Look up aaa_ue_fsm process each time it needs to be accessed ...................................................................... aaa_diameter_swm: Look up aaa_ue_fsm process each time it needs to be accessed Similar to what was already done in 745d542b9202d3c5ef69d44d8c1c140490012822 fpr epdg_ue_fsm. Change-Id: Ic019d41716284639f6256f7ba24533bf806333b1 --- M src/aaa_diameter_swm.erl M src/aaa_ue_fsm.erl 2 files changed, 37 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/31/36231/1 diff --git a/src/aaa_diameter_swm.erl b/src/aaa_diameter_swm.erl index 5050ffb..2e39048 100644 --- a/src/aaa_diameter_swm.erl +++ b/src/aaa_diameter_swm.erl @@ -7,15 +7,9 @@ -include_lib("diameter_3gpp_ts29_273.hrl"). -record(swm_state, { - table_id, % ets table id, - ues = sets:new() + table_id % ets table id }). --record(swm_session, { - imsi :: string(), - pid :: pid() - }). - -export([start_link/0]). -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). -export([code_change/3, terminate/2]). @@ -56,16 +50,18 @@ session_termination_request(Imsi) -> gen_server:cast(?SERVER, {str, Imsi}). -handle_cast({epdg_auth_req, Imsi, PdpTypeNr, Apn, EAP}, State0) -> - {Sess, State1} = find_or_new_swm_session(Imsi, State0), - aaa_ue_fsm:ev_swm_auth_req(Sess#swm_session.pid, {PdpTypeNr, Apn, EAP}), - {noreply, State1}; +handle_cast({epdg_auth_req, Imsi, PdpTypeNr, Apn, EAP}, State) -> + case aaa_ue_fsm:get_pid_by_imsi(Imsi) of + undefined -> {ok, Pid} = aaa_ue_fsm:start(Imsi); + Pid -> Pid + end, + aaa_ue_fsm:ev_swm_auth_req(Pid, {PdpTypeNr, Apn, EAP}), + {noreply, State}; handle_cast({epdg_auth_compl_req, Imsi, Apn}, State) -> - Sess = find_swm_session_by_imsi(Imsi, State), - case Sess of - #swm_session{imsi = Imsi} -> - aaa_ue_fsm:ev_swm_auth_compl(Sess#swm_session.pid, Apn); + case aaa_ue_fsm:get_pid_by_imsi(Imsi) of + Pid when is_pid(Pid) -> + aaa_ue_fsm:ev_swm_auth_compl(Pid, Apn); undefined -> RC_USER_UNKNOWN=5030, epdg_diameter_swm:auth_compl_response(Imsi, {error, RC_USER_UNKNOWN}) @@ -73,10 +69,9 @@ {noreply, State}; handle_cast({str, Imsi}, State) -> - Sess = find_swm_session_by_imsi(Imsi, State), - case Sess of - #swm_session{} -> - case aaa_ue_fsm:ev_rx_swm_str(Sess#swm_session.pid) of + case aaa_ue_fsm:get_pid_by_imsi(Imsi) of + Pid when is_pid(Pid) -> + case aaa_ue_fsm:ev_rx_swm_str(Pid) of ok -> ok; % Answering delayed due to SAR+SAA towards HSS. {ok, DiaRC} when is_integer(DiaRC) -> ok = epdg_diameter_swm:session_termination_answer(Imsi, DiaRC); @@ -126,32 +121,3 @@ %% ------------------------------------------------------------------ %% Internal Function Definitions %% ------------------------------------------------------------------ - -new_swm_session(Imsi, State) -> - {ok, Pid} = aaa_ue_fsm:start_link(Imsi), - UE = #swm_session{imsi = Imsi, pid = Pid}, - NewSt = State#swm_state{ues = sets:add_element(UE, State#swm_state.ues)}, - {UE, NewSt}. - -% returns swm_session if found, undefined if not -find_swm_session_by_imsi(Imsi, State) -> - {Imsi, Res} = sets:fold( - fun(UEsIt = #swm_session{imsi = LookupImsi}, {LookupImsi, _AccIn}) -> {LookupImsi, UEsIt}; - (_, AccIn) -> AccIn - end, - {Imsi, undefined}, - State#swm_state.ues), - Res. - -find_or_new_swm_session(Imsi, State) -> - UE = find_swm_session_by_imsi(Imsi, State), - case UE of - #swm_session{imsi = Imsi} -> - {UE, State}; - undefined -> - new_swm_session(Imsi, State) - end. - -delete_swm_session(Imsi, State) -> - SetRemoved = sets:del_element(Imsi, State#swm_state.ues), - State#swm_state{ues = SetRemoved}. \ No newline at end of file diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index 5a6e847..52057ba 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -39,7 +39,7 @@ -include_lib("diameter_3gpp_ts29_273_s6b.hrl"). -include("conv.hrl"). --export([start_link/1]). +-export([start/1, stop/1]). -export([init/1,callback_mode/0,terminate/3]). -export([get_server_name_by_imsi/1, get_pid_by_imsi/1]). -export([ev_swm_auth_req/2, ev_swm_auth_compl/2, ev_rx_swm_str/1, ev_rx_swx_maa/2, ev_rx_swx_saa/2, @@ -62,10 +62,18 @@ ServerName = get_server_name_by_imsi(Imsi), whereis(ServerName). -start_link(Imsi) -> +start(Imsi) -> ServerName = get_server_name_by_imsi(Imsi), lager:info("ue_fsm start_link(~p)~n", [ServerName]), - gen_statem:start_link({local, ServerName}, ?MODULE, Imsi, [{debug, [trace]}]). + gen_statem:start({local, ServerName}, ?MODULE, Imsi, [{debug, [trace]}]). + +stop(SrvRef) -> + try + gen_statem:stop(SrvRef) + catch + exit:Err -> + {error, Err} + end. ev_swm_auth_req(Pid, {PdpTypeNr, Apn, EAP}) -> lager:info("ue_fsm ev_swm_auth_req~n", []), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ic019d41716284639f6256f7ba24533bf806333b1 Gerrit-Change-Number: 36231 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in ...osmo-epdg[master]: AAA: Swx: Answer RTR with RTA
by pespin 11 Mar '24

11 Mar '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36232?usp=email ) Change subject: AAA: Swx: Answer RTR with RTA ...................................................................... AAA: Swx: Answer RTR with RTA Related: OS#6042 Change-Id: Iba49fe8565d2303f975003ed2a79de25a4b23832 --- M include/conv.hrl M src/aaa_diameter_swx_cb.erl 2 files changed, 52 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/32/36232/1 diff --git a/include/conv.hrl b/include/conv.hrl index 786bdff..dda21f4 100644 --- a/include/conv.hrl +++ b/include/conv.hrl @@ -31,6 +31,8 @@ % -hrl_name('conv.hrl'). +-define(VENDOR_ID_3GPP, 10415). + %% Can Hold information about Result-Code or Experimental-Result: -record(epdg_dia_rc, { vendor_id :: non_neg_integer(), %% or undefined if Result-Code diff --git a/src/aaa_diameter_swx_cb.erl b/src/aaa_diameter_swx_cb.erl index 8a6dd08..4936c24 100644 --- a/src/aaa_diameter_swx_cb.erl +++ b/src/aaa_diameter_swx_cb.erl @@ -10,7 +10,8 @@ %% diameter callbacks -export([peer_up/3, peer_down/3, pick_peer/4, pick_peer/5, prepare_request/3, prepare_request/4, prepare_retransmit/3, prepare_retransmit/4, - handle_answer/4, handle_answer/5, handle_error/4, handle_error/5, handle_request/3]). + handle_request/3, + handle_answer/4, handle_answer/5, handle_error/4, handle_error/5]). %% peer_up/3 peer_up(_SvcName, Peer, State) -> @@ -67,6 +68,41 @@ prepare_retransmit(Packet, SvcName, Peer, ExtraPars) -> prepare_request(Packet, SvcName, Peer, ExtraPars). +%% handle_request/3 + +%% 3GPP TS 29.273 8.2.2.4 Network Initiated De-Registration by HSS Procedure +handle_request(#diameter_packet{msg = Req, errors = []}, _SvcName, {_, Caps}) when is_record(Req, 'RTR') -> + lager:info("SWx Rx RTR from ~p: ~p~n", [Caps, Req]), + #diameter_caps{origin_host = {OH,_}, origin_realm = {OR,_}} = Caps, + #'RTR'{'Session-Id' = SessionId, + 'Vendor-Specific-Application-Id' = VendorAppId, + 'Auth-Session-State' = AuthSessState, + 'User-Name' = Imsi, + 'Deregistration-Reason' = _DeregReason} = Req, + case aaa_ue_fsm:get_pid_by_imsi(Imsi) of + Pid when is_pid(Pid) -> + aaa_ue_fsm:stop(Pid), + Res = 2001, %% Success + ERes = []; + undefined -> + Res = [], + %% TS 29.229 6.2.2.1 DIAMETER_ERROR_USER_UNKNOWN + ERes = #'Experimental-Result'{'Vendor-Id' = ?VENDOR_ID_3GPP, 'Experimental-Result-Code' = 5001} + end, + Resp = #'RTA'{'Session-Id' = SessionId, + 'Vendor-Specific-Application-Id' = VendorAppId, + 'Result-Code' = Res, + 'Experimental-Result' = ERes, + 'Auth-Session-State' = AuthSessState, + 'Origin-Host' = OH, + 'Origin-Realm' = OR}, + lager:info("SWx Tx to ~p: ~p~n", [Caps, Resp]), + {reply, Resp}; + +handle_request(Msg, _SvcName, Peer) -> + lager:error("SWx Rx unexpected msg from ~p: ~p~n", [Peer, Msg]), + erlang:error({unexpected, ?MODULE, ?LINE}). + %% handle_answer/4 handle_answer(#diameter_packet{msg = Msg, errors = Errors}, _Request, _SvcName, Peer, ReqPid) when is_record(Msg, 'MAA') -> lager:info("SWx Rx MAA ~p: ~p/ Errors ~p ~n", [Peer, Msg, Errors]), @@ -82,6 +118,7 @@ aaa_ue_fsm:ev_rx_swx_maa(ReqPid, {error, DiaRC}) end, {ok, Msg}; + handle_answer(#diameter_packet{msg = Msg, errors = Errors}, Request, _SvcName, Peer, ReqPid) when is_record(Msg, 'SAA') -> lager:info("SWx Rx SAA ~p: ~p/ Errors ~p ~n", [Peer, Msg, Errors]), % Recover fields from originating request: @@ -103,9 +140,11 @@ aaa_ue_fsm:ev_rx_swx_saa(ReqPid, {error, SAType, DiaRC}) end, {ok, Msg}. + handle_answer(#diameter_packet{msg = Msg, errors = []}, _Request, _SvcName, Peer) -> lager:info("SWx Rx ~p: ~p~n", [Peer, Msg]), {ok, Msg}; + handle_answer(#diameter_packet{msg = Msg, errors = Errors}, _Request, _SvcName, Peer) -> lager:info("SWx Rx ~p: ~p / Errors ~p ~n", [Peer, Msg, Errors]), {error, Errors}. @@ -122,10 +161,6 @@ lager:error("SWx error: ~p, ExtraPars: ~p~n", [Reason, ExtraPars]), {error, Reason}. -%% handle_request/3 -handle_request(_Packet, _SvcName, _Peer) -> - erlang:error({unexpected, ?MODULE, ?LINE}). - %% ------------------------------------------------------------------ %% Internal Function Definitions %% ------------------------------------------------------------------ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36232?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iba49fe8565d2303f975003ed2a79de25a4b23832 Gerrit-Change-Number: 36232 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_hss_initiated_deregister_new_server_assigned
by pespin 11 Mar '24

11 Mar '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36230?usp=email ) Change subject: epdg: Introduce test TC_hss_initiated_deregister_new_server_assigned ...................................................................... epdg: Introduce test TC_hss_initiated_deregister_new_server_assigned Related: OS#6042 Change-Id: Ia5bf7708d11421710f3a88669d94c4f01060cdd6 --- M epdg/EPDG_Tests.ttcn M epdg/gen_links.sh M library/DIAMETER_Templates.ttcn A library/DIAMETER_ts29_229_Templates.ttcn M library/DIAMETER_ts29_273_Templates.ttcn M pgw/gen_links.sh 6 files changed, 194 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/36230/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index d8112e8..9aaeb60 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -19,6 +19,7 @@ import from DIAMETER_Types all; import from DIAMETER_Templates all; import from DIAMETER_rfc4004_Templates all; +import from DIAMETER_ts29_229_Templates all; import from DIAMETER_ts29_272_Templates all; import from DIAMETER_ts29_273_Templates all; import from DIAMETER_Emulation all; @@ -470,6 +471,32 @@ } } +/* Send RTR as HSS to AAA server, expect back RTA */ +private function f_DIA_SWx_RT(template (value) CxDx_3GPP_Reason_Code reason_code, + template (present) GenericAVP exp_result_tmpl := tr_AVP_ResultCode(DIAMETER_SUCCESS)) runs on EPDG_ConnHdlr { + var PDU_DIAMETER rx_dia; + var UINT32 hbh_id := f_rnd_octstring(4); + var UINT32 ete_id := f_rnd_octstring(4); + var octetstring reason_info := char2oct("test"); + + /* Unlike STR, STA contains no IMSI. Register ete_id in DIAMETER_Emulation, + * so AIA is forwarded back to us in DIAMETER port instead of MTC_CT.DIAMETER_UNIT. + */ + f_epdg_connhldr_SWx_expect_eteid(ete_id); + + SWx.send(ts_DIA_SWx_RTR(g_pars.imsi, reason_code, reason_info, + hbh_id := hbh_id, + ete_id := ete_id)); + + alt { + [] SWx.receive(tr_DIA_SWx_RTA(exp_result_tmpl, hbh_id := hbh_id, ete_id := ete_id)) -> value rx_dia {} + [] SWx.receive(PDU_DIAMETER:?) -> value rx_dia { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected Diameter SWx msg rx: ", rx_dia)); + } + } +} + + /* Send AAR as PGW to AAA server, expect back AAA */ private function f_S6b_AA_success() runs on EPDG_ConnHdlr { var PDU_DIAMETER rx_dia; @@ -1025,6 +1052,25 @@ setverdict(pass); } +/* 3GPP TS 29.273 Network Initiated De-Registration by HSS, Administrative */ +private function f_TC_hss_initiated_deregister_new_server_assigned(charstring id) runs on EPDG_ConnHdlr { + f_initial_attach(); + /* Procedure should be performed properly: */ + f_DIA_SWx_RT(NEW_SERVER_ASSIGNED, tr_AVP_ResultCode(DIAMETER_SUCCESS)); + /* Subscriber was already removed, it should fail if requested again: */ + var DIAMETER_ts29_229_ExperimentalResultcode erc := DIAMETER_ERROR_USER_UNKNOWN; + f_DIA_SWx_RT(NEW_SERVER_ASSIGNED, tr_AVP_ExperimentalResult(vendor_id_3GPP, int2oct(enum2int(erc), 4))); + f_sleep(3.0); +} +testcase TC_hss_initiated_deregister_new_server_assigned() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_hss_initiated_deregister_new_server_assigned), pars); + vc_conn.done; + setverdict(pass); +} + private function f_TC_concurrent_ues(charstring id) runs on EPDG_ConnHdlr { COORD.send(COORD_CMD_READY); COORD.receive(COORD_CMD_START); @@ -1121,6 +1167,7 @@ execute ( TC_ho_lte_to_wifi() ); execute ( TC_ho_wifi_to_lte() ); execute ( TC_s2b_CreateSession_rejected() ); + execute ( TC_hss_initiated_deregister_new_server_assigned() ); execute ( TC_concurrent_ues2() ); execute ( TC_concurrent_ues100() ); execute ( TC_upf_echo_req() ); diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh index f0b2f5c..55e449f 100755 --- a/epdg/gen_links.sh +++ b/epdg/gen_links.sh @@ -55,7 +55,7 @@ FILES+="L3_Common.ttcn " FILES+="DNS_Helpers.ttcn " FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc DIAMETER_Emulation.ttcn " -FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc4004_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn DIAMETER_ts29_272_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn " +FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc4004_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn DIAMETER_ts29_229_Templates.ttcn DIAMETER_ts29_272_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn " FILES+="IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp " FILES+="PCO_Types.ttcn GSUP_Types.ttcn GSUP_Templates.ttcn GSUP_Emulation.ttcn " diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 338899f..31ea821 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -682,7 +682,7 @@ } } } -template (value) GenericAVP ts_AVP_UserNameImsi(hexstring imsi) := ts_AVP_UserName(char2oct(hex2str(imsi))); +template (value) GenericAVP ts_AVP_UserNameImsi(template (value) hexstring imsi) := ts_AVP_UserName(char2oct(hex2str(valueof(imsi)))); template (present) GenericAVP tr_AVP_UserNameImsi(template (present) hexstring imsi := ?) := tr_AVP_UserName(char2oct_tmpl(hex2str_tmpl(imsi))); diff --git a/library/DIAMETER_ts29_229_Templates.ttcn b/library/DIAMETER_ts29_229_Templates.ttcn new file mode 100644 index 0000000..bab9bd9 --- /dev/null +++ b/library/DIAMETER_ts29_229_Templates.ttcn @@ -0,0 +1,78 @@ +module DIAMETER_ts29_229_Templates { + +/* (C) 2023 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + * + * Templates for AVPs and messages for TS 29.273 + */ + +import from General_Types all; +import from DIAMETER_Types all; +import from DIAMETER_Templates all; +import from DIAMETER_rfc5447_Templates all; +import from DIAMETER_ts29_272_Templates all; +import from Osmocom_Types all; +import from Misc_Helpers all; + +/* 3GPP TS 29.229 section 6.2. Errors in Result-Code AVP values */ +type enumerated DIAMETER_ts29_229_ExperimentalResultcode { + /* Success */ + DIAMETER_FIRST_REGISTRATION (2001), + DIAMETER_SUBSEQUENT_REGISTRATION (2002), + DIAMETER_UNREGISTERED_SERVICE (2003), + DIAMETER_SUCCESS_SERVER_NAME_NOT_STORED (2004), + /* Permanent Failures */ + DIAMETER_ERROR_USER_UNKNOWN (5001), + DIAMETER_ERROR_IDENTITIES_DONT_MATCH (5002), + DIAMETER_ERROR_IDENTITY_NOT_REGISTERED (5003), + DIAMETER_ERROR_ROAMING_NOT_ALLOWED (5004), + DIAMETER_ERROR_IDENTITY_ALREADY_REGISTERED (5005), + DIAMETER_ERROR_AUTH_SCHEME_NOT_SUPPORTED (5006), + DIAMETER_ERROR_IN_ASSIGNMENT_TYPE (5007), + DIAMETER_ERROR_TOO_MUCH_DATA (5008), + DIAMETER_ERROR_NOT_SUPPORTED_USER_DATA (5009), + DIAMETER_ERROR_FEATURE_UNSUPPORTED (5011), + DIAMETER_ERROR_SERVING_NODE_FEATURE_UNSUPPORTED (5012) +} + +/* TS 29.229 6.3.16 Deregistration-Reason */ +template (value) GenericAVP ts_AVP_CxDx_3GPP_Deregistration_Reason(template (value) CxDx_3GPP_Reason_Code reason, + template (value) octetstring info) := { + avp := { + avp_header := ts_DIA_Hdr_3GPP(c_AVP_Code_AAA_3GPP_Non_3GPP_User_Data), + avp_data := { + avp_CxDx_3GPP_Deregistration_Reason := { + ts_AVP_CxDx_3GPP_Reason_Code(reason), + ts_AVP_CxDx_3GPP_Reason_Info(info) + } + } + } +} + +/* TS 29.229 6.3.17 Reason-Code AVP */ +template (value) GenericAVP ts_AVP_CxDx_3GPP_Reason_Code(template (value) CxDx_3GPP_Reason_Code reason) := { + avp := { + avp_header := ts_DIA_Hdr_3GPP(c_AVP_Code_CxDx_3GPP_Reason_Code), + avp_data := { + avp_CxDx_3GPP_Reason_Code := reason + } + } +} + + +/* 6.3.18 Reason-Info AVP */ +template (value) GenericAVP ts_AVP_CxDx_3GPP_Reason_Info(template (value) octetstring info) := { + avp := { + avp_header := ts_DIA_Hdr_3GPP(c_AVP_Code_CxDx_3GPP_Reason_Info), + avp_data := { + avp_CxDx_3GPP_Reason_Info := info + } + } +} + +} diff --git a/library/DIAMETER_ts29_273_Templates.ttcn b/library/DIAMETER_ts29_273_Templates.ttcn index f0ac442..0a42d6a 100644 --- a/library/DIAMETER_ts29_273_Templates.ttcn +++ b/library/DIAMETER_ts29_273_Templates.ttcn @@ -15,6 +15,7 @@ import from DIAMETER_Types all; import from DIAMETER_Templates all; import from DIAMETER_rfc5447_Templates all; +import from DIAMETER_ts29_229_Templates all; import from DIAMETER_ts29_272_Templates all; import from Osmocom_Types all; import from Misc_Helpers all; @@ -269,6 +270,61 @@ */ }); +/* Registration-Termination-Request (RTR) , 8.2.2.4 Network Initiated De-Registration by HSS Procedure */ +template (value) PDU_DIAMETER +ts_DIA_SWx_RTR(template (value) hexstring imsi, + template (value) CxDx_3GPP_Reason_Code reason_code := PERMANENT_TERMINATION, + template (value) octetstring reason_info := ''O, + template (value) uint32_t vendor_app_id := c_DIAMETER_3GPP_SWx_AID, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "hss.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) charstring dest_host := "aaa.localdomain", + template (value) charstring dest_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '11000000'B, + cmd_code := Registration_Termination, + app_id := int2oct(c_DIAMETER_3GPP_SWx_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_VendorSpecAppId(vendor_id_3GPP, valueof(vendor_app_id)), + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_DestinationHost(dest_host), + ts_AVP_DestinationRealm(dest_realm), + ts_AVP_UserNameImsi(imsi), + ts_AVP_CxDx_3GPP_Deregistration_Reason(reason_code, reason_info) + /* TODO: + * *[ Supported-Features ] + */ + }); + +template (present) PDU_DIAMETER +tr_DIA_SWx_RTA(template (present) GenericAVP tmpl_result := ?, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) charstring dest_host := ?, + template (present) charstring dest_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Registration_Termination, + app_id := int2oct(c_DIAMETER_3GPP_SWx_AID, 4), + hbh_id := hbh_id, ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_VendorSpecAppId(?, ?), + tmpl_result, + tr_AVP_AuthSessionState(NO_STATE_MAINTAINED), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm) + )); + /******************************* * S6b 3GPP TS 29.273 section 9 *******************************/ diff --git a/pgw/gen_links.sh b/pgw/gen_links.sh index 70494ce..9bdface 100755 --- a/pgw/gen_links.sh +++ b/pgw/gen_links.sh @@ -64,7 +64,7 @@ FILES+="GTPv2_CodecPort.ttcn GTPv2_CodecPort_CtrlFunctDef.cc GTPv2_CodecPort_CtrlFunct.ttcn GTPv2_Emulation.ttcn " FILES+="DNS_Helpers.ttcn " FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc DIAMETER_Emulation.ttcn " -FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc4004_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn DIAMETER_ts29_212_Templates.ttcn DIAMETER_ts29_272_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn DIAMETER_ts32_299_Templates.ttcn " +FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc4004_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn DIAMETER_ts29_212_Templates.ttcn DIAMETER_ts29_212_Templates.ttcn DIAMETER_ts29_229_Templates.ttcn DIAMETER_ts29_272_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn DIAMETER_ts32_299_Templates.ttcn " gen_links $DIR $FILES ignore_pp_results -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5bf7708d11421710f3a88669d94c4f01060cdd6 Gerrit-Change-Number: 36230 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
by pespin 11 Mar '24

11 Mar '24

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd ...................................................................... Patch Set 1: (2 comments) File ipad/IPAd_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/66c15806_3ca9… PS1, Line 445: for (i := 0; i < sizeof(esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87); i := i + 1) { sounds like you want to put this in a variable ;) "esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage" https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ea4af62a_0b04… PS1, Line 652: // execute ( TC_add_init_eim() ); why is this one commented out? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Mar 2024 14:56:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: library: add HTTP_Server_Emulation
by pespin 11 Mar '24

11 Mar '24

Attention is currently required from: daniel, dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36155?usp=email ) Change subject: library: add HTTP_Server_Emulation ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9a3b31a047b617ae69b7a65e1d69b8d3da863e5 Gerrit-Change-Number: 36155 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Mar 2024 14:54:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-ttcn3-hacks[master]: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templ...
by pespin 11 Mar '24

11 Mar '24

Attention is currently required from: daniel, dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email ) Change subject: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templates ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9df8caa98aeb6953a738660a758c92249832d780 Gerrit-Change-Number: 36154 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Mar 2024 14:53:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: library: add HTTP_Server_Emulation
by dexter 11 Mar '24

11 Mar '24

Attention is currently required from: daniel, laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36155?usp=email ) Change subject: library: add HTTP_Server_Emulation ...................................................................... Patch Set 3: (1 comment) This change is ready for review. Patchset: PS3: I have renamed the port so that it won't clash with HTTP_Adapter.ttcn -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9a3b31a047b617ae69b7a65e1d69b8d3da863e5 Gerrit-Change-Number: 36155 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Mar 2024 14:50:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in osmo-ttcn3-hacks[master]: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templ...
by dexter 11 Mar '24

11 Mar '24

Attention is currently required from: daniel, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email ) Change subject: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templates ...................................................................... Patch Set 4: (1 comment) This change is ready for review. Patchset: PS4: I have improved this a bit, in particular in regard of on the ES9+, which we will need for testing the eIM. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9df8caa98aeb6953a738660a758c92249832d780 Gerrit-Change-Number: 36154 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Mar 2024 14:49:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Emulation: fix typo
by dexter 11 Mar '24

11 Mar '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36228?usp=email ) Change subject: GTP_Emulation: fix typo ...................................................................... GTP_Emulation: fix typo Change-Id: I66685e0e4da97eda2bd5f4573c0994444824993f --- M library/GTP_Emulation.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/library/GTP_Emulation.ttcn b/library/GTP_Emulation.ttcn index f5c0eef..f7c54a1 100644 --- a/library/GTP_Emulation.ttcn +++ b/library/GTP_Emulation.ttcn @@ -272,7 +272,7 @@ } with { extension "internal" }; /*********************************************************************** - * Client Compoennt + * Client Component ***********************************************************************/ type component GTP_ConnHdlr { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66685e0e4da97eda2bd5f4573c0994444824993f Gerrit-Change-Number: 36228 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log