- gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: Set persistent->ctx pointer on HNB REGISTER REQ
by laforge 12 Mar '24

12 Mar '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36249?usp=email ) Change subject: Set persistent->ctx pointer on HNB REGISTER REQ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36249?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I18fe0e5aa968a1095c72e6bf32d08b031b342ac6 Gerrit-Change-Number: 36249 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 12 Mar 2024 20:36:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Set persistent->ctx pointer on HNB REGISTER REQ
by laforge 12 Mar '24

12 Mar '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36249?usp=email ) Change subject: Set persistent->ctx pointer on HNB REGISTER REQ ...................................................................... Set persistent->ctx pointer on HNB REGISTER REQ The previous commit was missing the assignment of hnb_persistent->ctx during successful HNB REGISTER REQ. Related: SYS#6773 Fixes: Change-Id Ife89a7a206836bd89334d19d3cf8c92969dd74de Change-Id: I18fe0e5aa968a1095c72e6bf32d08b031b342ac6 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/49/36249/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index f9ad478..0648ebc 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -441,6 +441,7 @@ return hnbgw_tx_hnb_register_rej(ctx); } ctx->persistent = hnbp; + hnbp->ctx = ctx; llist_for_each_entry_safe(hnb, tmp, &g_hnbgw->hnb_list, list) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36249?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I18fe0e5aa968a1095c72e6bf32d08b031b342ac6 Gerrit-Change-Number: 36249 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: mgw_fsm: Add some OSMO_ASSERT() to ensure only CS maps passed
by laforge 12 Mar '24

12 Mar '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36250?usp=email ) Change subject: mgw_fsm: Add some OSMO_ASSERT() to ensure only CS maps passed ...................................................................... mgw_fsm: Add some OSMO_ASSERT() to ensure only CS maps passed The mgw_fsm only supports CS RABs in the CS domain; let's add some ASSERTs to make sure the impossible doesn't happen. Change-Id: I264c4b3da17b6f59ebcdd02031318402a483041a --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/50/36250/1 diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 6d23790..d0dc6df 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -807,6 +807,8 @@ struct mgw_fsm_priv *mgw_fsm_priv; char fsm_name[255]; + OSMO_ASSERT(!map->is_ps); + /* Initialize FSM if not done yet */ if (!initialized) { OSMO_ASSERT(osmo_fsm_register(&mgw_fsm) == 0); @@ -878,6 +880,7 @@ struct mgw_fsm_priv *mgw_fsm_priv; OSMO_ASSERT(ranap_msg); + OSMO_ASSERT(!map->is_ps); if (!map->mgw_fi) { /* NOTE: This situation is a corner-case. We may end up here when the co-located MGW caused a problem @@ -916,6 +919,8 @@ * \returns 0 on success; negative on error. */ int mgw_fsm_release(struct hnbgw_context_map *map) { + OSMO_ASSERT(!map->is_ps); + if (!map->mgw_fi) return -EINVAL; @@ -930,6 +935,8 @@ struct timespec elapsed; uint64_t elapsed_ms; + OSMO_ASSERT(!map->is_ps); + if (!map->mgw_fi) return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I264c4b3da17b6f59ebcdd02031318402a483041a Gerrit-Change-Number: 36250 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: vty: Print the uptime during 'show hnb' output
by laforge 12 Mar '24

12 Mar '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36251?usp=email ) Change subject: vty: Print the uptime during 'show hnb' output ...................................................................... vty: Print the uptime during 'show hnb' output Change-Id: Ic414fe301b3fa5c357bd1cd8a7842b7d6333c709 --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_vty.c 3 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/51/36251/1 diff --git a/include/osmocom/hnbgw/hnbgw.h b/include/osmocom/hnbgw/hnbgw.h index 9fb6d98..d44fc7f 100644 --- a/include/osmocom/hnbgw/hnbgw.h +++ b/include/osmocom/hnbgw/hnbgw.h @@ -437,3 +437,5 @@ struct msgb *hnbgw_ranap_msg_alloc(const char *name); int hnbgw_peek_l3_ul(struct hnbgw_context_map *map, struct msgb *ranap_msg); + +unsigned long long hnb_get_updowntime(const struct hnb_context *ctx); diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 894f06c..9b15c7d 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -483,6 +483,13 @@ return difftime(tp.tv_sec, hnbp->updowntime); } +unsigned long long hnb_get_updowntime(const struct hnb_context *ctx) +{ + if (!ctx->persistent) + return 0; + return hnbp_get_updowntime(ctx->persistent); +} + /* timer call-back: Update the HNB_STAT_UPTIME_SECONDS stat item of each hnb_persistent */ static void hnbgw_store_hnb_uptime(void *data) { diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index 1870f5d..c5af249 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -204,6 +204,7 @@ struct hnbgw_context_map *map; unsigned int map_count[2] = {}; unsigned int state_count[2][MAP_S_NUM_STATES + 1] = {}; + unsigned long long sec; vty_out(vty, "HNB "); vty_out_ofd_addr(vty, hnb->conn? osmo_stream_srv_get_ofd(hnb->conn) : NULL); @@ -218,6 +219,12 @@ } vty_dump_hnb_info__map_states(vty, "IuCS", map_count[0], state_count[0]); vty_dump_hnb_info__map_states(vty, "IuPS", map_count[1], state_count[1]); + + sec = hnb_get_updowntime(hnb); + if (sec) { + vty_out(vty, " Iuh Uptime: %llu days %llu hours %llu min. %llu sec.%s", + OSMO_SEC2DAY(sec), OSMO_SEC2HRS(sec), OSMO_SEC2MIN(sec), sec % 60, VTY_NEWLINE); + } } static void vty_dump_ue_info(struct vty *vty, struct ue_context *ue) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic414fe301b3fa5c357bd1cd8a7842b7d6333c709 Gerrit-Change-Number: 36251 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-hnbgw[master]: Introduce counter for per-hnb cumulative active CS RAB duration
by laforge 12 Mar '24

12 Mar '24

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36205?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Introduce counter for per-hnb cumulative active CS RAB duration ...................................................................... Introduce counter for per-hnb cumulative active CS RAB duration This counter can be used to determine the traffic in Erlangs per HNB. Change-Id: Iffb6a3f38239094551a12c872cd8474d02a5ad56 --- M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/mgw_fsm.h M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/mgw_fsm.c 4 files changed, 95 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/05/36205/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iffb6a3f38239094551a12c872cd8474d02a5ad56 Gerrit-Change-Number: 36205 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: rename hnbgw_peek_l3 to hnbgw_peek_l3_ul as it's uplink only
by laforge 12 Mar '24

12 Mar '24

Attention is currently required from: laforge. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36207?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: rename hnbgw_peek_l3 to hnbgw_peek_l3_ul as it's uplink only ...................................................................... rename hnbgw_peek_l3 to hnbgw_peek_l3_ul as it's uplink only Let's not make the functions appear more generic than they are: They all explicitly only support uplink so far. Change-Id: I7db0d933a8f17f8c410141f43dab12b8c19fc8ae --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/hnbgw_l3.c M src/osmo-hnbgw/hnbgw_rua.c 3 files changed, 22 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/07/36207/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7db0d933a8f17f8c410141f43dab12b8c19fc8ae Gerrit-Change-Number: 36207 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: cosmetic: Rename hnbgw_rx_ranap and friends to *_rx_ranap_udt_ul
by laforge 12 Mar '24

12 Mar '24

Attention is currently required from: laforge. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36206?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cosmetic: Rename hnbgw_rx_ranap and friends to *_rx_ranap_udt_ul ...................................................................... cosmetic: Rename hnbgw_rx_ranap and friends to *_rx_ranap_udt_ul Those functions have always been handling only unit-data in uplink direction, so let's reflect that in the function name to prevent anyone assuming they process connection-oriented RANAP and/or the downlink direction. Change-Id: I29e8176ac19b2e7390e5950b8d0944c8961e491f --- M include/osmocom/hnbgw/hnbgw_ranap.h M src/osmo-hnbgw/hnbgw_ranap.c M src/osmo-hnbgw/hnbgw_rua.c 3 files changed, 31 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/06/36206/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I29e8176ac19b2e7390e5950b8d0944c8961e491f Gerrit-Change-Number: 36206 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: don't forward paging requests to HNB's not yet registered
by laforge 12 Mar '24

12 Mar '24

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36208?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: don't forward paging requests to HNB's not yet registered ...................................................................... don't forward paging requests to HNB's not yet registered Change-Id: I22ddfea1c6e13e91acecaf731b446e2de0976892 --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/08/36208/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I22ddfea1c6e13e91acecaf731b446e2de0976892 Gerrit-Change-Number: 36208 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: cosmetic: align downlink RANAP unitdata function names with uplink
by laforge 12 Mar '24

12 Mar '24

Attention is currently required from: laforge. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36210?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cosmetic: align downlink RANAP unitdata function names with uplink ...................................................................... cosmetic: align downlink RANAP unitdata function names with uplink In uplink we use *ranap_rx_udt_ul*, so let's use the same naming pattern for processing dowlink unit-data messages to make things more consistent. Also, make sure udt is always part of functions that only handle unitdata - not to be confused with connection-oriented messages. Change-Id: I1792e4c2cdce145ae906c181898163bcda36328d --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 26 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/10/36210/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1792e4c2cdce145ae906c181898163bcda36328d Gerrit-Change-Number: 36210 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: stats: Introduce CNLINK counter macros
by laforge 12 Mar '24

12 Mar '24

Attention is currently required from: laforge. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36211?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: stats: Introduce CNLINK counter macros ...................................................................... stats: Introduce CNLINK counter macros Ever since the ancient days of OpenBSC, we've always had macros to abbreviate the cumbersome 'rate_ctr_inc(rate_ctr_group_get_ctr(...))' construct. Somehow this was missed here. Also, since 2018 (libosmocore.git 175a4ae93aaf1068b61041dca12962059d65ed55) we have rate_ctr_inc2() to make it even simpler... Change-Id: I2754d7aa9d6c3e333bd729bc6e924c502b40cdad --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/hnbgw_cn.c 2 files changed, 25 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/11/36211/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2754d7aa9d6c3e333bd729bc6e924c502b40cdad Gerrit-Change-Number: 36211 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log