- gerrit-log - lists.osmocom.org

[M] Change in osmo-hnodeb[master]: Close LLSK during shutdown procedure
by pespin 13 Mar '24

13 Mar '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36248?usp=email ) Change subject: Close LLSK during shutdown procedure ...................................................................... Close LLSK during shutdown procedure This way we notify the lower layers that state must be reset, eg. when Iuh conn drops. Related: OS#6826 Change-Id: I282f3e75d31b3e481136aade34b30074300ab631 --- M include/osmocom/hnodeb/hnb_shutdown_fsm.h M include/osmocom/hnodeb/llsk.h M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/llsk.c 4 files changed, 57 insertions(+), 15 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/hnodeb/hnb_shutdown_fsm.h b/include/osmocom/hnodeb/hnb_shutdown_fsm.h index 69f9f4b..5b40551 100644 --- a/include/osmocom/hnodeb/hnb_shutdown_fsm.h +++ b/include/osmocom/hnodeb/hnb_shutdown_fsm.h @@ -28,6 +28,7 @@ enum hnb_shutdown_fsm_states { HNB_SHUTDOWN_ST_NONE, + HNB_SHUTDOWN_ST_IN_PROGRESS, HNB_SHUTDOWN_ST_EXIT, }; diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index 6a2686a..2c06f3e 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -34,6 +34,7 @@ int hnb_llsk_start_listen(struct hnb *hnb); bool hnb_llsk_connected(const struct hnb *hnb); bool hnb_llsk_can_be_configured(struct hnb *hnb); +void hnb_llsk_close_conn(const struct hnb *hnb); int ll_addr_type2af(enum u_addr_type t); int ll_addr2osa(enum u_addr_type t, const union u_addr *uaddr, uint16_t port, struct osmo_sockaddr *osa); diff --git a/src/osmo-hnodeb/hnb_shutdown_fsm.c b/src/osmo-hnodeb/hnb_shutdown_fsm.c index c97a124..7b04c6b 100644 --- a/src/osmo-hnodeb/hnb_shutdown_fsm.c +++ b/src/osmo-hnodeb/hnb_shutdown_fsm.c @@ -44,25 +44,33 @@ static void st_none(struct osmo_fsm_inst *fi, uint32_t event, void *data) { + switch (event) { + case HNB_SHUTDOWN_EV_START: + hnb_shutdown_fsm_state_chg(fi, HNB_SHUTDOWN_ST_IN_PROGRESS); + break; + } +} + +static void st_in_progress_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ struct hnb *hnb = (struct hnb *)fi->priv; struct hnb_ue *ue, *ue_tmp; - switch (event) { - case HNB_SHUTDOWN_EV_START: - /* TODO: here we may want to communicate to lower layers over UDsocket that we are shutting down... - * TODO: Also, if Iuh link is still up, maybe send a Hnb deregister req towards HNBGW - */ + /* TODO: Also, if Iuh link is still up, maybe send a Hnb deregister req towards HNBGW */ - /* Drop active UE contexts, together with their GTP/AUDIO sessions: */ - llist_for_each_entry_safe(ue, ue_tmp, &hnb->ue_list, list) - hnb_ue_free(ue); + /* Drop active UE contexts, together with their GTP/AUDIO sessions: */ + llist_for_each_entry_safe(ue, ue_tmp, &hnb->ue_list, list) + hnb_ue_free(ue); - if (osmo_stream_cli_is_connected(hnb->iuh.client)) - osmo_stream_cli_close(hnb->iuh.client); + if (osmo_stream_cli_is_connected(hnb->iuh.client)) + osmo_stream_cli_close(hnb->iuh.client); - hnb_shutdown_fsm_state_chg(fi, HNB_SHUTDOWN_ST_EXIT); - break; - } + /* Close LLSK to notify lower layers that we are shutting down + * even if we are not exiting the process. */ + if (hnb_llsk_connected(hnb)) + hnb_llsk_close_conn(hnb); + + hnb_shutdown_fsm_state_chg(fi, HNB_SHUTDOWN_ST_EXIT); } static void st_exit_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) @@ -82,11 +90,17 @@ .in_event_mask = X(HNB_SHUTDOWN_EV_START), .out_state_mask = - X(HNB_SHUTDOWN_ST_EXIT), + X(HNB_SHUTDOWN_ST_IN_PROGRESS), .name = "NONE", .onenter = st_none_on_enter, .action = st_none, }, + [HNB_SHUTDOWN_ST_IN_PROGRESS] = { + .out_state_mask = + X(HNB_SHUTDOWN_ST_EXIT), + .name = "IN_PROGRESS", + .onenter = st_in_progress_on_enter, + }, [HNB_SHUTDOWN_ST_EXIT] = { .name = "EXIT", .out_state_mask = diff --git a/src/osmo-hnodeb/llsk.c b/src/osmo-hnodeb/llsk.c index 7e25176..1a1b3c7 100644 --- a/src/osmo-hnodeb/llsk.c +++ b/src/osmo-hnodeb/llsk.c @@ -113,7 +113,12 @@ hnb->llsk.srv = NULL; hnb->llsk.valid_sapi_mask = 0x0; osmo_timer_del(&hnb->llsk.defer_configure_ind_timer); - hnb_shutdown(hnb, "LLSK conn dropped", false); + + /* We actively close the llsk conn during hnb_shutdown, no need to + * re-enter shutdown procedure thin that case: */ + if (!hnb_shutdown_in_progress(hnb)) + hnb_shutdown(hnb, "LLSK conn dropped", false); + return 0; } @@ -136,6 +141,14 @@ return false; } +void hnb_llsk_close_conn(const struct hnb *hnb) +{ + if (!hnb_llsk_connected(hnb)) + return; + osmo_prim_srv_close(hnb->llsk.srv); + /* pointer NULLed in llsk_closed_cb() */ +} + static void llsk_defer_configure_ind_timer_cb(void *data) { struct hnb *hnb = (struct hnb *)data; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I282f3e75d31b3e481136aade34b30074300ab631 Gerrit-Change-Number: 36248 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnodeb[master]: iuh: Name stream_cli connection
by pespin 13 Mar '24

13 Mar '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36236?usp=email ) Change subject: iuh: Name stream_cli connection ...................................................................... iuh: Name stream_cli connection This makes it easier to figure out the conn log lines. Change-Id: I1503b322f8ff053088688b3088a70801d10b3d88 --- M src/osmo-hnodeb/iuh.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c index 79df371..f1efb0d 100644 --- a/src/osmo-hnodeb/iuh.c +++ b/src/osmo-hnodeb/iuh.c @@ -180,6 +180,7 @@ cli = osmo_stream_cli_create(hnb); OSMO_ASSERT(cli); hnb->iuh.client = cli; + osmo_stream_cli_set_name(cli, "Iuh"); osmo_stream_cli_set_nodelay(cli, true); osmo_stream_cli_set_proto(cli, IPPROTO_SCTP); osmo_stream_cli_set_reconnect_timeout(cli, 5); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I1503b322f8ff053088688b3088a70801d10b3d88 Gerrit-Change-Number: 36236 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnodeb[master]: Name llsk prim_srv{_link}
by pespin 13 Mar '24

13 Mar '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36239?usp=email ) Change subject: Name llsk prim_srv{_link} ...................................................................... Name llsk prim_srv{_link} This allows easily identifying the prim_srv{_link} in logs. Depends: libosmo-netif.git Change-Id Iba683e4d65e0aba81e13bdf1b9d5a9065b1fc89c Change-Id: Idae27bc9a2a223710edb9fca905ad5ae924dde80 --- M TODO-RELEASE M src/osmo-hnodeb/llsk.c 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index 2c9f8ba..61eb973 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmocore depend >= 1.9.0 we need osmo_sockaddr_from_str_and_uint() +libosmo-netif depend > 1.4.0 osmo_prim_srv{_link}_set_name() \ No newline at end of file diff --git a/src/osmo-hnodeb/llsk.c b/src/osmo-hnodeb/llsk.c index ddb13c4..b76b595 100644 --- a/src/osmo-hnodeb/llsk.c +++ b/src/osmo-hnodeb/llsk.c @@ -85,6 +85,7 @@ static int llsk_opened_cb(struct osmo_prim_srv *srv) { struct hnb *hnb = (struct hnb *)osmo_prim_srv_get_priv(srv); + osmo_prim_srv_set_name(srv, "llsk"); if (hnb->llsk.srv) { LOGP(DLLSK, LOGL_ERROR, "New connection opened while one is already active, dropping it\n"); @@ -208,6 +209,7 @@ { hnb->llsk.link = osmo_prim_srv_link_alloc(hnb); osmo_prim_srv_link_set_priv(hnb->llsk.link, hnb); + osmo_prim_srv_link_set_name(hnb->llsk.link, "llsk-link"); osmo_prim_srv_link_set_log_category(hnb->llsk.link, DLLSK); osmo_prim_srv_link_set_addr(hnb->llsk.link, HNB_PRIM_UD_SOCK_DEFAULT); osmo_prim_srv_link_set_opened_conn_cb(hnb->llsk.link, llsk_opened_cb); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Idae27bc9a2a223710edb9fca905ad5ae924dde80 Gerrit-Change-Number: 36239 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnodeb[master]: cosmetic: Fix typo in comment
by pespin 13 Mar '24

13 Mar '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36245?usp=email ) Change subject: cosmetic: Fix typo in comment ...................................................................... cosmetic: Fix typo in comment Change-Id: Ie13952075be29201751d5b7884ca572a285ca9dd --- M src/osmo-hnodeb/hnb_shutdown_fsm.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/osmo-hnodeb/hnb_shutdown_fsm.c b/src/osmo-hnodeb/hnb_shutdown_fsm.c index 7c9eee8..9d7e186 100644 --- a/src/osmo-hnodeb/hnb_shutdown_fsm.c +++ b/src/osmo-hnodeb/hnb_shutdown_fsm.c @@ -47,7 +47,7 @@ struct hnb *hnb = (struct hnb *)fi->priv; switch (event) { case HNB_SHUTDOWN_EV_START: - /* TODO: here we may want to communicate t lower layers over UDsocket that we are shutting down... + /* TODO: here we may want to communicate to lower layers over UDsocket that we are shutting down... * TODO: Also, if Iuh link is still up, maybe send a Hnb deregister req towards HNBGW * TODO: also signal the hnb object somehow that we are starting to shut down? */ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie13952075be29201751d5b7884ca572a285ca9dd Gerrit-Change-Number: 36245 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: library: add templates for L1CTL_{DATA,TRAFFIC}_CONF
by fixeria 13 Mar '24

13 Mar '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36254?usp=email ) Change subject: library: add templates for L1CTL_{DATA,TRAFFIC}_CONF ...................................................................... Patch Set 1: (1 comment) File library/L1CTL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36254/comment/5e50021d_4ae3… PS1, Line 859: template L1ctlMessage > 1- It really is a "template (present)", it cannot be omit. Yes, it's obvious that a complete template definition cannot be `omit` unless it's a direct and implicit assignment of `omit` (`template Foo bar := omit;`), and unless it's generated and returned by a function (`template Foo bar := f_gen_tr_Foo(...);`). So I would say it's redundant to say that it's `(present)` in this specific case. > 2- Then if you want to pass it as a param to another template which expects as param "template (present)", it won't match the expectancies. This probably generates warnings. I don't think this is the case, at least it's not with TITAN. The following code compiles without any warnings, and the testcase is passing: ``` diff --git a/selftest/Selftest.ttcn b/selftest/Selftest.ttcn index 3d749253..5ee8a544 100644 --- a/selftest/Selftest.ttcn +++ b/selftest/Selftest.ttcn @@ -94,6 +94,39 @@ testcase TC_ipa_fragment() runs on IPA_selftest_CT { setverdict(pass); } +private type record FooBar { + integer foo, + integer bar +}; + +private type record FooBarZoo { + FooBar foo_bar, + integer zoo +}; + +template FooBar tr_FooBar(template (present) integer foo, + template (present) integer bar) := { + foo := foo, + bar := bar +} + +template FooBarZoo tr_FooBarZoo(template (present) FooBar foo_bar, + template (present) integer zoo) := { + foo_bar := foo_bar, + zoo := zoo +} + +private type component dummy_CT { }; + +testcase TC_foo_bar_zoo() runs on dummy_CT { + var FooBarZoo fbz := { { 1, 2 }, 42 }; + + if (match(fbz, tr_FooBarZoo(tr_FooBar(?, ?), 42))) { + setverdict(pass); + } else { + setverdict(fail); + } +} control { execute( TC_ipa_fragment() ); ``` Note that I am passing `tr_FooBar(?, ?)`, which is defined without the `(present)` restriction, to `tr_FooBarZoo`, which does expect the first template parameter to be `(present)`. All in all, I don't think we should be forcing this during code review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I914555ac8bf2784c14e1b5564b116221ecc7b539 Gerrit-Change-Number: 36254 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 15:06:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnodeb[master]: Close LLSK during shutdown procedure
by fixeria 13 Mar '24

13 Mar '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36248?usp=email ) Change subject: Close LLSK during shutdown procedure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I282f3e75d31b3e481136aade34b30074300ab631 Gerrit-Change-Number: 36248 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 15:03:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnodeb[master]: Free UE contexts when starting shutdown procedure
by fixeria 13 Mar '24

13 Mar '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36247?usp=email ) Change subject: Free UE contexts when starting shutdown procedure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I51aa449e7fd5b1049fcaaeef3f1378423a838c05 Gerrit-Change-Number: 36247 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 14:58:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnodeb[master]: llsk: Add APIs to interact with llsk->link
by fixeria 13 Mar '24

13 Mar '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36246?usp=email ) Change subject: llsk: Add APIs to interact with llsk->link ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I7723467d34670f89710f55c0c6731e2e38560f35 Gerrit-Change-Number: 36246 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 14:58:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnodeb[master]: cosmetic: Fix typo in comment
by fixeria 13 Mar '24

13 Mar '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36245?usp=email ) Change subject: cosmetic: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie13952075be29201751d5b7884ca572a285ca9dd Gerrit-Change-Number: 36245 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 14:57:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnodeb[master]: Name llsk prim_srv{_link}
by fixeria 13 Mar '24

13 Mar '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36239?usp=email ) Change subject: Name llsk prim_srv{_link} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Idae27bc9a2a223710edb9fca905ad5ae924dde80 Gerrit-Change-Number: 36239 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 14:56:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log