Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email )
Change subject: doc: various osmux API documentation updates
......................................................................
Patch Set 1:
(2 comments)
File src/osmux.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15133):
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/0e4f2b3e_ec96c2d6
PS1, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15133):
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/356daf0a_afa94cb1
PS1, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \
macros should not use a trailing semicolon
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5af0133322ddd5345a13380f1c007474c0bea117
Gerrit-Change-Number: 36299
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 15 Mar 2024 13:08:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email )
Change subject: osmo_io: Massive improvement of API documentation
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/core/osmo_io.h:
https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/f7d14cf1_776a65a0
PS1, Line 23: * completion call-backs once the write receives.
"once the write receives" is confusing, I don't get what you mean.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c
Gerrit-Change-Number: 36288
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 15 Mar 2024 11:59:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email )
Change subject: osmo_io: Dont use __linux__ but !EMBEDDED
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I260443ba3cd0bb81dade434208dea4ea70fe8ad8
Gerrit-Change-Number: 36287
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 15 Mar 2024 11:51:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36297?usp=email )
Change subject: docs: Split Stream Server and Stream Client into separate groups
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36297?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9e037fedaecb78396f435577b1652284b4951ded
Gerrit-Change-Number: 36297
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 15 Mar 2024 11:50:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36294?usp=email )
Change subject: docs: More verbose stream_{cli,srv} API documentation/manual
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36294/comment/c08f5ef2_00bc0f94
PS2, Line 84: * You may send data to the connection using osmo_tream_cli_send().
If we decided it's only possible to send data after becoming connected (connect_cb is called), then I'd write here:
"You may *then* send data"...
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36294?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Iae3c3af6533be408e5755ceeda0067606a3b0ca1
Gerrit-Change-Number: 36294
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 15 Mar 2024 11:49:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment