- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pcsc: open reader/card in EXCLUSIVE mode by default
by laforge 15 Mar '24

15 Mar '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36273?usp=email ) Change subject: pcsc: open reader/card in EXCLUSIVE mode by default ...................................................................... pcsc: open reader/card in EXCLUSIVE mode by default There was a support request hinting that other applications concurrently accessed the SIM and were messing up the card state while pySim-shell was running. Let's avoid such situations by opening the card/reader in EXCLUSIVE mode by default. If somebody really has a special use case, they can now add the --pcsc-shared flag to restore the legacy behavior (SHARED mode). Change-Id: I90d887714b559a4604708d3c6dd23b5e05f40576 --- M pySim/transport/pcsc.py 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index 47976ae..9198816 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -25,6 +25,7 @@ from smartcard.CardRequest import CardRequest from smartcard.Exceptions import NoCardException, CardRequestTimeoutException, CardConnectionException from smartcard.System import readers +from smartcard.ExclusiveConnectCardConnection import ExclusiveConnectCardConnection from pySim.exceptions import NoCardError, ProtocolError, ReaderError from pySim.transport import LinkBase @@ -56,6 +57,8 @@ raise ReaderError('No matching reader found for regex %s' % opts.pcsc_regex) self._con = self._reader.createConnection() + if not opts.pcsc_shared: + self._con = ExclusiveConnectCardConnection(self._con) def __del__(self): try: @@ -119,6 +122,8 @@ Windows, MacOS X and Linux. Most vendors of smart card readers provide drivers that offer a PC/SC interface, if not even a generic USB CCID driver is used. You can use a tool like ``pcsc_scan -r`` to obtain a list of readers available on your system. """) + pcsc_group.add_argument('--pcsc-shared', action='store_true', + help='Open PC/SC reaer in SHARED access (default: EXCLUSIVE)') dev_group = pcsc_group.add_mutually_exclusive_group() dev_group.add_argument('-p', '--pcsc-device', type=int, dest='pcsc_dev', metavar='PCSC', default=None, help='Number of PC/SC reader to use for SIM access') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I90d887714b559a4604708d3c6dd23b5e05f40576 Gerrit-Change-Number: 36273 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[M] Change in pysim[master]: pySim-prog: convert from optparse to argparse
by laforge 15 Mar '24

15 Mar '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36274?usp=email ) Change subject: pySim-prog: convert from optparse to argparse ...................................................................... pySim-prog: convert from optparse to argparse We already use argparse everywhere else, and we have moved reader-driver argument parsing into the library expecting argparse. Change-Id: I7407496643247c754d002656688e9fdcbcf644a8 --- M pySim-prog.py 1 file changed, 65 insertions(+), 79 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim-prog.py b/pySim-prog.py index 2911b46..3f506de 100755 --- a/pySim-prog.py +++ b/pySim-prog.py @@ -25,7 +25,7 @@ # import hashlib -from optparse import OptionParser +import argparse import os import random import re @@ -35,7 +35,7 @@ import csv from pySim.commands import SimCardCommands -from pySim.transport import init_reader +from pySim.transport import init_reader, argparse_add_reader_args from pySim.legacy.cards import _cards_classes, card_detect from pySim.utils import h2b, swap_nibbles, rpad, derive_milenage_opc, calculate_luhn, dec_iccid from pySim.ts_51_011 import EF_AD @@ -46,169 +46,146 @@ def parse_options(): - parser = OptionParser(usage="usage: %prog [options]") + parser = argparse.ArgumentParser() + argparse_add_reader_args(parser) - parser.add_option("-d", "--device", dest="device", metavar="DEV", - help="Serial Device for SIM access [default: %default]", - default="/dev/ttyUSB0", - ) - parser.add_option("-b", "--baud", dest="baudrate", type="int", metavar="BAUD", - help="Baudrate used for SIM access [default: %default]", - default=9600, - ) - parser.add_option("-p", "--pcsc-device", dest="pcsc_dev", type='int', metavar="PCSC", - help="Which PC/SC reader number for SIM access", - default=None, - ) - parser.add_option("--modem-device", dest="modem_dev", metavar="DEV", - help="Serial port of modem for Generic SIM Access (3GPP TS 27.007)", - default=None, - ) - parser.add_option("--modem-baud", dest="modem_baud", type="int", metavar="BAUD", - help="Baudrate used for modem's port [default: %default]", - default=115200, - ) - parser.add_option("--osmocon", dest="osmocon_sock", metavar="PATH", - help="Socket path for Calypso (e.g. Motorola C1XX) based reader (via OsmocomBB)", - default=None, - ) - parser.add_option("-t", "--type", dest="type", - help="Card type (user -t list to view) [default: %default]", + parser.add_argument("-t", "--type", dest="type", + help="Card type (user -t list to view) [default: %(default)s]", default="auto", ) - parser.add_option("-T", "--probe", dest="probe", + parser.add_argument("-T", "--probe", dest="probe", help="Determine card type", default=False, action="store_true" ) - parser.add_option("-a", "--pin-adm", dest="pin_adm", + parser.add_argument("-a", "--pin-adm", dest="pin_adm", help="ADM PIN used for provisioning (overwrites default)", ) - parser.add_option("-A", "--pin-adm-hex", dest="pin_adm_hex", + parser.add_argument("-A", "--pin-adm-hex", dest="pin_adm_hex", help="ADM PIN used for provisioning, as hex string (16 characters long", ) - parser.add_option("-e", "--erase", dest="erase", action='store_true', - help="Erase beforehand [default: %default]", + parser.add_argument("-e", "--erase", dest="erase", action='store_true', + help="Erase beforehand [default: %(default)s]", default=False, ) - parser.add_option("-S", "--source", dest="source", - help="Data Source[default: %default]", + parser.add_argument("-S", "--source", dest="source", + help="Data Source[default: %(default)s]", default="cmdline", ) # if mode is "cmdline" - parser.add_option("-n", "--name", dest="name", - help="Operator name [default: %default]", + parser.add_argument("-n", "--name", dest="name", + help="Operator name [default: %(default)s]", default="Magic", ) - parser.add_option("-c", "--country", dest="country", type="int", metavar="CC", - help="Country code [default: %default]", + parser.add_argument("-c", "--country", dest="country", type=int, metavar="CC", + help="Country code [default: %(default)s]", default=1, ) - parser.add_option("-x", "--mcc", dest="mcc", type="string", - help="Mobile Country Code [default: %default]", + parser.add_argument("-x", "--mcc", dest="mcc", + help="Mobile Country Code [default: %(default)s]", default="901", ) - parser.add_option("-y", "--mnc", dest="mnc", type="string", - help="Mobile Network Code [default: %default]", + parser.add_argument("-y", "--mnc", dest="mnc", + help="Mobile Network Code [default: %(default)s]", default="55", ) - parser.add_option("--mnclen", dest="mnclen", type="choice", - help="Length of Mobile Network Code [default: %default]", + parser.add_argument("--mnclen", dest="mnclen", + help="Length of Mobile Network Code [default: %(default)s]", default="auto", choices=["2", "3", "auto"], ) - parser.add_option("-m", "--smsc", dest="smsc", + parser.add_argument("-m", "--smsc", dest="smsc", help="SMSC number (Start with + for international no.) [default: '00 + country code + 5555']", ) - parser.add_option("-M", "--smsp", dest="smsp", + parser.add_argument("-M", "--smsp", dest="smsp", help="Raw SMSP content in hex [default: auto from SMSC]", ) - parser.add_option("-s", "--iccid", dest="iccid", metavar="ID", + parser.add_argument("-s", "--iccid", dest="iccid", metavar="ID", help="Integrated Circuit Card ID", ) - parser.add_option("-i", "--imsi", dest="imsi", + parser.add_argument("-i", "--imsi", dest="imsi", help="International Mobile Subscriber Identity", ) - parser.add_option("--msisdn", dest="msisdn", + parser.add_argument("--msisdn", dest="msisdn", help="Mobile Subscriber Integrated Services Digital Number", ) - parser.add_option("-k", "--ki", dest="ki", + parser.add_argument("-k", "--ki", dest="ki", help="Ki (default is to randomize)", ) - parser.add_option("-o", "--opc", dest="opc", + parser.add_argument("-o", "--opc", dest="opc", help="OPC (default is to randomize)", ) - parser.add_option("--op", dest="op", + parser.add_argument("--op", dest="op", help="Set OP to derive OPC from OP and KI", ) - parser.add_option("--acc", dest="acc", + parser.add_argument("--acc", dest="acc", help="Set ACC bits (Access Control Code). not all card types are supported", ) - parser.add_option("--opmode", dest="opmode", type="choice", + parser.add_argument("--opmode", dest="opmode", help="Set UE Operation Mode in EF.AD (Administrative Data)", default=None, choices=['{:02X}'.format(int(m)) for m in EF_AD.OP_MODE], ) - parser.add_option("-f", "--fplmn", dest="fplmn", action="append", + parser.add_argument("-f", "--fplmn", dest="fplmn", action="append", help="Set Forbidden PLMN. Add multiple time for multiple FPLMNS", ) - parser.add_option("--epdgid", dest="epdgid", + parser.add_argument("--epdgid", dest="epdgid", help="Set Home Evolved Packet Data Gateway (ePDG) Identifier. (Only FQDN format supported)", ) - parser.add_option("--epdgSelection", dest="epdgSelection", + parser.add_argument("--epdgSelection", dest="epdgSelection", help="Set PLMN for ePDG Selection Information. (Only Operator Identifier FQDN format supported)", ) - parser.add_option("--pcscf", dest="pcscf", + parser.add_argument("--pcscf", dest="pcscf", help="Set Proxy Call Session Control Function (P-CSCF) Address. (Only FQDN format supported)", ) - parser.add_option("--ims-hdomain", dest="ims_hdomain", + parser.add_argument("--ims-hdomain", dest="ims_hdomain", help="Set IMS Home Network Domain Name in FQDN format", ) - parser.add_option("--impi", dest="impi", + parser.add_argument("--impi", dest="impi", help="Set IMS private user identity", ) - parser.add_option("--impu", dest="impu", + parser.add_argument("--impu", dest="impu", help="Set IMS public user identity", ) - parser.add_option("--read-imsi", dest="read_imsi", action="store_true", + parser.add_argument("--read-imsi", dest="read_imsi", action="store_true", help="Read the IMSI from the CARD", default=False ) - parser.add_option("--read-iccid", dest="read_iccid", action="store_true", + parser.add_argument("--read-iccid", dest="read_iccid", action="store_true", help="Read the ICCID from the CARD", default=False ) - parser.add_option("-z", "--secret", dest="secret", metavar="STR", + parser.add_argument("-z", "--secret", dest="secret", metavar="STR", help="Secret used for ICCID/IMSI autogen", ) - parser.add_option("-j", "--num", dest="num", type=int, + parser.add_argument("-j", "--num", dest="num", type=int, help="Card # used for ICCID/IMSI autogen", ) - parser.add_option("--batch", dest="batch_mode", - help="Enable batch mode [default: %default]", + parser.add_argument("--batch", dest="batch_mode", + help="Enable batch mode [default: %(default)s]", default=False, action='store_true', ) - parser.add_option("--batch-state", dest="batch_state", metavar="FILE", + parser.add_argument("--batch-state", dest="batch_state", metavar="FILE", help="Optional batch state file", ) # if mode is "csv" - parser.add_option("--read-csv", dest="read_csv", metavar="FILE", + parser.add_argument("--read-csv", dest="read_csv", metavar="FILE", help="Read parameters from CSV file rather than command line") - parser.add_option("--write-csv", dest="write_csv", metavar="FILE", + parser.add_argument("--write-csv", dest="write_csv", metavar="FILE", help="Append generated parameters in CSV file", ) - parser.add_option("--write-hlr", dest="write_hlr", metavar="FILE", + parser.add_argument("--write-hlr", dest="write_hlr", metavar="FILE", help="Append generated parameters to OpenBSC HLR sqlite3", ) - parser.add_option("--dry-run", dest="dry_run", + parser.add_argument("--dry-run", dest="dry_run", help="Perform a 'dry run', don't actually program the card", default=False, action="store_true") - parser.add_option("--card_handler", dest="card_handler_config", metavar="FILE", + parser.add_argument("--card_handler", dest="card_handler_config", metavar="FILE", help="Use automatic card handling machine") - (options, args) = parser.parse_args() + options = parser.parse_args() if options.type == 'list': for kls in _cards_classes: @@ -242,9 +219,6 @@ parser.error( "Can't give ICCID/IMSI for batch mode, need to use automatic parameters ! see --num and --secret for more information") - if args: - parser.error("Extraneous arguments") - return options -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7407496643247c754d002656688e9fdcbcf644a8 Gerrit-Change-Number: 36274 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: pcsc: open reader/card in EXCLUSIVE mode by default
by laforge 15 Mar '24

15 Mar '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36273?usp=email ) Change subject: pcsc: open reader/card in EXCLUSIVE mode by default ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I90d887714b559a4604708d3c6dd23b5e05f40576 Gerrit-Change-Number: 36273 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:33:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: pySim-prog: convert from optparse to argparse
by laforge 15 Mar '24

15 Mar '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36274?usp=email ) Change subject: pySim-prog: convert from optparse to argparse ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7407496643247c754d002656688e9fdcbcf644a8 Gerrit-Change-Number: 36274 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo_io: Dont use __linux__ but !EMBEDDED
by laforge 15 Mar '24

15 Mar '24

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email ) Change subject: osmo_io: Dont use __linux__ but !EMBEDDED ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Should we do the same for `src/core/osmo_io_poll. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I260443ba3cd0bb81dade434208dea4ea70fe8ad8 Gerrit-Change-Number: 36287 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:32:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: osmo_io: Massive improvement of API documentation
by laforge 15 Mar '24

15 Mar '24

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email ) Change subject: osmo_io: Massive improvement of API documentation ...................................................................... Patch Set 4: (2 comments) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/b4e4048a_be564241 PS3, Line 51: relate > related Done https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/2f36cbca_2a51bc80 PS3, Line 156: msgb > `msg` Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c Gerrit-Change-Number: 36288 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:32:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: osmo_io: Massive improvement of API documentation
by laforge 15 Mar '24

15 Mar '24

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email ) Change subject: osmo_io: Massive improvement of API documentation ...................................................................... Patch Set 3: (4 comments) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/83314b08_cb49e818 PS3, Line 100: msgb > `msg`, not `msgb` Done https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/d601fc8f_a0dbbb91 PS3, Line 132: msgb > `msg` Done https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/c0d489a6_f7cddb93 PS3, Line 158: msgh > no such param? recvmsg_cb has a 'msgh' parameter! https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/aef250d9_b707db65 PS3, Line 168: msgh > no such param? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c Gerrit-Change-Number: 36288 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:32:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: osmo_io: Massive improvement of API documentation
by laforge 15 Mar '24

15 Mar '24

Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, jolly, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: osmo_io: Massive improvement of API documentation ...................................................................... osmo_io: Massive improvement of API documentation * introduce a new "Osmocom I/O interface" group to show up in API docs * expand the documentation to turn it into something useful for somebody wanting to write an application using it. Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c --- M include/osmocom/core/osmo_io.h M src/core/osmo_io.c 2 files changed, 235 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/36288/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c Gerrit-Change-Number: 36288 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: osmo_io: Dont use __linux__ but !EMBEDDED
by laforge 15 Mar '24

15 Mar '24

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: osmo_io: Dont use __linux__ but !EMBEDDED ...................................................................... osmo_io: Dont use __linux__ but !EMBEDDED osmo_io (unlike its io_uring backend) is not linux specific, so putting it in an "#ifdef __linux__" block is plain wrong. A side-effect is that all our doxygen comments are not processed as __linux__ is not set while doxygen parses the source file. Change-Id: I260443ba3cd0bb81dade434208dea4ea70fe8ad8 --- M src/core/osmo_io.c M src/core/osmo_io_poll.c 2 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/36287/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I260443ba3cd0bb81dade434208dea4ea70fe8ad8 Gerrit-Change-Number: 36287 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-upf[master]: manual: explain GTP Echo workaround for tunmap
by laforge 15 Mar '24

15 Mar '24

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35667?usp=email ) Change subject: manual: explain GTP Echo workaround for tunmap ...................................................................... Patch Set 1: -Code-Review (4 comments) Patchset: PS1: > I would remove the entire "tunend can be removed for forwarding-only" section. It's misleading. […] I'm not sure what exactly I was reading / referring to at the time. Let's ignore this comment, please. File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/2d7ddd38_fd25f593 PS1, Line 172: netfilter it s a nftables or nft table. "netfilter" is a set of kernel hooks in the network stack that have no tables. various packet filtering techniques (iptables, arptables, ip6tables and last nftables) are packet filter ruleset engines that have tables. https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/053a0cf7_e239e8ff PS1, Line 177: GTP peer is that "GTP peer" a term in the specification? The term I have in memory is "GSN", but that's probably too old-fashioned as it is from the 2G/3G days where we had SGSN/GGSN. I'm worried about "peer" here being interprete as "the remote peer". But we're actually talking about our local UPF node, not a remote peer. https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/44e0c63a_8208db06 PS1, Line 212: netfilter nft / nftables table -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic824fc876d1fad181254cb6894e51464c443b53c Gerrit-Change-Number: 35667 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:25:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log