- gerrit-log - lists.osmocom.org

[S] Change in libosmo-sccp[master]: cosmetic: add spec reference
by laforge 20 Mar '24

20 Mar '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email ) Change subject: cosmetic: add spec reference ...................................................................... Patch Set 2: (1 comment) File src/sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29158/comment/32d0d707_983098d0 PS1, Line 184: /* ITU-T Rec Q.713 */ > Background: SUA is a (much younger, IETF-provided) alternative protocol for (SCCP+MTP). […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 Gerrit-Change-Number: 29158 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:11:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: docs: shell: link to cmd2 documentation
by laforge 20 Mar '24

20 Mar '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34937?usp=email ) Change subject: docs: shell: link to cmd2 documentation ...................................................................... Patch Set 2: (1 comment) File docs/shell.rst: https://gerrit.osmocom.org/c/pysim/+/34937/comment/13cfb7bc_e069cfe4 PS1, Line 53: As pySim-shell is built upon ``cmd``, some generic cmd2 commands/features are available. You may > upon cmd2? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I532cb33781f95fe847db7fae7a5264b5d9c416de Gerrit-Change-Number: 34937 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:11:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: gsmtap-rlp: Add support for skipping generating NULL frames
by laforge 20 Mar '24

20 Mar '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35133?usp=email ) Change subject: gsmtap-rlp: Add support for skipping generating NULL frames ...................................................................... Patch Set 7: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/35133/comment/9b342e3b_57702e1a PS5, Line 13: I85a2159cfaa01bfb4205c1462e3a9dbda68e4bad > `Depends: libosmocore. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I85a2159cfaa01bfb4205c1462e3a9dbda68e4bad Gerrit-Change-Number: 35133 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:11:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: input/ipaccess: fix regression in ipaccess_bts_handle_ccm()
by laforge 20 Mar '24

20 Mar '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36100?usp=email ) Change subject: input/ipaccess: fix regression in ipaccess_bts_handle_ccm() ...................................................................... Patch Set 1: (1 comment) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/36100/comment/8df5b4a3_a7281a2a PS1, Line 897: LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", > maybe printing information about the link instead would be welcome. I agree, we should provide context. but let's fix the regression first. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic26181b580724a70c2af8a224155430902fe4101 Gerrit-Change-Number: 36100 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:11:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo_io: Add osmo_io_get_ioops() function
by laforge 20 Mar '24

20 Mar '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email ) Change subject: osmo_io: Add osmo_io_get_ioops() function ...................................................................... Patch Set 2: (1 comment) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/36076/comment/2c35a904_8bbce55a PS1, Line 112: void osmo_iofd_get_ioops(struct osmo_io_fd *iofd, struct osmo_io_ops *ioops); > Yeah well you can even do address calculation to change stuff even if you don't get the pointer, but […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03398c811b9534f50c6644b21eea89a04be29fb0 Gerrit-Change-Number: 36076 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:11:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jenkins: Add io_uring job for osmo-mgw
by laforge 20 Mar '24

20 Mar '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36365?usp=email ) Change subject: jenkins: Add io_uring job for osmo-mgw ...................................................................... jenkins: Add io_uring job for osmo-mgw A change introducing osmo_io for RTP/RTCP of omo-mgw is currently in review at https://gerrit.osmocom.org/c/osmo-mgw/+/36363 Let's make sure we have a related io_uring test job. Change-Id: I672c72c855bebc1f895be51f3fa3cf0e368005ff Related: OS#6387, SYS#5094 --- M jobs/ttcn3-testsuites.yml 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/36365/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 71bcb81..8b5ad09 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -223,6 +223,9 @@ - ttcn3-stp-test-io_uring: timer: H 11 * * * node: ttcn3-io_uring + - ttcn3-mgw-test-io_uring: + timer: H 11 * * * + node: ttcn3-io_uring - job-template: name: '{job-name}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I672c72c855bebc1f895be51f3fa3cf0e368005ff Gerrit-Change-Number: 36365 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-remsim[master]: debian/rules: don't compress pdfs
by osmith 20 Mar '24

20 Mar '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36359?usp=email ) Change subject: debian/rules: don't compress pdfs ...................................................................... debian/rules: don't compress pdfs Adjust debian packaging as in other Osmocom projects to not compress the pdf files. Related: SYS#6855 Change-Id: I4372c2d93b317a9deaed3650941c7438accf9211 --- M debian/rules 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/debian/rules b/debian/rules index fddb043..779d944 100755 --- a/debian/rules +++ b/debian/rules @@ -25,3 +25,7 @@ # Print test results in case of a failure #override_dh_auto_test: # dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false) + +# Don't create .pdf.gz files (barely saves space and they can't be opened directly by most pdf readers) +override_dh_compress: + dh_compress -X.pdf -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4372c2d93b317a9deaed3650941c7438accf9211 Gerrit-Change-Number: 36359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmo-abis[master]: Fix critical bug in default TCP keepalive user timeout
by laforge 20 Mar '24

20 Mar '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36079?usp=email ) Change subject: Fix critical bug in default TCP keepalive user timeout ...................................................................... Patch Set 4: (1 comment) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/36079/comment/e0eb58fe_e94e9e72 PS3, Line 613: uesr_timeout > user_timeout Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idca24d3e676a45d860d9eec60dc2097d8d87f3bf Gerrit-Change-Number: 36079 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:07:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: debian/rules: don't compress pdfs
by fixeria 20 Mar '24

20 Mar '24

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36359?usp=email ) Change subject: debian/rules: don't compress pdfs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4372c2d93b317a9deaed3650941c7438accf9211 Gerrit-Change-Number: 36359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 07:44:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: Change msgb ownership in processing of received msgb
by fixeria 20 Mar '24

20 Mar '24

Attention is currently required from: dexter, laforge, neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email ) Change subject: Change msgb ownership in processing of received msgb ...................................................................... Patch Set 2: (4 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/054b7bba_98b3a44e PS2, Line 1191: return rc missing `msgb_free()`? https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/2e47f083_0389a5bc PS2, Line 1205: return rc missing `msgb_free()`? https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/949625fb_1bc94e6f PS2, Line 1212: return rc missing `msgb_free()`? File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/e31c09c9_cb3f3273 PS2, Line 217: return -1; missing `msgb_free()` here and below? AFAIU, if a function claims to take ownership, then it's also responsible for `free()`ing it in all error paths? If not, this should be clarified in the docs above. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6a331f3c6b2eb51ea312ac6ef8c357185ddb79cf Gerrit-Change-Number: 36361 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 07:36:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log