- gerrit-log - lists.osmocom.org

[M] Change in osmo-mgw[master]: Change msgb ownership in processing of received msgb
by laforge 20 Mar '24

20 Mar '24

Attention is currently required from: dexter, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email ) Change subject: Change msgb ownership in processing of received msgb ...................................................................... Patch Set 3: (3 comments) File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/a5bb56bf_d1a998f9 PS3, Line 42: libosmocore bump_dep; workaround Bump libosmocore version dependency after I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 > I'd usually simply write: […] I might simply remove the line and keep the local copy function, if we don't want to change msgb_copy semantics itself. File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/d60898b6_08eb543a PS3, Line 75: static inline struct msgb *mgw_msgb_copy_c(void *ctx, struct msgb *msg, const char *name) > AS I mentioned in that patch, it may be worth having this API as a separate function in libosmocore. yes; even in that case, I'd introduce a local version here until those changes in libosmocore materialize. https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/1b66b8b5_88cb1ca2 PS3, Line 1375: if (conn_dst == conn) > I think if you do this, then you can drop the entire block of code spanning lines 1360-1365: […] I think it would have to be the other way around: ``` switch (conn_dst->mode) { case MGCP_CONN_SEND_ONLY: case MGCP_CONN_RECV_SEND: if (conn_dst == conn) continue; /* fall-through */ case MGCP_CONN_CONFECHO: /* we have multiple recipients and must make copies for each recipient */ msg2 = mgw_msgb_copy_c(conn_dst, msg, "RTP Tx copy"); if (OSMO_LIKELY(msg2)) rc = mgcp_conn_rtp_dispatch_rtp(&conn_dst->u.rtp, msg2); ``` In any case, that's a separate optimization and not related to changing msgb ownership. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6a331f3c6b2eb51ea312ac6ef8c357185ddb79cf Gerrit-Change-Number: 36361 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 13:04:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: simplify unused transcoding/processing call-back
by laforge 20 Mar '24

20 Mar '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36357?usp=email ) Change subject: simplify unused transcoding/processing call-back ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I002624f9008726e3d754d48aa2282c38e3b42953 Gerrit-Change-Number: 36357 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:56:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: remove strange loop for non-existant transcoding support
by laforge 20 Mar '24

20 Mar '24

Attention is currently required from: dexter, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36356?usp=email ) Change subject: remove strange loop for non-existant transcoding support ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36356/comment/386b9c79_d1c57b9e PS1, Line 1178: rc = endp->trunk->cfg->rtp_processing_cb(endp, rtp_end, (char *)msgb_data(msg), &buflen, RTP_BUF_SIZE); > You may was well drop the entire think which afaict is only used with cb mgcp_rtp_processing_default […] yes, I thought about that, too. But I dedided to keep it without the loop for now. Given there are more patches on top of this, I'd avoid not having to rewrite and sort out all the clashes of the patches on top. The goal here is to get osmo_io/io_uring working, not a more fundmental cleanup of osmo-mgw. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie1a629fd31c5ab806fc929d1e6b279c4be5b8246 Gerrit-Change-Number: 36356 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:55:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: don't log useless "transcoding disabled" message
by laforge 20 Mar '24

20 Mar '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36358?usp=email ) Change subject: don't log useless "transcoding disabled" message ...................................................................... don't log useless "transcoding disabled" message The entire mgw has no transcoding support. So printing that message is useless to begin with. And printing it for *every RTP packet* is even more useless. Let's remove it. Change-Id: If0ee2607404afc3a00665a5cf22a9e0eb62eb476 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 111c5cf..ae0a52d 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -412,7 +412,6 @@ struct mgcp_rtp_end *dst_end, char *data, int *len, int buf_size) { - LOGPENDP(endp, DRTP, LOGL_DEBUG, "transcoding disabled\n"); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If0ee2607404afc3a00665a5cf22a9e0eb62eb476 Gerrit-Change-Number: 36358 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-mgw[master]: Change msgb ownership in processing of received msgb
by pespin 20 Mar '24

20 Mar '24

Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email ) Change subject: Change msgb ownership in processing of received msgb ...................................................................... Patch Set 3: (3 comments) File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/abc03d28_1318f848 PS3, Line 42: libosmocore bump_dep; workaround Bump libosmocore version dependency after I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 I'd usually simply write: libosmocore > 1.9.0 Use my_msgb_copy_c() So that helps quickly understand it needs some API which was added after last current release. File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/b905a34f_d9032707 PS3, Line 75: static inline struct msgb *mgw_msgb_copy_c(void *ctx, struct msgb *msg, const char *name) AS I mentioned in that patch, it may be worth having this API as a separate function in libosmocore. https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/2f99e801_d7417b49 PS3, Line 1375: if (conn_dst == conn) I think if you do this, then you can drop the entire block of code spanning lines 1360-1365: switch (conn_dst->mode) { case MGCP_CONN_CONFECHO: if (conn_dst == conn) continue; case MGCP_CONN_SEND_ONLY: case MGCP_CONN_RECV_SEND: ... -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6a331f3c6b2eb51ea312ac6ef8c357185ddb79cf Gerrit-Change-Number: 36361 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: Change msgb ownership in processing of received msgb
by jolly 20 Mar '24

20 Mar '24

Attention is currently required from: dexter, laforge, neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email ) Change subject: Change msgb ownership in processing of received msgb ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6a331f3c6b2eb51ea312ac6ef8c357185ddb79cf Gerrit-Change-Number: 36361 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:51:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/master-builds: libosmocore: io_uring nodes
by osmith 20 Mar '24

20 Mar '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36370?usp=email ) Change subject: jobs/master-builds: libosmocore: io_uring nodes ...................................................................... jobs/master-builds: libosmocore: io_uring nodes Like the gerrit-verification jobs for libosmocore, run the master-builds jobs on nodes with the io_uring label. Related: OS#6405 Change-Id: Iea6791b3fbb5c445a539c2b4636a643d6c8d517b --- M jobs/master-builds.yml 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/70/36370/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 8b8d551..66043e5 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -166,6 +166,7 @@ master-osmo-sgsn - libosmocore: + slave_axis: !!python/tuple [io_uring] # OS#6405 a1_name: arch a1: !!python/tuple [arm-none-eabi, amd64] combination_filter: '!(arch=="arm-none-eabi" && label=="FreeBSD_amd64")' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36370?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iea6791b3fbb5c445a539c2b4636a643d6c8d517b Gerrit-Change-Number: 36370 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-mgw[master]: Change msgb ownership in processing of received msgb
by pespin 20 Mar '24

20 Mar '24

Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email ) Change subject: Change msgb ownership in processing of received msgb ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: This also may be useful in reusing the same msgb? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6a331f3c6b2eb51ea312ac6ef8c357185ddb79cf Gerrit-Change-Number: 36361 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:39:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: remove osmo_fd from mgcp_create_bind()
by pespin 20 Mar '24

20 Mar '24

Attention is currently required from: dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36360?usp=email ) Change subject: remove osmo_fd from mgcp_create_bind() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4a3b66a14fdfbc867daca0f0a05f694d5e0d7b66 Gerrit-Change-Number: 36360 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:38:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: don't log useless "transcoding disabled" message
by pespin 20 Mar '24

20 Mar '24

Attention is currently required from: dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36358?usp=email ) Change subject: don't log useless "transcoding disabled" message ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If0ee2607404afc3a00665a5cf22a9e0eb62eb476 Gerrit-Change-Number: 36358 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:38:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log