- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: sip: Get Rid of private copy of f_mgcp_addr2addrtype()
by pespin 22 Mar '24

22 Mar '24

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36382?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: sip: Get Rid of private copy of f_mgcp_addr2addrtype() ...................................................................... sip: Get Rid of private copy of f_mgcp_addr2addrtype() The function was copied from MGCP_Templates.ttcn since the logic is the same for SDP, but copied in order to avoid depending on whole MGCP file. Since now SDP logic has been moved to its own SDP_Templates and a new f_sdp_addr2addrtype() was added, use that one. Change-Id: I27ce46b6d23ba0f2704dd0cee290ed519dec278e --- M sip/SIP_Tests.ttcn M sip/gen_links.sh 2 files changed, 23 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/36382/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27ce46b6d23ba0f2704dd0cee290ed519dec278e Gerrit-Change-Number: 36382 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-trx[master]: ms: disabe uhd ms build
by Hoernchen 22 Mar '24

22 Mar '24

Attention is currently required from: laforge. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36377?usp=email ) Change subject: ms: disabe uhd ms build ...................................................................... Patch Set 1: (1 comment) File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/36377/comment/ddb3addf_e18c010c PS1, Line 130: #if ENABLE_MS_TRX > might be worth adding a reason in a comment here, not just in the commit log. […] I am not a fan of duplicating VCS information, modern IDEs will show the commit messages anyway, and multiple levels of blame are just one click away... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9db1740b5c399a02a41b1d07792c645cf7d1bd1b Gerrit-Change-Number: 36377 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 22 Mar 2024 10:26:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: transceiver: use log level cache
by Hoernchen 22 Mar '24

22 Mar '24

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email ) Change subject: transceiver: use log level cache ...................................................................... transceiver: use log level cache Depends: libosmocore.git I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 --- M Transceiver52M/osmo-trx.cpp 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/86/36386/1 diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 8f5cc85..c460e98 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -645,6 +645,7 @@ osmo_init_logging2(tall_trx_ctx, &log_info); log_enable_multithread(); + log_cache_enable(); osmo_stats_init(tall_trx_ctx); vty_init(&g_vty_info); logging_vty_add_cmds(); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: gerrit-verifications: execute 'distcheck' job for pysim
by osmith 22 Mar '24

22 Mar '24

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36384?usp=email ) Change subject: gerrit-verifications: execute 'distcheck' job for pysim ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9d4d9e9de2b16a4b745791f3c9c93507f43bfa6d Gerrit-Change-Number: 36384 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: char <osmocom(a)hypodyne.net> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Mar 2024 10:10:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: add 'distcheck' job to check package integrity
by osmith 22 Mar '24

22 Mar '24

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36383?usp=email ) Change subject: contrib/jenkins.sh: add 'distcheck' job to check package integrity ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/pysim/+/36383/comment/9507cfd1_3603b162 PS2, Line 35: "distcheck") > Well, it's a distribution integrity check. Yes, it's not exactly identical to what automake is doing when running make check, but still I see nothing wrong calling it this way. Can rename to smoketest if you guys like. I'm fine with both, just was slightly confused initially that it is called distcheck. > No, I am not planning to extend it. I just thought it would be cleaner to have a separate job for this additional check, so that one could quickly see what exactly is causing the build verification failure. The existing test is already doing few things: running unit tests, SIM programming tests, and pySim-trace tests. Likewise, if you think it's better to run the smoketest there, I can amend the patch. That is a good argument for having it in a separate job. https://gerrit.osmocom.org/c/pysim/+/36383/comment/ea9ee76e_392a3b04 PS2, Line 43: $prog --help > /dev/null > Not sure if printing help would this be useful, we're mostly interested to catch errors here. […] Ack. This isn't important enough to block the patch, we can also remove it later on if we would find it more useful. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic72d58494e8fd0cab8d66ce60f7b70593b770872 Gerrit-Change-Number: 36383 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: char <osmocom(a)hypodyne.net> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Mar 2024 10:09:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: add 'distcheck' job to check package integrity
by fixeria 22 Mar '24

22 Mar '24

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36383?usp=email ) Change subject: contrib/jenkins.sh: add 'distcheck' job to check package integrity ...................................................................... Patch Set 2: (2 comments) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/pysim/+/36383/comment/01851ff7_7dfd4a6d PS2, Line 35: "distcheck") > I'm not sure if we should call it "distcheck". It sounds like "make distcheck" from autotools, but it does something else here. Maybe smoketest? Well, it's a distribution integrity check. Yes, it's not exactly identical to what automake is doing when running `make check`, but still I see nothing wrong calling it this way. Can rename to `smoketest` if you guys like. > If you just want to print --help, maybe just add it at the end of the regular test job (since it will almost take no extra time, and then you can avoid having the test setup time)? Or is the idea to extend it later on and do more? No, I am not planning to extend it. I just thought it would be cleaner to have a separate job for this additional check, so that one could quickly see what exactly is causing the build verification failure. The existing `test` is already doing few things: running unit tests, SIM programming tests, and pySim-trace tests. Likewise, if you think it's better to run the smoketest there, I can amend the patch. https://gerrit.osmocom.org/c/pysim/+/36383/comment/4fdb1618_967be187 PS2, Line 43: $prog --help > /dev/null > why >/dev/null, wouldn't it be useful to have the output in jenkins, so one can take a look at it? Not sure if printing help would this be useful, we're mostly interested to catch errors here. If others find it useful, I can remove the `/dev/null` redirection then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic72d58494e8fd0cab8d66ce60f7b70593b770872 Gerrit-Change-Number: 36383 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: char <osmocom(a)hypodyne.net> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Mar 2024 10:03:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: gerrit-verifications: execute 'distcheck' job for pysim
by fixeria 22 Mar '24

22 Mar '24

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36384?usp=email ) Change subject: gerrit-verifications: execute 'distcheck' job for pysim ...................................................................... Patch Set 2: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/36384/comment/10aa747a_2bfb2840 PS1, Line 405: simtester > agreed, I suggest using osmocom-gerrit instead Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9d4d9e9de2b16a4b745791f3c9c93507f43bfa6d Gerrit-Change-Number: 36384 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: char <osmocom(a)hypodyne.net> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 22 Mar 2024 09:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: gerrit-verifications: execute 'distcheck' job for pysim
by fixeria 22 Mar '24

22 Mar '24

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/36384?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gerrit-verifications: execute 'distcheck' job for pysim ...................................................................... gerrit-verifications: execute 'distcheck' job for pysim Change-Id: I9d4d9e9de2b16a4b745791f3c9c93507f43bfa6d Related: pysim.git Ic72d58494e8fd0cab8d66ce60f7b70593b770872 --- M jobs/gerrit-verifications.yml 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/84/36384/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9d4d9e9de2b16a4b745791f3c9c93507f43bfa6d Gerrit-Change-Number: 36384 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: char <osmocom(a)hypodyne.net> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: add 'distcheck' job to check package integrity
by osmith 22 Mar '24

22 Mar '24

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36383?usp=email ) Change subject: contrib/jenkins.sh: add 'distcheck' job to check package integrity ...................................................................... Patch Set 2: (2 comments) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/pysim/+/36383/comment/0a11ba60_9c520a53 PS2, Line 35: "distcheck") I'm not sure if we should call it "distcheck". It sounds like "make distcheck" from autotools, but it does something else here. Maybe smoketest? If you just want to print --help, maybe just add it at the end of the regular test job (since it will almost take no extra time, and then you can avoid having the test setup time)? Or is the idea to extend it later on and do more? https://gerrit.osmocom.org/c/pysim/+/36383/comment/1dc55eb1_c2b6502d PS2, Line 43: $prog --help > /dev/null why >/dev/null, wouldn't it be useful to have the output in jenkins, so one can take a look at it? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic72d58494e8fd0cab8d66ce60f7b70593b770872 Gerrit-Change-Number: 36383 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: char <osmocom(a)hypodyne.net> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Mar 2024 09:44:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: gerrit-verifications: execute 'distcheck' job for pysim
by osmith 22 Mar '24

22 Mar '24

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36384?usp=email ) Change subject: gerrit-verifications: execute 'distcheck' job for pysim ...................................................................... Patch Set 1: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/36384/comment/0140d36c_ec95c469 PS1, Line 405: simtester > I don't like that, as I fear it makes the pre-commit tests take even longer. […] agreed, I suggest using osmocom-gerrit instead -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9d4d9e9de2b16a4b745791f3c9c93507f43bfa6d Gerrit-Change-Number: 36384 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: char <osmocom(a)hypodyne.net> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Mar 2024 09:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log