- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/ttcn3: …-pablo-gtp: don't wipe workspace
by osmith 03 Apr '24

03 Apr '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36486?usp=email ) Change subject: jobs/ttcn3: …-pablo-gtp: don't wipe workspace ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/36486/comment/51e571b7_557204f4 PS1, Line 10: cloning the kernel repositories takes a long time and lots of traffic I've implemented shallow fetching here: https://gerrit.osmocom.org/c/docker-playground/+/36510 (Note that before it used to clone once per jenkins node and then work on that, but agreed, shallow fetching is even better and saves more traffic.) > Also: if we know there are [likely] other kernel trees around somewhere in [other] workspaces, we can specify those with --reference-if-able to get any objects locally, if available/present. this is a cool feature, maybe we can use this in the future. right now the cloning + building kernel and initramfs is done inside a docker container, it would need rewriting to be able to potentially access git trees from other workspaces. so I'm leaving it as-is for now. File jobs/ttcn3-testsuites.yml: https://gerrit.osmocom.org/c/osmo-ci/+/36486/comment/e902ee6c_19da609f PS1, Line 35: wipe_workspace: false > maybe document it with a comment here on why this is needed. Done (used same comment as with the other wipe_workspace: false lines for kernel tests below) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4ac1b2c3f5ba63c131dd1d6a4888f32a27264eba Gerrit-Change-Number: 36486 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Apr 2024 10:32:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: put mknod commands in init.sh
by osmith 03 Apr '24

03 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36513?usp=email ) Change subject: scripts/kernel-test: put mknod commands in init.sh ...................................................................... scripts/kernel-test: put mknod commands in init.sh Prepare to run the preparation without root rights. Change-Id: I07648f058ca55515ffc7396598147a03dcfe7976 --- M scripts/kernel-test/initrd-build.sh M scripts/kernel-test/initrd-init.sh 2 files changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/13/36513/1 diff --git a/scripts/kernel-test/initrd-build.sh b/scripts/kernel-test/initrd-build.sh index e97ff89..a754d2d 100755 --- a/scripts/kernel-test/initrd-build.sh +++ b/scripts/kernel-test/initrd-build.sh @@ -117,11 +117,6 @@ initrd_add_file \ /lib/modules/*/modules.dep -mknod dev/null c 1 3 - -# Required for osmo-ggsn -mknod dev/net/tun c 10 200 - cp /kernel-test/initrd-init.sh init # Add project specific files (e.g. osmo-ggsn and gtp kernel module) diff --git a/scripts/kernel-test/initrd-init.sh b/scripts/kernel-test/initrd-init.sh index c2d936a..bc3aa59 100755 --- a/scripts/kernel-test/initrd-init.sh +++ b/scripts/kernel-test/initrd-init.sh @@ -9,6 +9,11 @@ /bin/busybox --install -s +mknod /dev/null c 1 3 + +# Required for osmo-ggsn +mknod /dev/net/tun c 10 200 + hostname qemu mount -t proc proc /proc -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I07648f058ca55515ffc7396598147a03dcfe7976 Gerrit-Change-Number: 36513 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in docker-playground[master]: scripts/kernel-test: build initrd+kernel as user
by osmith 03 Apr '24

03 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36514?usp=email ) Change subject: scripts/kernel-test: build initrd+kernel as user ...................................................................... scripts/kernel-test: build initrd+kernel as user Refactor code to build the initramfs and kernel as user, instead of running related code as root. Change-Id: I1670dd86f2670f42eb99e4527d483965d8222402 --- M jenkins-common.sh M scripts/kernel-test/prepare.sh A scripts/kernel-test/smoke-test.sh 3 files changed, 43 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/14/36514/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index f22158b..eae0473 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -467,11 +467,12 @@ cp "$initrd_project_script" \ "$CACHE_DIR/kernel-test/initrd-project-script.sh" + fix_perms + + # Build kernel and initramfs docker run \ --rm \ - --cap-add=NET_ADMIN \ - $(docker_kvm_param) \ - --device /dev/net/tun:/dev/net/tun \ + --user "build" \ -v "$CACHE_DIR:/cache" \ -v "$KERNEL_TEST_DIR:/kernel-test:ro" \ -e "KERNEL_BRANCH=$KERNEL_BRANCH" \ @@ -480,11 +481,25 @@ -e "KERNEL_REMOTE_NAME=$KERNEL_REMOTE_NAME" \ -e "KERNEL_URL=$KERNEL_URL" \ -e "KERNEL_SKIP_REBUILD=$KERNEL_SKIP_REBUILD" \ - -e "KERNEL_SKIP_SMOKE_TEST=$KERNEL_SKIP_SMOKE_TEST" \ $DOCKER_ARGS \ "$@" \ "$docker_image" \ "/kernel-test/prepare.sh" + + # Smoke test + if [ "$KERNEL_SKIP_SMOKE_TEST" != 1 ]; then + docker run \ + --rm \ + --cap-add=NET_ADMIN \ + $(docker_kvm_param) \ + --device /dev/net/tun:/dev/net/tun \ + -v "$CACHE_DIR:/cache" \ + -v "$KERNEL_TEST_DIR:/kernel-test:ro" \ + $DOCKER_ARGS \ + "$@" \ + "$docker_image" \ + "/kernel-test/smoke-test.sh" + fi } # Wait until the linux kernel is booted inside QEMU inside docker, and the diff --git a/scripts/kernel-test/prepare.sh b/scripts/kernel-test/prepare.sh index 1f1d1d5..a93a93d 100755 --- a/scripts/kernel-test/prepare.sh +++ b/scripts/kernel-test/prepare.sh @@ -1,17 +1,6 @@ #!/bin/sh -ex KERNEL_BUILD="${KERNEL_BUILD:-0}" -# Test if the kernel boots up, and initd code runs through without error -kernel_smoke_test() { - local log=/cache/kernel-test/smoke_test.log - /kernel-test/run-qemu.sh SMOKE_TEST > "$log" 2>&1 || true - if ! grep -q SMOKE_TEST_SUCCESS "$log"; then - cat "$log" - echo "ERROR: failed to boot the kernel and initrd in QEMU!" - exit 1 - fi -} - /kernel-test/initrd-build.sh if [ "$KERNEL_BUILD" = 1 ]; then @@ -19,7 +8,3 @@ else cp /boot/vmlinuz-* /cache/kernel-test/linux fi - -if [ "$KERNEL_SKIP_SMOKE_TEST" != 1 ]; then - kernel_smoke_test -fi diff --git a/scripts/kernel-test/smoke-test.sh b/scripts/kernel-test/smoke-test.sh new file mode 100755 index 0000000..ff4b9c8 --- /dev/null +++ b/scripts/kernel-test/smoke-test.sh @@ -0,0 +1,12 @@ +#!/bin/sh -ex +# Test if the kernel boots up, and initd code runs through without error + +LOG=/cache/kernel-test/smoke_test.log + +/kernel-test/run-qemu.sh SMOKE_TEST > "$LOG" 2>&1 || true +if ! grep -q SMOKE_TEST_SUCCESS "$LOG"; then + cat "$LOG" + set +x + echo "ERROR: failed to boot the kernel and initrd in QEMU!" + exit 1 +fi -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1670dd86f2670f42eb99e4527d483965d8222402 Gerrit-Change-Number: 36514 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: do shallow fetch
by osmith 03 Apr '24

03 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36510?usp=email ) Change subject: scripts/kernel-test: do shallow fetch ...................................................................... scripts/kernel-test: do shallow fetch Instead of fetching the entire history, only fetch the most recent commit. Change-Id: I92d90c1451ff6abff2df3b1318b5194880e77f2e --- M scripts/kernel-test/kernel-build.sh 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/10/36510/1 diff --git a/scripts/kernel-test/kernel-build.sh b/scripts/kernel-test/kernel-build.sh index d2127e4..9bd8064 100755 --- a/scripts/kernel-test/kernel-build.sh +++ b/scripts/kernel-test/kernel-build.sh @@ -39,7 +39,7 @@ fi fi - git fetch "$KERNEL_REMOTE_NAME" + git fetch --depth=1 "$KERNEL_REMOTE_NAME" git checkout "$KERNEL_REMOTE_NAME/$KERNEL_BRANCH" } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I92d90c1451ff6abff2df3b1318b5194880e77f2e Gerrit-Change-Number: 36510 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: jenkins-common: fix_perms: chown files too
by osmith 03 Apr '24

03 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36512?usp=email ) Change subject: jenkins-common: fix_perms: chown files too ...................................................................... jenkins-common: fix_perms: chown files too Ensure the user that runs docker owns files in cache and data dirs during fix_perms, if an old job created them as root. Change-Id: I43af48bd87e27abad5ad52e734256d78651f67c3 --- M jenkins-common.sh 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/12/36512/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 59224a0..f22158b 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -386,7 +386,10 @@ -v $CACHE_DIR:/cache \ --name ${BUILD_TAG}-cleaner \ "debian:$DEBIAN_DEFAULT" \ - chmod -R a+rX /data/ /cache/ + sh -e -x -c " + chmod -R a+rX /data/ /cache/ + chown -R $(id -u):$(id -g) /data /cache + " } collect_logs() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I43af48bd87e27abad5ad52e734256d78651f67c3 Gerrit-Change-Number: 36512 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: kernel-test/kernel-build: update net-next branch
by osmith 03 Apr '24

03 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36511?usp=email ) Change subject: kernel-test/kernel-build: update net-next branch ...................................................................... kernel-test/kernel-build: update net-next branch The branch of net-next is now called main. Update the default KERNEL_BRANCH to main, as the default KERNEL_URL points to net-next.git. Related: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ Change-Id: Ic4b13c3cbc0933db9d520e6d737c45b6b08e8c48 fixup Change-Id: Id7544960c50c948231046882e4d76085e8180f10 --- M README.md M scripts/kernel-test/kernel-build.sh 2 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/11/36511/1 diff --git a/README.md b/README.md index 4c6c40a..6c2c989 100644 --- a/README.md +++ b/README.md @@ -105,7 +105,7 @@ * `KERNEL_REMOTE_NAME`: git remote name (to add multiple git repositories in the same local linux clone, default: net-next) * `KERNEL_URL`: git remote url (default: net-next.git on kernel.org) -* `KERNEL_BRANCH` branch to checkout (default: master) +* `KERNEL_BRANCH` branch to checkout (default: main) * `KERNEL_SKIP_REBUILD`: set to 1 to not build the kernel again if already built with `KERNEL_BUILD=1` * `KERNEL_SKIP_SMOKE_TEST`: don't boot up the kernel in QEMU once before diff --git a/scripts/kernel-test/kernel-build.sh b/scripts/kernel-test/kernel-build.sh index 9bd8064..bbf3e43 100755 --- a/scripts/kernel-test/kernel-build.sh +++ b/scripts/kernel-test/kernel-build.sh @@ -3,7 +3,7 @@ KERNEL_REMOTE_NAME="${KERNEL_REMOTE_NAME:-net-next}" KERNEL_URL="${KERNEL_URL:-https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git}" -KERNEL_BRANCH="${KERNEL_BRANCH:-master}" +KERNEL_BRANCH="${KERNEL_BRANCH:-main}" KERNEL_DIR=/cache/linux -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id7544960c50c948231046882e4d76085e8180f10 Gerrit-Change-Number: 36511 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: ttcn3-ggsn-test-kernel-latest-net-next: update net-next branch
by osmith 03 Apr '24

03 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36509?usp=email ) Change subject: ttcn3-ggsn-test-kernel-latest-net-next: update net-next branch ...................................................................... ttcn3-ggsn-test-kernel-latest-net-next: update net-next branch The branch of net-next is now called main. By using the old name, the jenkins job was checking out a 6.3 kernel, we are now at 6.9 rcs. Related: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ Change-Id: Ieee448c514bc0ff457b9d17c8b12ee00953995d2 --- M jobs/ttcn3-testsuites.yml 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/09/36509/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index a560364..aee439e 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -285,7 +285,7 @@ export KERNEL_BUILD=1 export KERNEL_URL="https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git" export KERNEL_REMOTE_NAME="net-next" - export KERNEL_BRANCH="master" + export KERNEL_BRANCH="main" ;; ttcn3-ggsn-test-kernel-latest-torvalds) DIR="ttcn3-ggsn-test" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36509?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieee448c514bc0ff457b9d17c8b12ee00953995d2 Gerrit-Change-Number: 36509 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: …-pablo-gtp: don't wipe workspace
by osmith 03 Apr '24

03 Apr '24

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/36486?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: jobs/ttcn3: …-pablo-gtp: don't wipe workspace ...................................................................... jobs/ttcn3: …-pablo-gtp: don't wipe workspace The ttcn3-ggsn-test-kernel-* jobs should not wipe their workspace, so we can avoid shallow-cloning the kernel if the commit did not change. The way the scripts in docker-playground.git are written, this also caused a permission error. Change-Id: I4ac1b2c3f5ba63c131dd1d6a4888f32a27264eba --- M jobs/ttcn3-testsuites.yml 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/86/36486/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4ac1b2c3f5ba63c131dd1d6a4888f32a27264eba Gerrit-Change-Number: 36486 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: fix race condition in TC_mm_id_resp_no_identity
by laforge 03 Apr '24

03 Apr '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36502?usp=email ) Change subject: msc: fix race condition in TC_mm_id_resp_no_identity ...................................................................... msc: fix race condition in TC_mm_id_resp_no_identity This testcase is failing sporadically ever since it was introduced back in 2019, during 36C3. The problem is that osmo-msc does not react to the malformed MM IDENTITY RESPONSE immediately, but only after timeout of timer X1 (5 seconds, by default); while the testsuite expects the LU REJECT to be received within 5 seconds. We should ideally fix osmo-msc to react immediately, but for now let's enlarge the LU REJECT waiting timeout in the testcase. Change-Id: I5d2b5d49df8f7ae1eb12fc137f4256fe6fab9117 Related: OS#6426, OS#4340 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 28 insertions(+), 8 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index be12fae..6f8078b 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -916,11 +916,11 @@ } } -function f_expect_lu_reject(template OCT1 cause := ?) runs on BSC_ConnHdlr { +function f_expect_lu_reject(template OCT1 cause := ?, float Tval := 5.0) runs on BSC_ConnHdlr { var PDU_DTAP_MT dtap_mt; - timer T := 5.0; + timer T; - T.start; + T.start(Tval); alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej(cause))) { setverdict(pass); diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 52a5c2f..513e346 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6616,15 +6616,13 @@ vc_conn.done; } +/* Test how the MSC handles a malformed MM IDENTITY RESPONSE with no identity. */ friend function f_tc_mm_id_resp_no_identity(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { - pars.tmsi := 'FFFFFFFF'O; f_init_handler(pars); - f_create_gsup_expect(hex2str(g_pars.imsi)); - /* Initiate Location Updating using an unknown TMSI */ - f_bssap_compl_l3(f_build_lu_tmsi(pars.tmsi)); + f_bssap_compl_l3(f_build_lu_tmsi('FFFFFFFF'O)); /* Expect an Identity Request, send response with no identity */ BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(CM_ID_TYPE_IMSI))); @@ -6641,7 +6639,10 @@ } }))); - f_expect_lu_reject(); + /* XXX: Current osmo-msc does not react on bad/malformed MM IDENTITY RESPONSE immediately. + * It instead relies on expiry of timer X1, which is set to 5.0 seconds by default. This + * is not good (DoS vector) and should ideally be fixed, but for now just work it around. */ + f_expect_lu_reject(Tval := 5.0 + 1.0); f_expect_clear(); } testcase TC_mm_id_resp_no_identity() runs on MTC_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d2b5d49df8f7ae1eb12fc137f4256fe6fab9117 Gerrit-Change-Number: 36502 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: fix race condition in TC_mm_id_resp_no_identity
by laforge 03 Apr '24

03 Apr '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36502?usp=email ) Change subject: msc: fix race condition in TC_mm_id_resp_no_identity ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d2b5d49df8f7ae1eb12fc137f4256fe6fab9117 Gerrit-Change-Number: 36502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Apr 2024 07:53:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log