- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
by laforge 23 Apr '24

23 Apr '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email ) Change subject: HTTP_Adapter: allow API users to specifiy custom header ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/5527cc0d_740e… PS4, Line 57: h indent issue (tab missing) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 Gerrit-Change-Number: 36504 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 12:19:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: io_uring: set memlock to unlimited
by osmith 23 Apr '24

23 Apr '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email ) Change subject: jobs/ttcn3: io_uring: set memlock to unlimited ...................................................................... jobs/ttcn3: io_uring: set memlock to unlimited io_uring in the kernel memlocks a big amount of space with older kernels, such as the kernel on host2-deb11build-ansible. It seemed to be enough to increase it to 1 GiB. However now we see it failing again with: failure during io_uring_queue_init(): Cannot allocate memory Aborted (core dumped) Set it to unlimited to ensure that a low limit is not the reason we see it failing. If it still happens after this, we probably need to make sure that we don't run too many SUTs with io_uring in parallel on jenkins nodes with older kernels. Related: OS#6405 Change-Id: I39aaa2ed7d0310a12d0c4493a79ff46b2e7e2864 --- M jobs/ttcn3-testsuites.yml 1 file changed, 25 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 2e01645..2c3e07d 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -301,8 +301,8 @@ ;; *-io_uring) DIR="$(echo "{job-name}" | sed s/\-io_uring$//)" - # OS#6405: set memlock to 1 GB for older kernels - export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit memlock=1000000" + # OS#6405: set memlock to unlimited for older kernels + export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit memlock=-1" ;; *-latest) DIR="$(echo "{job-name}" | sed s/\-latest$//)" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I39aaa2ed7d0310a12d0c4493a79ff46b2e7e2864 Gerrit-Change-Number: 36626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: io_uring: set memlock to unlimited
by laforge 23 Apr '24

23 Apr '24

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email ) Change subject: jobs/ttcn3: io_uring: set memlock to unlimited ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I39aaa2ed7d0310a12d0c4493a79ff46b2e7e2864 Gerrit-Change-Number: 36626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 12:18:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: io_uring: set memlock to unlimited
by pespin 23 Apr '24

23 Apr '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email ) Change subject: jobs/ttcn3: io_uring: set memlock to unlimited ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I39aaa2ed7d0310a12d0c4493a79ff46b2e7e2864 Gerrit-Change-Number: 36626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 12:00:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: io_uring: set memlock to unlimited
by osmith 23 Apr '24

23 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email ) Change subject: jobs/ttcn3: io_uring: set memlock to unlimited ...................................................................... jobs/ttcn3: io_uring: set memlock to unlimited io_uring in the kernel memlocks a big amount of space with older kernels, such as the kernel on host2-deb11build-ansible. It seemed to be enough to increase it to 1 GiB. However now we see it failing again with: failure during io_uring_queue_init(): Cannot allocate memory Aborted (core dumped) Set it to unlimited to ensure that a low limit is not the reason we see it failing. If it still happens after this, we probably need to make sure that we don't run too many SUTs with io_uring in parallel on jenkins nodes with older kernels. Related: OS#6405 Change-Id: I39aaa2ed7d0310a12d0c4493a79ff46b2e7e2864 --- M jobs/ttcn3-testsuites.yml 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/26/36626/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 2e01645..2c3e07d 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -301,8 +301,8 @@ ;; *-io_uring) DIR="$(echo "{job-name}" | sed s/\-io_uring$//)" - # OS#6405: set memlock to 1 GB for older kernels - export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit memlock=1000000" + # OS#6405: set memlock to unlimited for older kernels + export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit memlock=-1" ;; *-latest) DIR="$(echo "{job-name}" | sed s/\-latest$//)" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I39aaa2ed7d0310a12d0c4493a79ff46b2e7e2864 Gerrit-Change-Number: 36626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
by pespin 23 Apr '24

23 Apr '24

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email ) Change subject: HTTP_Adapter: allow body to be "omit" ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 10:38:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
by Jenkins Builder 23 Apr '24

23 Apr '24

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd ...................................................................... Patch Set 6: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c4d5dc85_6c18… PS6, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a275a220_d72a… PS6, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/8a831858_332e… PS6, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9ef18c1c_6756… PS6, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/3c08f20c_3688… PS6, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bb1033d0_5d96… PS6, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9353f380_8958… PS6, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c337e41d_2470… PS6, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/27532674_f568… PS6, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/fe629262_3542… PS6, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/19826810_778e… PS6, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/edb942d3_408a… PS6, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/264e6d6f_f935… PS6, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 10:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: ipad: add an extra certificate+bundle for host "testsuite"
by Jenkins Builder 23 Apr '24

23 Apr '24

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email ) Change subject: ipad: add an extra certificate+bundle for host "testsuite" ...................................................................... Patch Set 3: (12 comments) File ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9d332259_ec81… PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9208d852_24e5… PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9907abf0_5f53… PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/72b015f5_a6f7… PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/62041970_fd5c… PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/1de452cf_4a85… PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/testsuite.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/848c428e_fa97… PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/c0482b2b_63cc… PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/476d2c94_a030… PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/298ab1dc_57c4… PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/e1dd91f7_a8cf… PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/3885f348_4ac5… PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2d4ba8b710b9cf518b90c7f7acc8982350705531 Gerrit-Change-Number: 36621 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 10:19:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
by dexter 23 Apr '24

23 Apr '24

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email ) Change subject: HTTP_Adapter: allow body to be "omit" ...................................................................... Patch Set 5: (1 comment) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/fc03802c_9cb6… PS3, Line 106: header := valueof(f_ts_HTTP_Header(body, host, custom_hdr)), > You don't need to call valueof() here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 10:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
by dexter 23 Apr '24

23 Apr '24

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow body to be "omit" ...................................................................... HTTP_Adapter: allow body to be "omit" In HTTP not all requests have a body. At the moment we describe a missing body with body := "". This is not 100% correct since the rest of the code interprets this as a present body with zero length and will put a content_length = 0 header line into the HTTP header, even in the GET request. This will most likely be ignored by any HTTP server, but it is still not 100% spec compliant. Related: SYS#6824 Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff --- M library/HTTP_Adapter.ttcn 1 file changed, 29 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/36505/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log