Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758?usp=email )
Change subject: asterisk: Use (and fix) ActionID field in Action Login
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758/comment/5b62ffdb_737a…
PS1, Line 12: but I didn't find an easy
: way to state that in TTCN-3 so far.
for regex matching there is the @nocase modifier, which can be used both with "pattern @nocase" as well as with the regex() built-in function.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9080f617c4e7272b9dd67d616069ac9350411f3c
Gerrit-Change-Number: 36758
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2024 08:18:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email )
Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/65f0bd93_2302…
PS2, Line 26: ": " token in the value. I'd expect TEXT decoder to put all subsequent
pleas do make sure to report each of those to the eclipse TITAN forum. They might either be genuine bugs, or there might be users with [other] solutions to the problems you're facing.
File asterisk/AMI_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/f4e087d6_aead…
PS2, Line 189: welcome_str := "Asterisk Call Manager/9.0.0\r\n"
wouldn't this better be a regex? so that code could match multiple different versions, or ignore versions altogether? You could rename welcome_str to welcome_str_pattern and then use it as a regex (using the "referenced" notation of TTCN3 regex where you can interpret a string as a regex).
Not critical, just a thought while reading this.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d
Gerrit-Change-Number: 36755
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2024 08:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria, osmith, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36754?usp=email )
Change subject: Misc_Helpers.ttcn: Add some more string handling API helpers
......................................................................
Patch Set 1:
(1 comment)
File library/Misc_Helpers.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36754/comment/da99475e_0cd1…
PS1, Line 83: function f_str_endswith(charstring str, charstring token) return boolean
: {
you are aware that TTCN-3 supports [some] regular expression? I'd expect matching a string start or end would be the most basic functionality supported by any regex implementation.
See Section B.1.5 and the "pattern" syntax described in the TTCN3 core language spec (ES 201 873-1).
So I'm wondering if we really need a manually implenented function for it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36754?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3d6da125a10807b7a2f3ecad8145a046a322c7d6
Gerrit-Change-Number: 36754
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2024 08:10:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria, laforge.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email
to look at the new patch set (#2).
Change subject: gsm0808: add knowledge of TW-TS-003 BSSMAP IE
......................................................................
gsm0808: add knowledge of TW-TS-003 BSSMAP IE
Themyscira Wireless Technical Specification TW-TS-003 adds
a non-standard IE to GSM 08.08 BSSMAP whose purpose is to signal
the use of enhanced RTP payload formats that go against the
stipulations of TS 26.102 (referenced from 48.103 for AoIP),
but allow an IP-based GSM network implementation to mimic
the workings of TDM-based GSM more faithfully.
Spec reference:
https://www.freecalypso.org/specs/tw-ts-003-v010001.txt
Related: OS#6448
Change-Id: Idd6f1838bdc0cd71a2f6357e9b6d8b8fa4f7c46c
---
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
2 files changed, 25 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/36669/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idd6f1838bdc0cd71a2f6357e9b6d8b8fa4f7c46c
Gerrit-Change-Number: 36669
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset