osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/36769?usp=email )
Change subject: ttcn3/ttcn3.sh: collect_logs: fix tester* paths
......................................................................
ttcn3/ttcn3.sh: collect_logs: fix tester* paths
For ttcn3-bts-test and ttcn3-ggsn-test, the tester dir has the
configuration at the end (…-tester-all etc.). Support that in the
collect_logs function.
Change-Id: I2aaab0c37fffedaeb49a362f77d795f017e2a7da
---
M ttcn3/ttcn3.sh
1 file changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/69/36769/1
diff --git a/ttcn3/ttcn3.sh b/ttcn3/ttcn3.sh
index 7cdf4c1..26f76da 100755
--- a/ttcn3/ttcn3.sh
+++ b/ttcn3/ttcn3.sh
@@ -502,11 +502,8 @@
}
collect_logs() {
- # Merge and move logs
- cd /tmp/logs/*-tester
-
# Format logs
- for log in *.merged; do
+ for log in /tmp/logs/*-tester*/*.merged; do
ttcn3_logformat -o "${log}.log" "$log"
sudo rm "$log"
done
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/36769?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I2aaab0c37fffedaeb49a362f77d795f017e2a7da
Gerrit-Change-Number: 36769
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email )
Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> > What if I build an old osmo-bts with new libosmocore? […]
ah yes, it's just the VTY tests. But still it should be possible to solve this in the vty test runner by making it understand [based on the text structure] what is a list of commands and then accepting any number of spaces after the command word.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56
Gerrit-Change-Number: 36761
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2024 11:42:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email )
Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes
......................................................................
tests/osmo-bts.vty: aligh with recent libosmovty changes
A new command was recently added to libosmovty:
show fsm-state-graph NAME
This is now the longest command, affecting spacing in the output
of 'show ?' command. Align spacing to make the test pass again.
Change-Id: I80f896e45a88550909c5767169286fc321a36e56
Related: libosmocore.git I09ee0a8c3fc4b1aa991ab5c93c0b654fccd7ea4c
---
M tests/osmo-bts.vty
1 file changed, 33 insertions(+), 16 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/tests/osmo-bts.vty b/tests/osmo-bts.vty
index 97629d0..a51ad63 100644
--- a/tests/osmo-bts.vty
+++ b/tests/osmo-bts.vty
@@ -19,14 +19,14 @@
OsmoBTS> show ?
...
- bts Display information about a BTS
- trx Display information about a TRX
- timeslot Display information about a TS
- lchan Display information about a logical channel
- timer Show timers
- e1_driver Display information about available E1 drivers
- e1_line Display information about a E1 line
- e1_timeslot Display information about a E1 timeslot
+ bts Display information about a BTS
+ trx Display information about a TRX
+ timeslot Display information about a TS
+ lchan Display information about a logical channel
+ timer Show timers
+ e1_driver Display information about available E1 drivers
+ e1_line Display information about a E1 line
+ e1_timeslot Display information about a E1 timeslot
...
OsmoBTS> show bts ?
[<0-255>] BTS Number
@@ -120,14 +120,14 @@
OsmoBTS# show ?
...
- bts Display information about a BTS
- trx Display information about a TRX
- timeslot Display information about a TS
- lchan Display information about a logical channel
- timer Show timers
- e1_driver Display information about available E1 drivers
- e1_line Display information about a E1 line
- e1_timeslot Display information about a E1 timeslot
+ bts Display information about a BTS
+ trx Display information about a TRX
+ timeslot Display information about a TS
+ lchan Display information about a logical channel
+ timer Show timers
+ e1_driver Display information about available E1 drivers
+ e1_line Display information about a E1 line
+ e1_timeslot Display information about a E1 timeslot
...
OsmoBTS# show bts ?
[<0-255>] BTS Number
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56
Gerrit-Change-Number: 36761
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email )
Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> What if I build an old osmo-bts with new libosmocore?
It would build just fine and pass the unit tests, but not the vty transcript test.
I am not really sure if we can fix this in the python script, or more precisely **how**. It's simply executing commands and matching the program output against the expected output. We cannot just change the script to ignore spacing, as that would break other stuff.
Maybe @nhofmeyr@sysmocom.de has an idea?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56
Gerrit-Change-Number: 36761
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2024 10:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36763?usp=email )
Change subject: asterisk: Use ActionID field in Action Login
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36763?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec320762ff0cca86319f7374b53c642f08a6e6df
Gerrit-Change-Number: 36763
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2024 08:37:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758?usp=email )
Change subject: AMI_Function: Match field keys in case insensitive way
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File asterisk/AMI_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758/comment/38890a4f_dd53…
PS1, Line 89: tr_AMI_Field_ActionId(template (present) charstring val := ?) := tr_AMI_Field(AMI_FIELD_ACTION_ID, val);
> This seems to be working afaict, thanks, I'll submit a new patch version soon.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9080f617c4e7272b9dd67d616069ac9350411f3c
Gerrit-Change-Number: 36758
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2024 08:36:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment