- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim-trace: Support decoding of eUICC traces
by laforge 10 May '24

10 May '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36777?usp=email ) Change subject: pySim-trace: Support decoding of eUICC traces ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 Gerrit-Change-Number: 36777 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 May 2024 19:18:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow setting transport in Via templates
by pespin 10 May '24

10 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36780?usp=email ) Change subject: SIP_Templates: Allow setting transport in Via templates ...................................................................... SIP_Templates: Allow setting transport in Via templates This is needed when using IMS, since TCP is used. Change-Id: Id45491615bcb5c074ef4fc298cbb24b2e034972d --- M asterisk/SIP_ConnectionHandler.ttcn M library/SIP_Templates.ttcn 2 files changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/36780/1 diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index 13b5f04..9c7cca5 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -178,6 +178,7 @@ { id := "received", paramValue := g_pars.remote_sip_host } }; */ return tr_Via_from(via_req.viaBody[0].sentBy, + via_req.viaBody[0].sentProtocol.transport, via_resp_params); } diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 3492dc4..e22646c 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -372,22 +372,24 @@ mediaType := "application/sdp" }; -template (value) Via ts_Via_from(template (value) HostPort addr) := { +template (value) Via ts_Via_from(template (value) HostPort addr, + template (value) charstring transport := "UDP") := { fieldName := VIA_E, viaBody := { { - sentProtocol := { "SIP", "2.0", "UDP" }, + sentProtocol := { "SIP", "2.0", transport }, sentBy := addr, viaParams := omit } } } template (present) Via tr_Via_from(template (present) HostPort host_port := ?, + template (present) charstring transport := ?, template SemicolonParam_List viaParams := *) := { fieldName := VIA_E, viaBody := { { - sentProtocol := { "SIP", "2.0", "UDP" }, + sentProtocol := { "SIP", "2.0", ? }, sentBy := host_port, viaParams := viaParams } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id45491615bcb5c074ef4fc298cbb24b2e034972d Gerrit-Change-Number: 36780 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing WwwAuthenticate to ts_SIP_msgh_std
by pespin 10 May '24

10 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36781?usp=email ) Change subject: SIP_Templates: Allow passing WwwAuthenticate to ts_SIP_msgh_std ...................................................................... SIP_Templates: Allow passing WwwAuthenticate to ts_SIP_msgh_std The field could already be passed to its tr_* counterpart, but not the the ts_* one. Change-Id: Ibc6cc5320f24ce82165c1b2140bad30cb356f8ae --- M library/SIP_Templates.ttcn 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/36781/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index e22646c..2498f49 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -454,7 +454,8 @@ template (omit) ContentType content_type := omit, template (omit)Authorization authorization := omit, template (value) Method_List allow_methods := c_SIP_defaultMethods, - template (omit) Expires expires := omit + template (omit) Expires expires := omit, + template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { allow := { fieldName := ALLOW_E, @@ -489,7 +490,8 @@ "osmo-ttcn3-hacks/0.23" } }, - via := via + via := via, + wwwAuthenticate := wwwAuthenticate } function tr_AllowMethods(template Method_List allow_methods) return template Allow { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc6cc5320f24ce82165c1b2140bad30cb356f8ae Gerrit-Change-Number: 36781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Require,Security-client,Supported fields...
by pespin 10 May '24

10 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36782?usp=email ) Change subject: SIP_Templates: Allow passing Require,Security-client,Supported fields to REGISTER templates ...................................................................... SIP_Templates: Allow passing Require,Security-client,Supported fields to REGISTER templates These fields are used in IMS. Change-Id: I20a0df5633db8c0e7732659c1316b85e63317afc --- M library/SIP_Templates.ttcn 1 file changed, 84 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/36782/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 2498f49..7e33b3b 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -197,6 +197,28 @@ deltaSec := deltaSec } + +// [20.32] +template (value) Require ts_Require(template (value) OptionTag_List optionsTags := {}) := { + fieldName := REQUIRE_E, + optionsTags := optionsTags +} +template (present) Require tr_Require(template (present) OptionTag_List optionsTags := ?) := { + fieldName := REQUIRE_E, + optionsTags := optionsTags +} + +// [20.37] +template (value) Supported ts_Supported(template (value) OptionTag_List optionsTags := {}) := { + fieldName := SUPPORTED_E, + optionsTags := optionsTags +} +template (present) Supported tr_Supported(template (present) OptionTag_List optionsTags := ?) := { + fieldName := SUPPORTED_E, + optionsTags := optionsTags +} + + template (value) SipAddr ts_SipAddr(template (value) HostPort host_port, template (omit) UserInfo user_info := omit, template (omit) charstring displayName := omit, @@ -442,6 +464,31 @@ challenge := challenge } +// RFC3329 +template (present) Security_client +tr_Security_client(template (present) Security_mechanism_list sec_mechanism_list := ?) := { + fieldName := SECURITY_CLIENT_E, + sec_mechanism_list := sec_mechanism_list +} +template (value) Security_client +ts_Security_client(template (value) Security_mechanism_list sec_mechanism_list) := { + fieldName := SECURITY_CLIENT_E, + sec_mechanism_list := sec_mechanism_list +} + +template (present) Security_mechanism +tr_Security_mechanism(template (present) charstring name := ?, + template SemicolonParam_List params := *) := { + mechanism_name := name, + mechanism_params := params +} +template (value) Security_mechanism +ts_Security_mechanism(template (value) charstring name, + template (omit) SemicolonParam_List params := omit) := { + mechanism_name := name, + mechanism_params := params +} + template (value) MessageHeader ts_SIP_msgHeader_empty := c_SIP_msgHeader_empty; template (value) MessageHeader ts_SIP_msgh_std(template (value) CallidString call_id, @@ -455,6 +502,9 @@ template (omit)Authorization authorization := omit, template (value) Method_List allow_methods := c_SIP_defaultMethods, template (omit) Expires expires := omit, + template (omit) Require require := omit, + template (omit) Security_client security_client := omit, + template (omit) Supported supported := omit, template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { allow := { @@ -479,6 +529,9 @@ addressField := from_addr.addr, fromParams := from_addr.params }, + require := require, + security_client := security_client, + supported := supported, toField := { fieldName := TO_E, addressField := to_addr.addr, @@ -520,6 +573,9 @@ template integer seq_nr := ?, template Method_List allow_methods := *, template Expires expires := *, + template Require require := *, + template Security_client security_client := *, + template Supported supported := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { allow := tr_AllowMethods(allow_methods), @@ -540,6 +596,9 @@ addressField := from_addr.addr, fromParams := from_addr.params }, + require := require, + security_client := security_client, + supported := supported, toField := { fieldName := TO_E, addressField := to_addr.addr, @@ -561,13 +620,19 @@ template (omit) Contact contact, template (omit) Expires expires, template (omit) Authorization authorization := omit, + template (omit) Require require := omit, + template (omit) Security_client security_client := omit, + template (omit) Supported supported := omit, template (omit) charstring body := omit) := { requestLine := ts_SIP_ReqLine(REGISTER_E, sip_url_host_port), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, contact, "REGISTER", seq_nr, via, f_ContentTypeOrOmit(ts_CT_SDP, body), authorization := authorization, - expires := expires), + expires := expires, + require := require, + security_client := security_client, + supported := supported), messageBody := body, payload := omit } @@ -580,11 +645,17 @@ template integer seq_nr := *, template Contact contact := *, template Expires expires := *, + template Require require := *, + template Security_client security_client := *, + template Supported supported := *, template charstring body := *) := { requestLine := tr_SIP_ReqLine(REGISTER_E, sip_url_host_port), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact, via, "REGISTER", *, seq_nr, - expires := expires), + expires := expires, + require := require, + security_client := security_client, + supported := supported), messageBody := body, payload := omit } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20a0df5633db8c0e7732659c1316b85e63317afc Gerrit-Change-Number: 36782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim-trace: Support decoding of eUICC traces
by laforge 10 May '24

10 May '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/36777?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-trace: Support decoding of eUICC traces ...................................................................... pySim-trace: Support decoding of eUICC traces Let's register the ISD-R and ECASD applications so we avoid the warnings printed when processing an eUICC protocol trace: WARNING pySim.apdu.ts_102_221: SELECT UNKNOWN AID a0000005591010ffffffff8900000100 Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 --- M pySim-trace.py M pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/77/36777/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 Gerrit-Change-Number: 36777 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: pySim.global_platform: Fix key encryption with DEK
by laforge 10 May '24

10 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36779?usp=email ) Change subject: pySim.global_platform: Fix key encryption with DEK ...................................................................... pySim.global_platform: Fix key encryption with DEK When a SCP is active, the DEK is used to encrypt any key material that's installed using PUT KEY. The code prior to this patch fails to handle this case as it calls the encrypt_key() method on the wrong object. Change-Id: I6e10fb9c7881ba74ad2986c36bba95b336470838 --- M pySim/global_platform/__init__.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 9960560..5086721 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -550,7 +550,7 @@ kcv = b2h(kcv_bin) if self._cmd.lchan.scc.scp: # encrypte key data with DEK of current SCP - kcb = b2h(self._cmd.lchan.scc.scp.card_keys.encrypt_key(h2b(opts.key_data[i]))) + kcb = b2h(self._cmd.lchan.scc.scp.encrypt_key(h2b(opts.key_data[i]))) else: # (for example) during personalization, DEK might not be required) kcb = opts.key_data[i] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6e10fb9c7881ba74ad2986c36bba95b336470838 Gerrit-Change-Number: 36779 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: euicc: Fix shell command for SGP.31 get_certs
by laforge 10 May '24

10 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36778?usp=email ) Change subject: euicc: Fix shell command for SGP.31 get_certs ...................................................................... euicc: Fix shell command for SGP.31 get_certs Change-Id: I2e59070992bb522d14a5e4956f0d8e738a785dd8 --- M pySim/euicc.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/euicc.py b/pySim/euicc.py index 8b8b973..c27c91f 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -279,7 +279,7 @@ _construct = GreedyBytes class EuiccCertificate(BER_TLV_IE, tag=0xa6): _construct = GreedyBytes -class GetCertsError(BER_TLV_IE, tag=0x80): +class GetCertsError(BER_TLV_IE, tag=0x81): _construct = Enum(Int8ub, invalidCiPKId=1, undefinedError=127) class GetCertsResp(BER_TLV_IE, tag=0xbf56, nested=[EumCertificate, EuiccCertificate, GetCertsError]): pass @@ -501,7 +501,7 @@ """Perform an ES10c GetCerts() function on an IoT eUICC.""" gc = CardApplicationISDR.store_data_tlv(self._cmd.lchan.scc, GetCertsReq(), GetCertsResp) d = gc.to_dict() - self._cmd.poutput_json(flatten_dict_lists(d['get_certficiates_resp'])) + self._cmd.poutput_json(flatten_dict_lists(d['get_certs_resp'])) def do_get_eim_configuration_data(self, _opts): """Perform an ES10b GetEimConfigurationData function on an Iot eUICC.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e59070992bb522d14a5e4956f0d8e738a785dd8 Gerrit-Change-Number: 36778 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: filesystem: Enforce lower-case hex AID
by laforge 10 May '24

10 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36776?usp=email ) Change subject: filesystem: Enforce lower-case hex AID ...................................................................... filesystem: Enforce lower-case hex AID our utils.b2h() returns values in lower-case hex string notation, so let's make sure the CardADF and CardApplication AID values are also stored in lower case notation, othewise the matching baesd on AIDs returned from the card will not work, specifically as we use uppercase AIDs in pySim.euicc for CardApplicationECASD and CardApplicationISDR. Rather than change those two instances, let's solve it in a generic way. We already do the same for the CardFile.fid member. Change-Id: Ie42392412d9eb817fbc563d9165faab198ffa7a9 --- M pySim/filesystem.py 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 4d5fde9..77482cc 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -512,7 +512,7 @@ super().__init__(**kwargs) # reference to CardApplication may be set from CardApplication constructor self.application = None # type: Optional[CardApplication] - self.aid = aid # Application Identifier + self.aid = aid.lower() # Application Identifier self.has_fs = has_fs # Flag to tell whether the ADF supports a filesystem or not mf = self.get_mf() if mf: @@ -1294,6 +1294,8 @@ adf : ADF name sw : Dict of status word conversions """ + if aid: + aid = aid.lower() self.name = name self.adf = adf self.sw = sw or {} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie42392412d9eb817fbc563d9165faab198ffa7a9 Gerrit-Change-Number: 36776 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: filesystem: Enforce lower-case hex AID
by laforge 10 May '24

10 May '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36776?usp=email ) Change subject: filesystem: Enforce lower-case hex AID ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial fix -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie42392412d9eb817fbc563d9165faab198ffa7a9 Gerrit-Change-Number: 36776 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 May 2024 18:17:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim.global_platform: Fix key encryption with DEK
by laforge 10 May '24

10 May '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36779?usp=email ) Change subject: pySim.global_platform: Fix key encryption with DEK ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: trivial fix -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6e10fb9c7881ba74ad2986c36bba95b336470838 Gerrit-Change-Number: 36779 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 May 2024 18:16:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log