- gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: gtp: remove unused conversion functions
by osmith 14 May '24

14 May '24

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gtp: remove unused conversion functions ...................................................................... gtp: remove unused conversion functions Remove ipv42eua and eua2ipv4, which are in the "internal functions" section of gtp.h, but are not used anywhere in the code anymore. This is in preparation of moving the internal functions that are used in multiple .c files into a separate header file, and to make the other internal functions static. (Compiler complains about unused static functions.) Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 --- M TODO-RELEASE M gtp/gtp.c M include/osmocom/gtp/gtp.h 3 files changed, 17 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/90/36790/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 Gerrit-Change-Number: 36790 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ggsn[master]: gtp: move conversion functions up
by osmith 14 May '24

14 May '24

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gtp: move conversion functions up ...................................................................... gtp: move conversion functions up Move the conversion functions above the first user, so we can make in_addr2gsna static in a follow-up commit and remove the extra declaration. Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1 --- M gtp/gtp.c 1 file changed, 47 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/91/36791/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1 Gerrit-Change-Number: 36791 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Enable debug for pjproject
by pespin 13 May '24

13 May '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/36795?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ttcn3-asterisk: Enable debug for pjproject ...................................................................... ttcn3-asterisk: Enable debug for pjproject Change-Id: I7de6ac31f7a75411fb515501611187f97e829ab3 --- M ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh A ttcn3-asterisk-ims-ue-test/asterisk/pjproject.conf 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/95/36795/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7de6ac31f7a75411fb515501611187f97e829ab3 Gerrit-Change-Number: 36795 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Server field
by pespin 13 May '24

13 May '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: SIP_Templates: Allow passing Server field ...................................................................... SIP_Templates: Allow passing Server field This field is used by an IMS core. Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc --- M library/SIP_Templates.ttcn 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/36797/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc Gerrit-Change-Number: 36797 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Server field
by pespin 13 May '24

13 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email ) Change subject: SIP_Templates: Allow passing Server field ...................................................................... SIP_Templates: Allow passing Server field This field is used by an IMS core. Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc --- M library/SIP_Templates.ttcn 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/36797/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 0b5c9bf..13cb10e 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -550,6 +550,7 @@ template (omit) Require require := omit, template (omit) Security_client security_client := omit, template (omit) Security_server security_server := omit, + template (omit) Server server := omit, template (omit) Supported supported := omit, template (omit) UserAgent userAgent := ts_UserAgent({ "osmo-ttcn3-hacks/0.23" }), template (omit) WwwAuthenticate wwwAuthenticate := omit @@ -576,6 +577,7 @@ require := require, security_client := security_client, security_server := security_server, + server := server, supported := supported, toField := { fieldName := TO_E, @@ -601,6 +603,7 @@ template Require require := *, template Security_client security_client := *, template Security_server security_server := *, + template Server server := *, template Supported supported := *, template UserAgent userAgent := *, template WwwAuthenticate wwwAuthenticate := * @@ -626,6 +629,7 @@ require := require, security_client := security_client, security_server := security_server, + server := server, supported := supported, toField := { fieldName := TO_E, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc Gerrit-Change-Number: 36797 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing UserAgent field
by pespin 13 May '24

13 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36796?usp=email ) Change subject: SIP_Templates: Allow passing UserAgent field ...................................................................... SIP_Templates: Allow passing UserAgent field This way it can be set to omit, since this field is not set by an IMS core. Change-Id: Ib1e3e66b8fe46ad2626b07193dfcaa594f26352e --- M library/SIP_Templates.ttcn 1 file changed, 26 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/36796/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 9b3d188..0b5c9bf 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -242,6 +242,16 @@ optionsTags := optionsTags } +// [20.41 RFC2616 14.43] +template (value) UserAgent ts_UserAgent(template (value) ServerVal_List userAgentBody := {}) := { + fieldName := USER_AGENT_E, + userAgentBody := userAgentBody +} +template (present) UserAgent tr_UserAgent(template (present) ServerVal_List userAgentBody := ?) := { + fieldName := USER_AGENT_E, + userAgentBody := userAgentBody +} + template (value) SipAddr ts_SipAddr(template (value) HostPort host_port, template (omit) UserInfo user_info := omit, @@ -541,6 +551,7 @@ template (omit) Security_client security_client := omit, template (omit) Security_server security_server := omit, template (omit) Supported supported := omit, + template (omit) UserAgent userAgent := ts_UserAgent({ "osmo-ttcn3-hacks/0.23" }), template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { allow := allow, @@ -571,12 +582,7 @@ addressField := to_addr.addr, toParams := to_addr.params }, - userAgent := { - fieldName := USER_AGENT_E, - userAgentBody := { - "osmo-ttcn3-hacks/0.23" - } - }, + userAgent := userAgent, via := via, wwwAuthenticate := wwwAuthenticate } @@ -596,6 +602,7 @@ template Security_client security_client := *, template Security_server security_server := *, template Supported supported := *, + template UserAgent userAgent := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { allow := allow, @@ -625,7 +632,7 @@ addressField := to_addr.addr, toParams := to_addr.params }, - userAgent := *, + userAgent := userAgent, via := via, wwwAuthenticate := wwwAuthenticate } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib1e3e66b8fe46ad2626b07193dfcaa594f26352e Gerrit-Change-Number: 36796 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Enable debug for pjproject
by pespin 13 May '24

13 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36795?usp=email ) Change subject: ttcn3-asterisk: Enable debug for pjproject ...................................................................... ttcn3-asterisk: Enable debug for pjproject Change-Id: I7de6ac31f7a75411fb515501611187f97e829ab3 --- M ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh A ttcn3-asterisk-ims-ue-test/asterisk/pjproject.conf 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/95/36795/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh b/ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh index f9b4bf5..b31015f 100755 --- a/ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh +++ b/ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh @@ -10,6 +10,7 @@ #cp -r /etc/asterisk/* "${ASTERISK_CFG_PATH}/" cp /data/asterisk.conf "${ASTERISK_CFG_PATH}/" #sed -i "s#/etc/asterisk#${ASTERISK_CFG_PATH}#" "${ASTERISK_CFG_PATH}/asterisk.conf" +cp /data/pjproject.conf "${ASTERISK_CFG_PATH}/" cp /data/pjsip.conf "${ASTERISK_CFG_PATH}/" cp /data/manager.conf "${ASTERISK_CFG_PATH}/" cp /data/logger.conf "${ASTERISK_CFG_PATH}/" diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjproject.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjproject.conf new file mode 100644 index 0000000..9a049f9 --- /dev/null +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjproject.conf @@ -0,0 +1,13 @@ +[startup] +;https://docs.asterisk.org/Certified-Asterisk_18.9_Documentation/API_Documentation/Module_Configuration/res_pjproject/ +; These logging level meanings are typically used by pjproject: +; - 0: fatal error +; - 1: error +; - 2: warning +; - 3: info +; - 4: debug +; - 5: trace +; - 6: more detailed trace +; +; log_level 6 "trace" is too much. +log_level=4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7de6ac31f7a75411fb515501611187f97e829ab3 Gerrit-Change-Number: 36795 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Add ts_SIP_Response_Trying
by pespin 13 May '24

13 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36794?usp=email ) Change subject: SIP_Templates: Add ts_SIP_Response_Trying ...................................................................... SIP_Templates: Add ts_SIP_Response_Trying Similar to ts_SIP_Response_Ringing. We also have the counterpart tr_* for both Trying and Ringing. This is needed in a follow-up patch. Change-Id: I05d8be9ce8860c610c509670392e14f1096fdddb --- M library/SIP_Templates.ttcn 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/36794/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index c82d36d..9b3d188 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -806,7 +806,22 @@ messageBody := body, payload := omit } - +/* 100 Trying */ +template (value) PDU_SIP_Response +ts_SIP_Response_Trying( + template (value) CallidString call_id, + template (value) SipAddr from_addr, + template (value) SipAddr to_addr, + Via via, + integer seq_nr, + charstring method := "INVITE", + template (omit) charstring body := omit) := { + statusLine := ts_SIP_StatusLine(100, "Trying"), + msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, + via, f_ContentTypeOrOmit(ts_CT_SDP, body)), + messageBody := body, + payload := omit +} /* 180 Ringing */ template (value) PDU_SIP_Response ts_SIP_Response_Ringing( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I05d8be9ce8860c610c509670392e14f1096fdddb Gerrit-Change-Number: 36794 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: Omit octet 3a in mobile-terminating setup requests if speech version ...
by fixeria 13 May '24

13 May '24

Attention is currently required from: neels, nt2mku. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: Omit octet 3a in mobile-terminating setup requests if speech version is GSM-FR only ...................................................................... Patch Set 2: (5 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/04d19fe5_db78a8f1 PS2, Line 7: mobile-terminating setup requests Please note that `gsm48_encode_bearer_cap()` is also used by osmocom-bb, so this change also affects mobile originating CC SETUP messages. I suggest to change commit name to `gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR is supported`. https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/ff0a3a8a_0adcbf0e PS2, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR (v1, 0x00) only, omit octet 3a. cosmetic: the usual line length limit for COMMIT_MSG is 72 chars, so please add line break(s). Patchset: PS2: As can be seen, the build verification is failing because the output of `tests/gsm0408` has changed: ``` --- experr 2024-05-12 19:45:16.719230477 +0000 +++ /build/builddir/tests/testsuite.dir/at-groups/28/stderr 2024-05-12 19:45:16.727230501 +0000 @@ -1,6 +1,3 @@ Incorrect encoded result of CSD 2400/V.22bis/transparent: should: 07 a2 b8 81 21 13 43 83 is: 07 a2 88 81 21 13 43 83 -Incorrect encoded result of Speech, without octet 3a: - should: 01 a0 - is: 02 20 80 --- expout 2024-05-12 19:45:16.719230477 +0000 +++ /build/builddir/tests/testsuite.dir/at-groups/28/stdout 2024-05-12 19:45:17.471232722 +0000 @@ -2,7 +2,7 @@ Test `CSD 4800/RLP/non-transparent' passed Test `CSD 2400/V.22bis/transparent' failed Test `Speech, all codecs' passed -Test `Speech, without octet 3a' failed +Test `Speech, without octet 3a' passed Simple TMSI encoding test....passed Simple IMSI encoding test....passed: [10] 17 08 99 10 07 00 00 00 64 02 ``` You need to amend the expected output in order to make the build verification pass, which can be done by running `make -C tests/ update_exp`. File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/1c7b7bea_045d8bdf PS2, Line 330: /* if we have only one speech version, which is FR, skip octet 3a */ Let's add a spec. reference here: ``` /* According to 3GPP TS 24.008, section 10.5.4.5.1, octet 3a etc. shall be included only if the mobile station supports CTM text telephony or if it supports at least one speech version for GERAN other than V1 (FR or HR). */ ``` https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/fea112e0_80f06b9f PS2, Line 331: bcap->speech_ver[1] >= 0 || (bcap->speech_ver[0] & 0x0f) != 0x00 Consider the following input: ``` bcap->speech_ver[] = { GSM48_BCAP_SV_HR /* 0x01 */ GSM48_BCAP_SV_FR /* 0x00 */ }; ``` In this case it's still only the speech version 1, but octets 3[ab] will be encoded. We should also still include octet(s) 3a etc. if `bcap->speech_ctm != 0`. I suggest adding unit tests for that too. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 2 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Comment-Date: Mon, 13 May 2024 14:36:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing 'Allow' field
by pespin 13 May '24

13 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email ) Change subject: SIP_Templates: Allow passing 'Allow' field ...................................................................... SIP_Templates: Allow passing 'Allow' field Change-Id: I10dd36d8c0ef8dbcbb58016c9684d877a0455b03 --- M library/SIP_Templates.ttcn 1 file changed, 37 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/36793/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index d35813e..c82d36d 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -66,6 +66,30 @@ } } +// [20.5] +template (present) Allow tr_Allow(template Method_List methods := *) := { + fieldName := ALLOW_E, + methods := methods +} +template (value) Allow ts_Allow(template (omit) Method_List methods := omit) := { + fieldName := ALLOW_E, + methods := methods +} +function tr_AllowMethods(template Method_List allow_methods) return template Allow { + if (istemplatekind(allow_methods, "omit")) { + return omit; + } else if (istemplatekind(allow_methods, "*")) { + return *; + } else if (istemplatekind(allow_methods, "?")) { + return ?; + } + var template (present) Allow ret := { + fieldName := ALLOW_E, + methods := allow_methods + } + return ret +} + template (value) Credentials ts_Credentials_DigestResponse(template (value) CommaParam_List digestResponse) := { digestResponse := digestResponse } @@ -511,7 +535,7 @@ template (value) Via via, template (omit) ContentType content_type := omit, template (omit)Authorization authorization := omit, - template (value) Method_List allow_methods := c_SIP_defaultMethods, + template (omit) Allow allow := ts_Allow(c_SIP_defaultMethods), template (omit) Expires expires := omit, template (omit) Require require := omit, template (omit) Security_client security_client := omit, @@ -519,10 +543,7 @@ template (omit) Supported supported := omit, template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { - allow := { - fieldName := ALLOW_E, - methods := allow_methods - }, + allow := allow, authorization := authorization, callId := { fieldName := CALL_ID_E, @@ -560,21 +581,6 @@ wwwAuthenticate := wwwAuthenticate } -function tr_AllowMethods(template Method_List allow_methods) return template Allow { - if (istemplatekind(allow_methods, "omit")) { - return omit; - } else if (istemplatekind(allow_methods, "*")) { - return *; - } else if (istemplatekind(allow_methods, "?")) { - return ?; - } - var template (present) Allow ret := { - fieldName := ALLOW_E, - methods := allow_methods - } - return ret -} - template (present) MessageHeader tr_SIP_msgh_std(template CallidString call_id, template SipAddr from_addr, @@ -584,7 +590,7 @@ template charstring method, template ContentType content_type := *, template integer seq_nr := ?, - template Method_List allow_methods := *, + template Allow allow := *, template Expires expires := *, template Require require := *, template Security_client security_client := *, @@ -592,7 +598,7 @@ template Supported supported := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { - allow := tr_AllowMethods(allow_methods), + allow := allow, callId := { fieldName := CALL_ID_E, callid := call_id -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10dd36d8c0ef8dbcbb58016c9684d877a0455b03 Gerrit-Change-Number: 36793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log