- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing 'Allow' field
by osmith 15 May '24

15 May '24

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email ) Change subject: SIP_Templates: Allow passing 'Allow' field ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10dd36d8c0ef8dbcbb58016c9684d877a0455b03 Gerrit-Change-Number: 36793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:02:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing 'Allow' field
by osmith 15 May '24

15 May '24

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email ) Change subject: SIP_Templates: Allow passing 'Allow' field ...................................................................... Patch Set 1: (1 comment) File library/SIP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793/comment/4d8c1849_78c5… PS1, Line 78: function tr_AllowMethods(template Method_List allow_methods) return template Allow { this is now unused, even in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759/4. is it worth keeping? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10dd36d8c0ef8dbcbb58016c9684d877a0455b03 Gerrit-Change-Number: 36793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:01:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Security_server field
by osmith 15 May '24

15 May '24

Attention is currently required from: jolly, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36792?usp=email ) Change subject: SIP_Templates: Allow passing Security_server field ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ee3d6dace39c784b0ec900d58a55421ac967269 Gerrit-Change-Number: 36792 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 06:57:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-upf[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36811?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I8994759df644d6edd8f937051b95690537b749be --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/postinst b/debian/postinst index 4310e7e..3298043 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-upf.cfg - chmod 0660 /etc/osmocom/osmo-upf.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "0.2.0"; then + if [ -e /etc/osmocom/osmo-upf.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-upf.cfg + chmod -v 0660 /etc/osmocom/osmo-upf.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I8994759df644d6edd8f937051b95690537b749be Gerrit-Change-Number: 36811 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-sip-connector[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/36809?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/postinst b/debian/postinst index d96fa8c..e9b1449 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-sip-connector.cfg - chmod 0660 /etc/osmocom/osmo-sip-connector.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.7.0"; then + if [ -e /etc/osmocom/osmo-sip-connector.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-sip-connector.cfg + chmod -v 0660 /etc/osmocom/osmo-sip-connector.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/36809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 Gerrit-Change-Number: 36809 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36805?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index d5bf871..616c969 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-hnbgw.cfg - chmod 0660 /etc/osmocom/osmo-hnbgw.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.6.0"; then + if [ -e /etc/osmocom/osmo-hnbgw.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-hnbgw.cfg + chmod -v 0660 /etc/osmocom/osmo-hnbgw.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f Gerrit-Change-Number: 36805 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-cbc[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/36802?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: Ic41d3ae2478c49aed222bfa978344727c5dc92a4 --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/debian/postinst b/debian/postinst index 922fa48..2e24c6a 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-cbc.cfg - chmod 0660 /etc/osmocom/osmo-cbc.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "0.5.0"; then + if [ -e /etc/osmocom/osmo-cbc.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-cbc.cfg + chmod -v 0660 /etc/osmocom/osmo-cbc.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/36802?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ic41d3ae2478c49aed222bfa978344727c5dc92a4 Gerrit-Change-Number: 36802 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36801?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I853097a13e27b2ebd0b940117c8f5f4b3ea49b9a --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/postinst b/debian/postinst index 26cdddf..8532a7a 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-bsc.cfg - chmod 0660 /etc/osmocom/osmo-bsc.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.12.0"; then + if [ -e /etc/osmocom/osmo-bsc.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-bsc.cfg + chmod -v 0660 /etc/osmocom/osmo-bsc.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I853097a13e27b2ebd0b940117c8f5f4b3ea49b9a Gerrit-Change-Number: 36801 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo_dia2gsup[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36803?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I48e8f5d2a36886d28366bef1918f7464a48d2159 --- M debian/postinst 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index 680cb2f..3353c37 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,8 +16,10 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - mkdir -p /var/lib/osmo_dia2gsup - chown -R osmocom:osmocom /var/lib/osmo_dia2gsup + if dpkg --compare-versions "$2" le "0.3.0"; then + mkdir -p /var/lib/osmo_dia2gsup + chown -R -v osmocom:osmocom /var/lib/osmo_dia2gsup + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I48e8f5d2a36886d28366bef1918f7464a48d2159 Gerrit-Change-Number: 36803 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnodeb[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36806?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index c65375e..8632699 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-hnodeb.cfg - chmod 0660 /etc/osmocom/osmo-hnodeb.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "0.2.0"; then + if [ -e /etc/osmocom/osmo-hnodeb.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-hnodeb.cfg + chmod -v 0660 /etc/osmocom/osmo-hnodeb.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f Gerrit-Change-Number: 36806 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log