- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Server field
by pespin 15 May '24

15 May '24

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SIP_Templates: Allow passing Server field ...................................................................... SIP_Templates: Allow passing Server field This field is used by an IMS core. Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc --- M library/SIP_Templates.ttcn 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/36797/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc Gerrit-Change-Number: 36797 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Always set Content-Length
by pespin 15 May '24

15 May '24

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SIP_Templates: Always set Content-Length ...................................................................... SIP_Templates: Always set Content-Length According to RFC3261 7.4.2, 7.5, 20.14 Content-Length SHOULD be set over any transport, and MUST be set over TCP. Hence, make sure we set it in all cases. This allows Asterisk being able to decode SIP messages sent to it over a TCP connection, since it uses the Content-Length field to look up for message boundaries over the TCP stream. Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf --- M library/SIP_Templates.ttcn 1 file changed, 68 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/36814/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf Gerrit-Change-Number: 36814 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Initial IMS registration
by pespin 15 May '24

15 May '24

Attention is currently required from: jolly, laforge, osmith, pespin. Hello Jenkins Builder, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: asterisk: Initial IMS registration ...................................................................... asterisk: Initial IMS registration This patch is a step towards testing IMS. So far only the code infrstrastructure to handle the 1st REGISTER (outside IPSEC) is provided. It can already be seen how Asterisk sends the second REGISTER over IPSEC, but there's no means to test it yet in TTCN-3. This will be done in a follow-up patch, which may take some work. Change-Id: Idb3b19ccd82cad25948106b2c72aa424d7f79cd8 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn M library/SIP_Templates.ttcn 3 files changed, 432 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/36759/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb3b19ccd82cad25948106b2c72aa424d7f79cd8 Gerrit-Change-Number: 36759 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Security_server field
by pespin 15 May '24

15 May '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36792?usp=email ) Change subject: SIP_Templates: Allow passing Security_server field ...................................................................... SIP_Templates: Allow passing Security_server field Change-Id: I7ee3d6dace39c784b0ec900d58a55421ac967269 --- M library/SIP_Templates.ttcn 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 7e33b3b..d35813e 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -476,6 +476,17 @@ sec_mechanism_list := sec_mechanism_list } +template (present) Security_server +tr_Security_server(template (present) Security_mechanism_list sec_mechanism_list := ?) := { + fieldName := SECURITY_SERVER_E, + sec_mechanism_list := sec_mechanism_list +} +template (value) Security_server +ts_Security_server(template (value) Security_mechanism_list sec_mechanism_list) := { + fieldName := SECURITY_SERVER_E, + sec_mechanism_list := sec_mechanism_list +} + template (present) Security_mechanism tr_Security_mechanism(template (present) charstring name := ?, template SemicolonParam_List params := *) := { @@ -504,6 +515,7 @@ template (omit) Expires expires := omit, template (omit) Require require := omit, template (omit) Security_client security_client := omit, + template (omit) Security_server security_server := omit, template (omit) Supported supported := omit, template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { @@ -531,6 +543,7 @@ }, require := require, security_client := security_client, + security_server := security_server, supported := supported, toField := { fieldName := TO_E, @@ -575,6 +588,7 @@ template Expires expires := *, template Require require := *, template Security_client security_client := *, + template Security_server security_server := *, template Supported supported := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { @@ -598,6 +612,7 @@ }, require := require, security_client := security_client, + security_server := security_server, supported := supported, toField := { fieldName := TO_E, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ee3d6dace39c784b0ec900d58a55421ac967269 Gerrit-Change-Number: 36792 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36800?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I853097a13e27b2ebd0b940117c8f5f4b3ea49b9a --- M debian/osmo-stp.postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/debian/osmo-stp.postinst b/debian/osmo-stp.postinst index bfcc1dc..3dbfd43 100755 --- a/debian/osmo-stp.postinst +++ b/debian/osmo-stp.postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-stp.cfg - chmod 0660 /etc/osmocom/osmo-stp.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.9.0"; then + if [ -e /etc/osmocom/osmo-stp.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-stp.cfg + chmod -v 0660 /etc/osmocom/osmo-stp.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I853097a13e27b2ebd0b940117c8f5f4b3ea49b9a Gerrit-Change-Number: 36800 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36807?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index 80821c4..46cd851 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-msc.cfg - chmod 0660 /etc/osmocom/osmo-msc.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.12.0"; then + if [ -e /etc/osmocom/osmo-msc.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-msc.cfg + chmod -v 0660 /etc/osmocom/osmo-msc.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 Gerrit-Change-Number: 36807 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-smlc[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/36810?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I8994759df644d6edd8f937051b95690537b749be --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index faecd26..6c99b1f 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-smlc.cfg - chmod 0660 /etc/osmocom/osmo-smlc.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "0.3.0"; then + if [ -e /etc/osmocom/osmo-smlc.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-smlc.cfg + chmod -v 0660 /etc/osmocom/osmo-smlc.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/36810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I8994759df644d6edd8f937051b95690537b749be Gerrit-Change-Number: 36810 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: debian/postinst: add checks, be verbose
by pespin 15 May '24

15 May '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36800?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I853097a13e27b2ebd0b940117c8f5f4b3ea49b9a Gerrit-Change-Number: 36800 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:47:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hlr[master]: debian/postinst: add checks, be verbose
by osmith 15 May '24

15 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/36804?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index 5dedec4..34fb79d 100755 --- a/debian/postinst +++ b/debian/postinst @@ -21,12 +21,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-hlr.cfg - chmod 0660 /etc/osmocom/osmo-hlr.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.8.0"; then + if [ -e /etc/osmocom/osmo-hlr.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-hlr.cfg + chmod -v 0660 /etc/osmocom/osmo-hlr.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/36804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f Gerrit-Change-Number: 36804 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: debian/postinst: add checks, be verbose
by pespin 15 May '24

15 May '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36807?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 Gerrit-Change-Number: 36807 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:47:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log