- gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix segfault on startup
by laforge 15 May '24

15 May '24

Attention is currently required from: Joey Berkovitz. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email ) Change subject: user_ifdhandler: Fix segfault on startup ...................................................................... Patch Set 1: (1 comment) File src/client/user_ifdhandler.c: https://gerrit.osmocom.org/c/osmo-remsim/+/36835/comment/c6824d93_206eb05a PS1, Line 374: ensure_osmo_ctx ensure_osmo_ctx() basically calls osmo_ctx_init() which is called just two lines below. Might it be that the existing code just needs to be re-ordered? Did you try the following: * not adding ensure_osmo_ctx * moving osmo_select_init below osmo_ctx_init Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 Gerrit-Change-Number: 36835 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-Comment-Date: Wed, 15 May 2024 14:55:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix segfault on startup
by Joey Berkovitz 15 May '24

15 May '24

Joey Berkovitz has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email ) Change subject: user_ifdhandler: Fix segfault on startup ...................................................................... user_ifdhandler: Fix segfault on startup Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 --- M src/client/user_ifdhandler.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/35/36835/1 diff --git a/src/client/user_ifdhandler.c b/src/client/user_ifdhandler.c index c6a9392..b9ddfb9 100644 --- a/src/client/user_ifdhandler.c +++ b/src/client/user_ifdhandler.c @@ -371,6 +371,7 @@ if (gethostname(hostname, sizeof(hostname)) < 0) OSMO_STRLCPY_ARRAY(hostname, "unknown"); + ensure_osmo_ctx(); osmo_select_init(); rc = osmo_ctx_init("client"); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923 Gerrit-Change-Number: 36835 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates...
by osmith 15 May '24

15 May '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email ) Change subject: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates.ttcn ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a5ededbd958c87537f84155092b6a6cd715865a Gerrit-Change-Number: 36832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 14:05:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: run ttcn3-msc-test earlier
by pespin 15 May '24

15 May '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email ) Change subject: jobs/ttcn3: run ttcn3-msc-test earlier ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7 Gerrit-Change-Number: 36834 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 13:33:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: KPI: Add initial set of DTAP message type rate counters
by osmith 15 May '24

15 May '24

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email ) Change subject: KPI: Add initial set of DTAP message type rate counters ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3e1ad7a2aa71674a22a27c31512600f2de139032 Gerrit-Change-Number: 36788 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 May 2024 13:17:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: run ttcn3-msc-test earlier
by osmith 15 May '24

15 May '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: jobs/ttcn3: run ttcn3-msc-test earlier ...................................................................... jobs/ttcn3: run ttcn3-msc-test earlier It seems like various tests are failing from time to time due to the builder having a too high load. As several ttcn3 testsuites run around 4 am already, move ttcn3-msc-test to 1 hour earlier where we don't have anything currently. Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7 --- M jobs/README.adoc M jobs/ttcn3-testsuites.yml 2 files changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/36834/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7 Gerrit-Change-Number: 36834 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: lint: do "docker run --rm" check only in jenkins
by osmith 15 May '24

15 May '24

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36833?usp=email ) Change subject: lint: do "docker run --rm" check only in jenkins ...................................................................... Abandoned submitted by accident, need to test more if this makes a difference -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I00a28a04b0fae8804846948a155c6214bf1aca00 Gerrit-Change-Number: 36833 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: run ttcn3-msc-test earlier
by osmith 15 May '24

15 May '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email ) Change subject: jobs/ttcn3: run ttcn3-msc-test earlier ...................................................................... jobs/ttcn3: run ttcn3-msc-test earlier It seems like various tests are failing from time to time due to the builder having a too high load. As several ttcn3 testsuites run around 4 am already, move ttcn3-msc-test to 1 hour earlier where we don't have anything currently. Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7 --- M jobs/README.adoc M jobs/ttcn3-testsuites.yml 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/36834/1 diff --git a/jobs/README.adoc b/jobs/README.adoc index eb14152..d403bff 100644 --- a/jobs/README.adoc +++ b/jobs/README.adoc @@ -139,7 +139,7 @@ 02:XX registry-triggers 02:XX registry-rebuild-upload-fpga-build (weekly) - 04:00 - 18:00 Jobs that need binary packages + 03:00 - 18:00 Jobs that need binary packages ttcn3-testsuites 04:XX osmocom-release-manuals 05:XX osmocom-release-tarballs diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index ac79f4d..8d17938 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -68,7 +68,7 @@ Test open5gs-smfd + open5gs-upfd main. email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - ttcn3-msc-test: - timer: H 04 * * * + timer: H 03 * * * - ttcn3-pcu-test: timer: H 04 * * * - ttcn3-pcu-test-sns: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7 Gerrit-Change-Number: 36834 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: lint: do "docker run --rm" check only in jenkins
by osmith 15 May '24

15 May '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36833?usp=email ) Change subject: lint: do "docker run --rm" check only in jenkins ...................................................................... lint: do "docker run --rm" check only in jenkins Change-Id: I00a28a04b0fae8804846948a155c6214bf1aca00 --- M jobs/gerrit-lint.yml M lint/lint_diff.sh 2 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/33/36833/1 diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index 3039829..62dc969 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -50,6 +50,7 @@ git -C osmo-ci log --oneline cd code-from-gerrit + export CHECK_DOCKER_RM=1 ../osmo-ci/lint/lint_diff.sh HEAD~1 wrappers: diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index 662bdd3..b8a84c4 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -21,10 +21,12 @@ ERROR=0 -echo "Running docker_run_rm.sh on the whole tree..." -echo -if ! "$SCRIPT_DIR"/docker_run_rm.sh; then - ERROR=1 +if [ "$CHECK_DOCKER_RM" = 1 ]; then + echo "Running docker_run_rm.sh on the whole tree..." + echo + if ! "$SCRIPT_DIR"/docker_run_rm.sh; then + ERROR=1 + fi fi echo "Running checkpatch on 'git diff $COMMIT'..." -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I00a28a04b0fae8804846948a155c6214bf1aca00 Gerrit-Change-Number: 36833 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates...
by pespin 15 May '24

15 May '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email ) Change subject: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates.ttcn ...................................................................... remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates.ttcn This way code can be used and extended for other testsuites. Change-Id: I4a5ededbd958c87537f84155092b6a6cd715865a --- A library/PIPEasp_Templates.ttcn M remsim/RemsimClient_Tests.ttcn M remsim/gen_links.sh 3 files changed, 41 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/36832/1 diff --git a/library/PIPEasp_Templates.ttcn b/library/PIPEasp_Templates.ttcn new file mode 100644 index 0000000..af4e434 --- /dev/null +++ b/library/PIPEasp_Templates.ttcn @@ -0,0 +1,27 @@ +module PIPEasp_Templates { + +import from PIPEasp_PortType all; +import from PIPEasp_Types all; + +template (value) ASP_PExecuteBackground ts_ExecBg(charstring cmd) := { + command := cmd +} + +template (present) ASP_PStdout tr_Stdout(template (present) charstring line) := { + stdout := line +} + +template (present) ASP_PStderr tr_Stderr(template (present) charstring line) := { + stderr := line +} + +template (value) ASP_PStdin ts_Stdin(template (value) charstring line) := { + stdin :=line +} + +/* Ignore output from stderr: */ +altstep as_ignore_stderr(PIPEasp_PT pt) { +[] pt.receive(tr_Stderr(?)) { repeat; } +} + +} diff --git a/remsim/RemsimClient_Tests.ttcn b/remsim/RemsimClient_Tests.ttcn index 219573c..d747eef 100644 --- a/remsim/RemsimClient_Tests.ttcn +++ b/remsim/RemsimClient_Tests.ttcn @@ -20,6 +20,7 @@ /* the PIPEasp port allows us to interact with osmo-remsim-client-shell via stdin/stdout */ import from PIPEasp_PortType all; import from PIPEasp_Types all; +import from PIPEasp_Templates all; import from RSPRO all; import from RSPRO_Types all; @@ -196,34 +197,13 @@ * Tests interacting with local remsim-bankd-client via PIPE port ***********************************************************************/ -template (value) ASP_PExecuteBackground ts_ExecBg(charstring cmd) := { - command := cmd -} - -template (present) ASP_PStdout tr_Stdout(template (present) charstring line) := { - stdout := line -} - -template (present) ASP_PStderr tr_Stderr(template (present) charstring line) := { - stderr := line -} - -template (value) ASP_PStdin ts_Stdin(template (value) charstring line) := { - stdin :=line -} - -/* osmo-remsim-client logs to stderr, so we need to ignore that log output */ -private altstep as_ignore_stderr() runs on client_test_CT { -[] PIPE.receive(tr_Stderr(?)) { repeat; } -} - /* start a local osmo-remsim-client as sub-process and attach it to PIPE port */ private function f_init_client_pipe(ClientSlot cs) runs on client_test_CT { var charstring cmdline := mp_client_shell_cmd & " -i 127.0.0.1"; map(self:PIPE, system:PIPE); PIPE.send(ts_ExecBg(cmdline & " -c " & int2str(cs.clientId) & " -n " & int2str(cs.slotNr))); - activate(as_ignore_stderr()); + activate(as_ignore_stderr(PIPE)); } /* pretty-print an octet string as series of ASCII encoded hex bytes with spaces */ diff --git a/remsim/gen_links.sh b/remsim/gen_links.sh index b25375b..615c550 100755 --- a/remsim/gen_links.sh +++ b/remsim/gen_links.sh @@ -39,6 +39,7 @@ DIR=../library FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_VTY_Functions.ttcn Osmocom_Types.ttcn " +FILES+="PIPEasp_Templates.ttcn " FILES+="IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp IPA_CodecPort.ttcn " #RSL_Types.ttcn RSL_Emulation.ttcn " FILES+="Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn " FILES+="Native_Functions.ttcn Native_FunctionDefs.cc " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a5ededbd958c87537f84155092b6a6cd715865a Gerrit-Change-Number: 36832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log