- gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Implement support to handle 2nd REGISTER through ipsec
by pespin 17 May '24

17 May '24

Attention is currently required from: jolly, laforge, osmith, pespin. Hello Jenkins Builder, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: asterisk: Implement support to handle 2nd REGISTER through ipsec ...................................................................... asterisk: Implement support to handle 2nd REGISTER through ipsec This patch implements the necessary infra to set up ipsec tunnel towards the asterisk IMS client, and receive the 2nd REGISTER through the ipsec tun plus answer it acking the registration successfully. Change-Id: Ic042422788ee406f5b71ca3878bc5617e5455579 --- M asterisk/Asterisk_Tests.cfg M asterisk/IMS_ConnectionHandler.ttcn A asterisk/IMS_ipsec_setup.sh M asterisk/gen_links.sh M asterisk/regen_makefile.sh M library/PIPEasp_Templates.ttcn M library/SIP_Templates.ttcn M sip/SIP_Tests.ttcn 8 files changed, 285 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36856/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic042422788ee406f5b71ca3878bc5617e5455579 Gerrit-Change-Number: 36856 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Fix missing ':' between URI scheme and host
by pespin 17 May '24

17 May '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36855?usp=email ) Change subject: SIP_Templates: Fix missing ':' between URI scheme and host ...................................................................... SIP_Templates: Fix missing ':' between URI scheme and host Change-Id: I5369db54901d50cf08d7ffc3e0d1cf3f5091e77b --- M library/SIP_Templates.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index ffd6f2b..37dee4b 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -1388,7 +1388,7 @@ } function f_sip_SipUrl_to_str(SipUrl uri) return charstring { - var charstring str := uri.scheme & f_sip_HostPort_to_str(uri.hostPort); + var charstring str := uri.scheme & ":" & f_sip_HostPort_to_str(uri.hostPort); return str; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5369db54901d50cf08d7ffc3e0d1cf3f5091e77b Gerrit-Change-Number: 36855 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk/expected-results.xml: Add missing TC_ims_registration
by pespin 17 May '24

17 May '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36852?usp=email ) Change subject: asterisk/expected-results.xml: Add missing TC_ims_registration ...................................................................... asterisk/expected-results.xml: Add missing TC_ims_registration Change-Id: Ie4f589a398f93b429a8b4a93da1b80784b4013ea --- M asterisk/expected-results.xml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/asterisk/expected-results.xml b/asterisk/expected-results.xml index 745a4d7..49f92bf 100644 --- a/asterisk/expected-results.xml +++ b/asterisk/expected-results.xml @@ -5,4 +5,5 @@ <testcase classname='Asterisk_Tests' name='TC_internal_call_all_2registered' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_internal_call_all_3registered' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_internal_call_all_4registered' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_registration' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4f589a398f93b429a8b4a93da1b80784b4013ea Gerrit-Change-Number: 36852 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: Log issue with packet dumper not properly sta...
by pespin 17 May '24

17 May '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36853?usp=email ) Change subject: ttcn3-tcpdump-start.sh: Log issue with packet dumper not properly started ...................................................................... ttcn3-tcpdump-start.sh: Log issue with packet dumper not properly started Change-Id: I50af5eb16a000c4f3585a3458f9130a349eff097 --- M ttcn3-tcpdump-start.sh 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index 36aa320..8564cd5 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -109,6 +109,7 @@ sleep 1 i=$((i+1)) if [ $i -eq 10 ]; then + echo "Packet dumper didn't start filling pcap file after $i seconds!!!" break fi done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36853?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50af5eb16a000c4f3585a3458f9130a349eff097 Gerrit-Change-Number: 36853 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk/AMI_Functions: Add workaround for empty 'Hint: ' field
by pespin 17 May '24

17 May '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36854?usp=email ) Change subject: asterisk/AMI_Functions: Add workaround for empty 'Hint: ' field ...................................................................... asterisk/AMI_Functions: Add workaround for empty 'Hint: ' field It sometimes shows up empty, let's skip it to avoid breaking the decoder for now, similar to what we do with other fields. Change-Id: I50fb51fab3755e4d63f3a0bc06d90b42814231d2 --- M asterisk/AMI_Functions.ttcn 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/asterisk/AMI_Functions.ttcn b/asterisk/AMI_Functions.ttcn index 1f3dc5e..c05403e 100644 --- a/asterisk/AMI_Functions.ttcn +++ b/asterisk/AMI_Functions.ttcn @@ -261,6 +261,7 @@ patched_txt := f_str_replace(patched_txt, "DestExten: \r\n", ""); patched_txt := f_str_replace(patched_txt, "Exten: \r\n", ""); patched_txt := f_str_replace(patched_txt, "Extension: \r\n", ""); + patched_txt := f_str_replace(patched_txt, "Hint: \r\n", ""); /* "AppData" field sometimes has a value containing separator ": ", which makes * TEXT dec not happy. Workaround it for now by removing the whole field line: -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36854?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50fb51fab3755e4d63f3a0bc06d90b42814231d2 Gerrit-Change-Number: 36854 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in simtrace2[master]: RFC: card emu config: add feature sim polarity
by lynxis lazus 17 May '24

17 May '24

Attention is currently required from: laforge. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36859?usp=email ) Change subject: RFC: card emu config: add feature sim polarity ...................................................................... Patch Set 1: Verified-1 (1 comment) Patchset: PS1: Only to review the protocol approach. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I36a8acb74ad7616205af68b1626b45ab79d7cb02 Gerrit-Change-Number: 36859 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 17 May 2024 12:27:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-*: install pylint from debian repos
by osmith 17 May '24

17 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36860?usp=email ) Change subject: debian-*: install pylint from debian repos ...................................................................... debian-*: install pylint from debian repos Get pylint from the debian repositories to be on the same version until we use the next debian version, instead of always installing the latest pylint version from pip. Change-Id: I721db1c18db43cc7a2d38177e9846c43dbdd0ae3 --- M debian-bookworm-build/Dockerfile M debian-bullseye-jenkins/Dockerfile M debian-buster-jenkins/Dockerfile 3 files changed, 16 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Verified Jenkins Builder: Verified lynxis lazus: Looks good to me, but someone else must approve diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index d847bf1..edca2d7 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -142,6 +142,7 @@ patchelf \ picolibc-arm-none-eabi \ pkg-config \ + pylint \ python3 \ python3-gi \ python3-mako \ @@ -179,7 +180,6 @@ 'git+https://github.com/osmocom/sphinx-argparse@master#egg=sphinx-argparse' \ 'git+https://github.com/podshumok/python-smpplib.git' \ 'pydbus' \ - 'pylint' \ 'pysispm' \ 'sphinx' \ 'sphinxcontrib-napoleon' \ diff --git a/debian-bullseye-jenkins/Dockerfile b/debian-bullseye-jenkins/Dockerfile index 3c186cc..5132c0a 100644 --- a/debian-bullseye-jenkins/Dockerfile +++ b/debian-bullseye-jenkins/Dockerfile @@ -107,6 +107,7 @@ patchelf \ picolibc-arm-none-eabi \ pkg-config \ + pylint \ python-setuptools \ python2.7 \ python3 \ @@ -148,7 +149,6 @@ 'git+https://github.com/osmocom/sphinx-argparse@master#egg=sphinx-argparse' \ 'git+https://github.com/podshumok/python-smpplib.git' \ 'pydbus' \ - 'pylint' \ 'pysispm' \ 'sphinx' \ 'sphinxcontrib-napoleon' \ diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index cf443f0..baa5931 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -104,6 +104,7 @@ osc \ patchelf \ pkg-config \ + pylint \ python-pip \ python-setuptools \ python-yaml \ @@ -147,7 +148,6 @@ 'git+https://github.com/osmocom/sphinx-argparse@master#egg=sphinx-argparse' \ 'git+https://github.com/podshumok/python-smpplib.git' \ 'pydbus' \ - 'pylint' \ 'pysispm' \ 'sphinx' \ 'sphinxcontrib-napoleon' \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I721db1c18db43cc7a2d38177e9846c43dbdd0ae3 Gerrit-Change-Number: 36860 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: debian-*: install pylint from debian repos
by fixeria 17 May '24

17 May '24

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36860?usp=email ) Change subject: debian-*: install pylint from debian repos ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I721db1c18db43cc7a2d38177e9846c43dbdd0ae3 Gerrit-Change-Number: 36860 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 May 2024 10:41:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-*: install pylint from debian repos
by lynxis lazus 17 May '24

17 May '24

Attention is currently required from: osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36860?usp=email ) Change subject: debian-*: install pylint from debian repos ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I721db1c18db43cc7a2d38177e9846c43dbdd0ae3 Gerrit-Change-Number: 36860 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 May 2024 10:02:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-*: install pylint from debian repos
by osmith 17 May '24

17 May '24

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36860?usp=email ) Change subject: debian-*: install pylint from debian repos ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: tested that it works -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I721db1c18db43cc7a2d38177e9846c43dbdd0ae3 Gerrit-Change-Number: 36860 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 17 May 2024 09:56:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log