- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: remove template/code dup
by laforge 23 May '24

23 May '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36918?usp=email ) Change subject: RSPDefinitions_Templates: remove template/code dup ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2dca9500572141642cc76ecacb3b2a6ed2cbfaad Gerrit-Change-Number: 36918 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:29:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add iccid to ts_profileInstallationResultData
by laforge 23 May '24

23 May '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36917?usp=email ) Change subject: RSPDefinitions_Templates: add iccid to ts_profileInstallationResultData ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7f16b490aadf17cb56eaa42a75d99cc781488a2e Gerrit-Change-Number: 36917 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:29:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: put EimConfigurationData into separate te...
by laforge 23 May '24

23 May '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36916?usp=email ) Change subject: SGP32Definitions_Templates: put EimConfigurationData into separate template ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id953bf286a6402528a6d3f82f73bb78538fe90cf Gerrit-Change-Number: 36916 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:29:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add templates for eCOs
by dexter 23 May '24

23 May '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36919?usp=email ) Change subject: SGP32Definitions_Templates: add templates for eCOs ...................................................................... SGP32Definitions_Templates: add templates for eCOs We do not have any templates for eCOs yet. This patch adds templates for all currently specified eCOs. Related: SYS#6824 Change-Id: I15d6a036b77c329e30a6f7323d511f8071683ec0 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 224 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/36919/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index b1b946f..709a58f 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -408,6 +408,72 @@ } } } +template (present) EuiccPackage +tr_euiccPackage_addEim := { + ecoList := { + { + addEim := tr_eimConfigurationData + } + } +} +template (value) EuiccPackage +ts_euiccPackage_addEim := { + ecoList := { + { + addEim := ts_eimConfigurationData + } + } +} +template (present) EuiccPackage +tr_euiccPackage_deleteEim := { + ecoList := { + { + deleteEim := ? + } + } +} +template (value) EuiccPackage +ts_euiccPackage_deleteEim := { + ecoList := { + { + deleteEim := { + eimId := "eIM" + } + } + } +} +template (present) EuiccPackage +tr_euiccPackage_updateEim := { + ecoList := { + { + updateEim := tr_eimConfigurationData + } + } +} +template (value) EuiccPackage +ts_euiccPackage_updateEim := { + ecoList := { + { + updateEim := ts_eimConfigurationData + } + } +} +template (present) EuiccPackage +tr_euiccPackage_listEim := { + ecoList := { + { + listEim := { } + } + } +} +template (value) EuiccPackage +ts_euiccPackage_listEim := { + ecoList := { + { + listEim := { } + } + } +} /* GSMA SGP.32, section 6.3.2.6 */ template (present) EsipaMessageFromEimToIpa @@ -851,6 +917,151 @@ euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O } } +template (present) EuiccPackageResult +tr_euiccPackageResultSigned_addEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := ?, + counterValue := ?, + transactionId := *, + seqNumber := ?, + euiccResult := { + { + addEimResult := ? + } + } + }, + euiccSignEPR := ? + } +} +template (value) EuiccPackageResult +ts_euiccPackageResultSigned_addEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEIM", + counterValue := 1, + transactionId := omit, + seqNumber := 123, + euiccResult := { + { + addEimResult := { + addEimResultCode := 0 + } + } + } + }, + euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O + } +} +template (present) EuiccPackageResult +tr_euiccPackageResultSigned_deleteEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := ?, + counterValue := ?, + transactionId := *, + seqNumber := ?, + euiccResult := { + { + deleteEimResult := ? + } + } + }, + euiccSignEPR := ? + } +} +template (value) EuiccPackageResult +ts_euiccPackageResultSigned_deleteEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEIM", + counterValue := 1, + transactionId := omit, + seqNumber := 123, + euiccResult := { + { + deleteEimResult := 0 + } + } + }, + euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O + } +} +template (present) EuiccPackageResult +tr_euiccPackageResultSigned_updateEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := ?, + counterValue := ?, + transactionId := *, + seqNumber := ?, + euiccResult := { + { + updateEimResult := ? + } + } + }, + euiccSignEPR := ? + } +} +template (value) EuiccPackageResult +ts_euiccPackageResultSigned_updateEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEIM", + counterValue := 1, + transactionId := omit, + seqNumber := 123, + euiccResult := { + { + updateEimResult := 0 + } + } + }, + euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O + } +} +template (present) EuiccPackageResult +tr_euiccPackageResultSigned_listEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := ?, + counterValue := ?, + transactionId := *, + seqNumber := ?, + euiccResult := { + { + listEimResult := ? + } + } + }, + euiccSignEPR := ? + } +} +template (value) EuiccPackageResult +ts_euiccPackageResultSigned_listEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEIM", + counterValue := 1, + transactionId := omit, + seqNumber := 123, + euiccResult := { + { + listEimResult := { + eimIdList := { + { + eimId := "eIM", + eimIdType := omit + } + } + } + } + } + }, + euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O + } +} template (present) EsipaMessageFromIpaToEim tr_provideEimPackageResult_ePRAndNotif(template (present) EuiccPackageResult euiccPackageResult := tr_euiccPackageResultSigned_enablePsmo) := { provideEimPackageResult := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I15d6a036b77c329e30a6f7323d511f8071683ec0 Gerrit-Change-Number: 36919 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: put EimConfigurationData into separate te...
by dexter 23 May '24

23 May '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36916?usp=email ) Change subject: SGP32Definitions_Templates: put EimConfigurationData into separate template ...................................................................... SGP32Definitions_Templates: put EimConfigurationData into separate template We currently have the EimConfigurationData enclosed in ts_getEimConfigurationDataResponse. This is mainly a list of with one EimConfigurationData record, so it is useful to have the EimConfigurationData in a dedicated template, so that we can use it in other places too. Related: SYS#6824 Change-Id: Id953bf286a6402528a6d3f82f73bb78538fe90cf --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 41 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/36916/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index d18fee4..b1b946f 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -902,6 +902,30 @@ } /* GSMA SGP.32, section 5.9.18 */ +template (present) EimConfigurationData +tr_eimConfigurationData := { + eimId := ?, + eimFqdn := *, + eimIdType := *, + counterValue := *, + associationToken := *, + eimPublicKeyData := *, + trustedPublicKeyDataTls := *, + eimSupportedProtocol := *, + euiccCiPKId := * +} +template (value) EimConfigurationData +ts_eimConfigurationData(template (omit) charstring eimFqdn := omit) := { + eimId := "myEIM", + eimFqdn := eimFqdn, + eimIdType := omit, + counterValue := omit, + associationToken := 123, + eimPublicKeyData := omit, + trustedPublicKeyDataTls := omit, + eimSupportedProtocol := omit, + euiccCiPKId := omit +} template (present) GetEimConfigurationDataResponse tr_getEimConfigurationDataResponse := { eimConfigurationDataList := ? @@ -909,17 +933,7 @@ template (value) GetEimConfigurationDataResponse ts_getEimConfigurationDataResponse(template (value) charstring eimFqdn := "127.0.0.1") := { eimConfigurationDataList := { - { - eimId := "myEIM", - eimFqdn := eimFqdn, - eimIdType := omit, - counterValue := omit, - associationToken := 123, - eimPublicKeyData := omit, - trustedPublicKeyDataTls := omit, - eimSupportedProtocol := omit, - euiccCiPKId := omit - } + ts_eimConfigurationData(eimFqdn) } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id953bf286a6402528a6d3f82f73bb78538fe90cf Gerrit-Change-Number: 36916 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add iccid to ts_profileInstallationResultData
by dexter 23 May '24

23 May '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36917?usp=email ) Change subject: RSPDefinitions_Templates: add iccid to ts_profileInstallationResultData ...................................................................... RSPDefinitions_Templates: add iccid to ts_profileInstallationResultData In the context of the ProfileInstallationResultData the iccid plays a major role as profile identifier, so we should not omit it in ts_profileInstallationResultData. Related: SYS#6824 Change-Id: I7f16b490aadf17cb56eaa42a75d99cc781488a2e --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/36917/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index fc87ff6..0746c48 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -229,7 +229,7 @@ seqNumber := 1234, profileManagementOperation := '01'B, /* is this correct? (notificationInstall) */ notificationAddress := "smdp.example.com", - iccid := omit + iccid := '123456789ABCDEFFAAAA'O }, smdpOid := id_rsp, /* random OBJECT IDENTIFIER for testing */ finalResult := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7f16b490aadf17cb56eaa42a75d99cc781488a2e Gerrit-Change-Number: 36917 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: remove template/code dup
by dexter 23 May '24

23 May '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36918?usp=email ) Change subject: RSPDefinitions_Templates: remove template/code dup ...................................................................... RSPDefinitions_Templates: remove template/code dup We can use ts_profileInstallationResultData in ts_retrieveNotificationsListResponse. Related: SYS#6824 Change-Id: I2dca9500572141642cc76ecacb3b2a6ed2cbfaad --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 14 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/36918/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 0746c48..4791cf5 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -563,22 +563,7 @@ notificationList := { { profileInstallationResult := { - profileInstallationResultData := { - transactionId := 'AABBCC'O, - notificationMetadata := { - seqNumber := 1234, - profileManagementOperation := '01'B, /* is this correct? (notificationInstall) */ - notificationAddress := "smdp.example.com", - iccid := omit - }, - smdpOid := id_rsp, /* random OBJECT IDENTIFIER for testing */ - finalResult := { - successResult := { - aid := 'A0000005591010FFFFFFFF8900000D00'O, - simaResponse := 'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'O - } - } - }, + profileInstallationResultData := ts_profileInstallationResultData, euiccSignPIR := 'BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB'O } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2dca9500572141642cc76ecacb3b2a6ed2cbfaad Gerrit-Change-Number: 36918 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[XL] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft
by pespin 23 May '24

23 May '24

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 12: (2 comments) File src/osmo-hnbgw/nft_kpi.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/a38b7429_18820cce PS12, Line 685: prev_starts_ts = now(); https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/285e7b62_d738b606 PS12, Line 694: unsigned long period_us = osmo_tdef_get(hnbgw_T_defs, -34, OSMO_TDEF_US, 1000000); elasped = now() - prev_start_ts; if (elapsed > period_us sched_us = 0; else sched_us = period_us - elasped; osmo_timer_schedule( ... , sched_us). -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2f0a9252715ea4b2fe9c367aa65f771357768ca Gerrit-Change-Number: 36539 Gerrit-PatchSet: 12 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 May 2024 12:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft
by pespin 23 May '24

23 May '24

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 12: (8 comments) File include/osmocom/hnbgw/hnbgw.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/6665b6ba_668798f4 PS6, Line 402: struct { > yes i mean that too. […] Done File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/7411b3df_81f63be8 PS6, Line 571: hnb_persistent_connected(ctx->persistent); > yes, but a hnb can be connected without being registered. (that is for a different redmine ticket) […] It really depends on the specific event you want to track here. I would only use the "connected/disconnected" wording for SCTP/TCP layer here. If you are actually tracking the registered state, then I'd for for "registered" or "active" or alike. Up to you. File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/8d040060_34f92616 PS9, Line 894: vty_out(vty, "%% WARNING: nft configuration changes need a restart of osmo-hnbw%s", VTY_NEWLINE); > hey! i fixed that! Done File src/osmo-hnbgw/nft_kpi.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/c0bb0fc3_540b6ff2 PS6, Line 193: static const char * const nft_thread_req_type_name[] = { > i want to avoid iteration ala value_string, because all callers are entirely constants within this . […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/77d602fc_5b43f7d4 PS6, Line 415: static int update_ctr(struct rate_ctr_group *cg, int cgidx, uint64_t *last_val, uint64_t new_val) > kk Done File src/osmo-hnbgw/nft_kpi.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/cbf89028_0749936e PS9, Line 626: /* From here on, until we receive the next NFT_THREAD_GET_COUNTERS in this thread, the > if ever the time it takes to retrieve counters does overlap the wait time configured in timer X34, t […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/ee81f850_2fa5823b PS9, Line 700: osmo_timer_setup(&g_hnbgw->nft_kpi.get_counters_timer, nft_kpi_get_counters_cb, NULL); > possible idea for the future: keep interval tracking at the worker, use osmo_timerfd_*() here, this […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/bba5ff67_9b66038e PS9, Line 994: nft_kpi_get_counters_schedule(); > i believe this was the result of our discussion: to wait X34 time *between* getting counters. […] I really think we want to at least do as I described, which is really quick to implement (adding one "prev" timestamp and one timestmap subtraction). This way logic conforms much more to what user would expect: If I configure X34 to 10000, I get updated counters every 10 seconds, not every 10+X seconds. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2f0a9252715ea4b2fe9c367aa65f771357768ca Gerrit-Change-Number: 36539 Gerrit-PatchSet: 12 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 May 2024 12:24:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: refactor prim management in tx_tch[fh]_fn()
by fixeria 23 May '24

23 May '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: trxcon/l1sched: refactor prim management in tx_tch[fh]_fn() ...................................................................... trxcon/l1sched: refactor prim management in tx_tch[fh]_fn() This change significantly reduces the number of goto statements in these two functions and makes them easier to read/follow. Change-Id: I5292abf6fcd308c9f7f12c7145d004103c9c7675 --- M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c 2 files changed, 82 insertions(+), 69 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/15/36915/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5292abf6fcd308c9f7f12c7145d004103c9c7675 Gerrit-Change-Number: 36915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log