- gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: fix update_exp: s/soft_uart.ok/soft_uart_test.ok
by neels 23 May '24

23 May '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36909?usp=email ) Change subject: fix update_exp: s/soft_uart.ok/soft_uart_test.ok ...................................................................... fix update_exp: s/soft_uart.ok/soft_uart_test.ok Change-Id: I2fb70b684978fa8a591d1d9e3cace919d590d1ef --- M tests/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index 3b4325e..58900d3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -727,7 +727,7 @@ >$(srcdir)/osmo_io/osmo_io_test.ok \ 2>$(srcdir)/osmo_io/osmo_io_test.err soft_uart/soft_uart_test \ - >$(srcdir)/soft_uart/soft_uart.ok + >$(srcdir)/soft_uart/soft_uart_test.ok rlp/rlp_test \ >$(srcdir)/rlp/rlp_test.ok \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2fb70b684978fa8a591d1d9e3cace919d590d1ef Gerrit-Change-Number: 36909 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in libosmocore[master]: add jhash.h, copied from linux/jhash.h
by neels 23 May '24

23 May '24

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email ) Change subject: add jhash.h, copied from linux/jhash.h ...................................................................... Patch Set 2: (1 comment) File include/osmocom/core/jhash.h: https://gerrit.osmocom.org/c/libosmocore/+/36913/comment/853af856_7a60341d PS1, Line 100: c += osmo_load32le(k + 8); > RFC, I am uncertain here: […] (actually this also assumes a little-endian CPU. not that it matters much, since who cares which way around the hash is populated.) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0c9652bbc9e2a18b1200e7d63bb6f64ded7d75fa Gerrit-Change-Number: 36913 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 May 2024 14:52:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: add jhash.h, copied from linux/jhash.h
by neels 23 May '24

23 May '24

Attention is currently required from: laforge. Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by laforge Change subject: add jhash.h, copied from linux/jhash.h ...................................................................... add jhash.h, copied from linux/jhash.h Allow using arbitrary length data as hashtable key: Copy jhash.h implementation from the linux kernel. Apply osmo_ prefix to all global symbols. Add jhash_test to ensure the code import works as intended. First application will be a hashtable keyed by umts_cell_id in osmo-hnbgw.git. Related: SYS#6773 Change-Id: I0c9652bbc9e2a18b1200e7d63bb6f64ded7d75fa --- M include/osmocom/core/Makefile.am A include/osmocom/core/jhash.h M tests/Makefile.am A tests/jhash/jhash_test.c A tests/jhash/jhash_test.ok M tests/testsuite.at 6 files changed, 304 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/36913/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0c9652bbc9e2a18b1200e7d63bb6f64ded7d75fa Gerrit-Change-Number: 36913 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in libosmocore[master]: add jhash.h, copied from linux/jhash.h
by neels 23 May '24

23 May '24

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email ) Change subject: add jhash.h, copied from linux/jhash.h ...................................................................... Patch Set 1: (1 comment) File include/osmocom/core/jhash.h: https://gerrit.osmocom.org/c/libosmocore/+/36913/comment/64140e98_c7e682b4 PS1, Line 100: c += osmo_load32le(k + 8); RFC, I am uncertain here: These calls were originally __get_unaligned_cpu32(). osmo_load32le() might be a suboptimal implementation. Any opinions / insights? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0c9652bbc9e2a18b1200e7d63bb6f64ded7d75fa Gerrit-Change-Number: 36913 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 May 2024 14:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-trace.py: Resolve possible variable use before assignment
by laforge 23 May '24

23 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36904?usp=email ) Change subject: pySim-trace.py: Resolve possible variable use before assignment ...................................................................... pySim-trace.py: Resolve possible variable use before assignment pySim-trace.py:198:27: E0606: Possibly using variable 's' before assignment (possibly-used-before-assignment) Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935 --- M pySim-trace.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim-trace.py b/pySim-trace.py index be1d40b..165e338 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -194,6 +194,8 @@ s = PysharkRsproLive(opts.interface) elif opts.source == 'gsmtap-pyshark-pcap': s = PysharkGsmtapPcap(opts.pcap_file) + else: + raise ValueError("unsupported source %s", opts.source) tracer = Tracer(source=s, suppress_status=opts.suppress_status, suppress_select=opts.suppress_select, show_raw_apdu=opts.show_raw_apdu) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935 Gerrit-Change-Number: 36904 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: osmo-smdpp.py: Resolve possible variable use before assignment
by laforge 23 May '24

23 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36902?usp=email ) Change subject: osmo-smdpp.py: Resolve possible variable use before assignment ...................................................................... osmo-smdpp.py: Resolve possible variable use before assignment osmo-smdpp.py:374:72: E0601: Using variable 'iccid_str' before assignment (used-before-assignment) Let's raise an exception in the erroneous case. Change-Id: I01b308226e12f91699b1b5c6bb06f853be47e185 --- M osmo-smdpp.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 1f4311d..3dc6131 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -368,6 +368,9 @@ pes = saip.ProfileElementSequence.from_der(f.read()) iccid_str = b2h(pes.get_pe_for_type('header').decoded['iccid']) + # make pylint happy: E0601: Using variable 'iccid_str' before assignment (used-before-assignment) + assert iccid_str + # FIXME: we actually want to perform the profile binding herr, and read the profile metadat from the profile # Put together profileMetadata + _bin -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01b308226e12f91699b1b5c6bb06f853be47e185 Gerrit-Change-Number: 36902 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: pySim-prog.py: Resolve possible variable use before assignment
by laforge 23 May '24

23 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36903?usp=email ) Change subject: pySim-prog.py: Resolve possible variable use before assignment ...................................................................... pySim-prog.py: Resolve possible variable use before assignment pySim-prog.py:741:7: E0606: Possibly using variable 'cp' before assignment (possibly-used-before-assignment) Change-Id: I6ab307db378d2ca76dfeae53dc3befa7c103974d --- M pySim-prog.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim-prog.py b/pySim-prog.py index 3f506de..db9c327 100755 --- a/pySim-prog.py +++ b/pySim-prog.py @@ -723,6 +723,7 @@ card.erase() card.reset() + cp = None # Generate parameters if opts.source == 'cmdline': cp = gen_parameters(opts) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6ab307db378d2ca76dfeae53dc3befa7c103974d Gerrit-Change-Number: 36903 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: euicc: clarify which eUICCs are supported
by laforge 23 May '24

23 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36837?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: euicc: clarify which eUICCs are supported ...................................................................... euicc: clarify which eUICCs are supported We currently do not support M2M eUICC Change-Id: I3deb9f181075411484158471012ed449c83028fa --- M pySim/euicc.py 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: lynxis lazus: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/euicc.py b/pySim/euicc.py index 7f4cdda..1683cac 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -1,9 +1,11 @@ # -*- coding: utf-8 -*- """ -Various definitions related to GSMA eSIM / eUICC +Various definitions related to GSMA consumer + IoT eSIM / eUICC -Related Specs: GSMA SGP.22, GSMA SGP.02, etc. +Does *not* implement anything related to M2M eUICC + +Related Specs: GSMA SGP.21, SGP.22, SGP.31, SGP32 """ # Copyright (C) 2023 Harald Welte <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3deb9f181075411484158471012ed449c83028fa Gerrit-Change-Number: 36837 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: sysmocom_sjs2: Make sure 'Const' is imported
by laforge 23 May '24

23 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36838?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: sysmocom_sjs2: Make sure 'Const' is imported ...................................................................... sysmocom_sjs2: Make sure 'Const' is imported File "/crypt/space/home/laforge/projects/git/pysim/pySim/sysmocom_sja2.py", line 180, in __init__ self._construct = Struct(Const(b'\x82'), 'time_unit'/self.TimeUnit, 'value'/Int8ub, ^^^^^ NameError: name 'Const' is not defined Change-Id: If34a48e349680ef84e68a4a1a19dde536ecda0e6 --- M pySim/sysmocom_sja2.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/sysmocom_sja2.py b/pySim/sysmocom_sja2.py index dd876aa..97de5a5 100644 --- a/pySim/sysmocom_sja2.py +++ b/pySim/sysmocom_sja2.py @@ -19,7 +19,7 @@ from struct import unpack from construct import FlagsEnum, Byte, Struct, Int8ub, Bytes, Mapping, Enum, Padding, BitsInteger -from construct import Bit, this, Int32ub, Int16ub, Nibble, BytesInteger, GreedyRange +from construct import Bit, this, Int32ub, Int16ub, Nibble, BytesInteger, GreedyRange, Const from construct import Optional as COptional from pySim.utils import * -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If34a48e349680ef84e68a4a1a19dde536ecda0e6 Gerrit-Change-Number: 36838 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: commands.py: Resolve possible variable use before assignment
by laforge 23 May '24

23 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36900?usp=email ) Change subject: commands.py: Resolve possible variable use before assignment ...................................................................... commands.py: Resolve possible variable use before assignment pySim/commands.py:608:39: E0606: Possibly using variable 'p2' before assignment (possibly-used-before-assignment) Let's raise an exception in the erroneous case. Change-Id: I23adf2e89aa8a13246cc20ef022c84f0113eb2cd --- M pySim/commands.py 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/commands.py b/pySim/commands.py index 08537bd..7b21faf 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -606,6 +606,8 @@ p2 = '81' elif context == 'gsm': p2 = '80' + else: + raise ValueError("Unsupported context '%s'" % context) (data, sw) = self.send_apdu_constr_checksw( self.cla_byte, '88', '00', p2, AuthCmd3G, cmd_data, AuthResp3G) if 'auts' in data: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I23adf2e89aa8a13246cc20ef022c84f0113eb2cd Gerrit-Change-Number: 36900 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log