- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use associationToken in addEimResult
by laforge 24 May '24

24 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email ) Change subject: SGP32Definitions_Templates: use associationToken in addEimResult ...................................................................... SGP32Definitions_Templates: use associationToken in addEimResult When an eIM is added, the eUICC usually computes an associationToken, so it will be the common case that an associationToken is sent back to the eIM. Related: SYS#6824 Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 709a58f..87ef86d 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -945,7 +945,7 @@ euiccResult := { { addEimResult := { - addEimResultCode := 0 + associationToken := 123 } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f Gerrit-Change-Number: 36922 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: fill in some realistic data into listProf...
by laforge 24 May '24

24 May '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email ) Change subject: SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult ...................................................................... SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult The listProfileInfoResult/profileInfoListOk currently onl has the profileName field populated, let's fill in some basic profile info to be more realistic. Related: SYS#6824 Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 87ef86d..98846c5 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -814,15 +814,15 @@ listProfileInfoResult := { profileInfoListOk := { { - iccid := omit, + iccid := '123456789ABCDEFFAAAA'O, isdpAid := omit, - profileState := omit, + profileState := 1, /* enabled */ profileNickname := omit, serviceProviderName := omit, profileName := "testme", iconType := omit, icon := omit, - profileClass := omit, + profileClass := 2, /* operational */ notificationConfigurationInfo := omit, profileOwner := omit, dpProprietaryData := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 Gerrit-Change-Number: 36923 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: fill in some realistic data into listProf...
by laforge 24 May '24

24 May '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email ) Change subject: SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 Gerrit-Change-Number: 36923 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 May 2024 20:21:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use associationToken in addEimResult
by laforge 24 May '24

24 May '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email ) Change subject: SGP32Definitions_Templates: use associationToken in addEimResult ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f Gerrit-Change-Number: 36922 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 May 2024 20:21:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: fill in some realistic data into listProf...
by dexter 24 May '24

24 May '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email ) Change subject: SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult ...................................................................... SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult The listProfileInfoResult/profileInfoListOk currently onl has the profileName field populated, let's fill in some basic profile info to be more realistic. Related: SYS#6824 Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/36923/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 87ef86d..98846c5 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -814,15 +814,15 @@ listProfileInfoResult := { profileInfoListOk := { { - iccid := omit, + iccid := '123456789ABCDEFFAAAA'O, isdpAid := omit, - profileState := omit, + profileState := 1, /* enabled */ profileNickname := omit, serviceProviderName := omit, profileName := "testme", iconType := omit, icon := omit, - profileClass := omit, + profileClass := 2, /* operational */ notificationConfigurationInfo := omit, profileOwner := omit, dpProprietaryData := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 Gerrit-Change-Number: 36923 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use associationToken in addEimResult
by dexter 24 May '24

24 May '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email ) Change subject: SGP32Definitions_Templates: use associationToken in addEimResult ...................................................................... SGP32Definitions_Templates: use associationToken in addEimResult When an eIM is added, the eUICC usually computes an associationToken, so it will be the common case that an associationToken is sent back to the eIM. Related: SYS#6824 Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/36922/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 709a58f..87ef86d 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -945,7 +945,7 @@ euiccResult := { { addEimResult := { - addEimResultCode := 0 + associationToken := 123 } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f Gerrit-Change-Number: 36922 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pcsc: don't assume opts.pcsc_shared is present
by osmith 24 May '24

24 May '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36921?usp=email ) Change subject: pcsc: don't assume opts.pcsc_shared is present ...................................................................... pcsc: don't assume opts.pcsc_shared is present Fixes running contrib/sim-rest-server.py: builtins.AttributeError: 'Namespace' object has no attribute 'pcsc_shared' Change-Id: I864f65849c5d43cf7c73e60f1935afdf4273f696 --- M pySim/transport/pcsc.py 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/36921/1 diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index 9198816..8a1e03c 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -57,7 +57,7 @@ raise ReaderError('No matching reader found for regex %s' % opts.pcsc_regex) self._con = self._reader.createConnection() - if not opts.pcsc_shared: + if not getattr(opts, "pcsc_shared", False): self._con = ExclusiveConnectCardConnection(self._con) def __del__(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I864f65849c5d43cf7c73e60f1935afdf4273f696 Gerrit-Change-Number: 36921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: contrib/sim-rest-client: don't crash without args
by osmith 24 May '24

24 May '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36920?usp=email ) Change subject: contrib/sim-rest-client: don't crash without args ...................................................................... contrib/sim-rest-client: don't crash without args When running without an argument, let argparse print a nice usage error: $ ./sim-rest-client.py usage: sim-rest-client.py [-h] [-H HOST] [-p PORT] [-v] [-n SLOT_NR] {auth,info} ... sim-rest-client.py: error: the following arguments are required: {auth,info} Instead of: $ ./sim-rest-client.py Traceback (most recent call last): File "/usr/share/pysim/contrib/./sim-rest-client.py", line 185, in <module> main(sys.argv) File "/usr/share/pysim/contrib/./sim-rest-client.py", line 181, in main args.func(args) ^^^^^^^^^ AttributeError: 'Namespace' object has no attribute 'func' Change-Id: I92998d9b94dcfb9dcfc3da161fe5d8f45f242b78 --- M contrib/sim-rest-client.py 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/20/36920/1 diff --git a/contrib/sim-rest-client.py b/contrib/sim-rest-client.py index 7da2363..a9fabb8 100755 --- a/contrib/sim-rest-client.py +++ b/contrib/sim-rest-client.py @@ -162,6 +162,7 @@ parser.add_argument("-v", "--verbose", help="increase output verbosity", action='count', default=0) parser.add_argument("-n", "--slot-nr", help="SIM slot number", type=int, default=0) subp = parser.add_subparsers() + subp.required = True auth_p = subp.add_parser('auth', help='UMTS AKA Authentication') auth_p.add_argument("-c", "--count", help="Auth count", type=int, default=10) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I92998d9b94dcfb9dcfc3da161fe5d8f45f242b78 Gerrit-Change-Number: 36920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by nt2mku 23 May '24

23 May '24

Attention is currently required from: neels, nt2mku. Hello Jenkins Builder, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR or GSM-HR (v1) only and CTM text telephony is not supported, omit octet 3a. Ref: 3GPP TS 24.008, section 10.5.4.5.1. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c M tests/gsm0408/gsm0408_test.c 2 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 5 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by nt2mku 23 May '24

23 May '24

Attention is currently required from: neels, nt2mku. Hello Jenkins Builder, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR or GSM-HR (v1) only and CTM text telephony is not supported, omit octet 3a. Ref: 3GPP TS 24.008, section 10.5.4.5.1. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 4 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log