- gerrit-log - lists.osmocom.org

[M] Change in openbsc[master]: tests: adjust to osmotestconfig no copytree change
by osmith 29 May '24

29 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email ) Change subject: tests: adjust to osmotestconfig no copytree change ...................................................................... tests: adjust to osmotestconfig no copytree change openbsc/doc/examples/osmo-bsc_nat/osmo-bsc-nat.cfg references a bscs.config in the same directory. With a recent change in osmotestconfig.py, the file does not get copied anymore to the test directory. Copying additional files around caused problems when running osmotestconfig.py during 'make distcheck'. (openbsc didn't run into these issues because we don't run the vty-tests in 'make distcheck'.) Make the test pass by running it on a copy of the config without: nat bscs-config-file bscs.config Related: osmo-python-tests Ic312d546da1c21f68a80b6a188616ef9bc84f4c6 Change-Id: Ice759b2205308ffb827293256eb1c0de9ac67edd --- M openbsc/osmoappdesc.py A openbsc/tests/osmo-bsc-nat.cfg 2 files changed, 89 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified neels: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/openbsc/osmoappdesc.py b/openbsc/osmoappdesc.py index ba3ccf9..8fee080 100644 --- a/openbsc/osmoappdesc.py +++ b/openbsc/osmoappdesc.py @@ -29,7 +29,7 @@ app_configs = { "osmo-bsc-sccplite": ["doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg"], - "nat": ["doc/examples/osmo-bsc_nat/osmo-bsc-nat.cfg"], + "nat": ["tests/osmo-bsc-nat.cfg"], "mgcp": ["doc/examples/osmo-bsc_mgcp/osmo-bsc-mgcp.cfg"], "nitb": ["doc/examples/osmo-nitb/nanobts/openbsc-multitrx.cfg", "doc/examples/osmo-nitb/nanobts/osmo-nitb.cfg"], diff --git a/openbsc/tests/osmo-bsc-nat.cfg b/openbsc/tests/osmo-bsc-nat.cfg new file mode 100644 index 0000000..4b0f266 --- /dev/null +++ b/openbsc/tests/osmo-bsc-nat.cfg @@ -0,0 +1,66 @@ +# Same as doc/examples/osmo-bsc_nat/osmo-bsc-nat.cfg, but without 'bscs-config-file' +! +! OsmoBSCNAT (0.12.0.266-2daa9) configuration saved from vty +!! +! +log stderr + logging filter all 1 + logging color 1 + logging timestamp 0 + logging level all debug + logging level rll notice + logging level cc notice + logging level mm notice + logging level rr notice + logging level rsl notice + logging level nm info + logging level mncc notice + logging level pag notice + logging level meas notice + logging level sccp notice + logging level msc notice + logging level mgcp notice + logging level ho notice + logging level db notice + logging level ref notice + logging level gprs debug + logging level ns info + logging level bssgp debug + logging level llc debug + logging level sndcp debug + logging level nat notice + logging level ctrl notice + logging level smpp debug + logging level lglobal notice + logging level llapd notice + logging level linp notice + logging level lmux notice + logging level lmi notice + logging level lmib notice + logging level lsms notice +! +line vty + no login +! +mgcp + bind ip 0.0.0.0 + bind port 2427 + rtp bts-base 4000 + rtp net-base 16000 + rtp ip-dscp 0 + no rtcp-omit + sdp audio-payload number 126 + sdp audio-payload name AMR/8000 + loop 0 + number endpoints 1 + call-agent ip 127.0.0.1 + rtp transcoder-base 0 + transcoder-remote-base 4000 +nat + msc ip 127.0.0.1 + msc port 5000 + timeout auth 2 + timeout ping 20 + timeout pong 5 + ip-dscp 0 + access-list bla imsi-allow ^11$ -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice759b2205308ffb827293256eb1c0de9ac67edd Gerrit-Change-Number: 36940 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in openbsc[master]: tests: adjust to osmotestconfig no copytree change
by osmith 29 May '24

29 May '24

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email ) Change subject: tests: adjust to osmotestconfig no copytree change ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > . given that this is a long abandoned code base I'll just keep this patch as-is -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice759b2205308ffb827293256eb1c0de9ac67edd Gerrit-Change-Number: 36940 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 May 2024 07:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcap[master]: contrib/systemd: run as osmocom user
by osmith 29 May '24

29 May '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/29724?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... contrib/systemd: run as osmocom user Related: OS#4107 Co-Developed-By: Oliver Smith <osmith(a)sysmocom.de> Change-Id: Iccea921f0d3e92dd7ca2f4810932568121260a2a --- M contrib/osmo-pcap.spec.in M contrib/systemd/osmo-pcap-client.service M contrib/systemd/osmo-pcap-server.service A debian/osmo-pcap-client.postinst A debian/osmo-pcap-server.postinst 5 files changed, 98 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/contrib/osmo-pcap.spec.in b/contrib/osmo-pcap.spec.in index 0aa079a..c7c0d19 100644 --- a/contrib/osmo-pcap.spec.in +++ b/contrib/osmo-pcap.spec.in @@ -62,6 +62,9 @@ %service_del_postun osmo-pcap-client.service osmo-pcap-server.service %pre +getent group osmocom >/dev/null || groupadd --system osmocom +getent passwd osmocom >/dev/null || useradd --system --gid osmocom --home-dir /var/lib/osmocom \ + --shell /sbin/nologin --comment "Open Source Mobile Communications" osmocom %service_add_pre osmo-pcap-client.service osmo-pcap-server.service %post @@ -75,13 +78,13 @@ %license COPYING %doc AUTHORS %doc %{_docdir}/%{name}/examples -%dir %{_sysconfdir}/osmocom +%dir %attr(2775, root, osmocom) %{_sysconfdir}/osmocom %config(noreplace) %{_sysconfdir}/osmocom/osmo-pcap-client.cfg %config(noreplace) %{_sysconfdir}/osmocom/osmo-pcap-server.cfg %{_bindir}/osmo-pcap-client %{_bindir}/osmo-pcap-server -%{_unitdir}/osmo-pcap-client.service -%{_unitdir}/osmo-pcap-server.service +%attr(0660, osmocom, osmocom) %{_unitdir}/osmo-pcap-client.service +%attr(0660, osmocom, osmocom) %{_unitdir}/osmo-pcap-server.service %dir %{_datadir}/%{name} %{_datadir}/%{name}/osmo_pcap_clean_old diff --git a/contrib/systemd/osmo-pcap-client.service b/contrib/systemd/osmo-pcap-client.service index c79fafc..85e6592 100644 --- a/contrib/systemd/osmo-pcap-client.service +++ b/contrib/systemd/osmo-pcap-client.service @@ -8,8 +8,11 @@ Restart=always StateDirectory=osmocom WorkingDirectory=%S/osmocom +User=osmocom +Group=osmocom ExecStart=/usr/bin/osmo-pcap-client -c /etc/osmocom/osmo-pcap-client.cfg RestartSec=2 +AmbientCapabilities=CAP_NET_ADMIN CAP_NET_RAW [Install] WantedBy=multi-user.target diff --git a/contrib/systemd/osmo-pcap-server.service b/contrib/systemd/osmo-pcap-server.service index a6b6822..a35cb3e 100644 --- a/contrib/systemd/osmo-pcap-server.service +++ b/contrib/systemd/osmo-pcap-server.service @@ -8,6 +8,8 @@ Restart=always StateDirectory=osmocom WorkingDirectory=%S/osmocom +User=osmocom +Group=osmocom ExecStart=/usr/bin/osmo-pcap-server -c /etc/osmocom/osmo-pcap-server.cfg RestartSec=2 diff --git a/debian/osmo-pcap-client.postinst b/debian/osmo-pcap-client.postinst new file mode 100755 index 0000000..ba0182d --- /dev/null +++ b/debian/osmo-pcap-client.postinst @@ -0,0 +1,38 @@ +#!/bin/sh -e +case "$1" in + configure) + # Create the osmocom group and user (if it doesn't exist yet) + if ! getent group osmocom >/dev/null; then + groupadd --system osmocom + fi + if ! getent passwd osmocom >/dev/null; then + useradd \ + --system \ + --gid osmocom \ + --home-dir /var/lib/osmocom \ + --shell /sbin/nologin \ + --comment "Open Source Mobile Communications" \ + osmocom + fi + + # Fix permissions of previous (root-owned) install (OS#4107) + if dpkg --compare-versions "$2" le "0.4.3"; then + if [ -e /etc/osmocom/osmo-pcap-client.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-pcap-client.cfg + chmod -v 0660 /etc/osmocom/osmo-pcap-client.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi + ;; +esac + +# dh_installdeb(1) will replace this with shell code automatically +# generated by other debhelper scripts. +#DEBHELPER# diff --git a/debian/osmo-pcap-server.postinst b/debian/osmo-pcap-server.postinst new file mode 100755 index 0000000..56d2b49 --- /dev/null +++ b/debian/osmo-pcap-server.postinst @@ -0,0 +1,38 @@ +#!/bin/sh -e +case "$1" in + configure) + # Create the osmocom group and user (if it doesn't exist yet) + if ! getent group osmocom >/dev/null; then + groupadd --system osmocom + fi + if ! getent passwd osmocom >/dev/null; then + useradd \ + --system \ + --gid osmocom \ + --home-dir /var/lib/osmocom \ + --shell /sbin/nologin \ + --comment "Open Source Mobile Communications" \ + osmocom + fi + + # Fix permissions of previous (root-owned) install (OS#4107) + if dpkg --compare-versions "$2" le "0.4.3"; then + if [ -e /etc/osmocom/osmo-pcap-server.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-pcap-server.cfg + chmod -v 0660 /etc/osmocom/osmo-pcap-server.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi + ;; +esac + +# dh_installdeb(1) will replace this with shell code automatically +# generated by other debhelper scripts. +#DEBHELPER# -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/29724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Iccea921f0d3e92dd7ca2f4810932568121260a2a Gerrit-Change-Number: 29724 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by fixeria 29 May '24

29 May '24

Attention is currently required from: falconia, neels, nt2mku. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 10: (2 comments) Patchset: PS2: > As can be seen, the build verification is failing because the output of `tests/gsm0408` has changed: […] Done File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/20c2b2a6_546260cc PS2, Line 331: bcap->speech_ver[1] >= 0 || (bcap->speech_ver[0] & 0x0f) != 0x00 > Consider the following input: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 10 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Comment-Date: Wed, 29 May 2024 07:40:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by fixeria 29 May '24

29 May '24

Attention is currently required from: falconia, neels, nt2mku. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 10: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/4bfb2975_865e03ff PS2, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR (v1, 0x00) only, omit octet 3a. > Not addressed. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 10 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Comment-Date: Wed, 29 May 2024 07:39:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by nt2mku 29 May '24

29 May '24

Attention is currently required from: falconia, fixeria, neels. nt2mku has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 10: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/901fd734_2bb085b8 PS7, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. > The logic of the patch is correct, as we now know thanks to @vyanitskiy@sysmocom. […] Done File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/3c589f4f_f7ec6a0b PS7, Line 322: int encode_3a = 0; > Make this bool instead of int? Done https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/a5aa362a_3857a23b PS7, Line 340: encode_3a == 1 > If encode_3a is changed to bool, then this check should take the bool directly, without == operator. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 10 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 May 2024 07:11:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by nt2mku 29 May '24

29 May '24

Attention is currently required from: fixeria, neels, nt2mku. Hello Jenkins Builder, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email to look at the new patch set (#10). Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported According to 3GPP TS 24.008, section 10.5.4.5.1, octet 3a etc. shall be included only if the mobile station supports CTM text telephony or if it supports at least one speech version for GERAN other than V1 (FR or HR). This change adds the logic to omit octet 3a if the condition is not satisfied. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.err M tests/gsm0408/gsm0408_test.ok 4 files changed, 39 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 10 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by nt2mku 29 May '24

29 May '24

Attention is currently required from: fixeria, neels, nt2mku. Hello Jenkins Builder, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR or GSM-HR (v1) only and CTM text telephony is not supported, omit octet 3a. Ref: 3GPP TS 24.008, section 10.5.4.5.1. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.err M tests/gsm0408/gsm0408_test.ok 4 files changed, 38 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 9 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by nt2mku 29 May '24

29 May '24

Attention is currently required from: fixeria, neels, nt2mku. Hello Jenkins Builder, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email to look at the new patch set (#8). Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported According to 3GPP TS 24.008, section 10.5.4.5.1, octet 3a etc. shall be included only if the mobile station supports CTM text telephony or if it supports at least one speech version for GERAN other than V1 (FR or HR). This change adds the logic to omit octet 3a if the condition is not satisfied. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.err M tests/gsm0408/gsm0408_test.ok 4 files changed, 36 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 8 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by falconia 29 May '24

29 May '24

Attention is currently required from: fixeria, neels, nt2mku. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 7: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/0c07b980_536d49fc PS7, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. The logic of the patch is correct, as we now know thanks to @vyanitskiy@sysmocom.de, but this commit message needs to be changed. We should not be talking about putting this bearer cap IE in the MT SETUP message, as doing so is wrong in itself, instead we should be focusing on MS-side implementations using this libosmocore function to construct outgoing bearer cap IE in MO SETUP messages, or in CALL CONFIRM responses to MT calls - but still encoding in MS implementations, not by networks. File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/8cba7a2b_b52d98dc PS7, Line 322: int encode_3a = 0; Make this bool instead of int? https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/0749540a_d484d8cc PS7, Line 340: encode_3a == 1 If encode_3a is changed to bool, then this check should take the bool directly, without == operator. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 7 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 May 2024 06:48:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log