- gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: libosmosim: class_tables: Resolve conflicting CLA=8x INS=F2 definitions
by laforge 06 Jun '24

06 Jun '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36501?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: libosmosim: class_tables: Resolve conflicting CLA=8x INS=F2 definitions ...................................................................... libosmosim: class_tables: Resolve conflicting CLA=8x INS=F2 definitions In their infinite wisdom, GlobalPlatform re-defined the CLA 8x / INS F2 command alreay specified by ETSI TS 102 221. This wouldn't be as bads if they had the same "Case". However, ETSI has case 2 while GP has case 4. Lucikly, the P1 coding of ETSI [so far] states all the four upper bits must be 0, while GP always has one of those bits set. Before this patch, it is possible that a Modem/Phone will send an 8xF2 command and intends it as a GlobalPlatform command (with Lc > 0 and command data portion), while this code assumes it is an ETSI UICC command with Lc=0 and hence no command data portion. This will make communication break when using simtrace2 'cardem'. Change-Id: I8dd317ef8f942542e412b18c834a0467c51291c3 Related: SYS#6865 Related: https://lists.osmocom.org/hyperkitty/list/simtrace@lists.osmocom.org/thread… --- M src/sim/class_tables.c M tests/sim/sim_test.c M tests/sim/sim_test.ok 3 files changed, 53 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/36501/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8dd317ef8f942542e412b18c834a0467c51291c3 Gerrit-Change-Number: 36501 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: libosmosim: class_tables: Fix GlobalPlatform CLA=8x INS=CA/CB GET DATA
by laforge 06 Jun '24

06 Jun '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37066?usp=email ) Change subject: libosmosim: class_tables: Fix GlobalPlatform CLA=8x INS=CA/CB GET DATA ...................................................................... libosmosim: class_tables: Fix GlobalPlatform CLA=8x INS=CA/CB GET DATA in their infinite wisdom, GlobalPlatform made GET DATA a command that can be either APDU case 2 or case 4. As the specify Le must be 0x00, we can conclude that P3 == 0x00 must be Le, while P3 != 0x00 must be Lc and hence case 4 */ Change-Id: Ic8a17921f5a42d227791f1de39f90b4967c2e1b6 Related: SYS#6865 --- M src/sim/class_tables.c M tests/sim/sim_test.c M tests/sim/sim_test.ok 3 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/37066/1 diff --git a/src/sim/class_tables.c b/src/sim/class_tables.c index 29ef2d7..3d50521 100644 --- a/src/sim/class_tables.c +++ b/src/sim/class_tables.c @@ -178,6 +178,7 @@ { uint8_t ins = hdr[1]; uint8_t p1 = hdr[2]; + uint8_t p3 = hdr[4]; switch (ins) { case 0xE2: /* STORE DATA */ @@ -197,6 +198,16 @@ else return 2; /* ETSI TS 102 221 V16.2.0 11.1.2 */ break; + case 0xCA: + case 0xCB: + /* in their infinite wisdom, GlobalPlatform made GET DATA a command that can be either APDU + * case 2 or case 4. As the specify Le must be 0x00, we can conclude that P3 == 0x00 must be + * Le, while P3 != 0x00 must be Lc and hence case 4 */ + if (p3 == 0x00) + return 2; + else + return 4; + break; } return 0; } @@ -225,8 +236,8 @@ static const uint8_t gp_ins_tbl_8ce[256] = { [0xE4] = 4, /* DELETE */ [0xE2] = 0x80, /* STORE DATA */ - [0xCA] = 4, /* GET DATA */ - [0xCB] = 4, /* GET DATA */ + [0xCA] = 0x80, /* GET DATA */ + [0xCB] = 0x80, /* GET DATA */ [0xF2] = 0x80, /* GET STATUS */ [0xE6] = 4, /* INSTALL */ [0xE8] = 4, /* LOAD */ diff --git a/tests/sim/sim_test.c b/tests/sim/sim_test.c index 9a52af4..ab5d2be 100644 --- a/tests/sim/sim_test.c +++ b/tests/sim/sim_test.c @@ -29,6 +29,8 @@ const uint8_t uicc_upd[] = { 0x00, 0xD6, 0x00, 0x00, 0x02, 0x01, 0x02 }; const uint8_t uicc_get_status[] = { 0x80, 0xf2, 0x00, 0x02, 0x10 }; const uint8_t euicc_m2m_get_status[] = { 0x81, 0xf2, 0x40, 0x02, 0x02, 0x4f, 0x00 }; +const uint8_t gp_get_data2[] = { 0x81, 0xCA, 0x00, 0x5A, 0x00 }; +const uint8_t gp_get_data4[] = { 0x81, 0xCA, 0x00, 0x5A, 0x12 }; #define APDU_CASE_ASSERT(x, y) \ do { \ @@ -49,6 +51,8 @@ APDU_CASE_ASSERT(uicc_upd, 3); APDU_CASE_ASSERT(uicc_get_status, 2); APDU_CASE_ASSERT(euicc_m2m_get_status, 4); + APDU_CASE_ASSERT(gp_get_data2, 2); + APDU_CASE_ASSERT(gp_get_data4, 4); } int main(int argc, char **argv) diff --git a/tests/sim/sim_test.ok b/tests/sim/sim_test.ok index cac59ba..3abfb71 100644 --- a/tests/sim/sim_test.ok +++ b/tests/sim/sim_test.ok @@ -6,3 +6,5 @@ Testing uicc_upd Testing uicc_get_status Testing euicc_m2m_get_status +Testing gp_get_data2 +Testing gp_get_data4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic8a17921f5a42d227791f1de39f90b4967c2e1b6 Gerrit-Change-Number: 37066 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-s1gw[master]: Makefile,contrib/jenkins: import from osmo-epdg
by fixeria 06 Jun '24

06 Jun '24

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email ) Change subject: Makefile,contrib/jenkins: import from osmo-epdg ...................................................................... Patch Set 2: (4 comments) File Makefile: https://gerrit.osmocom.org/c/osmo-s1gw/+/37054/comment/c362a459_cea0eaa5 PS1, Line 9: epdg > Ack Done https://gerrit.osmocom.org/c/osmo-s1gw/+/37054/comment/4dc389e7_6e5ae7be PS1, Line 25: rm -f src/diameter_*.erl > Ack Done File Makefile: https://gerrit.osmocom.org/c/osmo-s1gw/+/37054/comment/64cf4bc3_06eee0aa PS2, Line 5: src/S1AP-%.erl include/S1AP-%.hrl: asn1/S1AP-%.asn FYI: The idea here is to avoid re-compiling ASN.1 files every time we do `build`, `run`, or `shell`. make will invoke `rebar3 asn compile` only if it's necessary. https://gerrit.osmocom.org/c/osmo-s1gw/+/37054/comment/09279184_50029bb2 PS2, Line 18: check: $(GEN_FILES) FYI: `rebar3 eunit` should not depend on `build` because it compiles all `*.erl` files independently (with different flags) and puts the resulting `*.beam` files to `_build/test/` (not `_build/default/`). -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id8d6652c9007f4d565e2e0ca318e3a7b2113ea67 Gerrit-Change-Number: 37054 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jun 2024 17:02:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: ttcn3-asterisk: Validate Asterisk generates correct AKAv1-MD5 digest ...
by pespin 06 Jun '24

06 Jun '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37065?usp=email ) Change subject: ttcn3-asterisk: Validate Asterisk generates correct AKAv1-MD5 digest response ...................................................................... ttcn3-asterisk: Validate Asterisk generates correct AKAv1-MD5 digest response Values taken from pcap "register-unregister-example.pcapng" in SYS#6960 against testing Kamailio as IMS Core. Related: SYS#6960 Change-Id: I0c6a6ff86a8b32383f17487dc9eb46d0bf2bf7c2 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn M asterisk/SIP_ConnectionHandler.ttcn M library/SIP_Templates.ttcn 4 files changed, 163 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/37065/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index ba7cb38..a96e66a 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -66,13 +66,6 @@ const charstring broadcast_sip_extension := "0500"; -/* TODO: need to find correct RES, CK, IK, values for: - * Response: "a19de225d030e6e0ec20f6de5f9dd80d" - * CNonce Value: "9a6460bcc3c84a3eac69455a93b67a77" - */ -const charstring c_auth_res := "a19de225d030e6e0"; -const charstring c_auth_ck := "9a6460bcc3c84a3eac69455a93b67a77"; -const charstring c_auth_ik := "5238297dfcca759bd05d48ff49bc63fa"; function f_init_ConnHdlrPars(integer idx := 1) runs on test_CT return SIPConnHdlrPars { var template (value) CallPars cp := t_CallPars(mp_local_sip_host, 1234 + 2*idx); @@ -384,15 +377,17 @@ /* Trigger registration: */ f_ami_action_PJSIPRegister(AMI_CLIENT, mp_volte_ims_outbound_registration); - var charstring rand_str := oct2str(pars.subscr.rand); - var charstring autn_str := oct2str(pars.subscr.autn); + var charstring rand_str := oct2str(pars.subscr.auth.rand); + var charstring autn_str := oct2str(pars.subscr.auth.autn); AMI_CLIENT.receive(tr_AMI_Event_AuthRequest(mp_volte_ims_outbound_registration, rand := pattern @nocase rand_str, autn := pattern @nocase autn_str)); f_ami_action_AuthResponse_RES(AMI_CLIENT, mp_volte_ims_outbound_registration, - c_auth_res, c_auth_ck, c_auth_ik); + f_str_tolower(oct2str(pars.subscr.auth.res)), + f_str_tolower(oct2str(pars.subscr.auth.ck)), + f_str_tolower(oct2str(pars.subscr.auth.ik))); AMI_CLIENT.receive(tr_AMI_Event_Registry(f_sip_SipAddr_to_str(pars.subscr.local_sip_record), "sip:" & mp_ims_domain, diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 9a37b05..f10e2aa 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -56,6 +56,14 @@ } type record of IMS_ConnHdlr IMS_ConnHdlrList; +type record IMS_AuthVector { + OCT16 rand, + OCT16 autn, + OCT8 res, + OCT16 ck, + OCT16 ik +} + type record IMS_ConnHdlrSubscrPars { charstring remote_sip_host optional, uint16_t remote_sip_port optional, @@ -65,8 +73,7 @@ charstring msisdn, /* Expected User-Location-Info in P-Access-Network-Info */ charstring uli_str, - octetstring rand, - octetstring autn, + IMS_AuthVector auth, charstring ipsec_auth_key, integer ipsec_local_spi_c, integer ipsec_local_spi_s, @@ -158,10 +165,15 @@ password := password, msisdn := msisdn, uli_str := "2380100010000101", - /* The Nonce field is the Base64 encoded version of the RAND value and concatenated with the AUTN: */ - rand := '14987631f65f8e3788a0798b6ebcd08e'O, - autn := 'f6e19a7ccb028000a06b19c9544516e5'O, - ipsec_auth_key := "0x5238297dfcca759bd05d48ff49bc63fa00000000", + auth := { + /* The Nonce field is the Base64 encoded version of the RAND value and concatenated with the AUTN: */ + rand := 'd5d5de2bce418d7865ed7fa6956618a2'O, + autn := 'd42e61db5f15800067393a5b7691a227'O, + res := '6f2556bbe4366ab1'O, + ck := '0b389d08c833991734936bec55cac800'O, + ik := '17141862125bd30c81c4224391a0909a'O + }, + ipsec_auth_key := "0x17141862125bd30c81c4224391a0909a00000000", ipsec_local_spi_c := 4142, ipsec_local_spi_s := 4143, ipsec_remote_spi_c := omit, @@ -250,8 +262,7 @@ /* HTTP Digest Authentication Using AKA (AKAv1-MD5): RFC 3310 */ function f_tr_Authorization_AKAv1MD5(WwwAuthenticate www_authenticate, charstring username, - charstring uri, - integer nc_int := 1) + charstring uri) return template (present) Authorization { var CommaParam_List digestCln; var template (present) Authorization authorization; @@ -280,6 +291,12 @@ return authorization; } +private function f_ims_validate_Authorization_AKAv1MD5_Response(Authorization authorization, charstring method) +runs on IMS_ConnHdlr { + f_sip_digest_validate_Authorization_AKAv1MD5(authorization, method, g_pars.subscr.auth.res); +} + + private function f_ims_validate_register_contact(Contact rx_contact) { /* IMS contact shows up like this: @@ -532,7 +549,8 @@ ts_Param("realm", f_sip_str_quote(g_pars.realm)), ts_Param("qop", f_sip_str_quote("auth")), ts_Param("algorithm", "AKAv1-MD5"), - ts_Param("nonce", f_sip_str_quote(f_nonce_from_rand_autn(g_pars.subscr.rand, g_pars.subscr.autn))) + ts_Param("nonce", f_sip_str_quote(f_nonce_from_rand_autn(g_pars.subscr.auth.rand, + g_pars.subscr.auth.autn))) /* "opaque not needed in IMS "*/ }; wwwAuthenticate := ts_WwwAuthenticate( { ts_Challenge_digestCln(digestCln) } ) @@ -569,17 +587,9 @@ SIP.send(tx_resp); /* Now we should receive a new REGISTER over ipsec: */ - - /* TODO: Generate expected Authoritzation based on AKAv1-MD5: */ - /*authorization := f_sip_digest_gen_Authorization(valueof(wwwAuthenticate), - g_pars.user, g_pars.subscr.password, - "REGISTER", - f_sip_SipUrl_to_str(g_pars.subscr.registrar_sip_record.addr.nameAddr.addrSpec)) - */ authorization := f_tr_Authorization_AKAv1MD5(valueof(wwwAuthenticate), g_pars.subscr.imsi & "@" & g_pars.realm, f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)); - /* TODO: match Authorization from above: */ exp_req := tr_SIP_REGISTER(g_pars.registrar_sip_req_uri, ?, @@ -607,6 +617,9 @@ userAgent := omit); SIP.send(tx_resp); + /* Validate Digest Response: */ + f_ims_validate_Authorization_AKAv1MD5_Response(g_rx_sip_req.msgHeader.authorization, "REGISTER"); + /* Validate P-Access-Network-Info: */ f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := true); diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index a14dd03..cd50be6 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -296,10 +296,10 @@ as_SIP_expect_resp(exp); /* Digest Auth: RFC 2617 */ - authorization := f_sip_digest_gen_Authorization(g_rx_sip_resp.msgHeader.wwwAuthenticate, - g_pars.user, g_pars.password, - "REGISTER", - f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)) + authorization := f_sip_digest_gen_Authorization_MD5(g_rx_sip_resp.msgHeader.wwwAuthenticate, + g_pars.user, g_pars.password, + "REGISTER", + f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)) /* New transaction: */ g_pars.registrar_sip_seq_nr := g_pars.registrar_sip_seq_nr + 1; @@ -381,7 +381,7 @@ as_SIP_expect_resp(exp); /* Digest Auth: RFC 2617 */ - req.msgHeader.authorization := f_sip_digest_gen_Authorization( + req.msgHeader.authorization := f_sip_digest_gen_Authorization_MD5( g_rx_sip_resp.msgHeader.wwwAuthenticate, g_pars.user, g_pars.password, "INVITE", diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index f251767..77d4ee0 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -1275,7 +1275,17 @@ f_sip_str_unquote(realm) & ":" & password; var charstring digestA1 := f_str_tolower(f_calculateMD5(A1)); - log("A1: md5('", A1, "') = ", digestA1); + log("A1: md5(", A1, ") = ", digestA1); + return digestA1; +} + +/* RFC 3310: Same as f_sip_digest_A1(), but using an octet buffer as password (AKAv1-MD5, pwd=RES) */ +function f_sip_digest_A1_octpwd(charstring user, charstring realm, octetstring password) return charstring { + var charstring A1pre := f_sip_str_unquote(user) & ":" & + f_sip_str_unquote(realm) & ":"; + var octetstring A1 := char2oct(A1pre) & password; + var charstring digestA1 := f_str_tolower(oct2str(f_calculateMD5_oct(A1))); + log("A1-octpwd: md5(", A1, ") = ", digestA1); return digestA1; } @@ -1284,7 +1294,7 @@ var charstring A2 := method & ":" & uri var charstring digestA2 := f_str_tolower(f_calculateMD5(A2)); - log("A2: md5('", A2, "') = ", digestA2); + log("A2: md5(", A2, ") = ", digestA2); return digestA2; } @@ -1298,7 +1308,7 @@ f_sip_str_unquote(qop) & ":" & digestA2; var charstring req_digest := f_sip_digest_KD(digestA1, digest_data); - log("Request-Digest: md5('", digestA1, ":", digest_data ,"') = ", req_digest); + log("Request-Digest: md5(\"" & digestA1 & ":" & digest_data & "\") = " & "\"" & req_digest & "\""); return req_digest; } @@ -1310,7 +1320,41 @@ } /* Digest Auth: RFC 2617 */ -function f_sip_digest_gen_Authorization(WwwAuthenticate www_authenticate, +function f_sip_digest_gen_Authorization_Response_MD5(charstring user, charstring realm, charstring password, + charstring method, charstring uri, charstring qop, + charstring nonce, charstring cnonce, charstring nc) +return charstring { + /* RFC 2617 3.2.2.2 A1 */ + var charstring digestA1 := f_sip_digest_A1(user, realm, password); + + /* RFC 2617 3.2.2.3 A2 */ + var charstring digestA2 := f_sip_digest_A2(method, uri); + + /* RFC 2617 3.2.2.1 Request-Digest */ + var charstring req_digest := f_sip_digest_RequestDigest(digestA1, nonce, + nc, cnonce, + qop, digestA2); + return req_digest; +} + +/* Digest Auth: RFC 2617 */ +function f_sip_digest_gen_Authorization_Response_AKAv1MD5(charstring user, charstring realm, octetstring password, + charstring method, charstring uri, charstring qop, + charstring nonce, charstring cnonce, charstring nc) +return charstring { + /* RFC 2617 3.2.2.2 A1 */ + var charstring digestA1 := f_sip_digest_A1_octpwd(user, realm, password); + /* RFC 2617 3.2.2.3 A2 */ + var charstring digestA2 := f_sip_digest_A2(method, uri); + + /* RFC 2617 3.2.2.1 Request-Digest */ + var charstring req_digest := f_sip_digest_RequestDigest(digestA1, nonce, + nc, cnonce, + qop, digestA2); + return req_digest; +} + +function f_sip_digest_gen_Authorization_MD5(WwwAuthenticate www_authenticate, charstring user, charstring password, charstring method, charstring uri, charstring cnonce := "0a4f113b", integer nc_int := 1) return Authorization { @@ -1343,17 +1387,13 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected qop: ", qop)); } var charstring selected_qop := "auth"; - - /* RFC 2617 3.2.2.2 A1 */ - var charstring digestA1 := f_sip_digest_A1(user, realm, password); - /* RFC 2617 3.2.2.3 A2 */ - var charstring digestA2 := f_sip_digest_A2(method, uri); - - /* RFC 2617 3.2.2.1 Request-Digest */ var charstring nc := f_str_tolower(hex2str(int2hex(nc_int, 8))); - var charstring req_digest := f_sip_digest_RequestDigest(digestA1, nonce, - nc, cnonce, - selected_qop, digestA2); + + var charstring req_digest; + req_digest := + f_sip_digest_gen_Authorization_Response_MD5(user, realm, password, + method, uri, selected_qop, + nonce, cnonce, nc); cred := ts_Credentials_DigestResponseMD5(user, realm, nonce, uri, req_digest, @@ -1363,6 +1403,55 @@ return valueof(authorization); } +/* RFC 3310: Same as f_sip_digest_validate_Authorization_MD5(), but using an octet buffer as password (AKAv1-MD5, pwd=RES) */ +function f_sip_digest_validate_Authorization_AKAv1MD5(Authorization authorization, charstring method, octetstring password) { + var CommaParam_List auth_pars := authorization.body.digestResponse; + var template (omit) GenericParam rx_param; + + rx_param := f_sip_param_find(auth_pars, "algorithm"); + if (istemplatekind(rx_param, "omit")) { + /* Assume MD5 if not set */ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Algorithm param not present"); + } else { + var charstring algorithm := valueof(rx_param.paramValue); + if (f_strstr(algorithm, "AKAv1-MD5") == -1) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Unexpected algorithm: ", algorithm)); + } + } + + var charstring user := f_sip_param_get_value_present_or_fail(auth_pars, "username"); + var charstring realm := f_sip_param_get_value_present_or_fail(auth_pars, "realm"); + var charstring uri := f_sip_param_get_value_present_or_fail(auth_pars, "uri"); + var charstring nonce := f_sip_param_get_value_present_or_fail(auth_pars, "nonce"); + var charstring qop := f_sip_param_get_value_present_or_fail(auth_pars, "qop"); + var charstring response := f_sip_param_get_value_present_or_fail(auth_pars, "response"); + var charstring cnonce := f_sip_param_get_value_present_or_fail(auth_pars, "cnonce"); + var charstring nc := f_sip_param_get_value_present_or_fail(auth_pars, "nc"); + + if (f_strstr(qop, "auth") == -1) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected qop: ", qop)); + } + + var charstring exp_response := + f_sip_digest_gen_Authorization_Response_AKAv1MD5(f_sip_str_unquote(user), + f_sip_str_unquote(realm), + password, + method, + f_sip_str_unquote(uri), + qop, + f_sip_str_unquote(nonce), + f_sip_str_unquote(cnonce), + nc); + + response := f_sip_str_unquote(response); + if (response != exp_response) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Wrong digest response: ", response, + " vs exp: ", exp_response, ". Params: ", auth_pars)); + } +} + /* RFC 2617 3.5 Example */ function f_sip_digest_selftest() { /* @@ -1400,13 +1489,13 @@ ts_WwwAuthenticate( { ts_Challenge_digestCln(digestCln) } ) var Authorization authorization := - f_sip_digest_gen_Authorization(valueof(www_authenticate), - "Mufasa", - "Circle Of Life", - "GET", - "/dir/index.html", - cnonce := "0a4f113b", - nc_int := 1); + f_sip_digest_gen_Authorization_MD5(valueof(www_authenticate), + "Mufasa", + "Circle Of Life", + "GET", + "/dir/index.html", + cnonce := "0a4f113b", + nc_int := 1); var CommaParam_List digestResp := authorization.body.digestResponse; f_sip_param_match_value_or_fail(digestResp, "realm", f_sip_str_quote("testrealm(a)host.com")); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c6a6ff86a8b32383f17487dc9eb46d0bf2bf7c2 Gerrit-Change-Number: 37065 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-s1gw[master]: Makefile,contrib/jenkins: import from osmo-epdg
by fixeria 06 Jun '24

06 Jun '24

Attention is currently required from: fixeria, laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email ) Change subject: Makefile,contrib/jenkins: import from osmo-epdg ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id8d6652c9007f4d565e2e0ca318e3a7b2113ea67 Gerrit-Change-Number: 37054 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jun 2024 16:58:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-s1gw[master]: gitreview: new file
by fixeria 06 Jun '24

06 Jun '24

Attention is currently required from: osmith. fixeria has uploaded a new patch set (#2) to the change originally created by osmith. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37055?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gitreview: new file ...................................................................... gitreview: new file Change-Id: Ia3fc980e6ee942518d6ffd263a9e6a4496716b6f --- A .gitreview 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-s1gw refs/changes/55/37055/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia3fc980e6ee942518d6ffd263a9e6a4496716b6f Gerrit-Change-Number: 37055 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-s1gw[master]: README: use shorter 'make' commands
by fixeria 06 Jun '24

06 Jun '24

Attention is currently required from: osmith. fixeria has uploaded a new patch set (#2) to the change originally created by osmith. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37056?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: README: use shorter 'make' commands ...................................................................... README: use shorter 'make' commands Change-Id: If650c04c676f98d5f936f478a0e44a6e1713c3d2 --- M README.md 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-s1gw refs/changes/56/37056/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If650c04c676f98d5f936f478a0e44a6e1713c3d2 Gerrit-Change-Number: 37056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo_dia2gsup[master]: replace http:// urls with https:// (diameter files)
by pespin 06 Jun '24

06 Jun '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37064?usp=email ) Change subject: replace http:// urls with https:// (diameter files) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4e129e9e74e13731f254db3d69e389187680d421 Gerrit-Change-Number: 37064 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jun 2024 16:53:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: COPYING and copyright headers: use https instead of http
by pespin 06 Jun '24

06 Jun '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37058?usp=email ) Change subject: COPYING and copyright headers: use https instead of http ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I330a3219008ffb1afff41fb6f8210246e2ed6aa6 Gerrit-Change-Number: 37058 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jun 2024 16:52:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-s1gw[master]: add license file as COPYING
by pespin 06 Jun '24

06 Jun '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37063?usp=email ) Change subject: add license file as COPYING ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I0d93091da89a394250ae4e243568ebb53c938e43 Gerrit-Change-Number: 37063 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jun 2024 16:51:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log