- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: unber.py: work-around pylint reporting (possibly-used-before-assignment)
by laforge 10 Jun '24

10 Jun '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37154?usp=email ) Change subject: unber.py: work-around pylint reporting (possibly-used-before-assignment) ...................................................................... unber.py: work-around pylint reporting (possibly-used-before-assignment) contrib/unber.py:39:22: E0606: Possibly using variable 'content' before assignment (possibly-used-before-assignment) Change-Id: I725cd5e05e3121c853669eb4bbfe5ba51b79eb75 --- M contrib/unber.py 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/54/37154/1 diff --git a/contrib/unber.py b/contrib/unber.py index 65262e1..6b488b7 100755 --- a/contrib/unber.py +++ b/contrib/unber.py @@ -35,5 +35,8 @@ content = f.read() elif opts.hex: content = h2b(opts.hex) + else: + # avoid pylint "(possibly-used-before-assignment)" below + sys.exit(2) process_one_level(content, 0) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I725cd5e05e3121c853669eb4bbfe5ba51b79eb75 Gerrit-Change-Number: 37154 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: Execute pylint also on all contrib python scripts
by laforge 10 Jun '24

10 Jun '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37155?usp=email ) Change subject: contrib/jenkins.sh: Execute pylint also on all contrib python scripts ...................................................................... contrib/jenkins.sh: Execute pylint also on all contrib python scripts This way we get linting coverage for sim-rest-{server,client}, eidtool, unber and others. Change-Id: I2d6271d493d0f6765e6a184f8ae32f8325317be2 --- M contrib/jenkins.sh 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/37155/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7d3defb..a35241d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -57,9 +57,7 @@ --disable E0401 \ --enable W0301 \ pySim tests/*.py *.py \ - contrib/es2p_client.py \ - contrib/es9p_client.py \ - contrib/saip-tool.py + contrib/*.py ;; "docs") rm -rf docs/_build -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2d6271d493d0f6765e6a184f8ae32f8325317be2 Gerrit-Change-Number: 37155 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-abis[master]: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads
by falconia 10 Jun '24

10 Jun '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email ) Change subject: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads ...................................................................... RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads TW-TS-001 is an enhanced RTP transport format for FR and EFR codecs that replicates the functionality and semantics of GSM 08.60 TRAU-UL frames. Given that libosmotrau functions support converting from RTP to either TRAU-UL or TRAU-DL, the option of TW-TS-001 fits in naturally. It needs to be noted, however, that the fully correct path in OsmoMGW from RTP input to E1 output will need to include one more critical step _before_ the call to osmo_rtp2trau(): it will be a stateful preening engine that implements the rules of TS 28.062 section C.3.2.1.1, a codec-dependent stateful transform that can be fairly complex. The necessary engines will most likely be implemented in Themyscira codec libraries, and OsmoMGW will need to be outfitted with an _optional_ dependency on those libs. The "native" support for TW-TS-001 input in osmo_rtp2trau() for TRAU-DL (as opposed to TRAU-UL) output is a fallback in the case of OsmoMGW built without any Themyscira codec libraries. Related: OS#6448 Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 --- M src/trau/trau_rtp_conv.c 1 file changed, 77 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/53/37153/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index 069baab..e4aa885 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -269,13 +269,29 @@ { int i, j, k, l, o; enum osmo_gsm631_sid_class sidc; + bool bfi = false, taf = false, dtxd = false; - /* data_len == 0 for BFI frame */ - if (data_len < GSM_FR_BYTES && data_len != 0) - return -EINVAL; + /* accept TW-TS-001 input */ + if (data_len > 0 && (data[0] & 0xF0) == 0xE0) { + dtxd = (data[0] & 0x08) != 0; + bfi = (data[0] & 0x02) != 0; + taf = (data[0] & 0x01) != 0; + data++; + data_len--; + } - if (data_len && data[0] >> 4 != 0xd) + /* now we must have either standard FR or no-data input */ + switch (data_len) { + case GSM_FR_BYTES: + if ((data[0] & 0xF0) != 0xD0) + return -EINVAL; + break; + case 0: + bfi = true; + break; + default: return -EINVAL; + } tf->type = OSMO_TRAU16_FT_FR; @@ -308,20 +324,19 @@ } memset(&tf->c_bits[5], 0, 6); /* C6 .. C11: Time Alignment */ if (tf->dir == OSMO_TRAU_DIR_UL) { + tf->c_bits[11] = bfi; /* C12: BFI */ if (data_len == 0) { - tf->c_bits[11] = 1; /* C12: BFI */ tf->c_bits[12] = 0; /* C13: SID=0 */ tf->c_bits[13] = 0; /* C14: SID=0 */ } else { - tf->c_bits[11] = 0; /* C12: BFI */ /* SID classification per GSM 06.31 section 6.1.1 */ sidc = osmo_fr_sid_classify(data); tf->c_bits[12] = (sidc >> 1) & 1; /* C13: msb */ tf->c_bits[13] = (sidc >> 0) & 1; /* C14: lsb */ } - tf->c_bits[14] = 0; /* C15: TAF (SACCH or not) */ - tf->c_bits[15] = 1; /* C16: spare */ - tf->c_bits[16] = 0; /* C17: DTXd not applied */ + tf->c_bits[14] = taf; /* C15: TAF (SACCH or not) */ + tf->c_bits[15] = 1; /* C16: spare */ + tf->c_bits[16] = dtxd; /* C17: DTXd applied or not */ } else { memset(&tf->c_bits[11], 1, 4); /* C12 .. C15: spare */ if (data_len && osmo_fr_check_sid(data, data_len)) @@ -461,13 +476,29 @@ int i, j; ubit_t check_bits[26]; enum osmo_gsm631_sid_class sidc; + bool bfi = false, taf = false, dtxd = false; - /* data_len == 0 for BFI frame */ - if (data_len < GSM_EFR_BYTES && data_len != 0) - return -EINVAL; + /* accept TW-TS-001 input */ + if (data_len > 0 && (data[0] & 0xF0) == 0xE0) { + dtxd = (data[0] & 0x08) != 0; + bfi = (data[0] & 0x02) != 0; + taf = (data[0] & 0x01) != 0; + data++; + data_len--; + } - if (data_len && data[0] >> 4 != 0xc) + /* now we must have either standard EFR or no-data input */ + switch (data_len) { + case GSM_EFR_BYTES: + if ((data[0] & 0xF0) != 0xC0) + return -EINVAL; + break; + case 0: + bfi = true; + break; + default: return -EINVAL; + } tf->type = OSMO_TRAU16_FT_EFR; @@ -492,20 +523,19 @@ memset(&tf->c_bits[5], 0, 6); /* C6 .. C11: Time Alignment */ if (tf->dir == OSMO_TRAU_DIR_UL) { + tf->c_bits[11] = bfi; /* C12: BFI */ if (data_len == 0) { - tf->c_bits[11] = 1; /* C12: BFI */ tf->c_bits[12] = 0; /* C13: SID=0 */ tf->c_bits[13] = 0; /* C14: SID=0 */ } else { - tf->c_bits[11] = 0; /* C12: BFI */ /* SID classification per GSM 06.81 section 6.1.1 */ sidc = osmo_efr_sid_classify(data); tf->c_bits[12] = (sidc >> 1) & 1; /* C13: msb */ tf->c_bits[13] = (sidc >> 0) & 1; /* C14: lsb */ } - tf->c_bits[14] = 0; /* C15: TAF (SACCH) */ - tf->c_bits[15] = 1; /* C16: spare */ - tf->c_bits[16] = 0; /* C17: DTXd applied */ + tf->c_bits[14] = taf; /* C15: TAF (SACCH or not) */ + tf->c_bits[15] = 1; /* C16: spare */ + tf->c_bits[16] = dtxd; /* C17: DTXd applied or not */ } else { tf->c_bits[11] = 1; /* C12: UFE (good uplink) */ memset(&tf->c_bits[12], 1, 3); /* C13 .. C15: spare */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 Gerrit-Change-Number: 37153 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[M] Change in pysim[master]: pySim.ota.OtaDialectSms: Implement command decoding
by laforge 10 Jun '24

10 Jun '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37141?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim.ota.OtaDialectSms: Implement command decoding ...................................................................... pySim.ota.OtaDialectSms: Implement command decoding So far we only implemented command encoding and response decoding. Let's also add command decoding, which is useful for example when decoding protocol traces. Change-Id: Id666cea8a91a854209f3c19c1f09b512bb493c85 --- M pySim/ota.py M tests/test_ota.py 2 files changed, 79 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/37141/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id666cea8a91a854209f3c19c1f09b512bb493c85 Gerrit-Change-Number: 37141 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: pySim.ota.OtaDialectSMS: Move SMS header construct up to class level
by laforge 10 Jun '24

10 Jun '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37140?usp=email to look at the new patch set (#6). Change subject: pySim.ota.OtaDialectSMS: Move SMS header construct up to class level ...................................................................... pySim.ota.OtaDialectSMS: Move SMS header construct up to class level this way we can use it in other [future] methods. Change-Id: If296f823c18864fddcfb9cb1b82a087bac8875d4 --- M pySim/ota.py 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/37140/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If296f823c18864fddcfb9cb1b82a087bac8875d4 Gerrit-Change-Number: 37140 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in pysim[master]: add contrib/saip-tool.py
by laforge 10 Jun '24

10 Jun '24

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37011?usp=email to look at the new patch set (#8). Change subject: add contrib/saip-tool.py ...................................................................... add contrib/saip-tool.py This is a tool to work with eSIM profiles in SAIP format. It allows to dump the contents, run constraint checkers as well as splitting of the PE-Sequence into the individual PEs. Change-Id: I396bcd594e0628dfc26bd90233317a77e2f91b20 --- M contrib/jenkins.sh A contrib/saip-tool.py A pySim/pprint.py 3 files changed, 249 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/11/37011/8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I396bcd594e0628dfc26bd90233317a77e2f91b20 Gerrit-Change-Number: 37011 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmo-abis[master]: trau2rtp_hr16: change output format to RFC 5993
by falconia 10 Jun '24

10 Jun '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37152?usp=email ) Change subject: trau2rtp_hr16: change output format to RFC 5993 ...................................................................... trau2rtp_hr16: change output format to RFC 5993 Emitting RFC 5993 payload format instead of TS 101 318 brings Osmocom+E1 BSS into compliance with TS 48.103 (which requires RFC 5993 format at AoIP interface), and will also make it much easier to add optional support for TW-TS-002. There are no backward compatibility issues: OsmoMGW E1 support currently works only for FR and EFR, not for HR. Related: OS#6448 Change-Id: I0bcfdccbf4df5a5cd90a65525527f08107be2cf5 --- M src/trau/trau_rtp_conv.c 1 file changed, 43 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/52/37152/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index e1e0391..069baab 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -147,40 +147,51 @@ static const uint8_t rtp_hr_sid[14] = { 0x00, 0x00, 0x00, 0x00, 0x7f, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; -/*! Generate the 14 bytes ETSI TS 101 318 RTP payload for HR from a decoded 16k TRAU frame. - * Note that thsi differs from the IETF RFC5993 format. However, as OsmoBTS implements - * the TS 101 318 format, we also use the same format here. osmo-mgw can convert them. +/*! Generate an RFC 5993 RTP payload for HR from a decoded 16k TRAU frame. + * We previously emitted TS 101 318 format; however, RFC 5993 is the format + * specified in TS 48.103 for AoIP, it can also be extended with TRAU-UL-like + * capabilities with TW-TS-002, and we now support RFC 5993 output in OsmoBTS + * on all models. * \param[out] out caller-provided output buffer * \param[in] out_len length of out buffer in bytes * \param[in] tf input TRAU frame in decoded form * \returns number of bytes generated in 'out'; negative on error. */ static int trau2rtp_hr16(uint8_t *out, size_t out_len, const struct osmo_trau_frame *tf) { - unsigned int i; + enum osmo_gsm631_sid_class sidc; if (tf->type != OSMO_TRAU16_FT_HR) return -EINVAL; + if (out_len < GSM_HR_BYTES_RTP_RFC5993) + return -ENOSPC; + /* HR Data Bits according to TS 48.061 Section 5.1.4.1.1 */ - if (tf->dir == OSMO_TRAU_DIR_UL && tf->c_bits[11]) /* C12: BFI */ + sidc = (tf->c_bits[12] << 1) | tf->c_bits[13]; + /* both C13 and C14 being set is invalid combination */ + if (sidc > OSMO_GSM631_SID_CLASS_VALID) goto bad_frame; - if (out_len < GSM_HR_BYTES) - return -ENOSPC; + /* Plain RFC 5993 without TW-TS-002 extensions does not allow + * BFI or invalid SID packets. */ + if (tf->c_bits[11] || sidc == OSMO_GSM631_SID_CLASS_INVALID) + goto bad_frame; + + /* RFC 5993 Frame Type is equal to GSM 06.41 SID classification, + * restricted to just speech or valid SID per above. */ + out[0] = sidc << 4; /* TS 101 318 Section 5.2: The order of occurrence of the codec parameters in the buffer is * the same as order of occurrence over the Abis as defined in annex B of ETS 300 969 * [which is 3GPP TS 46.020 */ - osmo_ubit2pbit(out, tf->d_bits, 112); + osmo_ubit2pbit(out + 1, tf->d_bits, 112); - if (tf->c_bits[12] || tf->c_bits[13]) { - /* Generate SID frame as per TS 101 318 Section 5.2.2 */ - for (i = 0; i < sizeof(rtp_hr_sid); i++) - out[i] = out[i] | rtp_hr_sid[i]; - } + /* RFC 5993 requires SID frames to be perfect, error-free */ + if (sidc == OSMO_GSM631_SID_CLASS_VALID) + osmo_hr_sid_reset(out + 1); - return GSM_HR_BYTES; + return GSM_HR_BYTES_RTP_RFC5993; bad_frame: return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0bcfdccbf4df5a5cd90a65525527f08107be2cf5 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: accept both TS 101 318 and RFC 5993 payload formats
by falconia 10 Jun '24

10 Jun '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37151?usp=email ) Change subject: rtp2trau_hr16: accept both TS 101 318 and RFC 5993 payload formats ...................................................................... rtp2trau_hr16: accept both TS 101 318 and RFC 5993 payload formats OsmoBTS already accepts both payload formats for HRv1 - do likewise when interfacing to E1-based BTS. While OsmoMGW does have a vty config option to convert between TS 101 318 and RFC 5993 payload formats on the fly, it should be considered deprecated, and we should be moving toward recommended configurations with that option disabled. Change-Id: I125d57d3451b030e35a7b2b95a45e38b4581626c --- M src/trau/trau_rtp_conv.c 1 file changed, 29 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/51/37151/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index bad63ac..e1e0391 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -367,8 +367,20 @@ static int rtp2trau_hr16(struct osmo_trau_frame *tf, const uint8_t *data, size_t data_len) { - if (data_len < GSM_HR_BYTES && data_len != 0) + /* accept both TS 101 318 and RFC 5993 payloads */ + switch (data_len) { + case GSM_HR_BYTES: + break; + case GSM_HR_BYTES_RTP_RFC5993: + data++; + data_len--; + break; + case 0: + /* accept no-data input */ + break; + default: return -EINVAL; + } tf->type = OSMO_TRAU16_FT_HR; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I125d57d3451b030e35a7b2b95a45e38b4581626c Gerrit-Change-Number: 37151 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set D bits correctly
by falconia 10 Jun '24

10 Jun '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email ) Change subject: rtp2trau_hr16: set D bits correctly ...................................................................... rtp2trau_hr16: set D bits correctly The original code failed to do the step of osmo_pbit2ubit() for transferring HRv1 payload bits from packed to unpacked form, instead doing the bogon of memcpy()ing the RTP payload directly into tf->d_bits array - fix it. Also set all D bits to zeros in the case of empty payload input - not ideal, but better than transmitting uninitialized memory content. Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458 --- M src/trau/trau_rtp_conv.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/50/37150/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index 4a62cc0..bad63ac 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -425,7 +425,9 @@ tf->ufi = 1; /* CRC is computed by TRAU frame encoder */ if (data_len) - memcpy(tf->d_bits, data, GSM_HR_BYTES); + osmo_pbit2ubit(tf->d_bits, data, 112); + else + memset(tf->d_bits, 0, 112); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458 Gerrit-Change-Number: 37150 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: TRAU<->RTP HRv1: fix SID frame definition
by falconia 10 Jun '24

10 Jun '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37149?usp=email ) Change subject: TRAU<->RTP HRv1: fix SID frame definition ...................................................................... TRAU<->RTP HRv1: fix SID frame definition HRv1 SID frame consists of 33 bits of comfort noise parameters followed by 79 bits of all-1s SID codeword. The RTP-encoded representation of this construct in trau_rtp_conv.c was off by one bit - fix it. Change-Id: I4554a70f05bee428e0fb304868e25ee61ff375a1 --- M src/trau/trau_rtp_conv.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/49/37149/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index c70736d..4a62cc0 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -145,7 +145,7 @@ FT_NO_DATA = 7, }; -static const uint8_t rtp_hr_sid[14] = { 0x00, 0x00, 0x00, 0x00, 0x3f, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; +static const uint8_t rtp_hr_sid[14] = { 0x00, 0x00, 0x00, 0x00, 0x7f, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; /*! Generate the 14 bytes ETSI TS 101 318 RTP payload for HR from a decoded 16k TRAU frame. * Note that thsi differs from the IETF RFC5993 format. However, as OsmoBTS implements -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4554a70f05bee428e0fb304868e25ee61ff375a1 Gerrit-Change-Number: 37149 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log