pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37124?usp=email )
Change subject: asterisk: Fix wrong IP address arg creating IMS_CallPars
......................................................................
asterisk: Fix wrong IP address arg creating IMS_CallPars
This field is not yet really used because we are not doing any RTP so
far, so the previous error was harmless. We are at most sending it in
the SDP.
Change-Id: Iac0c240d785131954c4d8a2df90655e2a5ec3666
---
M asterisk/Asterisk_Tests.ttcn
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn
index a96e66a..c4cad38 100644
--- a/asterisk/Asterisk_Tests.ttcn
+++ b/asterisk/Asterisk_Tests.ttcn
@@ -79,7 +79,7 @@
}
function f_init_IMS_ConnHdlrPars(integer idx := 1) runs on test_CT return IMS_ConnHdlrPars {
- var template (value) IMS_CallPars cp := t_IMS_CallPars(mp_local_sip_host, 1234 + 2*idx);
+ var template (value) IMS_CallPars cp := t_IMS_CallPars(mp_local_ims_host, 1234 + 2*idx);
var template (value) IMS_ConnHdlrPars pars := t_IMS_Pars(mp_local_ims_host,
mp_local_ims_port,
mp_ims_domain,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37124?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iac0c240d785131954c4d8a2df90655e2a5ec3666
Gerrit-Change-Number: 37124
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37123?usp=email )
Change subject: asterisk: IMS: Validate P-Access-Network-Info in rx INVITE
......................................................................
asterisk: IMS: Validate P-Access-Network-Info in rx INVITE
Change-Id: Ie4c4c4e11abbaae81f934675c569b09433a5eb15
---
M asterisk/IMS_ConnectionHandler.ttcn
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn
index 7819e62..1eae16d 100644
--- a/asterisk/IMS_ConnectionHandler.ttcn
+++ b/asterisk/IMS_ConnectionHandler.ttcn
@@ -697,9 +697,15 @@
contact := g_rx_sip_req.msgHeader.contact;
f_ims_validate_register_contact(contact);
- /* Validate P-Access-Network-Info: */
+ /* Validate P-Access-Network-Info: 3GPP TS 24.229 5.1.2A.1.1
+ * "If available to the UE (as defined in the access technology specific annexes for each access technology), the UE shall
+ * insert a P-Access-Network-Info header field into any request for a dialog, any subsequent request (except CANCEL
+ * requests) or response (except CANCEL responses) within a dialog or any request for a standalone method (see
+ * subclause 7.2A.4). Insertion of the P-Access-Network-Info header field into the ACK request is optional."
+ */
f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := true);
+
/* Tx 100 Tyring */
tx_resp := ts_SIP_Response_Trying(sip_call_id,
from_addr,
@@ -772,6 +778,8 @@
f_ConnHdlr_parse_initial_SIP_INVITE(g_rx_sip_req);
via := g_rx_sip_req.msgHeader.via;
+ f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := true);
+
/* Tx 180 Ringing */
tx_resp := ts_SIP_Response_Ringing(g_pars.subscr.cp.sip_call_id,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37123?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c4c4e11abbaae81f934675c569b09433a5eb15
Gerrit-Change-Number: 37123
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37126?usp=email )
Change subject: asterisk: IMS: Expect protected server port in Via
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I56778507bb2c21d95feece0f814f4dc4977d2b0b
Gerrit-Change-Number: 37126
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Jun 2024 15:51:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment