- gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: trau2rtp_hr16: check CRC bits in the TRAU frame
by falconia 12 Jun '24

12 Jun '24

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37181?usp=email ) Change subject: trau2rtp_hr16: check CRC bits in the TRAU frame ...................................................................... trau2rtp_hr16: check CRC bits in the TRAU frame If CRC bits in the received TRAU frame are bad, the implication is that this frame must have got corrupted in E1 transport. In this case all other bits cannot be trusted, and we should deliver BFI-no-data to RTP. Change-Id: I4f97b67884ff7540be631298e5252d28f765fce9 --- M src/trau/trau_rtp_conv.c 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index d3d1cae..15d5a08 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -186,6 +186,7 @@ static int trau2rtp_hr16(uint8_t *out, size_t out_len, const struct osmo_trau_frame *tf, bool emit_twts002) { enum osmo_gsm631_sid_class sidc; + int rc; if (tf->type != OSMO_TRAU16_FT_HR) return -EINVAL; @@ -195,6 +196,12 @@ /* HR Data Bits according to TS 48.061 Section 5.1.4.1.1 */ + /* bad CRC means bad frame, no matter what else is going on */ + rc = osmo_crc8gen_check_bits(&gsm0860_efr_crc3, tf->d_bits, 44, + tf->crc_bits); + if (rc) + goto bad_frame; + sidc = (tf->c_bits[12] << 1) | tf->c_bits[13]; /* both C13 and C14 being set is invalid combination */ if (sidc > OSMO_GSM631_SID_CLASS_VALID) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4f97b67884ff7540be631298e5252d28f765fce9 Gerrit-Change-Number: 37181 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-gsm-manuals[master]: add static SS7 routing example to cs7-config.adoc
by pespin 12 Jun '24

12 Jun '24

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email ) Change subject: add static SS7 routing example to cs7-config.adoc ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File common/chapters/cs7-config.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/cd8e1da8_1425… PS5, Line 375: For static routing, the M3UA port numbers must be fixed, i.e. there must be no `0` for a client's local port as in : `asp foo 2905 0 m3ua`. Instead, you may use `asp foo 2905 2905 m3ua`. > sorry for not noticing the response... […] With current state of things in libosmo-sccp (I think better management of IP addresses during socket creation also regarding primarys and so on) it should not be a problem, because you are using specific local-ip addresses, so the socket should not be announcing other IPs not listed there. So let's merge as is I guess. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I44afddf7004f5bf37eec706ca3da12c04f83f8fa Gerrit-Change-Number: 32273 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:55:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1
by fixeria 12 Jun '24

12 Jun '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email ) Change subject: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 ...................................................................... sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 We want to keep the SCTP connection alive even if we hit a bug in s1ap_proxy:handle_pdu/1. Otherwise, all the PDN contexts of all the subscribers served by the respective eNB will be killed. Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa --- M src/sctp_proxy.erl 1 file changed, 27 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 9f9072b..29cc425 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -155,8 +155,7 @@ {[#sctp_sndrcvinfo{assoc_id = Aid}], Data}}, S) -> logger:debug("MME connection (id=~p, ~p:~p) -> eNB: ~p", [Aid, MmeAddr, MmePort, Data]), - sctp_server:send_data(maps:get(enb_aid, S), - s1ap_proxy:handle_pdu(Data)), + sctp_server:send_data(maps:get(enb_aid, S), handle_pdu(Data)), {keep_state, S}; %% Catch-all for other kinds of SCTP events @@ -193,10 +192,21 @@ %% private API %% ------------------------------------------------------------------ +%% A safe wrapper for s1ap_proxy:handle_pdu/1 +-spec handle_pdu(binary()) -> binary(). +handle_pdu(Data) when is_binary(Data) -> + try s1ap_proxy:handle_pdu(Data) of + NewData -> NewData + catch + Exception:Reason -> + logger:error("An exception occurred: ~p, ~p", [Exception, Reason]), + Data %% proxy as-is + end. + + %% Send a single message to the MME sctp_send(#{sock := Sock, mme_aid := Aid}, Data) -> - sctp_client:send_data({Sock, Aid}, - s1ap_proxy:handle_pdu(Data)). + sctp_client:send_data({Sock, Aid}, handle_pdu(Data)). %% Send pending messages to the MME -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa Gerrit-Change-Number: 37122 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1
by fixeria 12 Jun '24

12 Jun '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email ) Change subject: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa Gerrit-Change-Number: 37122 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:50:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-abis[master]: TRAU->RTP: add support for TW-TS-001 & TW-TS-002
by pespin 12 Jun '24

12 Jun '24

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email ) Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002 ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab Gerrit-Change-Number: 37156 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:49:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-abis[master]: TRAU->RTP: add support for TW-TS-001 & TW-TS-002
by fixeria 12 Jun '24

12 Jun '24

Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email ) Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab Gerrit-Change-Number: 37156 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:40:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau2rtp_hr16: check CRC bits in the TRAU frame
by fixeria 12 Jun '24

12 Jun '24

Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37181?usp=email ) Change subject: trau2rtp_hr16: check CRC bits in the TRAU frame ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4f97b67884ff7540be631298e5252d28f765fce9 Gerrit-Change-Number: 37181 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:39:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set CRC bits correctly
by fixeria 12 Jun '24

12 Jun '24

Attention is currently required from: dexter, falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email ) Change subject: rtp2trau_hr16: set CRC bits correctly ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5c8aa5891e3862f978f14093bff46bd00b6702a5 Gerrit-Change-Number: 37180 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:38:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-abis[master]: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads
by falconia 12 Jun '24

12 Jun '24

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads ...................................................................... RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads TW-TS-001 is an enhanced RTP transport format for FR and EFR codecs that replicates the functionality and semantics of GSM 08.60 TRAU-UL frames. Given that libosmotrau functions support converting from RTP to either TRAU-UL or TRAU-DL, the option of TW-TS-001 fits in naturally. It needs to be noted, however, that the fully correct path in OsmoMGW from RTP input to E1 output will need to include one more critical step _before_ the call to osmo_rtp2trau(): it will be a stateful preening engine that implements the rules of TS 28.062 section C.3.2.1.1, a codec-dependent stateful transform that can be fairly complex. The necessary engines will most likely be implemented in Themyscira codec libraries, and OsmoMGW will need to be outfitted with an _optional_ dependency on those libs. The "native" support for TW-TS-001 input in osmo_rtp2trau() for TRAU-DL (as opposed to TRAU-UL) output is a fallback in the case of OsmoMGW built without any Themyscira codec libraries. Related: OS#6448 Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 --- M src/trau/trau_rtp_conv.c 1 file changed, 77 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index b19d582..21322fc 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -269,13 +269,29 @@ { int i, j, k, l, o; enum osmo_gsm631_sid_class sidc; + bool bfi = false, taf = false, dtxd = false; - /* data_len == 0 for BFI frame */ - if (data_len < GSM_FR_BYTES && data_len != 0) - return -EINVAL; + /* accept TW-TS-001 input */ + if (data_len > 0 && (data[0] & 0xF0) == 0xE0) { + dtxd = (data[0] & 0x08) != 0; + bfi = (data[0] & 0x02) != 0; + taf = (data[0] & 0x01) != 0; + data++; + data_len--; + } - if (data_len && data[0] >> 4 != 0xd) + /* now we must have either standard FR or no-data input */ + switch (data_len) { + case GSM_FR_BYTES: + if ((data[0] & 0xF0) != 0xD0) + return -EINVAL; + break; + case 0: + bfi = true; + break; + default: return -EINVAL; + } tf->type = OSMO_TRAU16_FT_FR; @@ -308,20 +324,19 @@ } memset(&tf->c_bits[5], 0, 6); /* C6 .. C11: Time Alignment */ if (tf->dir == OSMO_TRAU_DIR_UL) { + tf->c_bits[11] = bfi; /* C12: BFI */ if (data_len == 0) { - tf->c_bits[11] = 1; /* C12: BFI */ tf->c_bits[12] = 0; /* C13: SID=0 */ tf->c_bits[13] = 0; /* C14: SID=0 */ } else { - tf->c_bits[11] = 0; /* C12: BFI */ /* SID classification per GSM 06.31 section 6.1.1 */ sidc = osmo_fr_sid_classify(data); tf->c_bits[12] = (sidc >> 1) & 1; /* C13: msb */ tf->c_bits[13] = (sidc >> 0) & 1; /* C14: lsb */ } - tf->c_bits[14] = 0; /* C15: TAF (SACCH or not) */ - tf->c_bits[15] = 1; /* C16: spare */ - tf->c_bits[16] = 0; /* C17: DTXd not applied */ + tf->c_bits[14] = taf; /* C15: TAF (SACCH or not) */ + tf->c_bits[15] = 1; /* C16: spare */ + tf->c_bits[16] = dtxd; /* C17: DTXd applied or not */ } else { memset(&tf->c_bits[11], 1, 4); /* C12 .. C15: spare */ if (data_len && osmo_fr_check_sid(data, data_len)) @@ -461,13 +476,29 @@ int i, j; ubit_t check_bits[26]; enum osmo_gsm631_sid_class sidc; + bool bfi = false, taf = false, dtxd = false; - /* data_len == 0 for BFI frame */ - if (data_len < GSM_EFR_BYTES && data_len != 0) - return -EINVAL; + /* accept TW-TS-001 input */ + if (data_len > 0 && (data[0] & 0xF0) == 0xE0) { + dtxd = (data[0] & 0x08) != 0; + bfi = (data[0] & 0x02) != 0; + taf = (data[0] & 0x01) != 0; + data++; + data_len--; + } - if (data_len && data[0] >> 4 != 0xc) + /* now we must have either standard EFR or no-data input */ + switch (data_len) { + case GSM_EFR_BYTES: + if ((data[0] & 0xF0) != 0xC0) + return -EINVAL; + break; + case 0: + bfi = true; + break; + default: return -EINVAL; + } tf->type = OSMO_TRAU16_FT_EFR; @@ -492,20 +523,19 @@ memset(&tf->c_bits[5], 0, 6); /* C6 .. C11: Time Alignment */ if (tf->dir == OSMO_TRAU_DIR_UL) { + tf->c_bits[11] = bfi; /* C12: BFI */ if (data_len == 0) { - tf->c_bits[11] = 1; /* C12: BFI */ tf->c_bits[12] = 0; /* C13: SID=0 */ tf->c_bits[13] = 0; /* C14: SID=0 */ } else { - tf->c_bits[11] = 0; /* C12: BFI */ /* SID classification per GSM 06.81 section 6.1.1 */ sidc = osmo_efr_sid_classify(data); tf->c_bits[12] = (sidc >> 1) & 1; /* C13: msb */ tf->c_bits[13] = (sidc >> 0) & 1; /* C14: lsb */ } - tf->c_bits[14] = 0; /* C15: TAF (SACCH) */ - tf->c_bits[15] = 1; /* C16: spare */ - tf->c_bits[16] = 0; /* C17: DTXd applied */ + tf->c_bits[14] = taf; /* C15: TAF (SACCH or not) */ + tf->c_bits[15] = 1; /* C16: spare */ + tf->c_bits[16] = dtxd; /* C17: DTXd applied or not */ } else { tf->c_bits[11] = 1; /* C12: UFE (good uplink) */ memset(&tf->c_bits[12], 1, 3); /* C13 .. C15: spare */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 Gerrit-Change-Number: 37153 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set D bits correctly
by falconia 12 Jun '24

12 Jun '24

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email ) Change subject: rtp2trau_hr16: set D bits correctly ...................................................................... rtp2trau_hr16: set D bits correctly The original code failed to do the step of osmo_pbit2ubit() for transferring HRv1 payload bits from packed to unpacked form, instead doing the bogon of memcpy()ing the RTP payload directly into tf->d_bits array - fix it. Also set all D bits to zeros in the case of empty payload input - not ideal, but better than transmitting uninitialized memory content. Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458 --- M src/trau/trau_rtp_conv.c 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index 4a62cc0..cf8d12e 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -425,7 +425,9 @@ tf->ufi = 1; /* CRC is computed by TRAU frame encoder */ if (data_len) - memcpy(tf->d_bits, data, GSM_HR_BYTES); + osmo_pbit2ubit(tf->d_bits, data, GSM_HR_BYTES * 8); + else + memset(tf->d_bits, 0, GSM_HR_BYTES * 8); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458 Gerrit-Change-Number: 37150 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log