- gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: logging: cosmetic: print mfa at the end of each line
by pespin 13 Jun '24

13 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37217?usp=email ) Change subject: logging: cosmetic: print mfa at the end of each line ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib5b8aabd1d7285d22a4cee2beece77691c61f753 Gerrit-Change-Number: 37217 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 18:25:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: logging: cosmetic: print mfa at the end of each line
by fixeria 13 Jun '24

13 Jun '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37217?usp=email ) Change subject: logging: cosmetic: print mfa at the end of each line ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > what is mfa? From Erlang's API docs: ``` mfa => {?MODULE, ?FUNCTION_NAME, ?FUNCTION_ARITY} ``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib5b8aabd1d7285d22a4cee2beece77691c61f753 Gerrit-Change-Number: 37217 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 18:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: logging: cosmetic: print mfa at the end of each line
by pespin 13 Jun '24

13 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37217?usp=email ) Change subject: logging: cosmetic: print mfa at the end of each line ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: what is mfa? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib5b8aabd1d7285d22a4cee2beece77691c61f753 Gerrit-Change-Number: 37217 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 18:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: sctp_server: fix state in catch-all handle_call()
by pespin 13 Jun '24

13 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37218?usp=email ) Change subject: sctp_server: fix state in catch-all handle_call() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I1cc683e549c3bb61e3e4c45bb3d244202d61be53 Gerrit-Change-Number: 37218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 18:17:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: logging: convert error_logger:error_report/1 to ?LOG_ERROR
by pespin 13 Jun '24

13 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37219?usp=email ) Change subject: logging: convert error_logger:error_report/1 to ?LOG_ERROR ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id6c61fb5ca730209ef625fc5f63d627574e60fbe Gerrit-Change-Number: 37219 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 18:16:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-s1gw[master]: logging: use ?LOG macros instead of calling logger:level()
by pespin 13 Jun '24

13 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37216?usp=email ) Change subject: logging: use ?LOG macros instead of calling logger:level() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3b6e4296f736f9c87d2706ef5fb75146fd9f1239 Gerrit-Change-Number: 37216 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 18:16:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: jenkins-common: Treat -asan builds the same as -master
by pespin 13 Jun '24

13 Jun '24

Attention is currently required from: daniel, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email ) Change subject: jenkins-common: Treat -asan builds the same as -master ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc Gerrit-Change-Number: 37192 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 18:15:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: refactor prim management in tx_tch[fh]_fn()
by pespin 13 Jun '24

13 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email ) Change subject: trxcon/l1sched: refactor prim management in tx_tch[fh]_fn() ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: I agree the way the gotos and labels are used in those functions is not nice at all, since they are not used as ordered return paths (catch/except style). So I'm in favour of removing those. I cannot say the patch is fine, but I guess Vadim himself is the one knowing this the best, so +1 from my side. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5292abf6fcd308c9f7f12c7145d004103c9c7675 Gerrit-Change-Number: 36915 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 18:15:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: logging: convert error_logger:error_report/1 to ?LOG_ERROR
by fixeria 13 Jun '24

13 Jun '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37219?usp=email ) Change subject: logging: convert error_logger:error_report/1 to ?LOG_ERROR ...................................................................... logging: convert error_logger:error_report/1 to ?LOG_ERROR In Erlang/OTP 21.0, a new API for logging was added. The old error_logger module can still be used by legacy code, but log events are redirected to the new Logger API. New code should use the Logger API directly. Change-Id: Id6c61fb5ca730209ef625fc5f63d627574e60fbe --- M src/sctp_server.erl 1 file changed, 17 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/19/37219/1 diff --git a/src/sctp_server.erl b/src/sctp_server.erl index 5c73fc2..2c3893a 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -93,9 +93,8 @@ mme_addr_port = MmeAddrPort}}. -handle_call(Info, _From, State) -> - error_logger:error_report(["unknown handle_call()", - {module, ?MODULE}, {info, Info}, {state, State}]), +handle_call(Info, From, State) -> + ?LOG_ERROR("unknown ~p() from ~p: ~p", [?FUNCTION_NAME, From, Info]), {reply, {error, not_implemented}, State}. @@ -107,8 +106,7 @@ {noreply, State}; handle_cast(Info, State) -> - error_logger:error_report(["unknown handle_cast()", - {module, ?MODULE}, {info, Info}, {state, State}]), + ?LOG_ERROR("unknown ~p(): ~p", [?FUNCTION_NAME, Info]), {noreply, State}. @@ -132,8 +130,7 @@ %% Catch-all for unknown messages handle_info(Info, State) -> - error_logger:error_report(["unknown handle_info()", - {module, ?MODULE}, {info, Info}, {state, State}]), + ?LOG_ERROR("unknown ~p(): ~p", [?FUNCTION_NAME, Info]), {noreply, State}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id6c61fb5ca730209ef625fc5f63d627574e60fbe Gerrit-Change-Number: 37219 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-s1gw[master]: sctp_server: fix state in catch-all handle_call()
by fixeria 13 Jun '24

13 Jun '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37218?usp=email ) Change subject: sctp_server: fix state in catch-all handle_call() ...................................................................... sctp_server: fix state in catch-all handle_call() Sending an unexpected call breaks the server, because the third member of a returned tuple (not_implemented) becomes the new state. It was actually meant to be part of the Reply - fix this. https://www.erlang.org/doc/apps/stdlib/gen_server.html#c:handle_call/3 {reply, Reply :: term(), NewState :: term()} Change-Id: I1cc683e549c3bb61e3e4c45bb3d244202d61be53 --- M src/sctp_server.erl 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/18/37218/1 diff --git a/src/sctp_server.erl b/src/sctp_server.erl index e93dd9f..806c559 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -95,7 +95,7 @@ handle_call(Info, _From, State) -> error_logger:error_report(["unknown handle_call()", {module, ?MODULE}, {info, Info}, {state, State}]), - {reply, error, not_implemented}. + {reply, {error, not_implemented}, State}. handle_cast({send_data, Aid, Data}, State) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I1cc683e549c3bb61e3e4c45bb3d244202d61be53 Gerrit-Change-Number: 37218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log