- gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix -Wswitch in tch_voice_state_init()
by laforge 14 Jun '24

14 Jun '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email ) Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb Gerrit-Change-Number: 37212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jun 2024 09:54:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/coverity: fix clean up permission errors
by osmith 14 Jun '24

14 Jun '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37231?usp=email ) Change subject: jobs/coverity: fix clean up permission errors ...................................................................... jobs/coverity: fix clean up permission errors Don't mount the host's osmo-ci/coverity dir in /build/osmo-ci/coverity. The current working dir is mounted as /build, and because docker creates the /build/osmo-ci directory structure as root, we end up with having subdirectories created by root in our current working dir. These then cause an error on the next run when jenkins tries to clean them up. Fixes: 6a2451a0 ("jobs/coverity: adjust mount path to new home dir") Change-Id: Ie0aa02d3821df6d0505748a7dd70ff67e4cf1405 --- M coverity/jenkins.sh M jobs/coverity.yml 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh index b33ae86..d19b93c 100755 --- a/coverity/jenkins.sh +++ b/coverity/jenkins.sh @@ -7,7 +7,7 @@ export PATH=$PATH:/opt/coverity/current/bin -base_dir="$HOME/osmo-ci/coverity" +base_dir="/opt/osmo-ci/coverity" src_dir="$PWD/source-Osmocom" cov_dir="$src_dir/cov-int" diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 8159940..d7492c4 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -17,7 +17,7 @@ -e PARALLEL_MAKE="$PARALLEL_MAKE" \ -u build \ -v "$PWD:/build" \ - -v "$HOME/osmo-ci/coverity:/build/osmo-ci/coverity:ro" \ + -v "$HOME/osmo-ci/coverity:/opt/osmo-ci/coverity:ro" \ -v "/opt/coverity:/opt/coverity:ro" \ -w /build/coverity \ "$USER/debian-bookworm-build" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie0aa02d3821df6d0505748a7dd70ff67e4cf1405 Gerrit-Change-Number: 37231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/coverity: fix clean up permission errors
by laforge 14 Jun '24

14 Jun '24

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37231?usp=email ) Change subject: jobs/coverity: fix clean up permission errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie0aa02d3821df6d0505748a7dd70ff67e4cf1405 Gerrit-Change-Number: 37231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jun 2024 09:53:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in simtrace2[master]: dissector: add support for sim polarity
by laforge 14 Jun '24

14 Jun '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36980?usp=email ) Change subject: dissector: add support for sim polarity ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If3ae350d0f4d737bc9e80c4f5d73cc1a39d076af Gerrit-Change-Number: 36980 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 14 Jun 2024 09:53:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/coverity: fix clean up permission errors
by osmith 14 Jun '24

14 Jun '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37231?usp=email ) Change subject: jobs/coverity: fix clean up permission errors ...................................................................... jobs/coverity: fix clean up permission errors Don't mount the host's osmo-ci/coverity dir in /build/osmo-ci/coverity. The current working dir is mounted as /build, and because docker creates the /build/osmo-ci directory structure as root, we end up with having subdirectories created by root in our current working dir. These then cause an error on the next run when jenkins tries to clean them up. Fixes: 6a2451a0 ("jobs/coverity: adjust mount path to new home dir") Change-Id: Ie0aa02d3821df6d0505748a7dd70ff67e4cf1405 --- M coverity/jenkins.sh M jobs/coverity.yml 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/31/37231/1 diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh index b33ae86..d19b93c 100755 --- a/coverity/jenkins.sh +++ b/coverity/jenkins.sh @@ -7,7 +7,7 @@ export PATH=$PATH:/opt/coverity/current/bin -base_dir="$HOME/osmo-ci/coverity" +base_dir="/opt/osmo-ci/coverity" src_dir="$PWD/source-Osmocom" cov_dir="$src_dir/cov-int" diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 8159940..d7492c4 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -17,7 +17,7 @@ -e PARALLEL_MAKE="$PARALLEL_MAKE" \ -u build \ -v "$PWD:/build" \ - -v "$HOME/osmo-ci/coverity:/build/osmo-ci/coverity:ro" \ + -v "$HOME/osmo-ci/coverity:/opt/osmo-ci/coverity:ro" \ -v "/opt/coverity:/opt/coverity:ro" \ -w /build/coverity \ "$USER/debian-bookworm-build" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie0aa02d3821df6d0505748a7dd70ff67e4cf1405 Gerrit-Change-Number: 37231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()
by osmith 14 Jun '24

14 Jun '24

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email ) Change subject: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d Gerrit-Change-Number: 37213 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jun 2024 07:17:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: codec: make osmo_hr_check_sid() more efficient
by falconia 14 Jun '24

14 Jun '24

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/37227?usp=email to look at the new patch set (#3). Change subject: codec: make osmo_hr_check_sid() more efficient ...................................................................... codec: make osmo_hr_check_sid() more efficient The operation of checking an HRv1 codec frame for the possibility of a perfect, error-free SID entails checking the last 79 bits out of 112, to see if they are all 1s. This operation can be done much more efficiently without using bitvec. This change also affects the logic of what osmo_hr_check_sid() does when the payload length argument is 0, or otherwise less than the expected 14. The old code had a surely-unintended effect of returning true on a 0-length payload; the new version returns false (the input is not a perfect SID frame) if the payload length is 0 or otherwise shorter than GSM_HR_BYTES. Change-Id: Ib14204102c03c14d6c5aab42b0ffbef2c3dda3fd --- M src/codec/gsm620.c 1 file changed, 42 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/27/37227/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib14204102c03c14d6c5aab42b0ffbef2c3dda3fd Gerrit-Change-Number: 37227 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in simtrace2[master]: cardemu: add support for inverted sim presence pins
by lynxis lazus 14 Jun '24

14 Jun '24

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36441?usp=email ) Change subject: cardemu: add support for inverted sim presence pins ...................................................................... Abandoned replace by new patch series -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I33325f763b56b297762a3fb6fe6baa7b0354de3c Gerrit-Change-Number: 36441 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

[S] Change in simtrace2[master]: dissector: add support for sim polarity
by lynxis lazus 14 Jun '24

14 Jun '24

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/36980?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: dissector: add support for sim polarity ...................................................................... dissector: add support for sim polarity Needs testing. Related: SYS#6946 Change-Id: If3ae350d0f4d737bc9e80c4f5d73cc1a39d076af --- M contrib/simtrace.lua 1 file changed, 27 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/80/36980/4 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If3ae350d0f4d737bc9e80c4f5d73cc1a39d076af Gerrit-Change-Number: 36980 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in docker-playground[master]: s1gw: add osmo-s1gw-master
by fixeria 14 Jun '24

14 Jun '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37229?usp=email ) Change subject: s1gw: add osmo-s1gw-master ...................................................................... s1gw: add osmo-s1gw-master Change-Id: Ic732f57940fa41fe21a26af663fea559551b1811 Related: SYS#6772 --- A osmo-s1gw-master/Dockerfile A osmo-s1gw-master/Makefile A osmo-s1gw-master/osmo-s1gw.config 3 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/37229/1 diff --git a/osmo-s1gw-master/Dockerfile b/osmo-s1gw-master/Dockerfile new file mode 100644 index 0000000..34028f8 --- /dev/null +++ b/osmo-s1gw-master/Dockerfile @@ -0,0 +1,24 @@ +ARG USER +ARG DISTRO +FROM $USER/$DISTRO-erlang +# Arguments used after FROM must be specified again +ARG DISTRO + +WORKDIR /tmp + +ARG OSMO_S1GW_BRANCH="master" + +RUN git clone https://gerrit.osmocom.org/erlang/osmo-s1gw.git +ADD https://gerrit.osmocom.org/plugins/gitiles/erlang/osmo-s1gw/+/$OSMO_S1GW_BR… /tmp/commit-osmo-s1gw + +RUN cd osmo-s1gw && \ + git fetch && git checkout $OSMO_S1GW_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_S1GW_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + make build + +VOLUME /data + +COPY osmo-s1gw.config /data/osmo-s1gw.config + +CMD ["/bin/sh", "-c", "ERL_FLAGS='-config /data/osmo-s1gw.config' /tmp/osmo-s1gw/_build/default/bin/osmo-s1gw > /data/osmo-s1gw.log 2>&1"] diff --git a/osmo-s1gw-master/Makefile b/osmo-s1gw-master/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/osmo-s1gw-master/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/osmo-s1gw-master/osmo-s1gw.config b/osmo-s1gw-master/osmo-s1gw.config new file mode 100644 index 0000000..ef48a29 --- /dev/null +++ b/osmo-s1gw-master/osmo-s1gw.config @@ -0,0 +1,2 @@ +[{osmo_s1gw, [ +]}]. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic732f57940fa41fe21a26af663fea559551b1811 Gerrit-Change-Number: 37229 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log