- gerrit-log - lists.osmocom.org

[M] Change in docker-playground[master]: s1gw: add ttcn3-s1gw-test
by fixeria 16 Jun '24

16 Jun '24

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37230?usp=email ) Change subject: s1gw: add ttcn3-s1gw-test ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I95000d7a9d778df1da830cd5059e5b6899391fbe Gerrit-Change-Number: 37230 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 15 Jun 2024 20:35:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: mgcp_test.c: verify osmo-mgw accepts m=audio 0
by neels 16 Jun '24

16 Jun '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37233?usp=email ) Change subject: mgcp_test.c: verify osmo-mgw accepts m=audio 0 ...................................................................... mgcp_test.c: verify osmo-mgw accepts m=audio 0 When osmo-hnbgw does not yet know the remote port, it wants to send a CRCX to set up IuUP at the MGW, with the audio port set to zero. Make sure osmo-mgw accepts port == 0. Related: SYS#6907 SYS#6974 Change-Id: I42011c2e7256d372a37b6a2fe86af0153038e2d0 --- M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 2 files changed, 66 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index ffc8a20..65756e0 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -386,6 +386,56 @@ "a=rtpmap:97 GSM-EFR/8000\r\n" \ "a=ptime:40\r\n" +#define CRCX_PORT_0 \ + "CRCX 3 1@mgw MGCP 1.0\r\n" \ + "m: recvonly\r\n" \ + "C: 2\r\n" \ + "L: p:20\r\n" \ + "\r\n" \ + "v=0\r\n" \ + "c=IN IP4 123.12.12.123\r\n" \ + "m=audio 0 RTP/AVP 97\r\n" \ + "a=rtpmap:97 GSM-EFR/8000\r\n" \ + "a=ptime:40\r\n" + +#define CRCX_PORT_0_RET \ + "200 3 OK\r\n" \ + "I: %s\r\n" \ + "\r\n" \ + "v=0\r\n" \ + "o=- %s 23 IN IP4 0.0.0.0\r\n" \ + "s=-\r\n" \ + "c=IN IP4 0.0.0.0\r\n" \ + "t=0 0\r\n" \ + "m=audio 16014 RTP/AVP 97\r\n" \ + "a=rtpmap:97 GSM-EFR/8000\r\n" \ + "a=ptime:40\r\n" + +#define CRCX_PORT_0_IUFP \ + "CRCX 4 1@mgw MGCP 1.0\r\n" \ + "m: recvonly\r\n" \ + "C: 2\r\n" \ + "L: p:20\r\n" \ + "\r\n" \ + "v=0\r\n" \ + "c=IN IP4 123.12.12.123\r\n" \ + "m=audio 0 RTP/AVP 96\r\n" \ + "a=rtpmap:96 VND.3GPP.IUFP/16000\r\n" \ + "a=ptime:40\r\n" + +#define CRCX_PORT_0_IUFP_RET \ + "200 4 OK\r\n" \ + "I: %s\r\n" \ + "\r\n" \ + "v=0\r\n" \ + "o=- %s 23 IN IP4 0.0.0.0\r\n" \ + "s=-\r\n" \ + "c=IN IP4 0.0.0.0\r\n" \ + "t=0 0\r\n" \ + "m=audio 16016 RTP/AVP 96\r\n" \ + "a=rtpmap:96 VND.3GPP.IUFP/16000\r\n" \ + "a=ptime:40\r\n" + #define DLCX \ "DLCX 7 1@mgw MGCP 1.0\r\n" \ "I: %s\r\n" \ @@ -623,6 +673,8 @@ {"MDCX_NULL", MDCX_NULL, MDCX_NULL_RET}, {"DLCX_NULL", DLCX_NULL, DLCX_NULL_RET}, {"RQNT_NULL", RQNT_NULL, RQNT_NULL_RET}, + {"CRCX_PORT_0", CRCX_PORT_0, CRCX_PORT_0_RET, 97}, + {"CRCX_PORT_0_IUFP", CRCX_PORT_0_IUFP, CRCX_PORT_0_IUFP_RET, 96}, }; static const struct mgcp_test retransmit[] = { diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index d76e455..a81d9dd 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok Binary files differ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37233?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I42011c2e7256d372a37b6a2fe86af0153038e2d0 Gerrit-Change-Number: 37233 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmo-netif[master]: stream_test: Increase log level to debug
by daniel 15 Jun '24

15 Jun '24

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37232?usp=email ) Change subject: stream_test: Increase log level to debug ...................................................................... stream_test: Increase log level to debug Debug logging might help us get to the bottom of these weird test failures due to varying mainloop iterations. Change-Id: I3cd6e3ed36c2a52acc08e92439c34f6e1e7b5d5d Related: OS#6477 --- M tests/stream/stream_test.c M tests/stream/stream_test.err 2 files changed, 76 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c index 6e849ca..67f7429 100644 --- a/tests/stream/stream_test.c +++ b/tests/stream/stream_test.c @@ -906,7 +906,7 @@ osmo_gettimeofday_override_time.tv_usec = 0; osmo_init_logging2(tall_test, &osmo_stream_test_log_info); - log_set_log_level(osmo_stderr_target, LOGL_INFO); + log_set_log_level(osmo_stderr_target, LOGL_DEBUG); log_set_use_color(osmo_stderr_target, 0); log_set_print_category_hex(osmo_stderr_target, 0); log_set_print_category(osmo_stderr_target, 0); diff --git a/tests/stream/stream_test.err b/tests/stream/stream_test.err index 6c85c43..5180409 100644 --- a/tests/stream/stream_test.err +++ b/tests/stream/stream_test.err @@ -2,28 +2,50 @@ CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTING} connection established {2.000001} autoreconnecting test step 11 [client NA, server OK], FD reg 1 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connected write +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} sending 29 bytes of data {2.000002} autoreconnecting test step 10 [client NA, server OK], FD reg 1 +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) connected read/write (what=0x1) +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) message received +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) received 29 bytes from client {2.000003} autoreconnecting test step 9 [client NA, server OK], FD reg 1 +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) connected read/write (what=0x2) +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) sending 11 bytes of data {2.000004} autoreconnecting test step 8 [client NA, server OK], FD reg 1 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connected read +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} message received +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} received 11 bytes from srv {2.000005} autoreconnecting test step 7 [client OK, server OK], FD reg 1 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connected write +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} sending 29 bytes of data {2.000006} autoreconnecting test step 6 [client OK, server OK], FD reg 1 +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) connected read/write (what=0x1) +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) message received +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) received 29 bytes from client {2.000007} autoreconnecting test step 5 [client OK, server OK], FD reg 1 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connected read +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} message received CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connection closed with srv +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CLOSED} connection closed CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){WAIT_RECONNECT} retrying reconnect in 9 seconds... {11.000008} autoreconnecting test step 4 [client OK, server OK], FD reg 0 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){WAIT_RECONNECT} reconnecting {11.000009} autoreconnecting test step 3 [client OK, server OK], FD reg 1 SRV(srv_link_test,127.0.0.11:1111) accept()ed new link from 127.0.0.1:8976 CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTING} connection established +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CLOSED} connection closed {11.000010} autoreconnecting test step 2 [client OK, server OK], FD reg 0 +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) connected read/write (what=0x1) +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) message received SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) connection closed with client {11.000011} autoreconnecting test step 1 [client OK, server NA], FD reg 0 @@ -31,23 +53,63 @@ CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTING} connection established {11.000012} non-reconnecting test step 7 [client NA, server OK], FD reg 1 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connected write +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} sending 29 bytes of data {11.000013} non-reconnecting test step 6 [client NA, server OK], FD reg 1 +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) connected read/write (what=0x1) +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) message received +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) received 29 bytes from client {11.000014} non-reconnecting test step 5 [client NA, server OK], FD reg 1 +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) connected read/write (what=0x2) +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) sending 11 bytes of data {11.000015} non-reconnecting test step 4 [client NA, server OK], FD reg 1 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connected read +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} message received +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} received 11 bytes from srv {11.000016} non-reconnecting test step 3 [client OK, server OK], FD reg 1 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connected write +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} sending 29 bytes of data {11.000017} non-reconnecting test step 2 [client OK, server OK], FD reg 1 +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) connected read/write (what=0x1) +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) message received +SRVCONN(srv_test,r=127.0.0.1:8976<->l=127.0.0.11:1111) received 29 bytes from client {11.000018} non-reconnecting test step 1 [client OK, server OK], FD reg 1 +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connected read +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} message received CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CONNECTED} connection closed with srv +CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CLOSED} connection closed CLICONN(cli_test,r=127.0.0.11:1111<->l=127.0.0.1:8976){CLOSED} not reconnecting, disabled {20.000019} non-reconnecting test step 0 [client OK, server OK], FD reg 0 SRV(srv_link_test,127.0.0.11:1111) accept()ed new link from 127.0.0.1:8977 CLICONN(,r=127.0.0.11:1111<->l=127.0.0.1:8977){CONNECTING} connection established +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1111) received 24 bytes from client +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1111) received 24 bytes from client +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1111) received 24 bytes from client +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1111) received 24 bytes from client +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1111) connected write +CLICONN(,r=127.0.0.11:1111<->l=127.0.0.1:8977){CONNECTED} received 6 bytes from srv +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1111) received 10 bytes from client +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1111) received 10 bytes from client +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1111) received 10 bytes from client +CLICONN(,r=127.0.0.11:1111<->l=127.0.0.1:8977){CLOSED} connection closed SRV(srv_link_test,127.0.0.11:1112) accept()ed new link from 127.0.0.1:8977 CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CONNECTING} connection established +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1112) connected write +CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CONNECTED} received 24 bytes from srv +CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CONNECTED} received 24 bytes from srv +CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CONNECTED} received 24 bytes from srv +CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CONNECTED} received 24 bytes from srv +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1112) received 6 bytes from client +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1112) connected write +SRVCONN(,r=127.0.0.1:8977<->l=127.0.0.11:1112) connected write +CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CONNECTED} received 10 bytes from srv +CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CONNECTED} received 10 bytes from srv +CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CONNECTED} received 10 bytes from srv +CLICONN(,r=127.0.0.11:1112<->l=127.0.0.1:8977){CLOSED} connection closed -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37232?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I3cd6e3ed36c2a52acc08e92439c34f6e1e7b5d5d Gerrit-Change-Number: 37232 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmo-netif[master]: stream_test: Increase log level to debug
by daniel 15 Jun '24

15 Jun '24

Attention is currently required from: jolly. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37232?usp=email ) Change subject: stream_test: Increase log level to debug ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37232?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I3cd6e3ed36c2a52acc08e92439c34f6e1e7b5d5d Gerrit-Change-Number: 37232 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Sat, 15 Jun 2024 07:10:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT
by fixeria 15 Jun '24

15 Jun '24

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 06:09:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: mgcp_test.c: verify osmo-mgw accepts m=audio 0
by fixeria 15 Jun '24

15 Jun '24

Attention is currently required from: dexter, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37233?usp=email ) Change subject: mgcp_test.c: verify osmo-mgw accepts m=audio 0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37233?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I42011c2e7256d372a37b6a2fe86af0153038e2d0 Gerrit-Change-Number: 37233 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 05:25:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix -Wswitch in tch_voice_state_init()
by fixeria 15 Jun '24

15 Jun '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email ) Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ...................................................................... mobile: cosmetic: fix -Wswitch in tch_voice_state_init() Not really critical, just make gcc happy: tch_voice.c: In function ‘tch_voice_state_init’: tch_voice.c:117:9: warning: enumeration value ‘TCH_VOICE_IOH_GAPK’ not handled in switch [-Wswitch] 117 | switch (state->handler) { | ^~~~~~ Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb --- M src/host/layer23/src/mobile/tch_voice.c 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/tch_voice.c b/src/host/layer23/src/mobile/tch_voice.c index ac793e8..a740f71 100644 --- a/src/host/layer23/src/mobile/tch_voice.c +++ b/src/host/layer23/src/mobile/tch_voice.c @@ -122,8 +122,8 @@ case TCH_VOICE_IOH_LOOPBACK: rr->audio_mode = AUDIO_RX_TRAFFIC_IND | AUDIO_TX_TRAFFIC_REQ; break; -#ifdef WITH_GAPK_IO case TCH_VOICE_IOH_GAPK: +#ifdef WITH_GAPK_IO if ((cd->chan_nr & RSL_CHAN_NR_MASK) == RSL_CHAN_Bm_ACCHs) state->gapk_io = gapk_io_state_alloc_mode_rate(ms, cd->mode, true); else /* RSL_CHAN_Lm_ACCHs */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb Gerrit-Change-Number: 37212 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()
by fixeria 15 Jun '24

15 Jun '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email ) Change subject: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep() ...................................................................... mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep() This is very unlikely to happen, because we set strongest to 127, but anyway we don't want to see those warnings: gsm48_rr.c: In function ‘gsm48_rr_tx_meas_rep.isra’: gsm48_rr.c:3714:74: warning: ‘strongest_i’ may be used uninitialized [-Wmaybe-uninitialized] 3714 | if (rrmeas->nc_rxlev_dbm[i] == strongest && i <= strongest_i) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ gsm48_rr.c:3696:31: note: ‘strongest_i’ was declared here 3696 | int i, index, strongest_i; | ^~~~~~~~~~~ Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 83287c1..1750c57 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -3703,6 +3703,7 @@ /* get 6 strongest measurements */ strongest = 127; /* infinite */ + strongest_i = -1; /* make gcc happy */ for (n = 0; n < 6; n++) { current = -128; /* -infinite */ index = 0; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d Gerrit-Change-Number: 37213 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT
by neels 15 Jun '24

15 Jun '24

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: msc: test re-assignment to match codec with MT ...................................................................... msc: test re-assignment to match codec with MT Related: osmo-msc I8760feaa8598047369ef8c3ab2673013bac8ac8a Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 84 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/35053/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT
by neels 15 Jun '24

15 Jun '24

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT ...................................................................... Patch Set 2: (3 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/3f87abb7_e977… PS2, Line 986: /* What to Codec (Chosen) to send back in Assignment Complete */ > "What to Codec to" doesn't make sense to me? […] thx https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/c7e7b22a_e3a1… PS2, Line 993: BSSMAP_FIELD_CodecElements re_ass_req_codecs, > Sounds like "optional" is missing in this field. it is always {FR} by default, so it is never actually absent. Should it still be marked optional? There is no practical benefit of 'optional', because there already is the expect_re_assignment flag -- that bool indicates usage for both re_ass_req_codecs and re_ass_compl_chosen_codec, so adding more optionality makes checks for presence more complex; point being that there is no caller ever using the optional part. The same is true for the already existing transaction_id: it is marked optional, yet it is always initialized. So maybe I am wrong here? But why add more possible states == more complexity?? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/664a4c15_0aaa… PS2, Line 995: re_ass_compl_chosen_codec > Sounds like "optional" is missing in this field. (s.a.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 03:06:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log