- gerrit-log - lists.osmocom.org

[S] Change in osmo-qcdiag[master]: Makefile: print files removed when running 'clean'
by fixeria 17 Jun '24

17 Jun '24

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37224?usp=email ) Change subject: Makefile: print files removed when running 'clean' ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/37224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: Ic93a43a8ee771f5d8eb5f36cc0c90aedea72a51c Gerrit-Change-Number: 37224 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jun 2024 05:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: fixeria, laforge, nt2mku. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 10: Code-Review+1 (1 comment) Patchset: PS10: I CR+1'd on the other patch, but I have no reason against this one really. I mean, when it's according to spec and verified to pass tests... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 10 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jun 2024 02:32:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gsm48_ie: add helper function for speech bearer cap on GSM MS side
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: falconia, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36967?usp=email ) Change subject: gsm48_ie: add helper function for speech bearer cap on GSM MS side ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36967/comment/dc9b1d48_d8463cb9 PS1, Line 9: The speech version list part of TS 24.008 section 10.5.4.5 bearer I think it would be great if this explanation is in the api doc comment for the function, because it helps to understand a great deal, and in a commit log it is far less visible than in the api doc... If it was me, I'd start it like ``` /*! Fill out full gsm_mncc_bearer_cap from speech version list and CTM flag. * * This function is meant to be called only [...]. * * The speech version list part of TS 24.008 [...] * [...] only v1 codecs are supported. */ int gsm48_ms_prepare_speech_bearer_cap(struct gsm_mncc_bearer_cap *bcap) { ``` Patchset: PS1: I'm a bit unsure, would be great to know if @vyanitskiy@sysmocom.de is good with this? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaf41687da1d377e98f26e6a16d991ab7d95be0fc Gerrit-Change-Number: 36967 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jun 2024 02:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Test initial IMS REGISTER timeout
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: jolly, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email ) Change subject: asterisk: Test initial IMS REGISTER timeout ...................................................................... Patch Set 2: (3 comments) File asterisk/Asterisk_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/4864920c_92cf… PS2, Line 51: /* Current default by pjproject (timeout_timer_val) to 32s, and not changed by Asterisk */ the comment doesn't seem to be a valid sentence? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/12c978c3_c8b4… PS2, Line 52: integer mp_volte_ims_outbound_register_timeout := 32; (wouldn't a float make more sense, since titan handles all timers in float? does it have to be limited to full integer values for some reason?) File asterisk/IMS_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/8c4b1484_eaf9… PS2, Line 211: t_guard := 60.0, in some test suites we can set individual test timeouts to a larger value by f_init(t_guard := 60.0) -- this here seems to generally double the time it takes to fail pre-existing tests by timeout? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If59d43b2779dfbd14890a88d664077c194f843a1 Gerrit-Change-Number: 37194 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jun 2024 02:10:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement SIP UA unregister
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email ) Change subject: asterisk: Implement SIP UA unregister ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: the diff shows weird in gerrit but this does in fact only add the f_SIP_unregister function, not adding more behavior in other functions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ea6be662db00e52dbd39c4f54bb656dc4587ec7 Gerrit-Change-Number: 37193 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jun 2024 02:02:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Test auth resync procedure
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email ) Change subject: asterisk: Test auth resync procedure ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4 Gerrit-Change-Number: 37191 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jun 2024 01:57:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Test auth resync procedure
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email ) Change subject: asterisk: Test auth resync procedure ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: This patch is huge. Can't say that I can quickly review this in full, but it's the test suite, right, and seems to work... File asterisk/Asterisk_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191/comment/50bf3e4a_d732… PS1, Line 367: private function f_AMI_IMS_start_register(IMS_ConnHdlrPars pars) runs on test_CT f_AMI_IMS_register_start() matching below f_AMI_IMS_register_auth() File asterisk/IMS_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191/comment/2443a3e1_60b5… PS1, Line 529: g_pars.subscr.auth.autn))) (indent off?) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4 Gerrit-Change-Number: 37191 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jun 2024 01:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: remsim_client: add support to set sim presence pin polarity
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email ) Change subject: remsim_client: add support to set sim presence pin polarity ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: (not really important: i think naming wise, it's more elegant to stick to one variant of the name, not mixing "_pres_" and "_presence_") -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iaa61967d2e8cd5c2269b73f4e65b42072e0ec513 Gerrit-Change-Number: 36983 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Jun 2024 01:45:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in simtrace2[master]: firmware: allow to change the sim presence pin polarity
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email ) Change subject: firmware: allow to change the sim presence pin polarity ...................................................................... Patch Set 6: Code-Review+1 (4 comments) Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/8761dd5c_d1434f16 PS6, Line 12: n "Even though" ? Patchset: PS6: rather fix the "prensence" typo in the symbol name before merging (see in-line comment). otherwise looks sane, though I don't know this code. File firmware/libcommon/include/simtrace.h: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/b99831f2_2b2a50c4 PS6, Line 128: prensence typo in the name, should be "_presence_" (same below) File firmware/libcommon/include/simtrace_prot.h: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/872ccfcf_c571d209 PS6, Line 274: is valid bit maybe "is a validity bit" or "indicates validity"? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456 Gerrit-Change-Number: 36981 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Jun 2024 01:34:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in docker-playground[master]: s1gw: add ttcn3-s1gw-test
by neels 17 Jun '24

17 Jun '24

Attention is currently required from: fixeria, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37230?usp=email ) Change subject: s1gw: add ttcn3-s1gw-test ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I95000d7a9d778df1da830cd5059e5b6899391fbe Gerrit-Change-Number: 37230 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jun 2024 01:22:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log