- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw
by pespin 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email ) Change subject: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File ttcn3-s1gw-test/S1GW_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/37270/comment/91b29da7_b14… PS1, Line 10: S1GW_Tests.mp_s1gw_enb_ip := "172.18.10.100"; My understanding is of this patch is that since we asked you drop the multiple interface changes to the docker setup, you decided to move back to use the same IP address for both sides. It's fine to keep using the same IP address, but if you really need/want to test with multiple addresses, you can do so in the docker setup too, by adding an intermediate .sh script which does "ip addr add A.B.C.D". We do that already in several testsuites like PGW, ePDG, Asterisk, etc. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I109a5feaca5acf050008e883cc8b4e1e28beebab Gerrit-Change-Number: 37270 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 16:29:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw
by fixeria 21 Jun '24

21 Jun '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email ) Change subject: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw ...................................................................... ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw This patch finally makes ttcn3-s1gw-test pass. Change-Id: I109a5feaca5acf050008e883cc8b4e1e28beebab Related: SYS#6772 --- M ttcn3-s1gw-test/S1GW_Tests.cfg M ttcn3-s1gw-test/osmo-s1gw.config 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/70/37270/1 diff --git a/ttcn3-s1gw-test/S1GW_Tests.cfg b/ttcn3-s1gw-test/S1GW_Tests.cfg index a81c95e..b0f6c2d 100644 --- a/ttcn3-s1gw-test/S1GW_Tests.cfg +++ b/ttcn3-s1gw-test/S1GW_Tests.cfg @@ -7,7 +7,7 @@ [TESTPORT_PARAMETERS] [MODULE_PARAMETERS] -S1GW_Tests.mp_s1gw_enb_ip := "172.18.10.200"; +S1GW_Tests.mp_s1gw_enb_ip := "172.18.10.100"; S1GW_Tests.mp_s1gw_mme_ip := "172.18.10.100"; S1GW_Tests.mp_mme_bind_ip := "172.18.10.101"; diff --git a/ttcn3-s1gw-test/osmo-s1gw.config b/ttcn3-s1gw-test/osmo-s1gw.config index 13b5058..4dabb8f 100644 --- a/ttcn3-s1gw-test/osmo-s1gw.config +++ b/ttcn3-s1gw-test/osmo-s1gw.config @@ -11,7 +11,7 @@ %% +----------------+ +-----------------+ %% ================================================================================ {osmo_s1gw, - [{s1gw_bind_addr, "172.18.10.200"}, %% S1GW bind address for incoming eNB connections + [{s1gw_bind_addr, "172.18.10.100"}, %% S1GW bind address for incoming eNB connections {mme_loc_addr, "172.18.10.100"}, %% local address for outgoing connections to the MME {mme_rem_addr, "172.18.10.101"} %% remote address for outgoing connections to the MME ]}, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I109a5feaca5acf050008e883cc8b4e1e28beebab Gerrit-Change-Number: 37270 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement AMI Action DedicatedBearerStatus
by pespin 21 Jun '24

21 Jun '24

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37252?usp=email ) Change subject: asterisk: Implement AMI Action DedicatedBearerStatus ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49c216f8874fe63480414096d9c03a1af00a0fc2 Gerrit-Change-Number: 37252 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 21 Jun 2024 16:21:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: check Contact attributes on IMS side
by pespin 21 Jun '24

21 Jun '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37260?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: asterisk: check Contact attributes on IMS side ...................................................................... asterisk: check Contact attributes on IMS side Related: SYS#6877 Related: SYS#6981 Change-Id: I866d89ec137d264e257b05226900b744a93c257e --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn 2 files changed, 86 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/37260/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I866d89ec137d264e257b05226900b744a93c257e Gerrit-Change-Number: 37260 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: validate audio tag present in INVITE Contact header
by pespin 21 Jun '24

21 Jun '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37269?usp=email ) Change subject: asterisk: IMS: validate audio tag present in INVITE Contact header ...................................................................... asterisk: IMS: validate audio tag present in INVITE Contact header Related: SYS#6984 Change-Id: I36011f36f0dd3f9ddafd658d003373bd63d1ae1b --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 45 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/37269/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index d08dad4..b9a9852 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -338,7 +338,7 @@ f_sip_digest_validate_Authorization_AKAv1MD5(authorization, method, g_pars.subscr.auth.res); } - +/* GSMA IR-92 2.2.1 SIP Registration Procedure */ private function f_ims_validate_register_contact(Contact rx_contact) runs on IMS_ConnHdlr { /* IMS contact shows up like this: @@ -435,6 +435,34 @@ } } +/* GSMA IR.92 2.2.4 Call Establishment and Termination */ +private function f_ims_validate_INVITE_Contact(Contact rx_contact) runs on IMS_ConnHdlr +{ + /* INVITE Contact header shows up like this: + * Contact: <sip:e05d8e82-8565-47b5-aca5-5f6b9164b074@192.168.101.2:44823>;+g.3gpp.icsi-ref="urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel";audio;+g.3gpp.mid-call;+g.3gpp.srvcc-alerting;+g.3gpp.ps2cs-srvcc-orig-pre-alerting + */ + if (ischosen(rx_contact.contactBody.wildcard)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Received unexpected Contact wildcard := ", rx_contact)); + } + var ContactAddress_List caddrs := rx_contact.contactBody.contactAddresses; + if (lengthof(caddrs) == 0) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Received unexpected empty Contact Address list")); + } + for (var integer i := 0; i < lengthof(caddrs); i := i + 1) { + var ContactAddress caddr := caddrs[i]; + /* "The UE must include the audio media feature tag, as defined in IETF RFC 3840, + * in the Contact header field of the SIP INVITE request, and in the Contact header + * field of the SIP response to the SIP INVITE request" */ + if (not ispresent(caddr.contactParams)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Received unexpected empty Contact attributes (omit)")); + } + f_sip_param_match_value_or_fail(caddr.contactParams, "audio", omit); + } +} + private function f_ims_parse_security_client(Security_client security_client) runs on IMS_ConnHdlr { var boolean found := false; @@ -1187,7 +1215,7 @@ g_pars.subscr.cp.sip_seq_nr, "INVITE"); d_ringing := activate(as_SIP_ignore_resp(exp)); - /* Wait for OK answer */ + /* Wait for 200 OK (INVITE) answer */ exp := tr_SIP_Response( g_pars.subscr.cp.sip_call_id, from_addr_exp, @@ -1202,6 +1230,9 @@ deactivate(d_trying); deactivate(d_ringing); + /* Make sure "audio" tag set in Contact header */ + f_ims_validate_INVITE_Contact(g_rx_sip_resp.msgHeader.contact); + /* Update To with the tags received from peer: */ g_pars.subscr.cp.to_addr := g_rx_sip_resp.msgHeader.toField; @@ -1294,6 +1325,8 @@ via := g_rx_sip_req.msgHeader.via; f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := true); + f_ims_validate_INVITE_Contact(g_rx_sip_req.msgHeader.contact); + if (g_pars.subscr.cp.require_precondition_ext and not peer_support_precondition) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str(g_name & ": Missing '100rel,precondition' in INVITE Supported header: ", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37269?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I36011f36f0dd3f9ddafd658d003373bd63d1ae1b Gerrit-Change-Number: 37269 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: fix no-op 'connecting' state timeout
by pespin 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265?usp=email ) Change subject: sctp_proxy: fix no-op 'connecting' state timeout ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I45d874f3f73d5b9a8aa62c8a36e94e51497d6754 Gerrit-Change-Number: 37265 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 14:48:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: fix no-op 'connecting' state timeout
by fixeria 21 Jun '24

21 Jun '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265?usp=email ) Change subject: sctp_proxy: fix no-op 'connecting' state timeout ...................................................................... Patch Set 1: (2 comments) File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265/comment/fb883a69_31f1… PS1, Line 85: connecting(enter, OldState, > tip: I find it useful to prefix these state functions with "st_", this way it's clearer they are par […] I can rename states, but in a separate patch. This patch is fixing a timer... https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265/comment/0d662bda_29f3… PS1, Line 90: {next_state, connecting, S#{sock => Sock}, > Reentering the state from withing the enter phase looks a bit werid to me tbh. I think it's totally fine and the proper thing to do to "keep_state" in here [...] Looks like I did not emphasize this in the commit message clearly enough. I was under the same impression while writing this code, but as it turns out the `state_timeout` is ignored for `keep_state`. I did some experiments and found out that it only works for `next_state`, so this is why I am doing a loop state transition here. The API documentation confirms my discovery. > The problem I think is that in line 94 connecting_timeout, instead of shutting down you actually need to do "{next_state, connecting, ...}" No. I do not implement the re-connection logic here, so I am just terminating the FSM. This is intentional and not really related to the problem of timeout never expiring (no mater what value I schedule, even very short ones). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I45d874f3f73d5b9a8aa62c8a36e94e51497d6754 Gerrit-Change-Number: 37265 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 14:37:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: rebar.{config,lock}: add pfcplib to deps[]
by pespin 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37267?usp=email ) Change subject: rebar.{config,lock}: add pfcplib to deps[] ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37267?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4cf3b3b09b19ebabbaad082c616c31ffc1327fd7 Gerrit-Change-Number: 37267 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 12:34:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: reduce 'connecting' state timeout: 2000s -> 2s
by pespin 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37266?usp=email ) Change subject: sctp_proxy: reduce 'connecting' state timeout: 2000s -> 2s ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37266?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I79b04c0bc087d598b3e322fd697508ac840402d5 Gerrit-Change-Number: 37266 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 12:33:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: fix no-op 'connecting' state timeout
by pespin 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265?usp=email ) Change subject: sctp_proxy: fix no-op 'connecting' state timeout ...................................................................... Patch Set 1: (2 comments) File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265/comment/cd0d45a2_9fb1… PS1, Line 85: connecting(enter, OldState, tip: I find it useful to prefix these state functions with "st_", this way it's clearer they are part of the FSM https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265/comment/003d8c0c_f7b9… PS1, Line 90: {next_state, connecting, S#{sock => Sock}, Reentering the state from withing the enter phase looks a bit werid to me tbh. I think it's totally fine and the proper thing to do to "keep_state" in here, I did that in osmo-pedg and it was working with ttcn3 tests afair. The problem I think is that in line 94 connecting_timeout, instead of shutting down you actually need to do "{next_state, connecting, ...}" Feel free to look at it or merge it if anyway it works for you... -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I45d874f3f73d5b9a8aa62c8a36e94e51497d6754 Gerrit-Change-Number: 37265 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 12:33:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log