- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Expect P-Early-Media supported in MO INVITE
by laforge 03 Jul '24

03 Jul '24

Attention is currently required from: Hoernchen, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37325?usp=email ) Change subject: asterisk: IMS: Expect P-Early-Media supported in MO INVITE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37325?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I21f2c84b50be9b16fc45fa1fe72af40d715ee883 Gerrit-Change-Number: 37325 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jul 2024 20:11:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: asterisk: conf: Handle precondition through app_waitforprecondition.so
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37337?usp=email ) Change subject: asterisk: conf: Handle precondition through app_waitforprecondition.so ...................................................................... asterisk: conf: Handle precondition through app_waitforprecondition.so This module has been introduced recently, which allows handling precondition FSM during MT calls. Change-Id: I84eefec6cd38d50e88633ac01f606b1dda06bb43 --- M ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/37/37337/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf b/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf index 0b98707..e7ed535 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf @@ -38,6 +38,7 @@ [volte_ims] exten => _.!,1,Verbose(5,${EXTEN}: Call internal number from ${CALLERID(num)}) + same => n,WaitForPrecondition(10,2000); same => n,Gosub(get-valid-endpoints,s,1()) same => n,Set(DIALGROUP(CALL_EVERYONE_LIST)=${GOSUB_RETVAL}) same => n,Set(DIALGROUP(CALL_EVERYONE_LIST,del)=PJSIP/${CALLERID(num)}) ; remove the caller diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index f7bf49a..ea13360 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -1,3 +1,6 @@ +[global] +allow_sending_180_after_183=yes + ;############ ; LOCAL SIP ;############ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37337?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I84eefec6cd38d50e88633ac01f606b1dda06bb43 Gerrit-Change-Number: 37337 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: asterisk: Allow alaw code from IMS until evs is supported
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37338?usp=email ) Change subject: asterisk: Allow alaw code from IMS until evs is supported ...................................................................... asterisk: Allow alaw code from IMS until evs is supported EVS codec is not yet fully supported, specially if no specific implementation of the EVS API is available. Let's allow using alway from/to IMS for now, so calls can be made and tests work. Change-Id: I4835f73ef1b13343ff209f1aba84fab43427aa9d --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/38/37338/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index ea13360..574ecf6 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -106,6 +106,7 @@ type=endpoint context=volte_ims disallow=all +allow=alaw allow=vevs transport=transport-tcp outbound_auth=volte_ims -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37338?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4835f73ef1b13343ff209f1aba84fab43427aa9d Gerrit-Change-Number: 37338 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix seq_nr during MT calls
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37335?usp=email ) Change subject: asterisk: IMS: Fix seq_nr during MT calls ...................................................................... asterisk: IMS: Fix seq_nr during MT calls Change-Id: Ieeb9fb803ab3b1d02b5bfd8198702780914ec318 --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/37335/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 4b50c31..c7d87b2 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -1128,6 +1128,7 @@ var default d_trying, d_ringing; var charstring branch_value; var Contact calling_contact, called_contact; + var integer sip_seq_nr; /* RFC 3261 8.1.1.3 From */ g_pars.subscr.cp.from_addr := valueof(ts_From(g_pars.subscr.cp.calling.addr, g_pars.subscr.cp.calling.params)); @@ -1168,12 +1169,13 @@ supported := ts_Supported(supported_list); } + sip_seq_nr := g_pars.subscr.cp.sip_seq_nr; req := ts_SIP_INVITE(g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, via, calling_contact, - g_pars.subscr.cp.sip_seq_nr, + sip_seq_nr, accept := ts_Accept({ ts_AcceptBody("application/sdp"), ts_AcceptBody("application/3gpp-ims+xml") }), min_SE := min_SE, session_expires := session_expires, @@ -1187,7 +1189,7 @@ from_addr_exp, to_addr_exp, f_tr_Via_response(via), - g_pars.subscr.cp.sip_seq_nr, "INVITE"); + sip_seq_nr, "INVITE"); d_trying := activate(as_SIP_ignore_resp(exp)); if (g_pars.subscr.cp.mt.tx_coord_cmd_session_progress) { @@ -1203,7 +1205,7 @@ from_addr_exp, to_addr_exp, f_tr_Via_response(via), - g_pars.subscr.cp.sip_seq_nr, "INVITE", + sip_seq_nr, "INVITE", require := tr_Require(superset("100rel", "precondition")), rseq := tr_RSeq(?), body := ?); @@ -1310,13 +1312,14 @@ g_pars.subscr.cp.sip_seq_nr := g_rx_sip_resp.msgHeader.cSeq.seqNumber + 1; } + g_pars.subscr.cp.sip_seq_nr := g_pars.subscr.cp.sip_seq_nr + 1; /* Conditionally match and accept 180 Ringing */ exp := tr_SIP_Response_Ringing(g_pars.subscr.cp.sip_call_id, from_addr_exp, to_addr_exp, f_tr_Via_response(via), - g_pars.subscr.cp.sip_seq_nr, "INVITE"); + sip_seq_nr, "INVITE"); d_ringing := activate(as_SIP_ignore_resp(exp)); called_contact := g_rx_sip_resp.msgHeader.contact; @@ -1329,7 +1332,7 @@ f_tr_Via_response(via), called_contact, "INVITE", 200, - g_pars.subscr.cp.sip_seq_nr, "OK", + sip_seq_nr, "OK", body := *); as_SIP_expect_resp(exp, fail_others := false); @@ -1343,7 +1346,6 @@ g_pars.subscr.cp.to_addr := g_rx_sip_resp.msgHeader.toField; /* Transmit ACK */ - g_pars.subscr.cp.sip_seq_nr := g_pars.subscr.cp.sip_seq_nr + 1; req := ts_SIP_ACK(called_contact.contactBody.contactAddresses[0].addressField.nameAddr.addrSpec, g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37335?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieeb9fb803ab3b1d02b5bfd8198702780914ec318 Gerrit-Change-Number: 37335 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: Fix missing COORD messages during IMS MT call test
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37336?usp=email ) Change subject: asterisk: Fix missing COORD messages during IMS MT call test ...................................................................... asterisk: Fix missing COORD messages during IMS MT call test Change-Id: I1aab078d52d31382933511e5ca9ec427e0552ce1 --- M asterisk/Asterisk_Tests.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/37336/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 3dbb81c..9502ee8 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -878,9 +878,11 @@ f_ami_action_DedicatedBearerStatus(AMI_CLIENT, g_asterisk_chan_name, "Down", fail_others := false); + COORD.receive(COORD_CMD_CALL_FINISHED) from vc_conn_sip; /* Trigger unregistration: */ f_sleep(1.0); + COORD.send(COORD_CMD_UNREGISTER) to vc_conn_sip; AMI_CLIENT.clear; f_AMI_IMS_unregister(ims_pars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37336?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1aab078d52d31382933511e5ca9ec427e0552ce1 Gerrit-Change-Number: 37336 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix To tag not updated when sending PRACK in MT call
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37333?usp=email ) Change subject: asterisk: IMS: Fix To tag not updated when sending PRACK in MT call ...................................................................... asterisk: IMS: Fix To tag not updated when sending PRACK in MT call Change-Id: I55716b7a48b63bc97ea936904a712e53899f03f6 --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/37333/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 1609304..ec163f5 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -1238,6 +1238,9 @@ g_pars.subscr.cp.peer_sdp.media_list[0].attributes)); } + /* Update To with the tags received from peer: */ + g_pars.subscr.cp.to_addr := g_rx_sip_resp.msgHeader.toField; + /* Tx PRACK */ req := ts_SIP_PRACK(g_pars.subscr.cp.to_addr.addressField.nameAddr.addrSpec, g_pars.subscr.cp.sip_call_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37333?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I55716b7a48b63bc97ea936904a712e53899f03f6 Gerrit-Change-Number: 37333 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix Contact and URI headers during MT call precondition
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37334?usp=email ) Change subject: asterisk: IMS: Fix Contact and URI headers during MT call precondition ...................................................................... asterisk: IMS: Fix Contact and URI headers during MT call precondition Change-Id: Id0036adf850d71eda92d6c0f07eeb873bdfa9d0c --- M asterisk/IMS_ConnectionHandler.ttcn M asterisk/SIP_ConnectionHandler.ttcn M library/SIP_Templates.ttcn M sip/SIP_Tests.ttcn 4 files changed, 30 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34/37334/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index ec163f5..4b50c31 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -1127,7 +1127,7 @@ var charstring tx_sdp; var default d_trying, d_ringing; var charstring branch_value; - var Contact calling_contact; + var Contact calling_contact, called_contact; /* RFC 3261 8.1.1.3 From */ g_pars.subscr.cp.from_addr := valueof(ts_From(g_pars.subscr.cp.calling.addr, g_pars.subscr.cp.calling.params)); @@ -1238,11 +1238,12 @@ g_pars.subscr.cp.peer_sdp.media_list[0].attributes)); } + called_contact := g_rx_sip_resp.msgHeader.contact; /* Update To with the tags received from peer: */ g_pars.subscr.cp.to_addr := g_rx_sip_resp.msgHeader.toField; /* Tx PRACK */ - req := ts_SIP_PRACK(g_pars.subscr.cp.to_addr.addressField.nameAddr.addrSpec, + req := ts_SIP_PRACK(called_contact.contactBody.contactAddresses[0].addressField.nameAddr.addrSpec, g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, @@ -1263,11 +1264,11 @@ "PRACK", 200, g_rx_sip_resp.msgHeader.cSeq.seqNumber + 1, "OK", body := omit); - as_SIP_expect_resp(exp, fail_others := false); + as_SIP_expect_resp(exp); /* Tx UPDATE */ tx_sdp := f_gen_sdp(IMS_GEN_SDP_MO_UPDATE); - req := ts_SIP_UPDATE(g_pars.subscr.cp.to_addr.addressField.nameAddr.addrSpec, + req := ts_SIP_UPDATE(called_contact.contactBody.contactAddresses[0].addressField.nameAddr.addrSpec, g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, @@ -1283,11 +1284,11 @@ from_addr_exp, to_addr_exp, f_tr_Via_response(via), - omit, + called_contact, "UPDATE", 200, g_rx_sip_resp.msgHeader.cSeq.seqNumber + 1, "OK", body := ?); - as_SIP_expect_resp(exp, fail_others := false); + as_SIP_expect_resp(exp); /* Validate SDP in 200 OK (UPDATE) contains the preconditions: * a=curr:qos local sendrecv @@ -1318,13 +1319,15 @@ g_pars.subscr.cp.sip_seq_nr, "INVITE"); d_ringing := activate(as_SIP_ignore_resp(exp)); + called_contact := g_rx_sip_resp.msgHeader.contact; + /* Wait for 200 OK (INVITE) answer */ exp := tr_SIP_Response( g_pars.subscr.cp.sip_call_id, from_addr_exp, to_addr_exp, f_tr_Via_response(via), - *, + called_contact, "INVITE", 200, g_pars.subscr.cp.sip_seq_nr, "OK", body := *); @@ -1341,7 +1344,8 @@ /* Transmit ACK */ g_pars.subscr.cp.sip_seq_nr := g_pars.subscr.cp.sip_seq_nr + 1; - req := ts_SIP_ACK(g_pars.subscr.cp.sip_call_id, + req := ts_SIP_ACK(called_contact.contactBody.contactAddresses[0].addressField.nameAddr.addrSpec, + g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, via, diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index 0cb6167..f688fe0 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -531,7 +531,8 @@ g_pars.cp.to_addr := g_rx_sip_resp.msgHeader.toField; /* Transmit ACK */ - req := ts_SIP_ACK(g_pars.cp.sip_call_id, + req := ts_SIP_ACK(g_pars.cp.to_addr.addressField.nameAddr.addrSpec, + g_pars.cp.sip_call_id, g_pars.cp.from_addr, g_pars.cp.to_addr, via, diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 3d2112c..c05ab02 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -995,13 +995,14 @@ template (value) PDU_SIP_Request -ts_SIP_ACK(template (value) CallidString call_id, +ts_SIP_ACK(template (value) SipUrl uri, + template (value) CallidString call_id, template (value) From from_addr, template (value) To to_addr, template (value) Via via, integer seq_nr, template (omit) charstring body) := { - requestLine := ts_SIP_ReqLine(ACK_E, to_addr.addressField.nameAddr.addrSpec), + requestLine := ts_SIP_ReqLine(ACK_E, uri), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, ts_Contact({ ts_ContactAddress(from_addr.addressField, from_addr.fromParams) }), "ACK", seq_nr, diff --git a/sip/SIP_Tests.ttcn b/sip/SIP_Tests.ttcn index 74e0688..6064372 100644 --- a/sip/SIP_Tests.ttcn +++ b/sip/SIP_Tests.ttcn @@ -295,7 +295,8 @@ } [] SIP.receive { setverdict(fail, "Received unexpected SIP response"); - SIP.send(ts_SIP_ACK(cp.comp.sip_call_id, + SIP.send(ts_SIP_ACK(to_addr.addressField.nameAddr.addrSpec, + cp.comp.sip_call_id, from_addr, to_addr, via, cp.comp.sip_seq_nr, omit)); @@ -363,7 +364,8 @@ body := expect_sdp_to_sip)); /* OSC <- SIP: SIP world acknowledges "200 OK" */ - SIP.send(ts_SIP_ACK(cp.comp.sip_call_id, + SIP.send(ts_SIP_ACK(to_addr.addressField.nameAddr.addrSpec, + cp.comp.sip_call_id, from_addr, to_addr, via, cp.comp.sip_seq_nr, omit)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37334?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id0036adf850d71eda92d6c0f07eeb873bdfa9d0c Gerrit-Change-Number: 37334 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: WIP: asterisk: Avoid waiting for 183 to signal DedicatedBearerStatus Up
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37332?usp=email ) Change subject: WIP: asterisk: Avoid waiting for 183 to signal DedicatedBearerStatus Up ...................................................................... WIP: asterisk: Avoid waiting for 183 to signal DedicatedBearerStatus Up Change-Id: Icca6268f484d2a723d4d70de8755b7ec605b9194 --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/37332/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 51f96ea..1609304 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -1190,6 +1190,11 @@ g_pars.subscr.cp.sip_seq_nr, "INVITE"); d_trying := activate(as_SIP_ignore_resp(exp)); + if (g_pars.subscr.cp.mt.tx_coord_cmd_session_progress) { + /* Signal used to inform that Dedicated bearer can be established: */ + COORD.send(IMS_COORD_CMD_CALL_SESSION_PROGRESS); + } + if (g_pars.subscr.cp.require_precondition_ext) { var template (present) SDP_attribute_list preconds; /* Rx 183 Session Progress */ @@ -1246,11 +1251,6 @@ body := omit); SIP.send(req); - if (g_pars.subscr.cp.mt.tx_coord_cmd_session_progress) { - /* Signal used to inform that Dedicated bearer can be established: */ - COORD.send(IMS_COORD_CMD_CALL_SESSION_PROGRESS); - } - /* Rx 200 OK (PRACK) */ exp := tr_SIP_Response(g_pars.subscr.cp.sip_call_id, from_addr_exp, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icca6268f484d2a723d4d70de8755b7ec605b9194 Gerrit-Change-Number: 37332 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-e1d[master]: mux from not-started raw TS: fill with 0xFF
by falconia 03 Jul '24

03 Jul '24

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37321?usp=email ) Change subject: mux from not-started raw TS: fill with 0xFF ...................................................................... mux from not-started raw TS: fill with 0xFF When the channelized mux reads from a raw TS, but that raw TS is not in tx_started state yet, the read function returns "fake" data. However, it was actually returning uninitialized memory content, rather than 0xFF filler used everywhere else, thereby transmitting uninit-memory garbage to whatever is connected to the E1 line. Change it to fill with 0xFF, same as the filler used in other cases such as inactive timeslots. Change-Id: I42849a6d19b020bab789853c3b60af6a1c09f92f --- M src/mux_demux.c 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve tnt: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/mux_demux.c b/src/mux_demux.c index a0ae717..72379fe 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -55,8 +55,10 @@ /* If we're not started yet, we 'fake' data until the other side * send something */ - if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) + if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) { + memset(buf, 0xFF, len); return len; + } ts->raw.tx_started = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I42849a6d19b020bab789853c3b60af6a1c09f92f Gerrit-Change-Number: 37321 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1d[master]: mux_demux.c cosmetic: fix indent level in _e1_tx_raw()
by falconia 03 Jul '24

03 Jul '24

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37320?usp=email ) Change subject: mux_demux.c cosmetic: fix indent level in _e1_tx_raw() ...................................................................... mux_demux.c cosmetic: fix indent level in _e1_tx_raw() Change-Id: Ie0674d6500c9f66b58a7fca8bf28dada035d28d0 --- M src/mux_demux.c 1 file changed, 18 insertions(+), 9 deletions(-) Approvals: tnt: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/mux_demux.c b/src/mux_demux.c index dd8ca45..a0ae717 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -48,19 +48,19 @@ static int _e1_tx_raw(struct e1_ts *ts, uint8_t *buf, int len) { - int l; + int l; - l = read(ts->fd, buf, len); - /* FIXME: handle underflow */ + l = read(ts->fd, buf, len); + /* FIXME: handle underflow */ - /* If we're not started yet, we 'fake' data until the other side - * send something */ - if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) - return len; + /* If we're not started yet, we 'fake' data until the other side + * send something */ + if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) + return len; - ts->raw.tx_started = true; + ts->raw.tx_started = true; - return l; + return l; } static int -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie0674d6500c9f66b58a7fca8bf28dada035d28d0 Gerrit-Change-Number: 37320 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log