Attention is currently required from: daniel, fixeria, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by daniel, Code-Review+2 by pespin, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: Makefile: new file
......................................................................
Makefile: new file
Add a Makefile similar to the ones in osmo-epdg and osmo-s1gw.
Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486
---
A Makefile
1 file changed, 41 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/40/37340/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37340?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: Ida7ce261bfaac845ecdbec43e0bdd7d1669e5486
Gerrit-Change-Number: 37340
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset
fixeria has created a revert of this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37226?usp=email )
Change subject: s1ap: add {enc,dec}_S1AP_Global_ENB_ID() API
......................................................................
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37226?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I856fd426b92046dcae72149f46737da3e1b65219
Gerrit-Change-Number: 37226
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: revert
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37226?usp=email )
Change subject: s1ap: add {enc,dec}_S1AP_Global_ENB_ID() API
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Huh, I thought I marked it WIP? I don't think this is going to work with libfftranscode. […]
Indeed, we have a regression in ttcn3-mme-test now:
```
TC_RIM_RAN_INF0(34)@79228701f472: Dynamic test case error: Unknown coding method requested to encode type '@S1AP-IEs.Global-ENB-ID'
TC_RIM_RAN_INF0(34)@79228701f472: setverdict(error): none -> error
TC_RIM_RAN_INF0(34)@79228701f472: Final verdict of PTC: error
```
I am reverting this patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37226?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I856fd426b92046dcae72149f46737da3e1b65219
Gerrit-Change-Number: 37226
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 04 Jul 2024 20:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment