- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim.esim.http_json_api: 'header' is not always present in response
by laforge 16 Jul '24

16 Jul '24

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37496?usp=email ) Change subject: pySim.esim.http_json_api: 'header' is not always present in response ...................................................................... Patch Set 1: (1 comment) File pySim/esim/http_json_api.py: https://gerrit.osmocom.org/c/pysim/+/37496/comment/0509f59a_99ab6ce3 PS1, Line 259: return None > this violates the return type hint for this function […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia3c5703b746c1eba91f85f8545f849a3f2d56e0b Gerrit-Change-Number: 37496 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jul 2024 14:58:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim.esim.http_json_api: 'header' is not always present in response
by laforge 16 Jul '24

16 Jul '24

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37496?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySim.esim.http_json_api: 'header' is not always present in response ...................................................................... pySim.esim.http_json_api: 'header' is not always present in response For example, the ES9+ handleNotification function is defined with an empty response body, so we cannot unconditionally assume that every HTTP response will contain a JSON "header" value. Change-Id: Ia3c5703b746c1eba91f85f8545f849a3f2d56e0b --- M pySim/esim/http_json_api.py 1 file changed, 26 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/96/37496/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia3c5703b746c1eba91f85f8545f849a3f2d56e0b Gerrit-Change-Number: 37496 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in pysim[master]: contrib/es9p_client: Add support for reporting notifications to SM-DP+
by laforge 16 Jul '24

16 Jul '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37499?usp=email ) Change subject: contrib/es9p_client: Add support for reporting notifications to SM-DP+ ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iefba7fa0471b34eae30700ed43531a515af0eb93 Gerrit-Change-Number: 37499 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jul 2024 14:55:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification
by laforge 16 Jul '24

16 Jul '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37511?usp=email ) Change subject: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification ...................................................................... osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification As SGP.22 states, the handleNotification endpoint uses HTTP status 204, not 200 (due to its empty body). Change-Id: I890bdbd3e1c4578d2d5f0367958fdce26e338cac --- M osmo-smdpp.py M pySim/esim/es9p.py 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/11/37511/1 diff --git a/osmo-smdpp.py b/osmo-smdpp.py index e9638aa..4420b1c 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -526,6 +526,9 @@ print("handleNotification: EID %s: %s of %s" % (eid, pmo, iccid)) else: raise ValueError(pendingNotification) + # SGP.22 Section 6.3: "A normal notification function execution status (MEP Notification) + # SHALL be indicated by the HTTP status code '204' (No Content) with an empty HTTP response body" + request.setResponseCode(204) #(a)app.route('/gsma/rsp3/es9plus/handleDeviceChangeRequest, methods=['POST']') #@rsp_api_wrapper diff --git a/pySim/esim/es9p.py b/pySim/esim/es9p.py index 41f2eeb..2c4b10f 100644 --- a/pySim/esim/es9p.py +++ b/pySim/esim/es9p.py @@ -136,6 +136,7 @@ 'pendingNotification': param.PendingNotification, } input_mandatory = ['pendingNotification'] + expected_http_status = 204 # ES9+ CancelSession function (SGP.22 section 6.5.2.10) class CancelSession(Es9PlusApiFunction): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I890bdbd3e1c4578d2d5f0367958fdce26e338cac Gerrit-Change-Number: 37511 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: osmo-smdpp: Request enable/disable/delete notifications in metadata
by laforge 16 Jul '24

16 Jul '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37509?usp=email ) Change subject: osmo-smdpp: Request enable/disable/delete notifications in metadata ...................................................................... osmo-smdpp: Request enable/disable/delete notifications in metadata this way, the eUICC will send us notifications whenever our profiles are enabled/disabled/deleted. Change-Id: I2861290864522b691b30b079c7c2e1466904df2d --- M osmo-smdpp.py M pySim/esim/es8p.py 2 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/09/37509/1 diff --git a/osmo-smdpp.py b/osmo-smdpp.py index cc4b121..e9638aa 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -376,6 +376,9 @@ # Put together profileMetadata + _bin ss.profileMetadata = ProfileMetadata(iccid_bin=h2b(swap_nibbles(iccid_str)), spn="OsmocomSPN", profile_name=matchingId) + # enable notifications for all operations + for event in ['enable', 'disable', 'delete']: + ss.profileMetadata.add_notification(event, self.server_hostname) profileMetadata_bin = ss.profileMetadata.gen_store_metadata_request() # Put together smdpSigned2 + _bin diff --git a/pySim/esim/es8p.py b/pySim/esim/es8p.py index ff266ce..a5c88f0 100644 --- a/pySim/esim/es8p.py +++ b/pySim/esim/es8p.py @@ -25,6 +25,7 @@ import pySim.esim.rsp as rsp from pySim.esim.bsp import BspInstance +from pySim.esim import PMO # Given that GSMA RSP uses ASN.1 in a very weird way, we actually cannot encode the full data type before # signing, but we have to build parts of it separately first, then sign that, so we can put the signature @@ -78,6 +79,11 @@ self.iccid_bin = iccid_bin self.spn = spn self.profile_name = profile_name + self.notifications = [] + + def add_notification(self, event: str, address: str): + """Add an 'other' notification to the notification configuration of the metadata""" + self.notifications.append((event, address)) def gen_store_metadata_request(self) -> bytes: """Generate encoded (but unsigned) StoreMetadataReqest DO (SGP.22 5.5.3)""" @@ -86,6 +92,12 @@ 'serviceProviderName': self.spn, 'profileName': self.profile_name, } + nci = [] + for n in self.notifications: + pmo = PMO(n[0]) + nci.append({'profileManagementOperation': pmo.to_bitstring(), 'notificationAddress': n[1]}) + if len(nci): + smr['notificationConfigurationInfo'] = nci return rsp.asn1.encode('StoreMetadataRequest', smr) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37509?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2861290864522b691b30b079c7c2e1466904df2d Gerrit-Change-Number: 37509 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: osmo-smdpp: Implement 'other' notification signature validation
by laforge 16 Jul '24

16 Jul '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37508?usp=email ) Change subject: osmo-smdpp: Implement 'other' notification signature validation ...................................................................... osmo-smdpp: Implement 'other' notification signature validation "other" notifications (enable, disable, delete) contain ECDSA signatures that also need verification. Change-Id: If610058b7af6f9fc7822576c93f9970e2ce9aba9 --- M osmo-smdpp.py 1 file changed, 36 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/08/37508/1 diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 390db18..cc4b121 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -35,7 +35,7 @@ from pySim.utils import h2b, b2h, swap_nibbles import pySim.esim.rsp as rsp -from pySim.esim import saip +from pySim.esim import saip, PMO from pySim.esim.es8p import * from pySim.esim.x509_cert import oid, cert_policy_has_oid, cert_get_auth_key_id from pySim.esim.x509_cert import CertAndPrivkey, CertificateSet, cert_get_subject_key_id, VerifyError @@ -494,13 +494,33 @@ pird_bin = rsp.asn1.encode('ProfileInstallationResultData', pird) # verify eUICC signature if not self._ecdsa_verify(ss.euicc_cert, profileInstallRes['euiccSignPIR'], pird_bin): - print("Unable to verify eUICC signature") + raise Exception('ECDSA signature verification failed on notification') print("Profile Installation Final Result: ", pird['finalResult']) # remove session state del self.rss[transactionId] elif pendingNotification[0] == 'otherSignedNotification': - # TODO - pass + otherSignedNotif = pendingNotification[1] + # TODO: use some kind of partially-parsed original data, don't re-encode? + euiccCertificate_bin = rsp.asn1.encode('Certificate', otherSignedNotif['euiccCertificate']) + eumCertificate_bin = rsp.asn1.encode('Certificate', otherSignedNotif['eumCertificate']) + euicc_cert = x509.load_der_x509_certificate(euiccCertificate_bin) + eum_cert = x509.load_der_x509_certificate(eumCertificate_bin) + ci_cert_id = cert_get_auth_key_id(eum_cert) + # Verify the validity of the eUICC certificate chain + cs = CertificateSet(self.ci_get_cert_for_pkid(ci_cert_id)) + cs.add_intermediate_cert(eum_cert) + # TODO v3: otherCertsInChain + cs.verify_cert_chain(euicc_cert) + tbs_bin = rsp.asn1.encode('NotificationMetadata', otherSignedNotif['tbsOtherNotification']) + if not self._ecdsa_verify(euicc_cert, otherSignedNotif['euiccNotificationSignature'], tbs_bin): + raise Exception('ECDSA signature verification failed on notification') + other_notif = otherSignedNotif['tbsOtherNotification'] + pmo = PMO.from_bitstring(other_notif['profileManagementOperation']) + eid = euicc_cert.subject.get_attributes_for_oid(x509.oid.NameOID.SERIAL_NUMBER)[0].value + iccid = other_notif.get('iccid', None) + if iccid: + iccid = swap_nibbles(b2h(iccid)) + print("handleNotification: EID %s: %s of %s" % (eid, pmo, iccid)) else: raise ValueError(pendingNotification) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If610058b7af6f9fc7822576c93f9970e2ce9aba9 Gerrit-Change-Number: 37508 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim.esim.es8p: Add support for encoding icon in ProfileMetadata
by laforge 16 Jul '24

16 Jul '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37510?usp=email ) Change subject: pySim.esim.es8p: Add support for encoding icon in ProfileMetadata ...................................................................... pySim.esim.es8p: Add support for encoding icon in ProfileMetadata Change-Id: I8c6a0c628f07c2a9608174457d20b8955114731a --- M pySim/esim/es8p.py 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/10/37510/1 diff --git a/pySim/esim/es8p.py b/pySim/esim/es8p.py index a5c88f0..ba824d6 100644 --- a/pySim/esim/es8p.py +++ b/pySim/esim/es8p.py @@ -79,8 +79,20 @@ self.iccid_bin = iccid_bin self.spn = spn self.profile_name = profile_name + self.icon = None + self.icon_type = None self.notifications = [] + def set_icon(self, is_png: bool, icon_data: bytes): + """Set the icon that is part of the metadata.""" + if len(icon_data) > 1024: + raise ValueError('Icon data must not exceed 1024 bytes') + self.icon = icon_data + if is_png: + self.icon_type = 1 + else: + self.icon_type = 0 + def add_notification(self, event: str, address: str): """Add an 'other' notification to the notification configuration of the metadata""" self.notifications.append((event, address)) @@ -92,6 +104,9 @@ 'serviceProviderName': self.spn, 'profileName': self.profile_name, } + if self.icon: + smr['icon'] = self.icon + smr['iconType'] = self.icon_type nci = [] for n in self.notifications: pmo = PMO(n[0]) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8c6a0c628f07c2a9608174457d20b8955114731a Gerrit-Change-Number: 37510 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: gerrit-verifications-dahdi: set concurrent: false
by pespin 16 Jul '24

16 Jul '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37505?usp=email ) Change subject: gerrit-verifications-dahdi: set concurrent: false ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fd4e85f0930b15b6c67e70fb2c140392c910bf5 Gerrit-Change-Number: 37505 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jul 2024 12:54:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/various: clean workspace on success
by pespin 16 Jul '24

16 Jul '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37506?usp=email ) Change subject: jobs/various: clean workspace on success ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibedef518782ea9f68c6386f1ce7fba216e1886bc Gerrit-Change-Number: 37506 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jul 2024 12:53:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: gerrit-verifications-dahdi: set concurrent: false
by osmith 16 Jul '24

16 Jul '24

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37505?usp=email ) Change subject: gerrit-verifications-dahdi: set concurrent: false ...................................................................... Patch Set 2: (1 comment) File jobs/gerrit-verifications-dahdi.yml: https://gerrit.osmocom.org/c/osmo-ci/+/37505/comment/8bde469e_9c754f8e PS1, Line 26: concurrent: false > I'd add a comment explaining that the sole rationale to have this as false is disk space, nothing re […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fd4e85f0930b15b6c67e70fb2c140392c910bf5 Gerrit-Change-Number: 37505 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jul 2024 12:46:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log