- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: pySim-shell: add "fsdump" command
by laforge 21 Jul '24

21 Jul '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37543?usp=email ) Change subject: pySim-shell: add "fsdump" command ...................................................................... pySim-shell: add "fsdump" command This command exports the entire filesystem state as one JSON document, which can be useful for storing it in a noSQL database, or for doing a structured diff between different such dumps. It's similar to "export", but then reasonably different to rectify a separate command. Change-Id: Ib179f57bc04d394efe11003ba191dca6098192d3 --- M docs/shell.rst M pySim-shell.py M pySim/exceptions.py 3 files changed, 198 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/37543/1 diff --git a/docs/shell.rst b/docs/shell.rst index 111c502..768765e 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -145,6 +145,32 @@ trying to SELECT them. +fsdump +~~~~~~ +.. argparse:: + :module: pySim-shell + :func: PySimCommands.fsdump_parser + +Please note that `fsdump` works relative to the current working +directory, so if you are in `MF`, then the dump will contain all known +files on the card. However, if you are in `ADF.ISIM`, only files below +that ADF will be part of the dump. + +Furthermore, it is strongly advised to first enter the ADM1 pin +(`verify_adm`) to maximize the chance of having permission to read +all/most files. + +One use case for this is to systematically analyze the differences between the contents of two +cards. To do this, you can create fsdumps of the two cards, and then use some general-purpose JSON +diffing tool like `jycm --show` (see https://github.com/eggachecat/jycm). + +Example: +:: + + pySIM-shell (00:MF)> fsdump > /tmp/fsdump.json + pySIM-shell (00:MF)> + + tree ~~~~ Display a tree of the card filesystem. It is important to note that this displays a tree diff --git a/pySim-shell.py b/pySim-shell.py index 7523ca2..548bb46 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -719,6 +719,150 @@ raise RuntimeError( "unable to export %i dedicated files(s)%s" % (context['ERR'], exception_str_add)) + def fsdump_ef(self, filename, context, as_json): + """Select and dump a single elementary file (EF) """ + # TODO: this is very similar to export_ef(), but I couldn't really come up with a way to share + # code between the two. They only hypothetical option could be turn "export" into a mere + # post-processing / printing function that works on the fsdump-generated dict/json? + df = self._cmd.lchan.selected_file + + # The currently selected file (not the file we are going to export) + # must always be an ADF or DF. From this starting point we select + # the EF we want to export. To maintain consistency we will then + # select the current DF again (see comment below). + if not isinstance(df, CardDF): + raise RuntimeError("currently selected file %s is not a DF or ADF" % str(df)) + + df_path_list = df.fully_qualified_path(True) + df_path = df.fully_qualified_path_str(True) + df_path_fid = df.fully_qualified_path_str(False) + + file_str = df_path + "/" + str(filename) + + res = { + 'path': df_path_list + [str(filename)], + } + + try: + fcp_dec = self._cmd.lchan.select(filename, self._cmd) + + res['fcp_raw'] = str(self._cmd.lchan.selected_file_fcp_hex) + res['fcp'] = fcp_dec + + structure = self._cmd.lchan.selected_file_structure() + if structure == 'transparent': + if as_json: + result = self._cmd.lchan.read_binary_dec() + body = result[0] + else: + result = self._cmd.lchan.read_binary() + body = str(result[0]) + elif structure == 'cyclic' or structure == 'linear_fixed': + body = [] + # Use number of records specified in select response + num_of_rec = self._cmd.lchan.selected_file_num_of_rec() + if num_of_rec: + for r in range(1, num_of_rec + 1): + if as_json: + result = self._cmd.lchan.read_record_dec(r) + body.append(result[0]) + else: + result = self._cmd.lchan.read_record(r) + body.append(str(result[0])) + + # When the select response does not return the number of records, read until we hit the + # first record that cannot be read. + else: + r = 1 + while True: + try: + if as_json: + result = self._cmd.lchan.read_record_dec(r) + body.append(result[0]) + else: + result = self._cmd.lchan.read_record(r) + body.append(result[0]) + except SwMatchError as e: + # We are past the last valid record - stop + if e.sw_actual == "9402": + break + # Some other problem occurred + else: + raise e + r = r + 1 + elif structure == 'ber_tlv': + tags = self._cmd.lchan.retrieve_tags() + body = {} + for t in tags: + result = self._cmd.lchan.retrieve_data(t) + (tag, l, val, remainer) = bertlv_parse_one(h2b(result[0])) + body[t] = b2h(val) + else: + raise RuntimeError('Unsupported structure "%s" of file "%s"' % (structure, filename)) + res['body'] = body + + except SwMatchError as e: + res['error'] = { + 'sw_actual': e.sw_actual, + 'sw_expected': e.sw_expected, + 'message': e.description, + } + except Exception as e: + raise(e) + res['error'] = { + 'message': str(e) + } + + context['result']['files'][file_str] = res + + # When reading the file is done, make sure the parent file is + # selected again. This will be the usual case, however we need + # to check before since we must not select the same DF twice + if df != self._cmd.lchan.selected_file: + self._cmd.lchan.select(df.fid or df.aid, self._cmd) + + + fsdump_parser = argparse.ArgumentParser() + fsdump_parser.add_argument( + '--filename', type=str, default=None, help='only export specific (named) file') + fsdump_parser.add_argument( + '--json', action='store_true', help='export file contents as JSON (less reliable)') + + @cmd2.with_argparser(fsdump_parser) + def do_fsdump(self, opts): + """Export filesystem metadata and file contents of all files below current DF in + machine-readable json format. This is similar to "export", but much easier to parse by + downstream processing tools. You usually may want to call this from the MF and verify + the ADM1 PIN (if available) to maximize the amount of readable files.""" + result = { + 'name': self._cmd.card.name, + 'atr': self._cmd.rs.identity['ATR'], + 'eid': self._cmd.rs.identity.get('EID', None), + 'iccid': self._cmd.rs.identity.get('ICCID', None), + 'aids': {x.aid:{} for x in self._cmd.rs.mf.applications.values()}, + 'files': {}, + } + print(result) + context = {'result': result, 'DF_SKIP': 0, 'DF_SKIP_REASON': []} + kwargs_export = {'as_json': opts.json} + exception_str_add = "" + + if opts.filename: + # export only that one specified file + self.export_ef(opts.filename, context, **kwargs_export) + else: + # export an entire subtree + try: + self.walk(0, self.fsdump_ef, None, context, **kwargs_export) + except Exception as e: + print("# Stopping early here due to exception: " + str(e)) + print("#") + exception_str_add = ", also had to stop early due to exception:" + str(e) + #raise e + + self._cmd.poutput_json(context['result']) + + def do_desc(self, opts): """Display human readable file description for the currently selected file""" desc = self._cmd.lchan.selected_file.desc diff --git a/pySim/exceptions.py b/pySim/exceptions.py index f726aa6..1c9e3b8 100644 --- a/pySim/exceptions.py +++ b/pySim/exceptions.py @@ -49,9 +49,18 @@ self.sw_expected = sw_expected self.rs = rs - def __str__(self): + @property + def description(self): if self.rs and self.rs.lchan[0]: r = self.rs.lchan[0].interpret_sw(self.sw_actual) if r: - return "SW match failed! Expected %s and got %s: %s - %s" % (self.sw_expected, self.sw_actual, r[0], r[1]) - return "SW match failed! Expected %s and got %s." % (self.sw_expected, self.sw_actual) + return "%s - %s" % (r[0], r[1]) + return '' + + def __str__(self): + description = self.description + if description: + description = ": " + description + else: + description = "." + return "SW match failed! Expected %s and got %s%s" % (self.sw_expected, self.sw_actual, description) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib179f57bc04d394efe11003ba191dca6098192d3 Gerrit-Change-Number: 37543 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim.global_platform.ota: Support KVN 0x70 for SCP02
by laforge 21 Jul '24

21 Jul '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37542?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim.global_platform.ota: Support KVN 0x70 for SCP02 ...................................................................... pySim.global_platform.ota: Support KVN 0x70 for SCP02 This is a non-standard extension of sysmocom products. Change-Id: I00d52f7629aae190ee487ea3453f42b5f94cf42f --- M pySim/global_platform/scp.py 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/37542/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37542?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I00d52f7629aae190ee487ea3453f42b5f94cf42f Gerrit-Change-Number: 37542 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: saip-tool: Fix TAR display for implicit TAR
by laforge 20 Jul '24

20 Jul '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37541?usp=email ) Change subject: saip-tool: Fix TAR display for implicit TAR ...................................................................... saip-tool: Fix TAR display for implicit TAR Until Change-Id Ifba1048e3000829d54769b0420f5134e2f9b04e1 the TAR output was working for implicit tar. With said commit we fixed it for explicit tar but broke implicit tar. With this commit it works for both implicit and explicit TAR. Change-Id: I76133b0e02996a138257f3fba5ceb0d2fc6fad80 --- M contrib/saip-tool.py 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/37541/1 diff --git a/contrib/saip-tool.py b/contrib/saip-tool.py index 8208602..d9d33c0 100755 --- a/contrib/saip-tool.py +++ b/contrib/saip-tool.py @@ -202,7 +202,8 @@ adf = rfm.decoded.get('adfRFMAccess', None) if adf: print("\tADF AID: %s" % b2h(adf['adfAID'])) - for tar in rfm.decoded['tarList']: + tar_list = rfm.decoded.get('tarList', [inst_aid[-3:]]) + for tar in tar_list: print("\tTAR: %s" % b2h(tar)) def do_extract_apps(pes:ProfileElementSequence, opts): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37541?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I76133b0e02996a138257f3fba5ceb0d2fc6fad80 Gerrit-Change-Number: 37541 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim.global_platform.ota: Support KVN 0x70 for SCP02
by laforge 20 Jul '24

20 Jul '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37542?usp=email ) Change subject: pySim.global_platform.ota: Support KVN 0x70 for SCP02 ...................................................................... pySim.global_platform.ota: Support KVN 0x70 for SCP02 This is a non-standard extension of sysmocom products. Change-Id: I00d52f7629aae190ee487ea3453f42b5f94cf42f --- M pySim/global_platform/scp.py 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/37542/1 diff --git a/pySim/global_platform/scp.py b/pySim/global_platform/scp.py index 967a582..0d52f04 100644 --- a/pySim/global_platform/scp.py +++ b/pySim/global_platform/scp.py @@ -115,6 +115,11 @@ if not card_keys.kvn in range(self.kvn_range[0], self.kvn_range[1]+1): raise ValueError('%s cannot be used with KVN outside range 0x%02x..0x%02x' % (self.__class__.__name__, self.kvn_range[0], self.kvn_range[1])) + elif hasattr(self, 'kvn_ranges'): + if all([not card_keys.kvn in range(x[0], x[1]+1) for x in self.kvn_ranges]): + raise ValueError('%s cannot be used with KVN outside permitted ranges %s' % + (self.__class__.__name__, self.kvn_ranges)) + self.lchan_nr = lchan_nr self.card_keys = card_keys self.sk = None @@ -216,7 +221,8 @@ constr_iur = Struct('key_div_data'/Bytes(10), 'key_ver'/Int8ub, Const(b'\x02'), 'seq_counter'/Int16ub, 'card_challenge'/Bytes(6), 'card_cryptogram'/Bytes(8)) - kvn_range = [0x20, 0x2f] + # The 0x70 is a non-spec special-case of sysmoISIM-SJA2/SJA5 and possibly more sysmocom products + kvn_ranges = [[0x20, 0x2f], [0x70, 0x70]] def __init__(self, *args, **kwargs): self.overhead = 8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37542?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I00d52f7629aae190ee487ea3453f42b5f94cf42f Gerrit-Change-Number: 37542 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-python-tests[master]: contrib/jenkins.sh: use virtualenv and pip
by fixeria 20 Jul '24

20 Jul '24

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37540?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: contrib/jenkins.sh: use virtualenv and pip ...................................................................... contrib/jenkins.sh: use virtualenv and pip setup.py install is deprecated: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ Change-Id: I42ba71e2fd0ceb8466758ea46e9ae33e3d4fcb91 --- M contrib/jenkins.sh 1 file changed, 18 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/40/37540/2 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I42ba71e2fd0ceb8466758ea46e9ae33e3d4fcb91 Gerrit-Change-Number: 37540 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo-python-tests[master]: contrib/jenkins.sh: do not run test_py3.py twice
by fixeria 20 Jul '24

20 Jul '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37539?usp=email ) Change subject: contrib/jenkins.sh: do not run test_py3.py twice ...................................................................... contrib/jenkins.sh: do not run test_py3.py twice Change-Id: Ib7e8e358d38be37055d44c8ff284d1578a30f6ac --- M contrib/jenkins.sh 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/39/37539/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index b129190..810cb7e 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -8,7 +8,6 @@ PY3=python3 PY3_LIST="osmopy scripts/osmo_ctrl.py scripts/osmo_rate_ctr2csv.py scripts/osmodumpdoc.py scripts/osmotestvty.py scripts/osmotestconfig.py scripts/osmo_interact_ctrl.py scripts/osmo_interact_vty.py scripts/osmo_verify_transcript_ctrl.py scripts/osmo_verify_transcript_vty.py scripts/soap.py scripts/twisted_ipa.py" $PY3 ./setup.py install --user -$PY3 tests/test_py3.py for f in $PY3_LIST do $PY3 $COM_FLAGS $f -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Ib7e8e358d38be37055d44c8ff284d1578a30f6ac Gerrit-Change-Number: 37539 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-python-tests[master]: [pylint] osmopy/obscvty.py: fix E1130 (invalid-unary-operand-type)
by fixeria 20 Jul '24

20 Jul '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37538?usp=email ) Change subject: [pylint] osmopy/obscvty.py: fix E1130 (invalid-unary-operand-type) ...................................................................... [pylint] osmopy/obscvty.py: fix E1130 (invalid-unary-operand-type) This is not really a problem. Just making pylint happy. Change-Id: I32b637fdc0941d051e80e677857321b861ae0c20 --- M osmopy/obscvty.py 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/38/37538/1 diff --git a/osmopy/obscvty.py b/osmopy/obscvty.py index 5789f98..8228bda 100755 --- a/osmopy/obscvty.py +++ b/osmopy/obscvty.py @@ -191,7 +191,7 @@ if close: self._close_socket() - return res[len(request) + 2: -end] + return res[len(request) + 2: end * -1] """A generator function yielding lines separated by delim. Behaves similar to a file readlines() method. -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37538?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I32b637fdc0941d051e80e677857321b861ae0c20 Gerrit-Change-Number: 37538 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-python-tests[master]: contrib/jenkins.sh: use virtualenv and pip
by fixeria 20 Jul '24

20 Jul '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37540?usp=email ) Change subject: contrib/jenkins.sh: use virtualenv and pip ...................................................................... contrib/jenkins.sh: use virtualenv and pip setup.py install is deprecated: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ Change-Id: I42ba71e2fd0ceb8466758ea46e9ae33e3d4fcb91 --- M contrib/jenkins.sh 1 file changed, 18 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/40/37540/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 810cb7e..978dc35 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -2,16 +2,12 @@ set -ex -COM_FLAGS='-m compileall' - -rm -rf ./build PY3=python3 -PY3_LIST="osmopy scripts/osmo_ctrl.py scripts/osmo_rate_ctr2csv.py scripts/osmodumpdoc.py scripts/osmotestvty.py scripts/osmotestconfig.py scripts/osmo_interact_ctrl.py scripts/osmo_interact_vty.py scripts/osmo_verify_transcript_ctrl.py scripts/osmo_verify_transcript_vty.py scripts/soap.py scripts/twisted_ipa.py" -$PY3 ./setup.py install --user -for f in $PY3_LIST -do - $PY3 $COM_FLAGS $f -done + +rm -rf ./env +virtualenv --system-site-packages env +source env/bin/activate +pip install . # Run async server which tests scripts/osmo_ctrl.py interaction $PY3 tests/test_py3.py -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I42ba71e2fd0ceb8466758ea46e9ae33e3d4fcb91 Gerrit-Change-Number: 37540 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: doc/examples: drop no-op 'gsmtap-sapi' lines
by laforge 19 Jul '24

19 Jul '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37518?usp=email ) Change subject: doc/examples: drop no-op 'gsmtap-sapi' lines ...................................................................... doc/examples: drop no-op 'gsmtap-sapi' lines These lines yield nothing without the 'gsmtap-remote-host' parameter actually enabling GSMTAP Um logging. Remove them to avoid confusion. Change-Id: Icde668b5829a56663c258e54957e2f639a8e82a9 --- M doc/examples/trx/osmo-bts-trx-calypso.cfg M doc/examples/trx/osmo-bts-trx.cfg 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/examples/trx/osmo-bts-trx-calypso.cfg b/doc/examples/trx/osmo-bts-trx-calypso.cfg index 018744f..8eda4f3 100644 --- a/doc/examples/trx/osmo-bts-trx-calypso.cfg +++ b/doc/examples/trx/osmo-bts-trx-calypso.cfg @@ -34,8 +34,6 @@ bts 0 oml remote-ip 127.0.0.1 ipa unit-id 6969 0 - gsmtap-sapi pdtch - gsmtap-sapi ccch band 900 trx 0 phy 0 instance 0 diff --git a/doc/examples/trx/osmo-bts-trx.cfg b/doc/examples/trx/osmo-bts-trx.cfg index 6b23952..b8da7f7 100644 --- a/doc/examples/trx/osmo-bts-trx.cfg +++ b/doc/examples/trx/osmo-bts-trx.cfg @@ -31,7 +31,5 @@ band 1800 ipa unit-id 6969 0 oml remote-ip 192.168.122.1 - gsmtap-sapi ccch - gsmtap-sapi pdtch trx 0 phy 0 instance 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icde668b5829a56663c258e54957e2f639a8e82a9 Gerrit-Change-Number: 37518 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: doc/examples: use common 'ipa unit-id' in all files
by laforge 19 Jul '24

19 Jul '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37517?usp=email ) Change subject: doc/examples: use common 'ipa unit-id' in all files ...................................................................... doc/examples: use common 'ipa unit-id' in all files Ensure that the 'ipa unit-id' in all config examples is set to value 6969, matching the value used in the osmo-bsc config examples. Change-Id: I2b5ed8eaa5c2cbfe20091dcfea0dd1a70f148f7c --- M doc/examples/litecell15/osmo-bts-lc15.cfg M doc/examples/oc2g/osmo-bts-oc2g.cfg M doc/examples/octphy/osmo-bts-octphy.cfg M doc/examples/octphy/osmo-bts-trx2dsp1.cfg M doc/examples/sysmo/osmo-bts-sysmo.cfg 5 files changed, 17 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/examples/litecell15/osmo-bts-lc15.cfg b/doc/examples/litecell15/osmo-bts-lc15.cfg index 16651eb..f61613b 100644 --- a/doc/examples/litecell15/osmo-bts-lc15.cfg +++ b/doc/examples/litecell15/osmo-bts-lc15.cfg @@ -39,7 +39,7 @@ trx-calibration-path /mnt/rom/factory/calib bts 0 band 900 - ipa unit-id 1500 0 + ipa unit-id 6969 0 oml remote-ip 192.168.234.185 trx 0 phy 0 instance 0 diff --git a/doc/examples/oc2g/osmo-bts-oc2g.cfg b/doc/examples/oc2g/osmo-bts-oc2g.cfg index ddf69f4..5a501fb 100644 --- a/doc/examples/oc2g/osmo-bts-oc2g.cfg +++ b/doc/examples/oc2g/osmo-bts-oc2g.cfg @@ -36,7 +36,7 @@ trx-calibration-path /mnt/rom/factory/calib bts 0 band 900 - ipa unit-id 1500 0 + ipa unit-id 6969 0 oml remote-ip 10.42.0.1 trx 0 phy 0 instance 0 diff --git a/doc/examples/octphy/osmo-bts-octphy.cfg b/doc/examples/octphy/osmo-bts-octphy.cfg index a3a0093..c7394d9 100644 --- a/doc/examples/octphy/osmo-bts-octphy.cfg +++ b/doc/examples/octphy/osmo-bts-octphy.cfg @@ -29,7 +29,7 @@ instance 0 bts 0 band 1800 - ipa unit-id 1234 0 + ipa unit-id 6969 0 oml remote-ip 127.0.0.1 trx 0 phy 0 instance 0 diff --git a/doc/examples/octphy/osmo-bts-trx2dsp1.cfg b/doc/examples/octphy/osmo-bts-trx2dsp1.cfg index 477bff8..79a670e 100644 --- a/doc/examples/octphy/osmo-bts-trx2dsp1.cfg +++ b/doc/examples/octphy/osmo-bts-trx2dsp1.cfg @@ -30,7 +30,7 @@ instance 1 bts 0 band 1800 - ipa unit-id 1234 0 + ipa unit-id 6969 0 oml remote-ip 127.0.0.1 trx 0 phy 0 instance 0 diff --git a/doc/examples/sysmo/osmo-bts-sysmo.cfg b/doc/examples/sysmo/osmo-bts-sysmo.cfg index f44c718..8375a7c 100644 --- a/doc/examples/sysmo/osmo-bts-sysmo.cfg +++ b/doc/examples/sysmo/osmo-bts-sysmo.cfg @@ -27,7 +27,7 @@ instance 0 bts 0 band 1800 - ipa unit-id 666 0 + ipa unit-id 6969 0 oml remote-ip 10.1.2.3 trx 0 phy 0 instance 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37517?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b5ed8eaa5c2cbfe20091dcfea0dd1a70f148f7c Gerrit-Change-Number: 37517 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log