- gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[rel-1.5.1]: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data
by osmith 02 Aug '24

02 Aug '24

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37673?usp=email ) Change subject: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Ok and thanks for handling it. […] Oh right, not sure why I've missed that -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: rel-1.5.1 Gerrit-Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Gerrit-Change-Number: 37673 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 05:44:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ggsn[master]: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID
by pespin 01 Aug '24

01 Aug '24

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email ) Change subject: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1fc48be5c0f177ccf6fbe97c003b4df44809c0fe Gerrit-Change-Number: 37691 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Aug 2024 18:51:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: scripts/kernel-test/smoke-test.sh: Log qemu output to stdout
by pespin 01 Aug '24

01 Aug '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37693?usp=email ) Change subject: scripts/kernel-test/smoke-test.sh: Log qemu output to stdout ...................................................................... scripts/kernel-test/smoke-test.sh: Log qemu output to stdout This allows logging the run-qemu.sh output/progress to eg. /tmp/logs/ggsn-v6_only/osmo-ggsn.log when running the jenkins.sh. Change-Id: Ia638b0b9631518a9bb58e70ef55029085ce0fa9c --- M scripts/kernel-test/smoke-test.sh 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/93/37693/1 diff --git a/scripts/kernel-test/smoke-test.sh b/scripts/kernel-test/smoke-test.sh index b0570dd..21a2a4f 100755 --- a/scripts/kernel-test/smoke-test.sh +++ b/scripts/kernel-test/smoke-test.sh @@ -3,7 +3,7 @@ LOG=/tmp/smoke_test.log -/kernel-test/run-qemu.sh SMOKE_TEST > "$LOG" 2>&1 || true +/kernel-test/run-qemu.sh SMOKE_TEST 2>&1 | tee "$LOG" || true if ! grep -q SMOKE_TEST_SUCCESS "$LOG"; then cat "$LOG" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia638b0b9631518a9bb58e70ef55029085ce0fa9c Gerrit-Change-Number: 37693 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout
by pespin 01 Aug '24

01 Aug '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email ) Change subject: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout ...................................................................... pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout Related: OS#3928 Change-Id: I08921132de863404485581dfa439a54f109b0078 --- M pcu/PCU_Tests.ttcn M pcu/expected-results.xml 2 files changed, 199 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index cab70e8..7aca712 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -65,6 +65,7 @@ modulepar { charstring mp_pcu_sock_path := PCU_SOCK_DEFAULT; + float X2001 := 2.0; /* Timer -2001, Pkt Dl Ass timeout */ float X2002 := 0.2; /* Timer -2002, IMM ASSIGN confirm delay */ charstring mp_pcu_statsd_ip := "127.0.0.1"; @@ -2176,6 +2177,192 @@ f_TC_t3172(3000, '1'B); } +/* Scenario: MS has an ongoing UL TBF, new DL data arrives at the PCU which then + * attempts PKT DL Ass to be able to send data to the MS. The PKT CTRL ACK + * confirming the PKt DL Ass never get to the PCU. + * The Assignment should time out at some point (X2001). */ +testcase TC_x2001_pacch_pkt_dl_ass_unanswered_timeout() runs on RAW_PCU_Test_CT { + var PCUIF_info_ind info_ind := valueof(ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS)); + var RlcmacDlBlock dl_block; + var octetstring payload; + var template (value) LlcBlockHdr blk_hdr; + var template (value) LlcBlocks blocks; + var uint32_t sched_fn; + var uint32_t dl_fn; + var template RlcmacDlBlock acknack_tmpl; + var GprsMS ms; + var octetstring data := f_rnd_octstring(10); + var BTS_PDTCH_Block data_msg; + var uint3_t rx_usf; + var uint32_t dl_ack_nack_poll_fn; + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + + /* Only 1 TRX with 8 PDCH */ + f_PCUIF_PDCHMask_set(info_ind, '11111111'B, 0); + f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7)); + + /* Initialize GPRS MS side */ + f_init_gprs_ms(); + ms := g_ms[0]; /* We only use first MS in this test */ + + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), info_ind); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + /* Establish an Uplink TBF. 1 TS is assigned over AGCH. */ + f_ms_establish_ul_tbf(ms); + + /* Wait until PCU starts requesting for UL block on this TBF: */ + dl_fn := f_ms_wait_usf(ms, nr := f_ms_tx_TsTrxBtsNum(ms)); + sched_fn := f_next_pdch_block(dl_fn); + + /* Send one UL block (with TLLI since we are in One-Phase Access + * contention resolution) and make sure it is ACKED fine. */ + payload := f_rnd_octstring(16); /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */ + blk_hdr := t_RLCMAC_LLCBLOCK_HDR(length_ind := lengthof(payload), + more := false, e := true); + blocks := { t_RLCMAC_LLCBLOCK(payload, blk_hdr) }; + /* Set CV = 15 to signal there's still more than BS_CV_MAX blocks to be sent */ + f_ms_tx_ul_data_blocks_gprs(ms, blocks, cv := 15, with_tlli := true, fn := sched_fn, nr := f_ms_tx_TsTrxBtsNum(ms)); + + /* UL block should be received in SGSN */ + BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.bvc[0].cell_id)); + + acknack_tmpl := tr_RLCMAC_UL_ACK_NACK_GPRS(ms.ul_tbf.tfi, + tr_UlAckNackGprs(ms.tlli, + tr_AckNackDescription(final_ack := '0'B))) + f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn, acknack_tmpl, nr := f_ms_tx_TsTrxBtsNum(ms)); + + timer Tx2001 := X2001 + 0.5; /* 0.5 extra offset: */ + var integer pkt_dl_ass_count := 1; + + /* SGSN sends DL data, start X2001 on tcn3 side when we receive the 1st one: */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, racap := omit)); + dl_block := f_ms_rx_pkt_ass_pacch(ms, sched_fn, tr_RLCMAC_DL_PACKET_ASS, nr := f_ms_tx_TsTrxBtsNum(ms)); + Tx2001.start; + /* Count Pkt DL ass during X2001 timespan, make sure we receive several retransmits. */ + while (true) { + var uint32_t poll_fn; + var template (value) TsTrxBtsNum nr := f_ms_tx_TsTrxBtsNum(ms); + BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, + sapi := PCU_IF_SAPI_PDTCH, fn := 0, + arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), + block_nr := nr.blk_nr)); + alt { + [] as_ms_rx_pkt_ass_pacch(ms, poll_fn, tr_RLCMAC_DL_PACKET_ASS, nr, dl_block) { + pkt_dl_ass_count := pkt_dl_ass_count + 1; + log("Received ", pkt_dl_ass_count , " Pkt Dl Ass"); + rx_usf := f_rlcmac_dl_block_get_usf(data_msg.dl_block); + if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) { + /* Transmit UL data block to keep UL TBF ongoing */ + f_ms_tx_ul_data_blocks_gprs(ms, blocks, cv := 15, with_tlli := true, nr := nr); + } + }; + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + tr_RLCMAC_DL_DUMMY_CTRL())) -> value data_msg { + rx_usf := f_rlcmac_dl_block_get_usf(data_msg.dl_block); + if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) { + /* Transmit UL data block to keep UL TBF ongoing */ + f_ms_tx_ul_data_blocks_gprs(ms, blocks, cv := 15, with_tlli := true, nr := nr); + } + } + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + tr_RLCMAC_UL_ACK_NACK_GPRS(ul_tfi := ?))) -> value data_msg { + rx_usf := f_rlcmac_dl_block_get_usf(data_msg.dl_block); + if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) { + /* Transmit UL data block to keep UL TBF ongoing */ + f_ms_tx_ul_data_blocks_gprs(ms, blocks, cv := 15, with_tlli := true, nr := nr); + } + dl_ack_nack_poll_fn := f_rrbp_ack_fn(data_msg.raw.fn, data_msg.dl_block.ctrl.mac_hdr.rrbp); + /* DL ACK/NACK above sets poll+rrbp requesting PACKET CONTROL ACK */ + f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), dl_ack_nack_poll_fn); + } + [] Tx2001.timeout { + log("Tx2001 timeout!"); + /* receive last block we requested: */ + BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), *)); + } + } + if (not Tx2001.running) { + log("Tx2001 stopped") + if (pkt_dl_ass_count < 10) { + setverdict(fail, "Expected at least 10 Pkt Dl Ass packets, got ", pkt_dl_ass_count); + f_shutdown(__BFILE__, __LINE__); + } + break; /* done */ + } + } + + /* Transmit UL data block to keep UL TBF ongoing */ + f_ms_tx_ul_data_blocks_gprs(ms, blocks, cv := 15, with_tlli := true, nr := f_ms_tx_TsTrxBtsNum(ms)); + + /* Now, after X2001, make sure we don't keep receiving Pkt Dl Ass: */ + timer Tafter := 1.0; + Tafter.start; + while (true) { + var uint32_t poll_fn; + var template RlcmacDlBlock t_pkt_ass := ?; + var template (value) TsTrxBtsNum nr := f_ms_tx_TsTrxBtsNum(ms); + BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, + sapi := PCU_IF_SAPI_PDTCH, fn := 0, + arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), + block_nr := nr.blk_nr)); + alt { + [] as_ms_rx_pkt_ass_pacch(ms, poll_fn, tr_RLCMAC_DL_PACKET_ASS, nr, dl_block) { + setverdict(fail, "Unexpected Pkt Dl Ass after X2001 timeout"); + f_shutdown(__BFILE__, __LINE__); + }; + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + tr_RLCMAC_DL_DUMMY_CTRL())) -> value data_msg { + rx_usf := f_rlcmac_dl_block_get_usf(data_msg.dl_block); + if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) { + /* Transmit UL data block to keep UL TBF ongoing */ + f_ms_tx_ul_data_blocks_gprs(ms, blocks, cv := 15, with_tlli := true, nr := nr); + } + } + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + tr_RLCMAC_UL_ACK_NACK_GPRS(ul_tfi := ?))) -> value data_msg { + rx_usf := f_rlcmac_dl_block_get_usf(data_msg.dl_block); + if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) { + /* Transmit UL data block to keep UL TBF ongoing */ + f_ms_tx_ul_data_blocks_gprs(ms, blocks, cv := 15, with_tlli := true, nr := nr); + } + dl_ack_nack_poll_fn := f_rrbp_ack_fn(data_msg.raw.fn, data_msg.dl_block.ctrl.mac_hdr.rrbp); + /* DL ACK/NACK above sets poll+rrbp requesting PACKET CONTROL ACK */ + f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), dl_ack_nack_poll_fn); + } + [] Tafter.timeout { + log("Tafter timeout!"); + /* receive last block we requested: */ + BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), *)); + } + } + if (not Tafter.running) { + log("Tafter stopped") + break; /* done */ + } + } + + /* Transmit UL data block to keep UL TBF ongoing */ + f_ms_tx_ul_data_blocks_gprs(ms, blocks, cv := 15, with_tlli := true, nr := f_ms_tx_TsTrxBtsNum(ms)); + + /* If new DL data arrives now, PCU should attempt assigning the Pkt Dl Ass again: */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, racap := omit)); + dl_block := f_ms_rx_pkt_ass_pacch(ms, sched_fn, tr_RLCMAC_DL_PACKET_ASS, nr := f_ms_tx_TsTrxBtsNum(ms)); + f_shutdown(__BFILE__, __LINE__, final := true); +} + /* Verify PCU handles correctly Countdown Procedure based on BS_CV_MAX */ testcase TC_countdown_procedure() runs on RAW_PCU_Test_CT { var RlcmacDlBlock dl_block; @@ -7472,6 +7659,7 @@ execute( TC_n3105_max_t3195() ); execute( TC_t3172_wait_ind_size0() ); execute( TC_t3172_wait_ind_size1() ); + execute( TC_x2001_pacch_pkt_dl_ass_unanswered_timeout() ); execute( TC_countdown_procedure() ); execute( TC_ul_all_sizes() ); execute( TC_ul_data_toolong_fills_padding() ); diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml index 17d95cc..e1fe2b5 100644 --- a/pcu/expected-results.xml +++ b/pcu/expected-results.xml @@ -41,6 +41,7 @@ <testcase classname='PCU_Tests' name='TC_n3105_max_t3195' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_t3172_wait_ind_size0' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_t3172_wait_ind_size1' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_x2001_pacch_pkt_dl_ass_unanswered_timeout' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_countdown_procedure' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ul_all_sizes' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ul_data_toolong_fills_padding' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08921132de863404485581dfa439a54f109b0078 Gerrit-Change-Number: 37677 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout
by fixeria 01 Aug '24

01 Aug '24

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email ) Change subject: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08921132de863404485581dfa439a54f109b0078 Gerrit-Change-Number: 37677 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 17:14:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: Reduce timers for ggsn-test-kernel-torvalds
by pespin 01 Aug '24

01 Aug '24

Attention is currently required from: daniel, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37692?usp=email ) Change subject: ttcn3-ggsn-test: Reduce timers for ggsn-test-kernel-torvalds ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I738b460996b29ca828c62427e01b9bb6b995c051 Gerrit-Change-Number: 37692 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 17:12:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout
by pespin 01 Aug '24

01 Aug '24

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout ...................................................................... pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout Related: OS#3928 Change-Id: I08921132de863404485581dfa439a54f109b0078 --- M pcu/PCU_Tests.ttcn M pcu/expected-results.xml 2 files changed, 199 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/37677/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08921132de863404485581dfa439a54f109b0078 Gerrit-Change-Number: 37677 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout
by pespin 01 Aug '24

01 Aug '24

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email ) Change subject: pcu: Introduce test TC_x2001_pacch_pkt_dl_ass_unanswered_timeout ...................................................................... Patch Set 1: (2 comments) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677/comment/c74c8cd0_3e2e… PS1, Line 2263: f_ms_tx_TsTrxBtsNum(ms)); > can we use cached `nr` here and below? […] Ack https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677/comment/61425ef2_e553… PS1, Line 2329: f_ms_tx_TsTrxBtsNum(ms)); > likewise, can we use `nr` here? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08921132de863404485581dfa439a54f109b0078 Gerrit-Change-Number: 37677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 17:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: Reduce timers for ggsn-test-kernel-torvalds
by daniel 01 Aug '24

01 Aug '24

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37692?usp=email ) Change subject: ttcn3-ggsn-test: Reduce timers for ggsn-test-kernel-torvalds ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not sure if this will be obsolete by the change to testenv.py, but in the meantime this will help with spurious ttcn3-ggsn-test-kernel-torvalds failures. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I738b460996b29ca828c62427e01b9bb6b995c051 Gerrit-Change-Number: 37692 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 16:46:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: Reduce timers for ggsn-test-kernel-torvalds
by daniel 01 Aug '24

01 Aug '24

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37692?usp=email ) Change subject: ttcn3-ggsn-test: Reduce timers for ggsn-test-kernel-torvalds ...................................................................... ttcn3-ggsn-test: Reduce timers for ggsn-test-kernel-torvalds The TTCN3 test already assumes that t3 = 1 and n3 = 2 and sets the timers accordingly. The osmo-ggsn config for the non-kernel test already includes these timer values and doesn't need to be updated. Change-Id: I738b460996b29ca828c62427e01b9bb6b995c051 --- M ttcn3-ggsn-test/osmo-ggsn-kernel/v4_only/osmo-ggsn.cfg M ttcn3-ggsn-test/osmo-ggsn-kernel/v4v6_only/osmo-ggsn.cfg M ttcn3-ggsn-test/osmo-ggsn-kernel/v6_only/osmo-ggsn.cfg 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/92/37692/1 diff --git a/ttcn3-ggsn-test/osmo-ggsn-kernel/v4_only/osmo-ggsn.cfg b/ttcn3-ggsn-test/osmo-ggsn-kernel/v4_only/osmo-ggsn.cfg index d8b67a2..f2fdfab 100644 --- a/ttcn3-ggsn-test/osmo-ggsn-kernel/v4_only/osmo-ggsn.cfg +++ b/ttcn3-ggsn-test/osmo-ggsn-kernel/v4_only/osmo-ggsn.cfg @@ -25,6 +25,9 @@ ggsn ggsn0 gtp state-dir /tmp gtp bind-ip 172.18.3.201 + timer gtp T3 1 + timer gtp T1003 2 + timer gtp X3 2 apn internet gtpu-mode kernel-gtp tun-device tun4 diff --git a/ttcn3-ggsn-test/osmo-ggsn-kernel/v4v6_only/osmo-ggsn.cfg b/ttcn3-ggsn-test/osmo-ggsn-kernel/v4v6_only/osmo-ggsn.cfg index c3f32f7..c605691 100644 --- a/ttcn3-ggsn-test/osmo-ggsn-kernel/v4v6_only/osmo-ggsn.cfg +++ b/ttcn3-ggsn-test/osmo-ggsn-kernel/v4v6_only/osmo-ggsn.cfg @@ -25,6 +25,9 @@ ggsn ggsn0 gtp state-dir /tmp gtp bind-ip 172.18.3.201 + timer gtp T3 1 + timer gtp T1003 2 + timer gtp X3 2 apn inet46 gtpu-mode kernel-gtp tun-device tun46 diff --git a/ttcn3-ggsn-test/osmo-ggsn-kernel/v6_only/osmo-ggsn.cfg b/ttcn3-ggsn-test/osmo-ggsn-kernel/v6_only/osmo-ggsn.cfg index 9de035f..a54bcdf 100644 --- a/ttcn3-ggsn-test/osmo-ggsn-kernel/v6_only/osmo-ggsn.cfg +++ b/ttcn3-ggsn-test/osmo-ggsn-kernel/v6_only/osmo-ggsn.cfg @@ -25,6 +25,9 @@ ggsn ggsn0 gtp state-dir /tmp gtp bind-ip 172.18.3.201 + timer gtp T3 1 + timer gtp T1003 2 + timer gtp X3 2 apn inet6 gtpu-mode kernel-gtp tun-device tun6 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I738b460996b29ca828c62427e01b9bb6b995c051 Gerrit-Change-Number: 37692 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log