- gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: gmm: Rename gmm_prim_test -> gmm_prim_ms_test
by fixeria 03 Aug '24

03 Aug '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37725?usp=email ) Change subject: gmm: Rename gmm_prim_test -> gmm_prim_ms_test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9c7bccbf229aa2e136869baf98c5401c0dbae954 Gerrit-Change-Number: 37725 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 03 Aug 2024 12:11:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmo-gprs[master]: gmm: Introduce interface GMMBSSGP
by fixeria 03 Aug '24

03 Aug '24

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email ) Change subject: gmm: Introduce interface GMMBSSGP ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gprs/gmm/gmm_prim.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/37724/comment/f4c46b05_fdd8dfc9 PS1, Line 369: /* Alloc primitive for GMMBSSGP SAP: */ As was discussed, let's just expose a generic alloc API and let the user fill prim specific fields using designated initializers (or whatever they like). Long function names with dozens of params are not nice, and it gets even worse when you add new fields to prims. AFAIR, we wanted to rework the existing API, so let's not add even more APIs which are to be removed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I39045833fd43cfe98cb1a3812fbce3fdcaae6dc6 Gerrit-Change-Number: 37724 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 03 Aug 2024 11:56:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-s1gw[master]: contrib/jenkins.sh: increase EUnit verbosity
by fixeria 03 Aug '24

03 Aug '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37731?usp=email ) Change subject: contrib/jenkins.sh: increase EUnit verbosity ...................................................................... contrib/jenkins.sh: increase EUnit verbosity Change-Id: I3d2dfab52ad41b693d89ef9e8b99df5014b999cf --- M Makefile M contrib/jenkins.sh 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/31/37731/1 diff --git a/Makefile b/Makefile index 4482b2c..fdf454f 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,5 @@ CONFIG ?= config/sys.config +EUNIT_ARGS ?= all: build @@ -18,7 +19,7 @@ rebar3 shell --config $(CONFIG) check: $(GEN_FILES) - rebar3 eunit + rebar3 eunit $(EUNIT_ARGS) analyze: $(GEN_FILES) rebar3 dialyzer diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index c738791..89c8b91 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -2,5 +2,5 @@ make clean make -make check +make check EUNIT_ARGS="-v" make analyze -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3d2dfab52ad41b693d89ef9e8b99df5014b999cf Gerrit-Change-Number: 37731 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-s1gw[master]: Makefile: add 'install' target
by fixeria 03 Aug '24

03 Aug '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Makefile: add 'install' target ...................................................................... Makefile: add 'install' target Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 --- M Makefile 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/28/37728/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 Gerrit-Change-Number: 37728 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo-s1gw[master]: contrib: add systemd unit file
by fixeria 03 Aug '24

03 Aug '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37729?usp=email ) Change subject: contrib: add systemd unit file ...................................................................... contrib: add systemd unit file Change-Id: I8417821d2d8ead0ab1bcea87ee40a16c1b98ce69 --- M Makefile A contrib/systemd/osmo-s1gw.service 2 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/29/37729/1 diff --git a/Makefile b/Makefile index 004e189..7fed821 100644 --- a/Makefile +++ b/Makefile @@ -3,6 +3,7 @@ # directory paths for 'install' BINDIR ?= /usr/bin CONFDIR ?= /etc/osmocom +SYSTEMDUNITDIR ?= /lib/systemd/system/ all: build @@ -30,8 +31,10 @@ install: build install -d $(DESTDIR)$(BINDIR) install -d $(DESTDIR)$(CONFDIR) + install -d $(DESTDIR)$(SYSTEMDUNITDIR) install -m 0755 _build/default/bin/osmo-s1gw $(DESTDIR)$(BINDIR) install -m 0644 -T config/sys.config $(DESTDIR)$(CONFDIR)/osmo-s1gw.config + install -m 0644 contrib/systemd/osmo-s1gw.service $(DESTDIR)$(SYSTEMDUNITDIR) clean: # Avoid running rebar3 clean if _build doesn't exist, since it would try diff --git a/contrib/systemd/osmo-s1gw.service b/contrib/systemd/osmo-s1gw.service new file mode 100644 index 0000000..f19354a --- /dev/null +++ b/contrib/systemd/osmo-s1gw.service @@ -0,0 +1,19 @@ +[Unit] +Description=Osmocom S1 Gateway +After=network-online.target +Wants=network-online.target + +[Service] +Type=simple +Restart=always +StateDirectory=osmo-s1gw +WorkingDirectory=%S/osmo-s1gw +User=osmocom +Group=osmocom +Environment="HOME=/var/lib/osmo-s1gw" +Environment="ERL_FLAGS=-config /etc/osmocom/osmo-s1gw.config" +ExecStart=/usr/bin/osmo-s1gw foreground +RestartSec=2 + +[Install] +WantedBy=multi-user.target -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8417821d2d8ead0ab1bcea87ee40a16c1b98ce69 Gerrit-Change-Number: 37729 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-s1gw[master]: Makefile: add 'install' target
by fixeria 03 Aug '24

03 Aug '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email ) Change subject: Makefile: add 'install' target ...................................................................... Makefile: add 'install' target Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 --- M Makefile 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/28/37728/1 diff --git a/Makefile b/Makefile index 4482b2c..004e189 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,8 @@ +# config file used by 'run' and 'shell' CONFIG ?= config/sys.config +# directory paths for 'install' +BINDIR ?= /usr/bin +CONFDIR ?= /etc/osmocom all: build @@ -23,6 +27,12 @@ analyze: $(GEN_FILES) rebar3 dialyzer +install: build + install -d $(DESTDIR)$(BINDIR) + install -d $(DESTDIR)$(CONFDIR) + install -m 0755 _build/default/bin/osmo-s1gw $(DESTDIR)$(BINDIR) + install -m 0644 -T config/sys.config $(DESTDIR)$(CONFDIR)/osmo-s1gw.config + clean: # Avoid running rebar3 clean if _build doesn't exist, since it would try # to fetch deps from the Internet and that may not be avaialble when in -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 Gerrit-Change-Number: 37728 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in ...osmo-s1gw[master]: add debian package files
by fixeria 03 Aug '24

03 Aug '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email ) Change subject: add debian package files ...................................................................... add debian package files Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c --- A debian/compat A debian/control A debian/postinst A debian/rules A debian/source/format 5 files changed, 63 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/30/37730/1 diff --git a/debian/compat b/debian/compat new file mode 100644 index 0000000..f599e28 --- /dev/null +++ b/debian/compat @@ -0,0 +1 @@ +10 diff --git a/debian/control b/debian/control new file mode 100644 index 0000000..4062ee8 --- /dev/null +++ b/debian/control @@ -0,0 +1,18 @@ +Source: osmo-s1gw +Maintainer: Osmocom team <openbsc(a)lists.osmocom.org> +Section: net +Priority: optional +Build-Depends: erlang-nox, + libpcap-dev, + rebar3, + debhelper (>= 10) +Standards-Version: 4.5.0 + +Package: osmo-s1gw +Architecture: any +Depends: erlang-nox +Multi-Arch: allowed +Description: Osmocom S1 gateway + This can be used on the S1 interface between eNB and MME/CN, and + acts as separation between the eNB-facing IP network and the + CN-facing IP network, which may be separate without routing in between. diff --git a/debian/postinst b/debian/postinst new file mode 100755 index 0000000..d4857a2 --- /dev/null +++ b/debian/postinst @@ -0,0 +1,22 @@ +#!/bin/sh -e +case "$1" in + configure) + # Create the osmocom group and user (if it doesn't exist yet) + if ! getent group osmocom >/dev/null; then + groupadd --system osmocom + fi + if ! getent passwd osmocom >/dev/null; then + useradd \ + --system \ + --gid osmocom \ + --home-dir /var/lib/osmocom \ + --shell /sbin/nologin \ + --comment "Open Source Mobile Communications" \ + osmocom + fi + ;; +esac + +# dh_installdeb(1) will replace this with shell code automatically +# generated by other debhelper scripts. +#DEBHELPER# diff --git a/debian/rules b/debian/rules new file mode 100755 index 0000000..ffd896c --- /dev/null +++ b/debian/rules @@ -0,0 +1,12 @@ +#!/usr/bin/make -f +export DH_VERBOSE=1 +export DEB_BUILD_MAINT_OPTIONS = hardening=+all +include /usr/share/dpkg/default.mk +export ERL_COMPILER_OPTIONS=deterministic + +%: + dh $@ + +override_dh_auto_build: + if [ -e build_dep.tar.gz ] ; then tar xzf ./build_dep.tar.gz ; fi + dh_auto_build diff --git a/debian/source/format b/debian/source/format new file mode 100644 index 0000000..89ae9db --- /dev/null +++ b/debian/source/format @@ -0,0 +1 @@ +3.0 (native) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c Gerrit-Change-Number: 37730 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config
by fixeria 03 Aug '24

03 Aug '24

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email ) Change subject: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 Gerrit-Change-Number: 37717 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 03 Aug 2024 09:44:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: add 'install' target, clean up debian/rules
by fixeria 03 Aug '24

03 Aug '24

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Makefile: add 'install' target, clean up debian/rules ...................................................................... Makefile: add 'install' target, clean up debian/rules Debian's dh_* scripts execute make commands by default, so we no longer need to override dh_* targets in debian/rules. Related: OS#6148 Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 --- M Makefile D debian/osmo-diameter2gsup.install M debian/rules 3 files changed, 23 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/27/37727/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo_dia2gsup[master]: examples/sys.config: add default lager formatting config
by fixeria 03 Aug '24

03 Aug '24

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37719?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: examples/sys.config: add default lager formatting config ...................................................................... examples/sys.config: add default lager formatting config Related: OS#6450 Change-Id: I2b9c3111a0539703f96c265ae16a0413460d0217 --- M examples/sys.config 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/19/37719/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2b9c3111a0539703f96c265ae16a0413460d0217 Gerrit-Change-Number: 37719 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log