- gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by fixeria 12 Aug '24

12 Aug '24

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > We had this discussion with @andreas@eversberg. […] Not saying there can't be a better way, though ;) It's just my understanding. Letting @andreas@eversberg.eu to comment here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:55:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by fixeria 12 Aug '24

12 Aug '24

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > while this is an improvement, we ideally would only call fsync on the one specific file, rather than […] We had this discussion with @andreas@eversberg.eu in a call, and at first I was also under impression that this is complicating things and we should just go for `fsync()`. But then we checked the code and I found out that it's not just writing stuff to one file, but doing several fs operations: `mkstemp()`, write to it, `unlink()`, `stat()`, than `link()` and `unlink()`. This made me think that the code is doing `sync()` for a reason. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:53:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-hnbgw[master]: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index
by laforge 12 Aug '24

12 Aug '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email ) Change subject: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index ...................................................................... hnb_persistent: Use incrementing counter for rate_ctr + stat_item index This will remove the annoying log messages like DLGLOBAL ERROR counter group 'hnb' already exists for index 0, instead using index 1. This is a software bug that needs fixing. (rate_ctr.c:221) Closes: OS#6433 Change-Id: I0bb6a679fb05a6aba917f089401fe3765a5d1fc3 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index d4515a8..90b8147 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -497,19 +497,22 @@ osmo_timer_schedule(&hnbp->disconnected_timeout, period_s, 0); } +static unsigned int g_hnbp_ctr_id; + struct hnb_persistent *hnb_persistent_alloc(const struct umts_cell_id *id) { struct hnb_persistent *hnbp = talloc_zero(g_hnbgw, struct hnb_persistent); + unsigned int ctr_id = g_hnbp_ctr_id++; if (!hnbp) return NULL; hnbp->id = *id; hnbp->id_str = talloc_strdup(hnbp, umts_cell_id_to_str(id)); - hnbp->ctrs = rate_ctr_group_alloc(hnbp, &hnb_ctrg_desc, 0); + hnbp->ctrs = rate_ctr_group_alloc(hnbp, &hnb_ctrg_desc, ctr_id); if (!hnbp->ctrs) goto out_free; rate_ctr_group_set_name(hnbp->ctrs, hnbp->id_str); - hnbp->statg = osmo_stat_item_group_alloc(hnbp, &hnb_statg_desc, 0); + hnbp->statg = osmo_stat_item_group_alloc(hnbp, &hnb_statg_desc, ctr_id); if (!hnbp->statg) goto out_free_ctrs; osmo_stat_item_group_set_name(hnbp->statg, hnbp->id_str); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0bb6a679fb05a6aba917f089401fe3765a5d1fc3 Gerrit-Change-Number: 37664 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index
by laforge 12 Aug '24

12 Aug '24

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email ) Change subject: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0bb6a679fb05a6aba917f089401fe3765a5d1fc3 Gerrit-Change-Number: 37664 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:46:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: recognize ADF.PKCS15, allow selecting it
by laforge 12 Aug '24

12 Aug '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/37690?usp=email ) Change subject: recognize ADF.PKCS15, allow selecting it ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/pkcs15.py: https://gerrit.osmocom.org/c/pysim/+/37690/comment/dca71239_960bb2ce?usp=em… : PS1, Line 32: files = [ might be worth adding a TODO / FIXME comment about this needing code to discover the files at runtime. I think we already have similar comments in other locations where this hapepns, like EF.ICON in DF.GRAPHICS or other instances? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7ea6d91805868645ae1c1a4a2c5870f7d041f74b Gerrit-Change-Number: 37690 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-gprs[master]: tests/gmm: Introduce skeleton for gmm_prim_network tests
by laforge 12 Aug '24

12 Aug '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37726?usp=email ) Change subject: tests/gmm: Introduce skeleton for gmm_prim_network tests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37726?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I832f16f598f49c18455531fac75367376a3065e6 Gerrit-Change-Number: 37726 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:44:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-gprs[master]: gmm: Rename gmm_prim_test -> gmm_prim_ms_test
by laforge 12 Aug '24

12 Aug '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37725?usp=email ) Change subject: gmm: Rename gmm_prim_test -> gmm_prim_ms_test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9c7bccbf229aa2e136869baf98c5401c0dbae954 Gerrit-Change-Number: 37725 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:44:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-gprs[master]: gmm: Introduce interface GMMBSSGP
by laforge 12 Aug '24

12 Aug '24

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email ) Change subject: gmm: Introduce interface GMMBSSGP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I39045833fd43cfe98cb1a3812fbce3fdcaae6dc6 Gerrit-Change-Number: 37724 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:44:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-upf[master]: vty doc fix
by laforge 12 Aug '24

12 Aug '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/37754?usp=email ) Change subject: vty doc fix ...................................................................... vty doc fix Change-Id: Ie1ba8c0a1fb6613b7f21d6889e3c6978288a51e4 --- M src/osmo-pfcp-tool/pfcp_tool_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-pfcp-tool/pfcp_tool_vty.c b/src/osmo-pfcp-tool/pfcp_tool_vty.c index 57968ef..da8d257 100644 --- a/src/osmo-pfcp-tool/pfcp_tool_vty.c +++ b/src/osmo-pfcp-tool/pfcp_tool_vty.c @@ -108,7 +108,7 @@ DEFUN(c_sleep, c_sleep_cmd, "sleep <0-999999> [<0-999>]", "Let some time pass\n" - "Seconds to wait\n") + "Seconds to wait\n" "Additional milliseconds to wait\n") { int secs = atoi(argv[0]); int msecs = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37754?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ie1ba8c0a1fb6613b7f21d6889e3c6978288a51e4 Gerrit-Change-Number: 37754 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-upf[master]: pfcp-tool: fix extra newline in vty_out
by laforge 12 Aug '24

12 Aug '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email ) Change subject: pfcp-tool: fix extra newline in vty_out ...................................................................... pfcp-tool: fix extra newline in vty_out Change-Id: Ib3bb0795238f251ea5b515fe639280be66542a01 --- M src/osmo-pfcp-tool/pfcp_tool_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-pfcp-tool/pfcp_tool_vty.c b/src/osmo-pfcp-tool/pfcp_tool_vty.c index da8d257..f0a46f4 100644 --- a/src/osmo-pfcp-tool/pfcp_tool_vty.c +++ b/src/osmo-pfcp-tool/pfcp_tool_vty.c @@ -97,7 +97,7 @@ rc = osmo_pfcp_endpoint_bind(g_pfcp_tool->ep); if (rc) { - vty_out(vty, "Failed to bind PFCP endpoint on %s: %s%s\n", + vty_out(vty, "Failed to bind PFCP endpoint on %s: %s%s", osmo_sockaddr_to_str_c(OTC_SELECT, osmo_pfcp_endpoint_get_local_addr(g_pfcp_tool->ep)), strerror(-rc), VTY_NEWLINE); return CMD_WARNING; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib3bb0795238f251ea5b515fe639280be66542a01 Gerrit-Change-Number: 37755 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log